From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96DC4C25B78 for ; Tue, 28 May 2024 13:40:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DCBA06B0083; Tue, 28 May 2024 09:40:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D52E46B0088; Tue, 28 May 2024 09:40:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BCC6B6B0089; Tue, 28 May 2024 09:40:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9FE4A6B0083 for ; Tue, 28 May 2024 09:40:33 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 28813A1583 for ; Tue, 28 May 2024 13:40:33 +0000 (UTC) X-FDA: 82167914346.24.C70F7D3 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf30.hostedemail.com (Postfix) with ESMTP id 44A1780009 for ; Tue, 28 May 2024 13:40:31 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=vlybEr0m; dkim=pass header.d=linutronix.de header.s=2020e header.b=dTyxuErG; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf30.hostedemail.com: domain of bigeasy@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716903631; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AAVkJCXJ4dkn+VlJdVdki+iHlel2IgcpuHOJvEpfZzg=; b=OZp/YFR4PsJQnMV7APUIbVWXHPctmE61m/4yHkKW4IeQyC4iJqMiN21zTu5pvGdVWU3hF8 6lUHbMnX2uvCu28IWQb2XKHkJgCAtuK3YoVQMIlALByxfXmHwwzg9Q2yWUL1GSQU4b5mSb Iel7YE6yfDUN71YFkAO5Tvpr9joti3g= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=vlybEr0m; dkim=pass header.d=linutronix.de header.s=2020e header.b=dTyxuErG; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf30.hostedemail.com: domain of bigeasy@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716903631; a=rsa-sha256; cv=none; b=PisPkGcS3viha/1y2D2Zz86Xy9dD9Ewr8GrqSjuvTNe/1TRia9YlKghk+FATLFgvcHIKTf zssuIJV30F6PsAWqNCfshZOsunxoWbQgHYr+IYD3WZvqbwOHF6fHNpfBrMHMYyM3UJleYn MW4vefF2haW58haQzjeLSt2x0lEvtqA= Date: Tue, 28 May 2024 15:40:27 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1716903628; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AAVkJCXJ4dkn+VlJdVdki+iHlel2IgcpuHOJvEpfZzg=; b=vlybEr0mhOc2+ZEjIFHVBhIOrIA9J0OSOvh7I69CVsMFLfXDR43kB82+V3m5RNAwnwKqvD 36srCUHqDfoIJGt6PHbUrB2MCLU/o3miqCWr6GUzHhtFUUk8iTF+hJ16Mngnod1X/Wz+0y ldkRBtgs1GmlHQPzbvg2BDt7u/H3Sa1JVAXB3f4nnobJEnRHpPXO0b9cL6VDelUidNxJoA tsQa7mrOOvnCojzK85mgPnqIgoL/05JsKSfgMP2r6m5j74xstw2jmaUF2E4AOIFEnWTJeK rDPNZM1mfboBQDzpBuZHBkUIdhOnBpfmg86gGkVYw3jnO0JiVcZMxQs6y2GGcg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1716903628; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AAVkJCXJ4dkn+VlJdVdki+iHlel2IgcpuHOJvEpfZzg=; b=dTyxuErG1eKdw5YDua9/Tanb4X6kCsKzP391CYzeNj2f4YmUdOKv4ExWTvhdVBzwgfpkCt TFrGd6BDWgp638CQ== From: Sebastian Andrzej Siewior To: "Vlastimil Babka (SUSE)" Cc: Shakeel Butt , Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Thomas Gleixner Subject: Re: [PATCH] memcg: Remove the lockdep assert from __mod_objcg_mlstate(). Message-ID: <20240528134027.OxDASsS3@linutronix.de> References: <20240528121928.i-Gu7Jvg@linutronix.de> <09e085bb-f09e-4901-a2dd-a0b789bb8a4d@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <09e085bb-f09e-4901-a2dd-a0b789bb8a4d@kernel.org> X-Rspamd-Queue-Id: 44A1780009 X-Stat-Signature: su66erdk5di781t1f3bp1wd88sp36631 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1716903631-358601 X-HE-Meta: U2FsdGVkX19WLDRkGibOyaUBtbOsY31tKP0/TVdD7+Mi7zklO5dZMb8LKMBkZ3yoDKuB+cm28A5GZdYyqwJzwYWxIPkPmioL+U5fSvuwuEcJaYkjmEME2jqWr2zKSAYoAPqdvlPVuzn7krt2gNNBMLGEwQeYFFWv2zt1K/Bk1QSO0ZBZFU3gZby8JiBymwcUpOKpZVadH5iufYwbzDJgsoXTYVWQxOhVowjHw0u+QKz6QasfhprkGl7ND3iJtmQKiq24L3/fdIvCjSBOgQriXVuwNTiQWo1rcN4S3WoEkk44zGrzQnGJgwNzhAyBvArAN306OL63viV5gxgL6I6sSClpYl4OLr19OdP+amb73PYRSURbLDaK8+nQbNJqrWZGJE7SqPW8PN+7Cid4uUg8QtlDm2t9bIodtpU5J8Zlz5F2CXD2o0MXiaWSNyDYXEgUIXMTGcgbEgFqrm2PruO7zOTmu/I23FwSKPGhdFCnBGBWrLLBJCV3EtOpryu5uZMGPyAcnzP4iPk6V3VD/U/G3sg8nGbXyg/q3LHwvu3MlL9/kwp70dDx500cmic7OP1wAkzq+gyDfVzGQcJ1ZmkJfKiJM/StcCvcwfCw6sZ2WNuZcG4BEkJEJ1W2SgbBueQye9XOu+wnr41ZdJ+IeZj5pPvdiXWil5WjIgCl3Dy0mHSHjHhGv/shxAj+F9pTnTAiaNs9bYgUotYSlx+XWgZfRVscMlWGNjLPh8GwcEGtqhqLbm9kd3lH9IOac5u+RxSYPp9RwQXYg2HXGZv+vugkmRStLoZqFRLhidXgXJ0uwPxPy+7+CgGdbauIDBSb6F2Y/Sff5ERDcc42116Qw2kRStC5pkObi/HL10tORykPG564ySREoUDPawpv0hg/EKjPnaLKCp+8zK8Svq0GHD9m0Yu0bPsZOu5ru6ebaywOOGCwVv2x35FEpAkjaw2pdMizTOUCb64Gu8QgFKY2Iao f8pIllnL GODa9/tD6/oyJ48iN7mKxJFivNNRIQR2PdtI+aBMqDo6BSpZj0I5cH6xgQuODecUMLV4om9x6q5IurgeTquPZwuc1YJAz4SinjwSYWNPjtDRbEVqlmmFjATkiGjxrL6OM0QMPKjqXIhS1hi4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024-05-28 14:34:55 [+0200], Vlastimil Babka (SUSE) wrote: > > The safety of the counter update is already ensured by > > VM_WARN_ON_IRQS_ENABLED() which is part of memcg_stats_lock() and does > > not require yet another check. > > I think here it's __mod_memcg_lruvec_state() doing the VM_WARN_ON_ as we > don't go through memcg_stats_lock()? It is either VM_WARN_ON_IRQS_ENABLED() directly as in __mod_memcg_lruvec_state() (which is special) or memcg_stats_lock(). Do you want me to rephrase this part? Sebastian