From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43E39C25B78 for ; Tue, 28 May 2024 11:40:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B240D6B0092; Tue, 28 May 2024 07:40:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AD4386B0095; Tue, 28 May 2024 07:40:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C3966B0098; Tue, 28 May 2024 07:40:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 801996B0092 for ; Tue, 28 May 2024 07:40:32 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2E4131C0BB2 for ; Tue, 28 May 2024 11:40:32 +0000 (UTC) X-FDA: 82167611904.10.D06BA83 Received: from mout-p-202.mailbox.org (mout-p-202.mailbox.org [80.241.56.172]) by imf22.hostedemail.com (Postfix) with ESMTP id 5A98FC001E for ; Tue, 28 May 2024 11:40:30 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b="vF/+8BNK"; dmarc=pass (policy=quarantine) header.from=pankajraghav.com; spf=pass (imf22.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.172 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716896430; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MH4iZoCa8o+1+vGItLvqB3NjLB67QMH9m+mQnQae1Lk=; b=k34YXdisRtd6jXJUMhtXIRNEpjkNwoTlDjQ6f43a8lij5rHOI2ReUvGq+naTiSybcoWum1 9YdpOuNDsl1fX3hw88UvGDOg0i5lFDpx+puA59YgtOLp+1fZxeBDzsfaIofT7nBVNSM/za Oupuf1e5Dg0gHQHW1xhQ3IiGCEckA3g= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b="vF/+8BNK"; dmarc=pass (policy=quarantine) header.from=pankajraghav.com; spf=pass (imf22.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.172 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716896430; a=rsa-sha256; cv=none; b=kICeOiTgxN6ipLUbLyhAOHLmsFVKY0bH72o340SKT503FJpatcAqUKfoMvUvAr/ZtDpoTK XG9ubqOq3NO9c99XLawlfdGAWemSac1kQJfXZ+4Ogg8OwmwFLEYYpN6z+DEUer23+e58C/ mc5mANC/UQNa1v86pgMfcQmbGNwb5LA= Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4VpVty3xdqz9skm; Tue, 28 May 2024 13:40:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1716896426; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MH4iZoCa8o+1+vGItLvqB3NjLB67QMH9m+mQnQae1Lk=; b=vF/+8BNK+QYumbRVeBn29Mnw12RlofB+1HZ/AR8dijTzet5Y781x9EmMBjeqhwJrobCtU2 rUB0WGzbDfGSo6mo/hyb5eZTUZUFvnBy7hfsHfe9tTKgqwZqxOxELRWnZF0wqzt+8NlTZZ kobE8B2cBleohXzHrsZ0VmKA9oLfkpmY5tNy/08tSiguUeAS6no1N71AfDSJm6/iG4RduD ZgeUzvzigairzfy7gHku5NoVgyd61xgyUJgo2C4GqwVc6qM6BTztWCpn9+LU1hXazJl2h8 hHVAAReqKk4qcOAuQWM+3lCrbpZ9nBIuzyx2wrY2S0NzMsNOJJFCcoXSV7IOVg== Date: Tue, 28 May 2024 11:40:20 +0000 From: "Pankaj Raghav (Samsung)" To: Hannes Reinecke Cc: "Matthew Wilcox (Oracle)" , akpm@linux-foundation.org, djwong@kernel.org, brauner@kernel.org, david@fromorbit.com, chandan.babu@oracle.com, ritesh.list@gmail.com, john.g.garry@oracle.com, ziy@nvidia.com, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, mcgrof@kernel.org Subject: Re: [PATCH v5.1] fs: Allow fine-grained control of folio sizes Message-ID: <20240528114020.eqnahlnna4srneax@quentin> References: <20240527210125.1905586-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 5A98FC001E X-Stat-Signature: q5dzjqebnjxaziahmf4yd6zx5ub3x86n X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1716896430-488256 X-HE-Meta: U2FsdGVkX18vNEKCEGC7rA2j9R94YUseL9oX/0fdzb1lkPC+lUMYYdb+Nt40CQCF2EH+ZSAm4p1QaKrYADBhsovixQuEjsWx26zX7pED7s3idpldl6MeDgEh899QMKJmwgRhF04Ntl7k26NfV6oOgxZM8A4N3To6d4J8jLbY+o4Yx/oFUDlCNHafiGhao3bahuetb68p3cDRjeE4ECC77eDbcCBSs3AWkwE+rp0DMRmsLTeFBSTjRHLk8MTqesubUhcqVBapnP0NCMujZ6qLh4waCDcV8t7mVtzryfWBPaiXRrXxlMBSzmX4Ke6Ic5PhJ6lUAMup82SZcEnPQ21Z7uSXbCXl83tR1bmgTlPSpji/ZX9tyhFQGfXmsXD3OqTEDwb5EZzglp/yrycj64J5T6hlMr30p782ExcRc8vfNmHrQ0rgmri1Yv2BHAJMyXYDklnOg+sIY5NHZ66QggqBX1uXG4m/nDpQBnI3bQ3lFwHnP9PB55B/WMQo5/TSMU417avWqVBKSC0XKnXGrRF31tInUK6msDT/hczYqhBaBEvjxDSFLDTHQCKXUa48/Iv/g77RUXUf0/PBed1iH1Mixvq+8g2cKN+FvkvyvNTSBQYeohqUlIrKGavoS1UYhBqj/MDRSUaHXlQ8NzhfjMF0jD9W41AW7kPVhjgR81dM7+4WDTYGtPvWdGCs95GiV0DBDzvRGEWM18qCuE8PSdJK+YfpvQx01t/iXQuPpTsGSjQfMZwybR2kIRNMs9RF5ZrBihSLOtKfGnqzu3ymE3kEPkbRqDQjd2aG2pfVZXOVcioKZ7JRW6dar3pSe3csj439W6QL8b1KZCOcWQkeH+9duN+eWHOy2Id3LJq02C9lnt+ohZVAnTHp/hE9O5emzbA5djZ/upYYtqL6S15uILYQe3AVVF6hXswbUTIPAXqkTyLP+OMH0fPzN9i2h3augrfwp8nXrjL1FBkAGfXSwad 4ytU83MG dH6i/BQ7ayLiSScP59hi6KHxk+4K4ByDSyQoCGPqUIEJJkExa7NAnmemY4tvg2NLmgwBXbydtikBUgfAPKTbIo8CYdVh4KCJzvXl5LF8JTRZVBDXwHI1CIwcCxMmJjRH2brpYoM2v1j370DRWCfGni6QafbHuS1GG+b7LLdw7IYeBujRu/eLIG0J4ja13U6SbhjMFaS62qCqg9OyvJwuwnNgajJzfzWKHvJIO5vuI96OU/f1WkkoNjynRuCipUb3HdmcIaMvHjNBzw9J1ddUGX2Ex2YMpPtpH4rzn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > + */ > > +static inline void mapping_set_folio_order_range(struct address_space *mapping, > > + unsigned int min, unsigned int max) > > +{ > > + if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) > > + return; > > + > Errm. Sure? When transparent hugepages are _enabled_ we don't support this > feature? > Confused. > Replied too quickly. I think this is a mistake. Thanks. I will fold this change. > Cheers, > > Hannes > -- > Dr. Hannes Reinecke Kernel Storage Architect > hare@suse.de +49 911 74053 688 > SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg > HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich > -- Pankaj Raghav