From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAA5EC25B78 for ; Tue, 28 May 2024 11:37:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6DD186B008A; Tue, 28 May 2024 07:37:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 68CA96B0092; Tue, 28 May 2024 07:37:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 57B6B6B0095; Tue, 28 May 2024 07:37:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3BB266B008A for ; Tue, 28 May 2024 07:37:57 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E9CA240996 for ; Tue, 28 May 2024 11:37:56 +0000 (UTC) X-FDA: 82167605352.15.B4B9187 Received: from mout-p-202.mailbox.org (mout-p-202.mailbox.org [80.241.56.172]) by imf28.hostedemail.com (Postfix) with ESMTP id 13546C0017 for ; Tue, 28 May 2024 11:37:54 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=Zm9g0deC; dmarc=pass (policy=quarantine) header.from=pankajraghav.com; spf=pass (imf28.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.172 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716896275; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GTsatAjEP5Z8hfmSAf2UWHF4m9F5ZsKNkIun34OCiBY=; b=JMsKE3fSXdd0AJIPRbPDBGNXtNZzMEHSKlCNzZNkJc4O+Veu6DZSJ4pQ7iw11XxKjxISvN QeQoq6YRGAulTKhxBH8By6jQc/Fd50NebhSPnY2e1vIC7Y9vKd5zFHD5/SJ9kwAo9Jlfzh v/7P9ZPxT64Ff0OLrjPSxHmwJh5rbHI= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=Zm9g0deC; dmarc=pass (policy=quarantine) header.from=pankajraghav.com; spf=pass (imf28.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.172 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716896275; a=rsa-sha256; cv=none; b=tk6NRud2gvmzkE/W00bDond+HNdL9/H/hw05Yt3qiHNBBYVcaC8ZhEidD81tFXNvLl1gdX vvz3U6CQnISjUc6nfanK4LAK42s4HFkFkYYGJ+Lu818HHwMamNoUWBn9PRbHsekMxfDkG0 erjUvncwbBLysVhnrh+913YwG8o0IRY= Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4VpVqx5SJ3z9sp7; Tue, 28 May 2024 13:37:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1716896269; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GTsatAjEP5Z8hfmSAf2UWHF4m9F5ZsKNkIun34OCiBY=; b=Zm9g0deCam8+HbkRh/fSgRnY4JWMb05jZLjC2f/Wj9SYi6E7+mdZHPZs6SyE3htSRNERjr EqWEYEei5jTbvWfIRzj3W4Dyy/SZLUSn+Y91W5exEERsSL5YFWLhWc8thlSck/DA0PYmcA 9fFjW3mdubYrMh+MeQaOTFQQGi6Lf6AMvxfCGEeX481BV9rhpMFhHmf+vTPXAlzDY8ogAO sx9EkNDYfLn6Ehjusk6t8lpVDy0c69VK4gkXaCv0cqsdyGtB3rESCkBGS7KeLR0hXfHSmS H5yu/mKg6imqOJy7btrNknjLhd4bbmbju763kIgEm1TpZ1fcJ1kN/+6+ael63Q== Date: Tue, 28 May 2024 11:37:43 +0000 From: "Pankaj Raghav (Samsung)" To: Hannes Reinecke Cc: "Matthew Wilcox (Oracle)" , akpm@linux-foundation.org, djwong@kernel.org, brauner@kernel.org, david@fromorbit.com, chandan.babu@oracle.com, ritesh.list@gmail.com, john.g.garry@oracle.com, ziy@nvidia.com, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, mcgrof@kernel.org Subject: Re: [PATCH v5.1] fs: Allow fine-grained control of folio sizes Message-ID: <20240528113743.7bpg2kgeirwysmoa@quentin> References: <20240527210125.1905586-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 13546C0017 X-Stat-Signature: 6kxbi947351odjg6zr935k9py7sygjpt X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1716896274-681325 X-HE-Meta: U2FsdGVkX1/EUyrgD7ek59ilDUeNaDaxumq6Z3iWSDI0ierisdl6Ry29r2tS0bHQcFqtrlhYxXNTRn5zQ8AyoaTznHtgF9JkHybvzpIhXE23ZFWhVtCDPCffpmza+dVmemaI/CIyRMin0BVb/yRA2wUU3cctpbLbaKe7vT5/RXCX0sfswyICahKx/wQ2BpuKxmnnlwKOkBZjjOjJ3dEAArtptTo0AvY0U6wLKFaf4MYB8MmgPkTLUxJMAkOXob5QXt/QqekglRH7rsg2CPf6E8fnG5gYoaA6CddGPO1QoqyRbp5w1IQLonPu3r+gLWetsLVisUp4yyCIIp6NPlpGuRVzJy6+oc/UmPSzxFyfEUizozGw1x5ytiTvFHzCgP3yMn5SBwB9j8LYG77NVsW94lmspx8MKaeaaE6gTyvvh9UQkOko5X3fB72gVHRcA828NL+adcQNYO99cqkT+nWrASLtB4mPKo4+QASHGTC54A2yqOZapvbKDNj5/ByaL1MBeydJxGQglr3/R51iOAFxt+NFMtQ45SA7dHJsk8kOgUYRMwdL9HTbp3mGFSwUIKOlhmrsVaB96MXG/1+JOK0sYinsNs/W0YGqzsHI4s8018N4OYo9xhdRzuZ+Noegykk1Al0ospvYJvBgFgpKZGk4trIBFgoAwWCNmYWSyPZnB+i8qpAskOC9UPgk1S/jhTOdmJd5hjV1Jx13IbCdtCuqGPw6RML4eX5QzNVxkr1Fp6QM2Qyd8tiDspUqqgbmKc8oFJhUr5EYZgNhrPlJq6FF3mquLyr8sQWHM1c7QJKIROXG2UXHHgLx8lyo70hhP2YLhJBbUc2kdecg92I3r7OrLtkoMI0WjN+WtJTUhvBUwpbPlxG5vO7N+4SWsZ5YCQ7Vcqi5uxr6ETREIm2cbYw6C9Ru5RmjkCMl8NxdrEiOLTWa8R3QBzTFdngcEr4YjCXAx2YrYEepySH5c6vD0dF b+Z1x65Z khWmgKXIZpQvLEPGD6kr34Uav20S7boH4afmUZzgNSAqUF4LU2TFYw2OjB3TsDNDjh7LeRxfD12aFjTOBHq8+M9+biYHwdulMpkGLK7E2bhSCKJz/k2K2rVvPCbZ8Q/fMe60Orzur4Z+sCJryCHcRndrj9iPeXBhjySP2xQzhLkUsQCZkTLyFuKyqZYPu8q7Ofp1uQMYAueWba5GGE3+uEhmkQzqaQuN6NoPQ92tZMdDbn2JNzpr47Po+gjr97gAHvm348lyK7Qhg6fVTiRZmPUZ8Aw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > + * is non-atomic. > > + */ > > +static inline void mapping_set_folio_order_range(struct address_space *mapping, > > + unsigned int min, unsigned int max) > > +{ > > + if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) > > + return; > > + > Errm. Sure? When transparent hugepages are _enabled_ we don't support this > feature? > Confused. I think large folio support depends on THP, at least for now. I remember willy mentioning that in a thread. The future plan is to get rid of this dependency. > > Cheers, > > Hannes > -- > Dr. Hannes Reinecke Kernel Storage Architect > hare@suse.de +49 911 74053 688 > SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg > HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich > -- Pankaj Raghav