From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DA34C25B78 for ; Tue, 28 May 2024 10:19:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 204466B0082; Tue, 28 May 2024 06:19:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B29A6B0088; Tue, 28 May 2024 06:19:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 07A9B6B008A; Tue, 28 May 2024 06:19:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DF4A36B0082 for ; Tue, 28 May 2024 06:19:12 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9ACD98049F for ; Tue, 28 May 2024 10:19:12 +0000 (UTC) X-FDA: 82167406944.01.9DA34F7 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf20.hostedemail.com (Postfix) with ESMTP id B6AD01C0017 for ; Tue, 28 May 2024 10:19:10 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b="c/OMErT6"; dkim=pass header.d=linutronix.de header.s=2020e header.b=ANOcN4Q+; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf20.hostedemail.com: domain of bigeasy@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716891551; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Oj4XdVUI9qLUqsuyCq3B3lu21WNFGQYe/dCkjjZ08E8=; b=MO8NyiMlyp4P3/cVj9Bs40pERGzqMGnru5fjFVst9WwqWeiRKKmC+nBaNIagqnqSGAnP4G itGeLz1QIX7N8s/6fczP5uApRZs8CowSsDWdgG7XKRIZVbU6h5MeE4sNy0nn7GcyvTZnyz 0LvKJAjQUThgmQeUgzp7MShLmdLmu7A= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b="c/OMErT6"; dkim=pass header.d=linutronix.de header.s=2020e header.b=ANOcN4Q+; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf20.hostedemail.com: domain of bigeasy@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716891551; a=rsa-sha256; cv=none; b=U2VBTAy4uPTZo2VM8oFsleUXBV0mhgqErPpr/Ub8klkGhcPrsGOGNVL2Z+4RPAWJPfh1gr 4wxRcc99qnhg6Xb/gGBLjqVbxsxvzcLasbaiAr+m+Bx+TilSHT+4/qib3ZsF9bWiaNmHOH gFthnfTweo88eZsGW1Oov2E6Gh5R7FY= Date: Tue, 28 May 2024 12:19:06 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1716891548; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Oj4XdVUI9qLUqsuyCq3B3lu21WNFGQYe/dCkjjZ08E8=; b=c/OMErT65eQpDjOOuCoAlir2qD9xE0i98dbANpjAG9uVf4pNhkmV2AveVZgwomMwfsNI/6 h273vMV2rgx7Opv2JM9vUHs4i2+dytB4xZquvs89ZwpzCijRZ1kIJMt9EhFydA1HT2GeoF 1u3TqP3RBUKH5QS9o0emIPrVsVsylQ7SxRrUjq2afFoXcctdt92PRzWHmMQBVJvt7sgzde /a0Uc5oG+2/S6GEHcaeekjKlsqmeFvGfDNpDzy3Fgnhxz8bAyHuTWqwBaESiiQl4+2ndYm RfFrCujtsCBWBlklCPSfqtzbMRm2UmeQuE11eb8DTzNjihupGM+dz+PgUbJUbg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1716891548; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Oj4XdVUI9qLUqsuyCq3B3lu21WNFGQYe/dCkjjZ08E8=; b=ANOcN4Q+/n0ojmW/+nTv158Zi0sbQEPrSXevIiJYINPUmHcTVz9JU27KnrR29TSxkc5E8a aZwJdLmoLgqUNSCQ== From: Sebastian Andrzej Siewior To: "Vlastimil Babka (SUSE)" Cc: Shakeel Butt , Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Thomas Gleixner Subject: Re: [PATCH v2] memcg: simple cleanup of stats update functions Message-ID: <20240528101906.ts4NjHvU@linutronix.de> References: <20240420232505.2768428-1-shakeel.butt@linux.dev> <20240527152200.P1rU7FaG@linutronix.de> <86006806-4ffc-4330-ab4b-29215ab2c98c@kernel.org> <20240528075623.oFcU1JLj@linutronix.de> <69c0e008-ddde-4a38-b856-b765dc2b9745@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <69c0e008-ddde-4a38-b856-b765dc2b9745@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: B6AD01C0017 X-Stat-Signature: ikbo5zpszququd5beo477eoh6dchfs8m X-HE-Tag: 1716891550-747439 X-HE-Meta: U2FsdGVkX18HBjL/3C085sTNAZ0Gz7dVA4eIC7IwLCaakNH+lm9xaHSjUEZYRfAQTyu4UMSaG8GQ9+lW2Mx1VyC9Zp+bWaR/TlpLeasgMv2duELE/y7Gvx0uHkbiHvWa3dm7biao9vkX8S+DMA5sDzJBAFJhDwiWywB7D0LK7Hdb1CUmbuBALIGCDwlB2hhVjTZZlEyuHd8hSTkNMGrJxv9KJpm4ZJINUv7IQWeFWgX22hwBCrltYbZoW39OJ6K3h0wMj9MtJDSy4A0gkAAGsPeCALXmnTmYazVMnVE7D7XFoStUJq/VxoJvqePtsTC0uNhIECBPzziuu/u2XJckrmfRDKvK5lmuHMARFKpF15F+CLKgWo1cdrUtfNPTBYEl/ULcPoXxJJhmcgrkKAI33JXZP8TFA6KdlM4kVM6+pV10js6P5oUxQCoUh8hoGWtdVV+ixd/fktdxrs9LNHuTfMjellZfKdcDatKEovGtlceoKZf5/pWAEYfURHfMsBCmmL/Hp6GCs21rVGMme4uPYCPQ69pphib+1RRkQcT5irWi98q86uq3NH1u2Arx7hm8w693RIKUwa2zfAzssBwAMNWa/lybgfAX3jrfIk7GMIONxNd9YWvbHeyJbC8z81rJK5VMrRxZ7Izh286bpdZ446IKfuZ8yveDIrCdnNVXQTE2vdDbT4nQzFaDcGapm1PgE7BwgaHOx5Z+xa4dBvZHKnkCpLNNMdl+9sr1tp2midukJSGjQPyfDYBAwyMfcluxN2mJ0/tLmcy+0kgLatQxrU75axEMmuqHP8BfkX26lH/Ne2yWS7qrJ+zjExurT6I6XCZWrkOoZaOOeM/rcmt0Z3V0B3yk6LCuAFKKHafMFscIjF/i+ITeUR0/9gi5xFXewqZTsLe+xCOKG1QXbTejyNoh+i5FHrPRM7e8ph24VnSUAdZalrXxmb0C3ELJyBTpqXFeugxJAhosvdm5D5V nK8t8Vx2 ESzl1q14+mRLYYLrCwHqHUyOSVIAr/fO4DUEpKfLlmF/nbQHQJYIget8YGdQLgbWXbofa/Uf6PxhXSIzqOymiYjI1130uMHpiqYAk X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024-05-28 10:10:50 [+0200], Vlastimil Babka (SUSE) wrote: > > I don't mind sending a patch. I'm just not sure if the lock is the right > > thing to do. However it should ensure that interrupts are disabled on > > !RT for the sake of the counter update (if observed in IRQ context). > > Looks like some places there use VM_WARN_ON_IRQS_ENABLED() that's turned off > for PREEMPT_RT, so maybe that's what should replace the current > lockdep_assert, perhaps together with > lockdep_assert_held(this_cpu_ptr(&memcg_stock.stock_lock)); > > But also __mod_memcg_lruvec_state() already has that VM_WARN_ON. This "VM_WARN_ON_IRQS_ENABLED" is the initial assert for "interrupts must be disabled while change the counter". You want to replace it with lockdep? Part of its requirement was that it yells with lockdep disabled. Currently I am leaning towards removing the lockdep_assert_irqs_disabled() from __mod_objcg_mlstate(). Nothing but the counter need it and they have their own check. So? Sebastian