From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32A67C25B78 for ; Tue, 28 May 2024 10:13:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8424D6B0083; Tue, 28 May 2024 06:13:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F3E06B0089; Tue, 28 May 2024 06:13:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B9DB6B008A; Tue, 28 May 2024 06:13:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4CC546B0083 for ; Tue, 28 May 2024 06:13:46 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B5C531203E9 for ; Tue, 28 May 2024 10:13:45 +0000 (UTC) X-FDA: 82167393210.02.0FF84D8 Received: from mout-p-102.mailbox.org (mout-p-102.mailbox.org [80.241.56.152]) by imf29.hostedemail.com (Postfix) with ESMTP id BBD49120017 for ; Tue, 28 May 2024 10:13:42 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b="Zs/bwTn/"; dmarc=pass (policy=quarantine) header.from=pankajraghav.com; spf=pass (imf29.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.152 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716891223; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IlTkJDd3mPfC10j7p6d3xbnwPdgFtV+YqSiluNFgjgk=; b=ZmWP9skxgzoi+sRztlhVdJZJAlS4hU8N/ZA3JTeE7FLcUU2ihHyU9HQifKY0WMPCC/KCPh g8Q2PtSm9M/iTMsMVEL69iSXAVapjv1xdMXW2etgd+VI87vfJtV6E+MsvHrQV8GznOCGxX vh2cweie4haBEwGC+MZZsBBTC1wzveo= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b="Zs/bwTn/"; dmarc=pass (policy=quarantine) header.from=pankajraghav.com; spf=pass (imf29.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.152 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716891223; a=rsa-sha256; cv=none; b=3tCSVCPQUqbmCYkD+tYQKKvZ2TXxGClsJjno7qPGFttPHjft9VnRKo8rnH+T30CJiKcYWb oZLk2sZ4tmo1sS/wkB23CApWd2eMexK3c6g4yiHELiptNLKkJXRIQqhOs3swsZk9klzGrh xCX5qUTOXRknZqkjCgoA4qPd2kcufmo= Received: from smtp2.mailbox.org (smtp2.mailbox.org [10.196.197.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4VpSyn3hHWz9sNZ; Tue, 28 May 2024 12:13:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1716891217; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IlTkJDd3mPfC10j7p6d3xbnwPdgFtV+YqSiluNFgjgk=; b=Zs/bwTn/VjSIHTVrhwAqKG/eBdjgud9JAMb0CgjAPmggXZhygVLTpBf0r8HGquwbYF6fYI Ye64b5ULXkCy/Hf9HHHEXC/u38s+9sKyA74ozfoSaDxFbo9+McKfvmC3ORuhaXXVXP3ONA AQ/R59evehKxXO/SiYFlMK81IGLHOU2MzZdw6kUo2Em5uJ/YCxB3HovHDZjiaJ8i82htdk Spy3Na5FckEIl+WlYIft1UMpfY3vvkFB8LJb3AuEeKu2/IEKoHaImLfXHDVk+y0jA4sCff KIscCpbXWQfM1yDvBr9ZCmZp0G2WSF2BDvILtRLCYRra82UFgudXPbcn7SeDkA== Date: Tue, 28 May 2024 10:13:32 +0000 From: "Pankaj Raghav (Samsung)" To: Matthew Wilcox Cc: akpm@linux-foundation.org, djwong@kernel.org, brauner@kernel.org, david@fromorbit.com, chandan.babu@oracle.com, hare@suse.de, ritesh.list@gmail.com, john.g.garry@oracle.com, ziy@nvidia.com, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, mcgrof@kernel.org Subject: Re: [PATCH v5.1] fs: Allow fine-grained control of folio sizes Message-ID: <20240528101332.b7uwjjjeifgsugrw@quentin> References: <20240527210125.1905586-1-willy@infradead.org> <20240527220926.3zh2rv43w7763d2y@quentin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: BBD49120017 X-Stat-Signature: xwz3budfjnfyrctg6j79bf3xr4d65q71 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1716891222-24581 X-HE-Meta: U2FsdGVkX1+i2Wj1/O1erPntePdrdAie+LPYSrhgBaOeV1nmnzXLpzvJWOokFccg/I0y10V7zdQJrkZ5+7p41YUZ4SMRgYl+lSmPoyoArXNBOlpwJFuc1BqjQA/6u7N7sJKVmzVdnZ4CtRu9hZi6i8aY3r1V30ic0gJDkAXx9o5BJO/7CK3eNhA9Ns7Pr9A4zdtu9drslWVN079evfApxnG9b/9Bmyie7Fzcf0yniP7gstMJFglKVPK+1mOHZBOj2rYSqEa+46h3ytDGEuQikoLebF19mjighh87EkMqCQulY+rfdGystcm3n4ZWBtFcMwzh3091DKHnLvgGoA/D7jO7PNYixFZCkgYe2uURsoYaBQrlLKVi9Yz/6H/0Ux6eDPvGxMPiBIjQjyjeREccjDhV6Oi7hdvELlWkXsOvR1wK/XDScw9jdqddBMcZt1G/EJ7SaWLq9/LnOwlVgIQGtLSem2IWuGSKsywAaRMW5F8GCUV1IX7zPYVmGRJ0Q2D1Trgx5/W9FjMO6WUMwqAX4vNinXMOxkrPG8jF4Dlwj+OMVAh86Q/txJKgUznUv+I+UeXuP7m7FbYIkhyoE3Hrmks0AmPyYdALFTob+lqQuX/qaWGhRq25w4gG+kIaPSRG/Wi5f9ZV7x3s/HhAGIu16bS0D3sTPazL4wOEIHPvduhH0P7TzyI+R2dJfxkegeQM4F5UnHWOiqDlKwHs6/AWDTYq4DFOeaUEucoM1QPfuK4IQaEOxT9z3cHNMQSZb8X47mbOG6bGIWgUAuRvhgUIeipKI6ffzE4KFMAZLScTSnG3e2zQFpg32b5kBcc8CNPPPF7Z+YXV4CNv9tvspxVzoBoZgMIM1C5N4wyQyUxBu6Jq1ScB8fTFS6Ydc9rDe5sogXo5ipBd2CB0nzp8p5Am8oXuqJf5XHMFUWAN91A+PuLrNjneeW95dlcHvbXNFWRVohZwH3BqTKJqOBgN6zi H7NmERFs p/Uxttll0chOFgEhik5xpQlT6efEGxq0R2cW5gZf9eqMvjpTWutdrIsJZFMLu2cKr4Mt2rg1Fh8EZN3YoRdjqzbuldeLYv/OMUPC78iTpIAsedb/Owp5+xEIaCLDwHII9pKphxg0rHVlyegMeY3+9p9hhCkb0n8G/V5ZbYIkZvOGe0JgOSqY0hV6VlcOcYTCBlpP4LzIuPiTpOIZUDKFCeCtS9FMV/osKm12abP0BAoz1+q57ezSRdUqJR9/fUhsAHFwxigcrRJ/e9MU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, May 27, 2024 at 11:39:47PM +0100, Matthew Wilcox wrote: > On Mon, May 27, 2024 at 10:09:26PM +0000, Pankaj Raghav (Samsung) wrote: > > > For this version, I fixed the TODO that the maximum folio size was not > > > being honoured. I made some other changes too like adding const, moving > > > the location of the constants, checking CONFIG_TRANSPARENT_HUGEPAGE, and > > > dropping some of the functions which aren't needed until later patches. > > > (They can be added in the commits that need them). Also rebased against > > > current Linus tree, so MAX_PAGECACHE_ORDER no longer needs to be moved). > > > > Thanks for this! So I am currently running my xfstests on the new series > > I am planning to send in a day or two based on next-20240523. > > > > I assume this patch is intended to be folded in to the next LBS series? > > Right, that was why I numbered it as 5.1 so as to not preempt your v6. > > > > diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h > > > index 1ed9274a0deb..c6aaceed0de6 100644 > > > --- a/include/linux/pagemap.h > > > +++ b/include/linux/pagemap.h > > > @@ -204,13 +204,18 @@ enum mapping_flags { > > > AS_EXITING = 4, /* final truncate in progress */ > > > /* writeback related tags are not used */ > > > AS_NO_WRITEBACK_TAGS = 5, > > > - AS_LARGE_FOLIO_SUPPORT = 6, > > > - AS_RELEASE_ALWAYS, /* Call ->release_folio(), even if no private data */ > > > - AS_STABLE_WRITES, /* must wait for writeback before modifying > > > + AS_RELEASE_ALWAYS = 6, /* Call ->release_folio(), even if no private data */ > > > + AS_STABLE_WRITES = 7, /* must wait for writeback before modifying > > > folio contents */ > > > - AS_UNMOVABLE, /* The mapping cannot be moved, ever */ > > > + AS_UNMOVABLE = 8, /* The mapping cannot be moved, ever */ > > > + AS_FOLIO_ORDER_MIN = 16, > > > + AS_FOLIO_ORDER_MAX = 21, /* Bits 16-25 are used for FOLIO_ORDER */ > > > }; > > > > > > +#define AS_FOLIO_ORDER_MIN_MASK 0x001f0000 > > > +#define AS_FOLIO_ORDER_MAX_MASK 0x03e00000 > > > > As you changed the mapping flag offset, these masks also needs to be > > changed accordingly. > > That's why I did change them? Oops, I missed the zeroes at the end. Btw, I noticed you have removed mapping_align_start_index(). I will add it back in. -- Pankaj Raghav