From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D11C9C25B78 for ; Tue, 28 May 2024 07:18:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 582216B009C; Tue, 28 May 2024 03:18:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 508396B009E; Tue, 28 May 2024 03:18:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 382076B009D; Tue, 28 May 2024 03:18:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1A3A66B009B for ; Tue, 28 May 2024 03:18:07 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BC097A3600 for ; Tue, 28 May 2024 07:18:06 +0000 (UTC) X-FDA: 82166950572.25.C427AA5 Received: from out-184.mta1.migadu.com (out-184.mta1.migadu.com [95.215.58.184]) by imf28.hostedemail.com (Postfix) with ESMTP id 59E8FC0006 for ; Tue, 28 May 2024 07:18:04 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=GIZhwNmj; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf28.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.184 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716880684; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6mzSTL6xyZKONSteLTPcFdPTWlXRiPL9M+VrIHD2DrE=; b=KKKD5Vmd8Nyy700etGn5QD9j69kz113DVAltcXN/zniL4olgxt0MeYX5Nh8EgMPRR3VNPo ZBbXHY62hOzQaX8x0wO0eEWuH80+HWFhHgHxs+Fh50BHmAMP6VosrrhI1tQgnFV74kyOjp U8pL0O1pnas6wxKxFRBWjShJPv6t1gA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716880684; a=rsa-sha256; cv=none; b=GCIrQiiCIBD4CxlYEZV9/JE0r34kJI9WnC+pAIK7+bUe4KfcJrxQIy60GhIJhVmuE3kXJe Rjo2XZF8pp70I8kJ6lqHKvO+6io9hyETAVxFSs6H1PfNZQRepNHIDHeWagbxo2egXGjpro qfW3vy8sbe3wexoI+4uQDAkcpzTfEDk= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=GIZhwNmj; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf28.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.184 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev X-Envelope-To: vbabka@suse.cz DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1716880683; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6mzSTL6xyZKONSteLTPcFdPTWlXRiPL9M+VrIHD2DrE=; b=GIZhwNmjd1A4KLiPMPJMJwLEdtYLjZEWMLDVF/mgiQC7dRxnpaGjt8gm2zEBpZ2YwPpjxc lWXClyUiDYKdNBioPOdE539JD1qfT7toEdPMJALk9hyrilyE2wagz0Qmcv4485nsKcJPEb ycRsxGC3SmhpkK1K0MSpAgxvwJFsfYw= X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: roman.gushchin@linux.dev X-Envelope-To: 42.hyeyoo@gmail.com X-Envelope-To: iamjoonsoo.kim@lge.com X-Envelope-To: linux-mm@kvack.org X-Envelope-To: rientjes@google.com X-Envelope-To: zhouchengming@bytedance.com X-Envelope-To: penberg@kernel.org X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: feng.tang@intel.com X-Envelope-To: cl@linux.com X-Envelope-To: chengming.zhou@linux.dev X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou Date: Tue, 28 May 2024 15:16:48 +0800 Subject: [PATCH 3/3] slab: delete useless RED_INACTIVE and RED_ACTIVE MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240528-b4-slab-debug-v1-3-8694ef4802df@linux.dev> References: <20240528-b4-slab-debug-v1-0-8694ef4802df@linux.dev> In-Reply-To: <20240528-b4-slab-debug-v1-0-8694ef4802df@linux.dev> To: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Feng Tang Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, zhouchengming@bytedance.com, Chengming Zhou X-Developer-Signature: v=1; a=ed25519-sha256; t=1716880668; l=2445; i=chengming.zhou@linux.dev; s=20240508; h=from:subject:message-id; bh=+rkgEJu+y9vxTpB/JnC+X49HMuwavO1IjQ2oUQ25XPg=; b=p/Psm2cQFQg7eXrJTvAMRypLyeXst5Pvu3ic2rgJ9awXVqHSyYAR8OY0r0xAZL//twzZAOluA tjn4CHCQYdgDf6pSTcOuq72rE4nnzdl+0iwbtPtXtAT5aFmXeza/3jp X-Developer-Key: i=chengming.zhou@linux.dev; a=ed25519; pk=kx40VUetZeR6MuiqrM7kPCcGakk1md0Az5qHwb6gBdU= X-Migadu-Flow: FLOW_OUT X-Stat-Signature: rwqmq4ewda3cs74dw3bueq6s53q8dz7s X-Rspamd-Queue-Id: 59E8FC0006 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1716880684-138910 X-HE-Meta: U2FsdGVkX1+ygOJ7wOnA+oaHW9KSziEyoSBlDK73bRmSjrRireoXWtqtkbrP1090SfM+lBut4whW1tc4dxIqlYyuJP2Ba/eH/FykEUh4+ziDM7hPJW5yOedf7vRAab5M9Q95AKIfknPR3t8lhow58EqytvqzNr554dKPj82V6VgUVMMtAnuEEAU+bqHu2UWAknBBHsGgc4beREQvxXHR2rRMWsJ0RzbeukoPFsr8n390AlQDFkLCxn2RDI6Dq2D4oYQbjCJjDg5N+YAWNEu1XvjbYCDBfVl2wU473raSgYyzOT+PztI+DkmhZamKwBVrb60Z0R7b4+tUK1nVVW7dlZ5+segOjhj5GaRRn2Tcda2NGG2HYdx+pTohDXipbnKoy93ekf0wuFrEp/qITsSWDruUAgCjW4scJjEVioRojH3dzcFFVcqQJZ03q0HdHNi8U8DCjy6/mRKzDgqXbInabysLY/anSfvRfqOMCxeNePLFZ2qu/2EU8NcFKpircsloIIpPJyazCS8CEwzOJ9KhQNb5IaZTVwhRZZ8Sqh/bHxhaHcBmBxsZ6oGKsEGsIEiO+F8AK1AjZ3OE+faYlhy0hLT1qQZZQe/6pecx21SKSbrJaHPBOF4pj9FkdLllaCqBl0zqdpHLem066qHELBLt83zi1bAtql2ttegCQs318M03plmhn3CAq/r6yAad2GxtwI5DYOWz0vCvr2+3jffqvooQv/vKCcvUD6ZfeBeCu01MV+4zHeeNVU4oEnkwUMT3Gr768mnDZ5Sb1JBDx7xWka76ACCt5Of6kpmb5itcuMjlMIwz8/Gnqz8GZodfO62Wdb6WwsGcYTb3a+LxFoIiQ4DXWKv9poQAE0mFlyHpmgGFxeUzp+nojAWhJGiwNoAVwlpjbts4Ia9bPxAeHmqtZITg6e2zdkANxFOwkxvwexj4yzE22mq/Rp5tqocxIrd49nk4zq9XEf2fNi07+3c JvRfPup5 QLojCzlWYnM+ssn3G26d9akChp9QXcGjFfojr7Jl8YqvJ/EPYN8TlNI1BCObarZwCkexYzpXJ+Ewyz1kid3OGY/eE0Iw5AJH+EwBw8Jv+xDDzg9P0HOkTGaubvUkwZGN9cL4gqmB7P9itWYqCg7ZvTy745MI2hZMYOXW8EjK4pou3pxUfz988fp59mVmNovWm/mkF4Gut5YCcPc4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: These seem useless since we use the SLUB_RED_INACTIVE and SLUB_RED_ACTIVE, so just delete them, no functional change. Signed-off-by: Chengming Zhou --- include/linux/poison.h | 7 ++----- mm/slub.c | 4 ++-- tools/include/linux/poison.h | 7 ++----- 3 files changed, 6 insertions(+), 12 deletions(-) diff --git a/include/linux/poison.h b/include/linux/poison.h index 1f0ee2459f2a..9c1a035af97c 100644 --- a/include/linux/poison.h +++ b/include/linux/poison.h @@ -38,11 +38,8 @@ * Magic nums for obj red zoning. * Placed in the first word before and the first word after an obj. */ -#define RED_INACTIVE 0x09F911029D74E35BULL /* when obj is inactive */ -#define RED_ACTIVE 0xD84156C5635688C0ULL /* when obj is active */ - -#define SLUB_RED_INACTIVE 0xbb -#define SLUB_RED_ACTIVE 0xcc +#define SLUB_RED_INACTIVE 0xbb /* when obj is inactive */ +#define SLUB_RED_ACTIVE 0xcc /* when obj is active */ /* ...and for poisoning */ #define POISON_INUSE 0x5a /* for use-uninitialised poisoning */ diff --git a/mm/slub.c b/mm/slub.c index b92d9a557852..9af868fa68a4 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -1216,8 +1216,8 @@ static int check_bytes_and_report(struct kmem_cache *s, struct slab *slab, * Padding is extended by another word if Redzoning is enabled and * object_size == inuse. * - * We fill with 0xbb (RED_INACTIVE) for inactive objects and with - * 0xcc (RED_ACTIVE) for objects in use. + * We fill with 0xbb (SLUB_RED_INACTIVE) for inactive objects and with + * 0xcc (SLUB_RED_ACTIVE) for objects in use. * * object + s->inuse * Meta data starts here. diff --git a/tools/include/linux/poison.h b/tools/include/linux/poison.h index 2e6338ac5eed..e530e54046c9 100644 --- a/tools/include/linux/poison.h +++ b/tools/include/linux/poison.h @@ -47,11 +47,8 @@ * Magic nums for obj red zoning. * Placed in the first word before and the first word after an obj. */ -#define RED_INACTIVE 0x09F911029D74E35BULL /* when obj is inactive */ -#define RED_ACTIVE 0xD84156C5635688C0ULL /* when obj is active */ - -#define SLUB_RED_INACTIVE 0xbb -#define SLUB_RED_ACTIVE 0xcc +#define SLUB_RED_INACTIVE 0xbb /* when obj is inactive */ +#define SLUB_RED_ACTIVE 0xcc /* when obj is active */ /* ...and for poisoning */ #define POISON_INUSE 0x5a /* for use-uninitialised poisoning */ -- 2.45.1