From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D526C25B78 for ; Tue, 28 May 2024 07:18:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A889A6B0095; Tue, 28 May 2024 03:18:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A383C6B0096; Tue, 28 May 2024 03:18:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DAAB6B0098; Tue, 28 May 2024 03:18:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6E84E6B0095 for ; Tue, 28 May 2024 03:18:00 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id F0A1616127E for ; Tue, 28 May 2024 07:17:59 +0000 (UTC) X-FDA: 82166950278.05.4DAF99E Received: from out-174.mta1.migadu.com (out-174.mta1.migadu.com [95.215.58.174]) by imf17.hostedemail.com (Postfix) with ESMTP id 8E17340023 for ; Tue, 28 May 2024 07:17:57 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=WeqnOlZv; spf=pass (imf17.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.174 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716880677; a=rsa-sha256; cv=none; b=n2w6ShsXzueR+WiT5SxQy/iTCUEJnruhAlRbB0S3H+LO9l2nxOTs1l8okG1euTqZt5EehY rktTdEpj212C7PnoMKmfXlyxCuN54jDR7Omd+nfscGQrIhhc/7bLJpXmWZaW++nWYzvGoA 4u+GhRkOFmMzL/VuueeAErkaK4Lj+L8= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=WeqnOlZv; spf=pass (imf17.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.174 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716880677; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CMaSIU7JsGNs76Hq+XgMuzCoHf1FVSkJsmdl8eAubO4=; b=3EXYpAN4DOY2hzWM8MrgqmPt+gLU9yhiPD+imqWFBaIKzo0fNFZ/pTpt8rRsakKxvzPiJs o7T8U5aRbwb4+KPGbZXA5ZyuvwsRamFx+FgHtfRZO3X70n0jD8BimMAAb6GTKI4Q66QMqC lQFODo+gETs/kAJMSTLQfqrKRiyML9M= X-Envelope-To: vbabka@suse.cz DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1716880675; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CMaSIU7JsGNs76Hq+XgMuzCoHf1FVSkJsmdl8eAubO4=; b=WeqnOlZv3cipOkQLZEMYBJArodWtyhIDRCTMWRq0PRFeDjk3ZR1BdAluGReAhpv4Ay2tWP ogZI+JWC1KW9+PFe5Un8C2lv+0ZmAJDJIXH4E808ZgEWP/yNaAFb5Wy2toIcXbf6D72iZj ccazgpEZSopK0HkDfZbGPibChtZ7Vng= X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: roman.gushchin@linux.dev X-Envelope-To: 42.hyeyoo@gmail.com X-Envelope-To: iamjoonsoo.kim@lge.com X-Envelope-To: linux-mm@kvack.org X-Envelope-To: rientjes@google.com X-Envelope-To: zhouchengming@bytedance.com X-Envelope-To: penberg@kernel.org X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: feng.tang@intel.com X-Envelope-To: cl@linux.com X-Envelope-To: chengming.zhou@linux.dev X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou Date: Tue, 28 May 2024 15:16:46 +0800 Subject: [PATCH 1/3] slab: check the return value of check_bytes_and_report() MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240528-b4-slab-debug-v1-1-8694ef4802df@linux.dev> References: <20240528-b4-slab-debug-v1-0-8694ef4802df@linux.dev> In-Reply-To: <20240528-b4-slab-debug-v1-0-8694ef4802df@linux.dev> To: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Feng Tang Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, zhouchengming@bytedance.com, Chengming Zhou X-Developer-Signature: v=1; a=ed25519-sha256; t=1716880668; l=849; i=chengming.zhou@linux.dev; s=20240508; h=from:subject:message-id; bh=rHIF8qKq64R0lpw1VUx1Im5wOBmo7sC3YG3g7WqN2W4=; b=KJKqsIabP6pZlL1NYn7OTAWboJRqdoyJ8ZW0qMpjhV9mc2wAbh48bk+//KvkAukAJAN2//aQ+ /iKLywB2qyNCAETzun7+8brQxfX5pTJ4TN3Sfo0EQwOhRl5cMfyQGAf X-Developer-Key: i=chengming.zhou@linux.dev; a=ed25519; pk=kx40VUetZeR6MuiqrM7kPCcGakk1md0Az5qHwb6gBdU= X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 8E17340023 X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: 8mn5gcfzd1meeakya551z1mtm75ogkzx X-HE-Tag: 1716880677-356935 X-HE-Meta: U2FsdGVkX1/Xb1hiBQyU63txH49n0RhJxon8viIyV/Os+spzFoeKIwGC2ukw3tuYe6BRme3ZBLDK4zT3dQ9PGsIxpXWutIkzAf/9XGPaeKfVRHIsgBqmlUAoWZhl42UhvQ7PcH89sVkG4dtasEptaQabOJ4vdXWLJuwW556n+7KK7WsCUa5GTcs3HvybEiHRfA0PzOZol+4dSFVNOwYmgXJP4nOaWKKkyA96cAqt/spwdOgceECOu4M6k+Grqijr19vD8yDOW6z54VKEKCSgEU5AGBWeJi3g8htx2Y1P/F7LPHPpvR/XvQQrAalbFU/VFKMjI0azHEhr5xdLJ04L9MMGVBhpBxHcn/BgqTLDZstaeHfDviGXJgN8aZI7lI9h/qGxYjiAn+D2NCybQyxkItnMaCv/QytL3LaWgyMmNUBeK6GX9YsW+cMEJ9Ar44RqM2ibkx2I8ZIR3mqbuqjiQ/noj99cyd3GoYMr1KRdb2ueuKZGP9XUnZII/HuoShsPsFt+909oJxP7BUFd3g53uSWq+9i17A9k0LqkuaPizbhAytnKFPpo35Te0kxEhgQgGYsOZ6K3ErwVkas8VK2MWZIN95G/guLEVce0Mu22s9NKLZiRait8G/5/gP3msnlShAMD7zTmc0I5s0vXYfx+IM9JbnBCg8dGgTdwTLyTVq9hPg7L793QlakM3T5eZQTuz+DLlvqXQ/HBazQOnigKcREOZcQfJ07O2qyEn/XR0mIJm5dEkGdawuTPq+LA84KcJz6fPu11bvMeIEzOQAXr8Cu/FNJEkFDm04SW9wD9yKpZRgXITDxljjfR60IZITe46m9yeQZe1qfXTV++Kb1xP+s+dWps0rm5Pwxa5eUDURfTH4s6DCchK1/uukOzESWDxz/za2UnkV5EMNUPG0CWjhOeA2SLvcsZeNSFeWDyssLJWRA14VbkpdWH8aDmNiae0JNZGSCOm0P4NFK7oP3 hO082zk7 iNznEWr9ZHA/S/LLR5gP0FyR9VQAzp1LmaWCbutOyGA9/MYkdpylBorvH8TrF5sNsJNKUqt6rAF+49Wbw+gBksjheYtDHFTlMSu2yF9/5ZyX1eaR8Y9Kv86AlFSiFyX0Scm4NBr9Gl2S6ZyvDqWSkwQnO8ZcSGAqQR659vRtAap3N+VRipwZ8pGASDP+ACphRARnd5CucR6G22UHTsiyhsQ0blw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: All check_bytes_and_report() callers have checked its return value except for this one. We should also check its return value here obviously, so fix it. Signed-off-by: Chengming Zhou --- mm/slub.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index 0809760cf789..de57512734ac 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -1324,9 +1324,10 @@ static int check_object(struct kmem_cache *s, struct slab *slab, } } else { if ((s->flags & SLAB_POISON) && s->object_size < s->inuse) { - check_bytes_and_report(s, slab, p, "Alignment padding", + if (!check_bytes_and_report(s, slab, p, "Alignment padding", endobject, POISON_INUSE, - s->inuse - s->object_size); + s->inuse - s->object_size)) + return 0; } } -- 2.45.1