From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23158C25B78 for ; Tue, 28 May 2024 05:16:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 91B8B6B0093; Tue, 28 May 2024 01:16:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8CCF76B0095; Tue, 28 May 2024 01:16:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7BA336B0096; Tue, 28 May 2024 01:16:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5D9E56B0093 for ; Tue, 28 May 2024 01:16:16 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0B91AC029D for ; Tue, 28 May 2024 05:16:16 +0000 (UTC) X-FDA: 82166643552.23.6B36751 Received: from out-175.mta1.migadu.com (out-175.mta1.migadu.com [95.215.58.175]) by imf03.hostedemail.com (Postfix) with ESMTP id 7D57920002 for ; Tue, 28 May 2024 05:16:13 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=JhkGo7pM; spf=pass (imf03.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.175 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716873373; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=VyRL8PBNU9YE+eypKTSOzSwD/xk7CoKAHbGpdBJ6A7U=; b=7gVlAfqvEzxd8oko09C3zcl0naPOhtlR1XF/OXGJOW4thzaLKn4zGIG/7HOQOOEdokQhRy VCZ4C3Pi/9a0RhsTiKlvFUBFlv3+94nBqfMsyZLT5JTMzQQsrAEJCP/YJkblVI9NHlaQ+B Rl9z3fygXGweGA5kmy8EOCAF0lRtiu8= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=JhkGo7pM; spf=pass (imf03.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.175 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716873373; a=rsa-sha256; cv=none; b=RstewJgQUyGVzh0Xw3TsUaqZ9cam9FuRczYRZh33IR9ypb7CORpRahS3BgNKfj5bVuowWn 7CF/2JB3XaIea9aJO1Wi4UTtY1e+ntr+UIvgRPJ0ljP6k2LvY1zGPqkcxFqs4rSXY9eLux iMhxCz6j3qXAtWz3ToQhpXCbIVGov+4= X-Envelope-To: david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1716873369; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=VyRL8PBNU9YE+eypKTSOzSwD/xk7CoKAHbGpdBJ6A7U=; b=JhkGo7pMI1uvH2mLl7uk17ANX6vq51AQImkqe9eqrQpwl0+CylpC2S6wTQjQdyVIRisJEx h9+iTkxcu3loHl4XgFb1ThSv3xDqxQDn5gAsACKUTWJkPHzKFMHfSkbqGhFI1jyE5BC57g VfHW+W/t3+aKhm6At3EUZNlpn7GVnr4= X-Envelope-To: linux-mm@kvack.org X-Envelope-To: hughd@google.com X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: linux-fsdevel@vger.kernel.org X-Envelope-To: chengming.zhou@linux.dev X-Envelope-To: yang.yang29@zte.com.cn X-Envelope-To: ran.xiaokai@zte.com.cn X-Envelope-To: xu.xin16@zte.com.cn X-Envelope-To: aarcange@redhat.com X-Envelope-To: shr@devkernel.io X-Envelope-To: zhouchengming@bytedance.com X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou Subject: [PATCH v3 0/2] mm/ksm: fix some accounting problems Date: Tue, 28 May 2024 13:15:20 +0800 Message-Id: <20240528-b4-ksm-counters-v3-0-34bb358fdc13@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAGloVWYC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyjHUUlJIzE vPSU3UzU4B8JSMDIxMDUyML3SQT3eziXN3k/NK8ktSiYl2zRDMTU6NUI+M0Q3MloK6CotS0zAq widGxtbUACeNhKmEAAAA= To: Andrew Morton , David Hildenbrand , hughd@google.com, aarcange@redhat.com, Stefan Roesch , Xiaokai Ran , xu xin , Yang Yang Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, zhouchengming@bytedance.com, Chengming Zhou X-Developer-Signature: v=1; a=ed25519-sha256; t=1716873365; l=1393; i=chengming.zhou@linux.dev; s=20240508; h=from:subject:message-id; bh=uV0w/FbbATdQz0x74mEbQb3mYslfFqBkWHzAlCYOP4M=; b=LNZ8d7Xrd57vF1RIH/+QDF04AnuHLosEglbn4JWu12rmDyYEkXq7Onal4rpuOsmAKAQytuzJO ZJc62++FZfzDiRzhRrPjNPBj6/LLmj4t2ZOgBiKTC5Hln0N30dgL+VA X-Developer-Key: i=chengming.zhou@linux.dev; a=ed25519; pk=kx40VUetZeR6MuiqrM7kPCcGakk1md0Az5qHwb6gBdU= X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 7D57920002 X-Stat-Signature: 4pw38tx6t1cqa9u7drxbpw4j5mfy5a51 X-HE-Tag: 1716873373-832718 X-HE-Meta: U2FsdGVkX19I7Z9bb24J3V1T4LVRE2rgkCFCt/alYIUcAHj/yBFJFM02ekKJe/PloRlJWKo4GqRIx5peX3eS2EFD6yd3qIkBrU6C4pJQczvSu4yhw/QfV79r5Tnh9VNsuH6PYb818mO01dO/SE1I7ICHcRWHfL840Y1stqnzGcS7vNwV7JNfNX7E/biTieUO+rd6GQApyy6uM6BWaHj/IQfzVwmt7WA1ODMSgJzsRrj5Ggq1Sfdafl2beHMoWSS4wCO8wJXCeeDR4sZTMUCfGoElwTO/RRjh8rc4hVBpEDkNXMKD3kL/YOyfBIF+QnsDF2WZbKPjj3nlNg8ezInMX24Uvrb1KNaesLPt2y209f8a45MMlQvABNFpZ2tR1NEkpq19dfYLbNlZrgdq8jU/HRNAKrJ5s3zkFWYg2oJsdFGVBrVZK/dMQ02cwFdUFoevOzO4+IcFPoXTAF8o2y1ZsueKOSsDZ0f1jNlCedEMKERJoTwxRdyFNjvlBZcz48pEvUsd5HVBdt39O/l82t/7ghuARtsglEw7ZfSxWw3UPOTYrwBo4LiRutKcOQhivrB09FOc1oDl7I233qNow0T+klzK3X2mcr+ircjQQ3VDJPzxoLLwexe/Y4mgIYwgvVQjUSu0i5BG+aZl6oKubivuqSoPDKjd9Lu64j1o4k9v9ECDvkKhfZLJs+X1e7KzYLueKjag0kXTP5JR9E3wZ/YtMN+OxPl+mV7o4dCcgWBxMuqUUNjCjnwypgkXfKFXUaowNhOCKJ4wUOousLvWUYX6c3ZuAlHm994v2PJ3aF6LxMETDePSD0k9qQOo7ALIvYEbBcKxlEkmczsTQpe7XDs8Kn5HA2T6vS6luAAKL2Qf8ZW4kwY+1oSe8CHCz1pf/0G95kGvNxXSVSPe85uUrxbxhWkvMY8KGQguRErISSDPgxvLY45wH3UUrdCrHdnoMXF/5UiJFKFbC6FHQyTI1FS RkOS/Rlm 78KFY+wooNPqwa/izMlOikEKTEmGK+Av3BWsklU4SGPj66KanP6tjfDTcKSmQcfSWR5fTJrl3UKeuq9FGEqBPDj/eFpLukxaii4NOv2jDPC7XC42ZPRRhKyonPAuUhIwAotDjeM02UKAOLIA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Changes in v3: - Collect Reviewed-by tag from xu xin, thanks! - Improve the changelog of patch-2, per xu xin. - Rebase and retest based on v6.10-rc1. - Link to v2: https://lore.kernel.org/r/20240513-b4-ksm-counters-v2-0-f2520183a8ca@linux.dev Changes in v2: - Add Fixes and Acked-by tags from David Hildenbrand, thanks! - Inline atomic_long_read(&ksm_zero_pages), per David Hildenbrand. - Don't include the last two optimization patches to keep this fix simple. - Link to v1: https://lore.kernel.org/r/20240508-b4-ksm-counters-v1-0-e2a9b13f70c5@linux.dev We encounter some abnormal ksm_pages_scanned and ksm_zero_pages during some random tests. 1. ksm_pages_scanned unchanged even ksmd scanning has progress. 2. ksm_zero_pages maybe -1 in some rare cases. Thanks for review and comments! Signed-off-by: Chengming Zhou --- Chengming Zhou (2): mm/ksm: fix ksm_pages_scanned accounting mm/ksm: fix ksm_zero_pages accounting fs/proc/base.c | 2 +- include/linux/ksm.h | 17 ++++++++++++++--- include/linux/mm_types.h | 2 +- mm/ksm.c | 17 +++++++---------- 4 files changed, 23 insertions(+), 15 deletions(-) --- base-commit: 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0 change-id: 20240528-b4-ksm-counters-6a6452e23f17 Best regards, -- Chengming Zhou