From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF35FC25B74 for ; Mon, 27 May 2024 15:22:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 349F36B0085; Mon, 27 May 2024 11:22:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D3846B0088; Mon, 27 May 2024 11:22:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1742F6B0089; Mon, 27 May 2024 11:22:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DCC856B0085 for ; Mon, 27 May 2024 11:22:08 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7CEA8A1589 for ; Mon, 27 May 2024 15:22:08 +0000 (UTC) X-FDA: 82164541536.15.97A882F Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf20.hostedemail.com (Postfix) with ESMTP id B06C11C000F for ; Mon, 27 May 2024 15:22:04 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=mjwFSv63; dkim=pass header.d=linutronix.de header.s=2020e header.b=jA2a5ozo; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf20.hostedemail.com: domain of bigeasy@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716823325; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X66fRhEaG53HhvO210CrX2zRjnKUjNPhLSmLEZ6FadU=; b=3JSbH0ZiMs+YkVXAKgAxHbwTcc4Lwkk2kugVUfC7UOmcpYKcDf2p3VpLgsoC/BGqRBXzpe bRewd+Mz5vPLYnWhqkKDCSbY3q5KeutpuA6Upc+vM9B1NpL0uHZsvGx0HdtRb2uu9kwTKS pDwGoaB7iskOcng8rfE2zOkrCVhyzAk= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=mjwFSv63; dkim=pass header.d=linutronix.de header.s=2020e header.b=jA2a5ozo; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf20.hostedemail.com: domain of bigeasy@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716823325; a=rsa-sha256; cv=none; b=Ajj0qjrSHbz5zRE5H4pR8+tUDkzTObVB2A7iV3hWogKYbbAAcJDoAB5PaPbcUOfA7z4tyM EKwGpwKNWKU+AK7Jis0b8s3nnhNFP4v4PqmBsgd0Zny5TdHyBp//RLzB0ftddcFdmEjYTx vertHsZYIFnFV7LvPPRbi7kztaz2mBY= Date: Mon, 27 May 2024 17:22:00 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1716823321; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X66fRhEaG53HhvO210CrX2zRjnKUjNPhLSmLEZ6FadU=; b=mjwFSv63M3pL0o8AQPPlDwb8cNHWtiAvIlZve3Mh/KqQuyBDQwAHuCtdlblx2gmquFCIyb lC5JumC36i6HOxHdyzg4fce1zNV61N0qfXiGnrQk/+uOwcI8CPNsB1qCLusFMKIho/dY+t 8utnUgpaDWDCFpCGJYVIhH6KWDCRp4rTjh9zs0NQ2pirSj6lSRxhNw/mwnQOSUURfBkfFW XWbmP+EJl+ql9fcfqIOo6zwk3LVPknnLLX4YGw7wStPxR5Lg5Z4GJChFIWJOkSLLD9ObZ9 lj0NENyeiF4vbOjgn3onpvMKpNJZNjF/UjyusHP2zrpoUXf++8ReY9mPUQbBew== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1716823321; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X66fRhEaG53HhvO210CrX2zRjnKUjNPhLSmLEZ6FadU=; b=jA2a5ozoRRwPXEkr59T06IohpNMxoHt93F3L5pfCvB1UME/7/9QBKakAIf1dyuGdx7V2Eo z70qVr1UVEY+fBBg== From: Sebastian Andrzej Siewior To: Shakeel Butt Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Thomas Gleixner Subject: Re: [PATCH v2] memcg: simple cleanup of stats update functions Message-ID: <20240527152200.P1rU7FaG@linutronix.de> References: <20240420232505.2768428-1-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20240420232505.2768428-1-shakeel.butt@linux.dev> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: B06C11C000F X-Stat-Signature: m4467wpr1afhb8o6yi9zmd8h4oyziege X-HE-Tag: 1716823324-276741 X-HE-Meta: U2FsdGVkX1+rwNWpwQjB/lTZdbjsWoQ7tXh7HyX8jZVPh3Ej7jhSLFGqHEroxOt5q25sPAQsQFghj1OWgqQuZmVIrc4/0VJkCKP/SqdnSGEN+qRbASI5/SSOyjC7dYQ+UcIaMlf/wN5V4mkDacKTxh9bD5QcIZlAOd827BjkyRB670cYUpfHDM5XE5pm3Hx82JddAwQjTXIXV1RfsspU01VuuMVimkwIZzgmJDvMrRQQDBvgdJiGKFS2w/ckdxAbbmze//GCwFi9bxUnLCiKerlm7VyI/nWhDPSROz54UZJVog0Vf0y1K6H2G4oK0H292DCk2koExTr0woPEwRSfYcnzC4Hg5O9z6jkqkhDJAgTJBcuO7KeDkz1J8LopfaGLS8U6WH1Gf0cdSkFdfQLGSje9M2BYVvKmL3iqRngsOfftZTVhdZJRiTSGpCC0dIawf6cbOScBLl3tHuar5sTXoo2knOQzN8OMVRVCOUDWcmBYYMTVM6O0tAOx3prSB5KUbQyLN4PNMhVsH6V3lOCs4y3WyCLOdNyWma41TyNKd9dCEkAokYO9P1PHg5pU1xYXWSqjw3Wk7PyJeB2Mn1peERs27qc30oVF/j2hVicIvzLpEafJx2bzjX1+4YV11J/lpyWeKGUHEtJykDcthjtN4GcPPzYid49T2W3sqTzyqkeN3hPZYBoJOCLQ/XvtmPc9a7JNyKPqZDqYIpcKh1/MN7I9PLd4GPmaFiM0quL8NVrY5FridEAvNKzkZWVRsseN2lIcPQ2BnNvHDNSWJSm/SOBy38nbiei4Mg37VNP3tVw95TFmRvZVc6KsIgItydpTzhjzPk6YHoN+aydL/uWqEVKq1pYSOQudOpLIEZiP9sdVKcZ1XMs7XueSorAgh1alQzlooFGVhUWHCLFbmbOXUjFs0PxfXondq7jq5REmZ6a8K8r4FiqS6vfWfu9R60WMvTU3p0clph+LXSAUdju Q1QF/Nlj YMJX9QSninWVtHKkfBMns4ONPxPG+fjcnN1XesTeRv8TJH9+SpbA64+xfvto1PSd24ubkSpSmIrHkaUses5SEk0L2cShwAaa79sjk X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024-04-20 16:25:05 [-0700], Shakeel Butt wrote: > mod_memcg_lruvec_state() is never called from outside of memcontrol.c > and with always irq disabled. So, replace it with the irq disabled > version and add an assert that irq is disabled in the caller. unless PREEMPT_RT is enabled. In that case IRQs are not disabled as part of local_lock_irqsave(&memcg_stock.stock_lock, =E2=80=A6) leading to: | ------------[ cut here ]------------ | WARNING: CPU: 0 PID: 1 at mm/memcontrol.c:3150 __mod_objcg_mlstate+0xc2/0= x110 | CPU: 0 PID: 1 Comm: systemd Not tainted 6.10.0-rc1-rt0+ #17 | Call Trace: | | mod_objcg_state+0x2b3/0x320 | __memcg_slab_post_alloc_hook+0x13c/0x340 | kmem_cache_alloc_lru_noprof+0x2bd/0x2e0 | alloc_inode+0x59/0xc0 | iget_locked+0xf0/0x290 suggestions? Sebastian