From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AAA0C25B74 for ; Fri, 24 May 2024 16:00:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 057C26B0085; Fri, 24 May 2024 12:00:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 007696B008A; Fri, 24 May 2024 12:00:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E128C6B008C; Fri, 24 May 2024 12:00:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C75AD6B0085 for ; Fri, 24 May 2024 12:00:35 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DF03280C24 for ; Fri, 24 May 2024 16:00:32 +0000 (UTC) X-FDA: 82153751904.17.6779122 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by imf02.hostedemail.com (Postfix) with ESMTP id BF27F80031 for ; Fri, 24 May 2024 16:00:29 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=PbfilPBR; spf=pass (imf02.hostedemail.com: domain of lkp@intel.com designates 192.198.163.9 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716566430; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iYlUvffPsQ/AOm08BM2vNZne3lhWOVScyEPV4rf6OtI=; b=brSVjgRlAxNGtofAB4/PnY/DN1nURhN8QIhLvhxVUgAfjRpyLB8jS8K2Agfv10hWaaB+SI GeM0/l+m3Zh6+/+4x9uP4/qS7lp8m/GWaUspK7Rb0gsb3fZNo637sw1/jz661hztQE7rTX jaU+AWjKLeulN35hk9of85CfCF/IAgY= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=PbfilPBR; spf=pass (imf02.hostedemail.com: domain of lkp@intel.com designates 192.198.163.9 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716566430; a=rsa-sha256; cv=none; b=WV5uTd6FCk6TsxHuCVgwnkG/FfnXtTigCBdmUy45ZKwVO0jKf5hXjty9nKevQctsjBvxKT dvLdyofnbj4q/NOnCCbqoyOBQx+WXqCOO90UUJLq5/qwZAQ1d/vMTw/MKOOYOKpNRIKwgm CtjcJbwcT+6BnwndPX3YBYUkVFOM48k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1716566430; x=1748102430; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=cIkbosX3WAgkpupjWKvUxqpqI35ry0vgf/GaC4+aR9Y=; b=PbfilPBRntO2WR5lB+ugVtq9/oqmSUNyyGAK1ApfGpOQAJ7tS15FEa73 R4vR2K5wMfusmLINTCE1DAnRrI1ECfKwdphXhPsRfUClelXp+GBZuFMcS w12483dmyBG+/xeq7mOGt6ghFKO2UYm1JUBOOJC/Np/sO25RH8hjb673o ylofh6cUipQMdK7GGKxtsmsKpQ9mQ7kxXpWin8+Igm2JXeKNtWRx17pIa XJIxZ68ZEGtj3vwXvgq+M9ifeRJ7WD/CekCDXww5PNgRz1WrZd1NRac5J eteAfqR8mp3YJnX0EUvAuEbVSWXe+nmmuOgvkMlyw2xMMa8L5Fo/w1kc5 w==; X-CSE-ConnectionGUID: MwNaQFM3Qg62trgpZD/piw== X-CSE-MsgGUID: v+N+tCFeTx6cMJaOe/68uQ== X-IronPort-AV: E=McAfee;i="6600,9927,11082"; a="23614790" X-IronPort-AV: E=Sophos;i="6.08,185,1712646000"; d="scan'208";a="23614790" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2024 09:00:28 -0700 X-CSE-ConnectionGUID: glhMuJ8BRzKyS4JocldrYg== X-CSE-MsgGUID: GlAbNeCwTTW2ihAl+Szi2w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,185,1712646000"; d="scan'208";a="71478838" Received: from unknown (HELO 0610945e7d16) ([10.239.97.151]) by orviesa001.jf.intel.com with ESMTP; 24 May 2024 09:00:26 -0700 Received: from kbuild by 0610945e7d16 with local (Exim 4.96) (envelope-from ) id 1sAXLC-0005a9-31; Fri, 24 May 2024 16:00:22 +0000 Date: Fri, 24 May 2024 23:59:43 +0800 From: kernel test robot To: Miaohe Lin , akpm@linux-foundation.org, tony.luck@intel.com, bp@alien8.de Cc: oe-kbuild-all@lists.linux.dev, nao.horiguchi@gmail.com, linmiaohe@huawei.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org Subject: Re: [PATCH 07/13] mm/memory-failure: remove unneeded hwpoison_filter() variant Message-ID: <202405242336.o1NEOrln-lkp@intel.com> References: <20240524091310.1430048-8-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240524091310.1430048-8-linmiaohe@huawei.com> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: BF27F80031 X-Stat-Signature: fjeyn74xoa6wsi63ptb953pbrbz6uzkw X-HE-Tag: 1716566429-375915 X-HE-Meta: U2FsdGVkX19FrPYiFfGUmFV8axka2Ad2L5Z6XgnjVwXolgsShOMwpnh0iVLj7dz/o0vKcB35WRW2ic6vzJW9j6YO4UEWzbd2h/iA4lM8RIWWAupsHFhTYAyPW59jRqq/GshC+L6uBfGWqRNpJ+CDoMBTWNdzUU0kBgfrqFkSZExmmzX/sALxFYcmt4KD8LnoB+tZV/eMR107uKj8yL2oAT2LR7Db7TAWjVXJOI78A36e0GPXMnHUdqHVJwSPPZI1j6dBVioH/fKccxDYgzbMjPEECrmedYHObUWtRxP4huCFnDFbdmC/vYXkcv86hV+82OtjIAkAbb8uwyZ/yua9khAXOJbi63EWLYPagw2A6FP0KtNrcebXVKoYIeMrw7QZBNt4/MjfRtLfz49yBXEmqYAPROdoWTqZpK8lq0nzR1QVKviZcJu7LMHXB1UpaaNkXDitDDLTJwot4nG68nJLRcvoWq80QuoVVegBDEef36hkMhGjj4nucnSQaf+JOzHduDOyjkWLhgTlwJ03vE/kn66oomEbNYWpoMkF35Xvdf7Rg66btJJn7w7YOFUNbsQfQ4CGINgh8MPJ34jaIbu0LYZ4R7hSH6BNsIhXXQjpA4tGuXM78kTU6yEaTJ7xlGcCv+4swjbagejy+B0nGsbV6oTiCKAopJIH9zc3hk4mAR/qmK03eWxjsW9YmlMdes4qmD9zcWcJLifoAJobT/3fv20A0ppYSDekTXU2QZ7U6sMShPHVZUGVyVc99nBhjwiyPe5uRLjKCROC6UFRRN3qE5Om6/RCoImI+jYa9974iR3NGo7QvaZQT1Ag8i2CqWSLcnZQijjJMw9NpR/1Nq0TvXVsaopQEEuFiqFT8xhAx6jHmYoHqaEGT7w1V7rJkSJu9hWco7ZGoFp8YoVGV2cFTy+Jw8wCmHnj3Dxno19rxNLf1CqB1AbWfwXmuo2tv0t/ttZXj+BBsB4uTJh0RLP 0XvwGe/U m6zwi3oAMFpUoQzIjR52+K+Fs6FRi6XtD18sEECn84QKj6A+ysP14OqMJuVmCMzez1Vw6gb1bYRKuMNnNXYIiPTSTs4oYuOiOH38sDNnJO7DC8Ure7RuC/aIUrQNYHqMBhiDz0fJaRkXn1ifbF0rVjp6Oj2fC5m4F2aCdVf2pbBpxZUgAepgV7Vw60sCbNnkEHqrePhtP1I6dKdwBfCNKnx4ZftX94ZGS8rnwkwKt/074pa8K6JymTtAZAITPGBD9jZuoYoYaWUXdFuBKCxA1vt7QtnrsX7vI4buMjaVCkt9/63MxjFn4qbr6ZfaOS5F/e4CyxI394lFLm6oo1AOhgmshMlXnIK/Ud+WUJVd+Lf8MzDTCaX2LlnutMm6E0rcybOpXxYZ5R4+eYSeiht6RCZeomy276F6wa3evnCiwuhpHOmaMs7g7Z8rGg16a8uhQ+oSXDdUQ4EBtALNwFgpd5FdEUJJNbuxIQc2GOYAZzKwlLgnGmtQc9w4r923bhpO2CZwT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Miaohe, kernel test robot noticed the following build errors: [auto build test ERROR on akpm-mm/mm-everything] [also build test ERROR on linus/master next-20240523] [cannot apply to v6.9] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Miaohe-Lin/mm-memory-failure-simplify-put_ref_page/20240524-171903 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20240524091310.1430048-8-linmiaohe%40huawei.com patch subject: [PATCH 07/13] mm/memory-failure: remove unneeded hwpoison_filter() variant config: i386-randconfig-005-20240524 (https://download.01.org/0day-ci/archive/20240524/202405242336.o1NEOrln-lkp@intel.com/config) compiler: gcc-11 (Ubuntu 11.4.0-4ubuntu1) 11.4.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240524/202405242336.o1NEOrln-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202405242336.o1NEOrln-lkp@intel.com/ All errors (new ones prefixed by >>): ld: mm/memory-failure.o: in function `try_memory_failure_hugetlb': >> mm/memory-failure.c:2098:(.text+0x28a8): undefined reference to `hwpoison_filter' ld: mm/memory-failure.o: in function `memory_failure': mm/memory-failure.c:2321:(.text+0x2a98): undefined reference to `hwpoison_filter' ld: mm/memory-failure.o: in function `soft_offline_page': mm/memory-failure.c:2841:(.text+0x3217): undefined reference to `hwpoison_filter' vim +2098 mm/memory-failure.c 405ce051236cc6 Naoya Horiguchi 2022-04-21 2057 405ce051236cc6 Naoya Horiguchi 2022-04-21 2058 /* 405ce051236cc6 Naoya Horiguchi 2022-04-21 2059 * Taking refcount of hugetlb pages needs extra care about race conditions 405ce051236cc6 Naoya Horiguchi 2022-04-21 2060 * with basic operations like hugepage allocation/free/demotion. 405ce051236cc6 Naoya Horiguchi 2022-04-21 2061 * So some of prechecks for hwpoison (pinning, and testing/setting 405ce051236cc6 Naoya Horiguchi 2022-04-21 2062 * PageHWPoison) should be done in single hugetlb_lock range. 405ce051236cc6 Naoya Horiguchi 2022-04-21 2063 */ 405ce051236cc6 Naoya Horiguchi 2022-04-21 2064 static int try_memory_failure_hugetlb(unsigned long pfn, int flags, int *hugetlb) 0348d2ebec9b00 Naoya Horiguchi 2017-07-10 2065 { 761ad8d7c7b548 Naoya Horiguchi 2017-07-10 2066 int res; 405ce051236cc6 Naoya Horiguchi 2022-04-21 2067 struct page *p = pfn_to_page(pfn); bc1cfde1946752 Sidhartha Kumar 2023-01-12 2068 struct folio *folio; 761ad8d7c7b548 Naoya Horiguchi 2017-07-10 2069 unsigned long page_flags; e591ef7d96d6ea Naoya Horiguchi 2022-10-24 2070 bool migratable_cleared = false; 761ad8d7c7b548 Naoya Horiguchi 2017-07-10 2071 405ce051236cc6 Naoya Horiguchi 2022-04-21 2072 *hugetlb = 1; 405ce051236cc6 Naoya Horiguchi 2022-04-21 2073 retry: e591ef7d96d6ea Naoya Horiguchi 2022-10-24 2074 res = get_huge_page_for_hwpoison(pfn, flags, &migratable_cleared); 405ce051236cc6 Naoya Horiguchi 2022-04-21 2075 if (res == 2) { /* fallback to normal page handling */ 405ce051236cc6 Naoya Horiguchi 2022-04-21 2076 *hugetlb = 0; 405ce051236cc6 Naoya Horiguchi 2022-04-21 2077 return 0; 405ce051236cc6 Naoya Horiguchi 2022-04-21 2078 } else if (res == -EHWPOISON) { 96f96763de26d6 Kefeng Wang 2022-07-26 2079 pr_err("%#lx: already hardware poisoned\n", pfn); 405ce051236cc6 Naoya Horiguchi 2022-04-21 2080 if (flags & MF_ACTION_REQUIRED) { bc1cfde1946752 Sidhartha Kumar 2023-01-12 2081 folio = page_folio(p); bc1cfde1946752 Sidhartha Kumar 2023-01-12 2082 res = kill_accessing_process(current, folio_pfn(folio), flags); 38fe2f81155c0e Jane Chu 2024-05-21 2083 action_result(pfn, MF_MSG_ALREADY_POISONED, MF_FAILED); 38fe2f81155c0e Jane Chu 2024-05-21 2084 return res; 405ce051236cc6 Naoya Horiguchi 2022-04-21 2085 } 405ce051236cc6 Naoya Horiguchi 2022-04-21 2086 return res; 405ce051236cc6 Naoya Horiguchi 2022-04-21 2087 } else if (res == -EBUSY) { 38f6d29397ccb9 Naoya Horiguchi 2022-07-14 2088 if (!(flags & MF_NO_RETRY)) { 38f6d29397ccb9 Naoya Horiguchi 2022-07-14 2089 flags |= MF_NO_RETRY; 405ce051236cc6 Naoya Horiguchi 2022-04-21 2090 goto retry; 405ce051236cc6 Naoya Horiguchi 2022-04-21 2091 } 38fe2f81155c0e Jane Chu 2024-05-21 2092 return action_result(pfn, MF_MSG_GET_HWPOISON, MF_IGNORED); 761ad8d7c7b548 Naoya Horiguchi 2017-07-10 2093 } 761ad8d7c7b548 Naoya Horiguchi 2017-07-10 2094 bc1cfde1946752 Sidhartha Kumar 2023-01-12 2095 folio = page_folio(p); bc1cfde1946752 Sidhartha Kumar 2023-01-12 2096 folio_lock(folio); 405ce051236cc6 Naoya Horiguchi 2022-04-21 2097 e37e7b0b3bd52e Naoya Horiguchi 2021-12-24 @2098 if (hwpoison_filter(p)) { 2ff6cecee669bf Sidhartha Kumar 2023-01-12 2099 folio_clear_hugetlb_hwpoison(folio); e591ef7d96d6ea Naoya Horiguchi 2022-10-24 2100 if (migratable_cleared) bc1cfde1946752 Sidhartha Kumar 2023-01-12 2101 folio_set_hugetlb_migratable(folio); bc1cfde1946752 Sidhartha Kumar 2023-01-12 2102 folio_unlock(folio); f36a5543a74883 Miaohe Lin 2022-08-18 2103 if (res == 1) bc1cfde1946752 Sidhartha Kumar 2023-01-12 2104 folio_put(folio); f36a5543a74883 Miaohe Lin 2022-08-18 2105 return -EOPNOTSUPP; 761ad8d7c7b548 Naoya Horiguchi 2017-07-10 2106 } 405ce051236cc6 Naoya Horiguchi 2022-04-21 2107 405ce051236cc6 Naoya Horiguchi 2022-04-21 2108 /* 405ce051236cc6 Naoya Horiguchi 2022-04-21 2109 * Handling free hugepage. The possible race with hugepage allocation 405ce051236cc6 Naoya Horiguchi 2022-04-21 2110 * or demotion can be prevented by PageHWPoison flag. 405ce051236cc6 Naoya Horiguchi 2022-04-21 2111 */ 405ce051236cc6 Naoya Horiguchi 2022-04-21 2112 if (res == 0) { bc1cfde1946752 Sidhartha Kumar 2023-01-12 2113 folio_unlock(folio); f40962a5b0bca2 Miaohe Lin 2024-05-23 2114 if (__page_handle_poison(p) > 0) { a8b2c2ce89d4e0 Oscar Salvador 2020-12-14 2115 page_ref_inc(p); a8b2c2ce89d4e0 Oscar Salvador 2020-12-14 2116 res = MF_RECOVERED; ceaf8fbea79a85 Naoya Horiguchi 2022-07-14 2117 } else { ceaf8fbea79a85 Naoya Horiguchi 2022-07-14 2118 res = MF_FAILED; a8b2c2ce89d4e0 Oscar Salvador 2020-12-14 2119 } b66d00dfebe79e Kefeng Wang 2022-10-21 2120 return action_result(pfn, MF_MSG_FREE_HUGE, res); 761ad8d7c7b548 Naoya Horiguchi 2017-07-10 2121 } 761ad8d7c7b548 Naoya Horiguchi 2017-07-10 2122 bc1cfde1946752 Sidhartha Kumar 2023-01-12 2123 page_flags = folio->flags; 761ad8d7c7b548 Naoya Horiguchi 2017-07-10 2124 03468a0f52893b Matthew Wilcox (Oracle 2024-04-12 2125) if (!hwpoison_user_mappings(folio, p, pfn, flags)) { bc1cfde1946752 Sidhartha Kumar 2023-01-12 2126 folio_unlock(folio); 38fe2f81155c0e Jane Chu 2024-05-21 2127 return action_result(pfn, MF_MSG_UNMAP_FAILED, MF_FAILED); 761ad8d7c7b548 Naoya Horiguchi 2017-07-10 2128 } 761ad8d7c7b548 Naoya Horiguchi 2017-07-10 2129 ea6d0630100b28 Naoya Horiguchi 2021-06-24 2130 return identify_page_state(pfn, p, page_flags); 761ad8d7c7b548 Naoya Horiguchi 2017-07-10 2131 } 00cc790e003693 Shiyang Ruan 2022-06-03 2132 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki