From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACDC8C25B74 for ; Fri, 24 May 2024 23:26:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 227F96B0088; Fri, 24 May 2024 19:26:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D6996B0089; Fri, 24 May 2024 19:26:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 09F456B008C; Fri, 24 May 2024 19:26:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E0B466B0088 for ; Fri, 24 May 2024 19:26:46 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 53D7740A52 for ; Fri, 24 May 2024 23:26:46 +0000 (UTC) X-FDA: 82154876412.05.65279D3 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by imf15.hostedemail.com (Postfix) with ESMTP id 72EEFA0006 for ; Fri, 24 May 2024 23:26:44 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=kdOpX4xW; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf15.hostedemail.com: domain of keescook@chromium.org designates 209.85.215.176 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716593204; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rAjF+8L3fyaBjPnruoNhZhHPvWxDSPr1FotbktRhuLw=; b=44CFYOIMHTqK0uSmggpqPjm34Bs7OyIN5mRyUtuvauYIs/CUCcnVPTnfAXIuyMJcmMRYxi vh0KQVmJLpib5iuhKpXoRgFiysq/E+dE2ALekshZZ0WXCY82uZshRujsgte+542K8+Z/Jb fzS7fjuX2CiyBVLle07Vghh9RWQrIR4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716593204; a=rsa-sha256; cv=none; b=TftZBR4r8BKhdSt/7xz7TFy5at4CZ4IFWW5GvJldzFe9CYgyYyg0tfobdrdVyKHsnoub7g b/AUiEqMevhYK49pfE0mxm8cdZORfl8+bQx9xGDJoUJAE5CNIZg3rwBCbiD6wRYYG/jjMp wy+nfecIo72T6l/g0NgbU6EghkQ5DNI= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=kdOpX4xW; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf15.hostedemail.com: domain of keescook@chromium.org designates 209.85.215.176 as permitted sender) smtp.mailfrom=keescook@chromium.org Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-68197de7400so1188786a12.3 for ; Fri, 24 May 2024 16:26:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1716593203; x=1717198003; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rAjF+8L3fyaBjPnruoNhZhHPvWxDSPr1FotbktRhuLw=; b=kdOpX4xWs5htv+mQtzRFphn2JGVwk3BSsBIzVaHAUunUbG8Aga9xdVtYHILQ4KoLDK bVvA86wRH7zwMLsVeL3FPRE8vbJrOmz2SG2HBAbYP6c91ef+W0h6PROHe3z04psS+uXO 8M3i/9Dd8cjwrou8SfRx9zLNz6PLJ+9mSdwMk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716593203; x=1717198003; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rAjF+8L3fyaBjPnruoNhZhHPvWxDSPr1FotbktRhuLw=; b=rQl1P0+D45V1kZWXfebzdkiKe/Y24RoFCH96AgDUnDnAMEEn9223aa4rRfCvzgIYzo nQTbUzFx9ibldt8lm/ZdAKn9DE7nku7bLW88ZtWrMn4y6fu1rdNvQHWpu0EFViJeBWKV HkVcvx5mWplTV87eHDSukW1QcXrHdYf+rjTpkWUmG4Tu/3SGerSJlZzINhrvUhsV9QPU eM+bSj9u8guevZ4nAg5OpxOW1edhmGBf3WPlnkCgXPbIVRgfg9+i2tfck4CXST5HBjzq 38CoIfHgNDLemDyAAk2EHQAY6MlIRZ5u3ehnIuWEPpAYin+quqfZCS5XEinuknbs4por t+3A== X-Forwarded-Encrypted: i=1; AJvYcCUJ3F2+FWU3b/a7YtKWB4luUJXZX1PNdJ8rHE0Xns/5Gf9pXau2iOEwqvfq8R3f8xz2HGCae1pnwox1HdsPGpgO6qI= X-Gm-Message-State: AOJu0YweMUFucvvOa0M16Usty/U7ZltS5BbRXwX4ln8nxPTFdlXk0Ryo x9IB9F84rVDKeYcxdj8ZC0DMMwS4ENKVhq78wS0RcaLrk304YHjzFgd5R7XMHg== X-Google-Smtp-Source: AGHT+IEKSUTMSPiBH8r09nVCDOLoiwzQ16beQH4Ep6n2vku2uU40EqC3Cg63ix+EKM+uTQAs1qDohg== X-Received: by 2002:a17:902:e883:b0:1f4:5b00:401 with SMTP id d9443c01a7336-1f45b0008c4mr19940655ad.54.1716593203148; Fri, 24 May 2024 16:26:43 -0700 (PDT) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f44c7592c1sm19078485ad.57.2024.05.24.16.26.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 May 2024 16:26:42 -0700 (PDT) Date: Fri, 24 May 2024 16:26:41 -0700 From: Kees Cook To: Vlastimil Babka Cc: Christoph Lameter , David Rientjes , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kent Overstreet , Suren Baghdasaryan Subject: Re: [PATCH] mm, slab: don't wrap internal functions with alloc_hooks() Message-ID: <202405241625.9FF3B5E@keescook> References: <20240522095037.13958-1-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240522095037.13958-1-vbabka@suse.cz> X-Stat-Signature: dpca9cfw7xegjunhfou39edfwa5q4jf5 X-Rspamd-Queue-Id: 72EEFA0006 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1716593204-199719 X-HE-Meta: U2FsdGVkX1+HSnm0be5nqDkWMijhdWmDQTRvE/El52HOzZzT0kT7o7kMPy+Yop/MMb/CqcB0RuhRX77jQ78vwLOW1spsQX5diU0RLpuiyzLZ6oJwGE/4p4xOCVl557uHMz3FfW1+YRmPXauK+XN7uDRA8u6Nz+s6KL9xsiZccytqYkPnsl2MV0p3eRKFJ7BGFproNC1flqrvLqc2DuW/SONfOI0oXRu6sFRO7qFV13RaGZuJ8O8uFdG974B3VCQ7aXupzFWTetFx7oj5ePyZigLBdDoJ9NgZFb6Op6DPm7/4D5ZSv+jvRePDVda8CAmAiT03VnwEjLyNQsbNfW+QWs6xm0Z8k/a/xCD4Gyr19NEtyYPvUf4ulAAm0VroI3g6jlXttx1CQ6X2CZXWr3EqAfMmzWHs5AjGflTBax7U7L/fLLTK6hDgtJxpKeATETMoudtLvP2kh1jZG3T7WsemBQ/1DFwUliN+x9XXw50fgVKAzfvOcH/u3RirmHeDuqaz1vjob56Luj9HDhFaddGnUU37YIT5ekExX1sGfeLkqx5UmT9gAIIFtpzNZQt0QPZTdSW/k7z1gFMtj3G39Pl+NL4i8gC9BV+7wW8VWPrCuikmIrqIVKXDh5eS1RsKOmHEgysF7oU1Gy1BgKh+/zJ9AEscAz1i27n/DYRYZMdg+GwnQdBbJKZ9yHGk3xJzoCUHJKuj7KxADrvTiJgIC7ns/7lIqpCTBJ/EHexl7bNlajwTWO33J/LTJtC7XZ1ebSFLQh9UrvsZcQFH7L4c++887c33LprmyqcHGL6ewtOJpbGQZOKXEN2HBy1JblHNpRx1rCkpys7eOFD84PHmsEDFR/WMOyWIbp/lnP4vwkbrVdwqlDbSrLA/GbQcwdFcyZQNuWkWNb8iN7t6VCFOZlVXM2RVRzePPRpIEa/oYnJn0TMoNFkAtEUyVT/mI0dtrEXim16at/neoi2cDryNz7s AHg6s6gc 61/hQmWVO6uhYqeSn1tKAvE6mJEM0bjaBQfqXzMi90tVi5dLIkcqZx3wbcOblWDGA3e3eUUVWfApSctKmvbiMVt6qxamwP9U0iBvNecVYyMK7t4FHzPc0q8p3gcahjfz/pwsgSvTF+AP852MqK+hzZixOmyc20rdurhWUBiPeK7RVWwvtWn2hkUvIRae7Rr/FafBWjOgDcMBd60vhDBDHyN5DETZf2BUHiXQIo++yM+CUNsMTyuvYzBa4cqXPSRoYGUyR1NYLAl+NsJMB3OI49RIV3LbiH+QizcedUy99MxGM6KMg6M475uwdWs5WqIb6Lvkt4JSLLIwHqwC5BzA1VpV1OczwI1BqilSq0pH2+C8wq+kONoQgWztgO0QxLNvugNT0bUL26sgiqlhye3fAWXKK+clWr+InHHKWHQx8DXHFrt0NuANf8H7YBnZt5ZFKMQ3DiWkfJ4y3mvzY8ewsHZEF9g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.296353, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 22, 2024 at 11:50:37AM +0200, Vlastimil Babka wrote: > The functions __kmalloc_noprof(), kmalloc_large_noprof(), > kmalloc_trace_noprof() and their _node variants are all internal to the > implementations of kmalloc_noprof() and kmalloc_node_noprof() and are > only declared in the "public" slab.h and exported so that those > implementations can be static inline and distinguish the build-time > constant size variants. The only other users for some of the internal > functions are slub_kunit and fortify_kunit tests which make very > short-lived allocations. If it's only internal, I'm happy to drop it from fortify_kunit. -Kees -- Kees Cook