From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 495C8C25B7A for ; Thu, 23 May 2024 21:01:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AA34C6B0095; Thu, 23 May 2024 17:01:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A53216B0098; Thu, 23 May 2024 17:01:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 942026B009A; Thu, 23 May 2024 17:01:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 782E06B0095 for ; Thu, 23 May 2024 17:01:05 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2B26A1C10CF for ; Thu, 23 May 2024 21:01:05 +0000 (UTC) X-FDA: 82150880490.03.F39695B Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf21.hostedemail.com (Postfix) with ESMTP id 445C01C0025 for ; Thu, 23 May 2024 21:01:02 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=doWioVeW; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716498062; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fz6C4rTluib+JFtAS5ELTQqLXEuP3SgExV8pay9i7vQ=; b=2HxtNgkV+ZT4oc6Ac+RPX1ZduPuWKC/duX8Dp0k8ZkMQQzOefIdWxWfmhwj72InZ9FwSi/ ZLD5Ip0fbGzvZutntJ+rMJCJg7bplPo4eg5fMno6yA23MelsmKsmug/jgZnWzmkFM+I6HP nwCg9mnBEtbbGMwKeQUeHXXtQfa+5gE= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=doWioVeW; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716498062; a=rsa-sha256; cv=none; b=ZIMdU+LD2+YsLq8wmy7H23/4kphjS/jWSJpBVF4VbJEXMRbek03LKj0lwRvSRdJkPfHz4x iWcLpDVmxTw64WO9lc4dUnhRGkhUGCEiju0P8gUYviYRnUxhpcLVo3LFLkD30P+MZVSB1k JjtUKLebotlghtHiZXNf10NS6K3Lf/4= Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1f3423646b7so9354545ad.0 for ; Thu, 23 May 2024 14:01:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716498061; x=1717102861; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fz6C4rTluib+JFtAS5ELTQqLXEuP3SgExV8pay9i7vQ=; b=doWioVeWKXjax9P6BAY1qhOWTV4q4cEBCAWprXyCtAAjhsnPfGVxnS5Q1UM8iBBeHR nZZvyYVBXfGHRlLfqf4gS4MCxO/+o3A0pTSkx7+dWPDs6BZYlb8+fbfe6GC7RKXD9q5x FR5+Bvt6xMrkTHicStwOyqFu/oEY/q/WzBnVZCT34mCsPzgpc8ooXAT3sELa6aEFy2W1 R1KZ/owkB8MJg+Ii7OxLs2WWX+ZFms0/aj3bV8y1hgdpbWCqnv/wmkA9J3F7fy+s60vT h2TpIPMo67UYz1CkLsZ5yyZPQMDrQF8J0HsAZoVJbBNjjG7OJswoY0n6Xr3hYX9OhMXr Z75A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716498061; x=1717102861; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fz6C4rTluib+JFtAS5ELTQqLXEuP3SgExV8pay9i7vQ=; b=BaalMpJjeX9tuRKQE2Td07vgsN11AQJP4HpLhfezqi6UaT9YWColxKBJwSaZYzSpKr U84Wo2oDaTyobpieoRQzIsvA01/eB7lv/CNUnka1g0lN4hkz7Fma46yVxEBsKYiAhN/P xWyaGfz7Hjtw6LnwN1On/DbTQPf8lR3Gtn4asnbOWtlxnGKmjbxnbnnQbwaJTtBOk1hJ 4Q0c7x4TcJYyXjMXlowFQFWStFHD12Eief3qtY8bRQLzdOU9L8I8fJ2iirLc15LYt+WB KRQASekWvqdRMD+1gZpsWDiUCUwh8mLLS2arB8QKoMcuq0fm8cc+KaD4VdgeOrOB5qRd a9mw== X-Forwarded-Encrypted: i=1; AJvYcCWns8FlQpZ4JUVs0gbsrCXHRaFZLGL9qQE3R8atMrAKNYOUenPTSvA45LoQR8mEGN2XsVw6yl5prMUCE8pOslAK/CU= X-Gm-Message-State: AOJu0YyM3tgrTiAJ6QxvRcLMYKxthfAIOjQg1kZSeszKQrue7/0bpUvy zch1SCok951PES778NXzi6ZMWRKqWXp6U5qtMMgLdFtJUMTmMA6y X-Google-Smtp-Source: AGHT+IFS23wiPQKouuaen4geZNnXoXPiVbTmYmxSZgo7tQLACdNxUr3Ngi4qQ0W+oJANbqvL4AK0Kg== X-Received: by 2002:a17:902:ce92:b0:1f3:3d07:d6e3 with SMTP id d9443c01a7336-1f448740bfemr4641085ad.34.1716498060780; Thu, 23 May 2024 14:01:00 -0700 (PDT) Received: from localhost.localdomain ([2407:7000:8942:5500:aaa1:59ff:fe57:eb97]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f44c797ca5sm261005ad.71.2024.05.23.14.00.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 May 2024 14:01:00 -0700 (PDT) From: Barry Song <21cnbao@gmail.com> To: lkp@intel.com Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, oe-kbuild-all@lists.linux.dev, v-songbaohua@oppo.com Subject: Re: include/linux/huge_mm.h:285:undefined reference to `mthp_stats' Date: Fri, 24 May 2024 09:00:45 +1200 Message-Id: <20240523210045.40444-1-21cnbao@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <202405231728.tCAogiSI-lkp@intel.com> References: <202405231728.tCAogiSI-lkp@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 445C01C0025 X-Stat-Signature: c3h8tiiezxijoqeq64cr4f6qqos88jqg X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1716498062-783049 X-HE-Meta: U2FsdGVkX1+JB0+rx4gfw9l0I2GkMWvq5lZS3GmTuBfW6/FgI8zXhUmOMbym3ovTerkvTb552lkKVzHiWAdIg9sDf+GJOEqkpbaI7gE9LroxqKXphoz+/BrmF1zX03exWVLYsfHMkNVCs3/QkequoOp3zObQ4bVBnsq11D08oZPmdmgm92ae0rWXnz6Fc4oBmyxvOtK2x3itNQspVOefmL+HjG76/gqCQip3t7u2i9YmE5KifryTlgdQrsBxN669cHS0S0UGDTS2pnvTXbMRQdSmtFxm6EN3BM8UI5TjQg1uk1URqB4bHGFauk+m0f9ymZt9RSvxsjGW9UVy49/MFHpmfSf+g93BvMXvQfPaAljJlvLMr1Xy6OBz7uj2PtjzAK4fnmIzwv6gMihnLzHYjP7JmCFXf1atYsZGP2+EwCmkANW+iZ1tfV9qYJcGIxhpOoC1Bs396rr0aYxEunpzKYAMj8imLn4jQYKTfsPoH7TskxGCPJJ8i4xlImw/oVjlRVazyqrRTLWS7bKU7bGcPJ83zCedqt4FoIN9KDxG5z7RFklWd4ih5s1aOAHVVBpxhMXyH3/4so0IBw4Otnu4Qyye7hWpElwSp1EFO0pAt1QTjK+ndNZlyYOluPw1HQSoHuhBMSrcqp8HvcRs9lMdiUiwPoURKefSyQuq6IGZ2YTUVoetF/YY6HD3DY0Opn41eG/+g3D6515N3WW6o4fSobLBx3ZzewGx/YkkMS7Hy8ysOUZQP4oeX9nXF9pKWlulE80PNlk35Nye5t0calgHuhP0UCuRYfyuTNbqgQV0OiKDtwQLxcj9rayXgWVesSY+k0uphmAwJOVwsY+c8KsrVZQBCZ8UOWTyha0YQt7LMUEAYtJfh9rR0STZxLrSB+SnbftCnRUA6VV6hmkwZotl3iSqHMrFBOFf8m0GmGdHV01Lcpp0OCwr0XinS+ADKrxficd3yAGL1+p05fqwjTk Jr5ofJQ6 vOfBVHDjoJtqQU2lNanwUksMcfJ8oemylQEw82tezg446x3c5WB1TzCB+b+IQ81yzYzFoyHFyHeABXfXxGgYpDsMTYnuEx3H6ANk6n8a3MzH06V+RuDa1fKClnzDR8k8fpMDdNLptxOzmZV+08NRr5zKxb19zxOviyLEXobWbs9bsUyDTqembXJD4L++wTbiNP30kJdzXS//b7mP2u1uhYQmWWzkZQOmlTSK0EFVnFPFgHTTBScNGEbIBofNEFUZriwUw6S2lXPIlqODdBQINGbQs0x9AteK+w/dhyiWBx8OfqFZ77pJsNnBeqT6x24rDo7SO0rkt+TG3e59mjGExTDdd937wupUhpOURrFS6dDvaM9HyToG2Me3JduBc1TCjJgnLj/VNCLT+IA8omVtqNH/717Gk4hhusNL2E3SKHUgQo0zJN2lNQJUrBns24rtuyLAi4P1G3fGn4nZOxUHFD82KqUauktkA0HkKrlwgG5Ujg1OIwbhOV6+2SgyyCmnW8I5Q3A6lydhT4wdd9kJrHTBPYRJxVDYVjZJqSN9/3iw+HR2JhS9g+h9DrsLF4fyyy1T0fT/TORsB4m+TTEZl3qfnhLwPc98P12O0U4wNxQhLORXqGIU/xbYi03eaReyFd70EJSHmNNU+diJKgjl57aVpfX9oG5JKSDoEdTuB4BSd8J7FTBHA6utGQIfLQ2O6KW3RR1fsK2N1lbk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > head: c760b3725e52403dc1b28644fb09c47a83cacea6 > commit: ec33687c674934dfefd782a8ffd58370b080b503 mm: add per-order mTHP anon_fault_alloc and anon_fault_fallback counters > date: 2 weeks ago > config: s390-randconfig-r005-20230226 (https://download.01.org/0day-ci/archive/20240523/202405231728.tCAogiSI-lkp@intel.com/config) > compiler: s390-linux-gcc (GCC) 13.2.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240523/202405231728.tCAogiSI-lkp@intel.com/reproduce) > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202405231728.tCAogiSI-lkp@intel.com/ > > All errors (new ones prefixed by >>): > > s390-linux-ld: mm/memory.o: in function `count_mthp_stat': >>> include/linux/huge_mm.h:285:(.text+0x191c): undefined reference to `mthp_stats' > s390-linux-ld: mm/huge_memory.o:(.rodata+0x10): undefined reference to `mthp_stats' > > > vim +285 include/linux/huge_mm.h > > 279 > 280 static inline void count_mthp_stat(int order, enum mthp_stat_item item) > 281 { > 282 if (order <= 0 || order > PMD_ORDER) > 283 return; > 284 >> 285 this_cpu_inc(mthp_stats.stats[order][item]); > 286 } > 287 Thanks, would you please test if the below patch fixes the problem, From: Barry Song Date: Fri, 24 May 2024 08:50:48 +1200 Subject: [PATCH] mm: huge_mm: fix undefined reference to `mthp_stats' for CONFIG_SYSFS=n if CONFIG_SYSFS is not enabled in config, we get the below error, All errors (new ones prefixed by >>): s390-linux-ld: mm/memory.o: in function `count_mthp_stat': >> include/linux/huge_mm.h:285:(.text+0x191c): undefined reference to `mthp_stats' s390-linux-ld: mm/huge_memory.o:(.rodata+0x10): undefined reference to `mthp_stats' vim +285 include/linux/huge_mm.h 279 280 static inline void count_mthp_stat(int order, enum mthp_stat_item item) 281 { 282 if (order <= 0 || order > PMD_ORDER) 283 return; 284 > 285 this_cpu_inc(mthp_stats.stats[order][item]); 286 } 287 Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202405231728.tCAogiSI-lkp@intel.com/ Signed-off-by: Barry Song --- include/linux/huge_mm.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h index c8d3ec116e29..09c5744d9124 100644 --- a/include/linux/huge_mm.h +++ b/include/linux/huge_mm.h @@ -278,6 +278,7 @@ struct mthp_stat { unsigned long stats[ilog2(MAX_PTRS_PER_PTE) + 1][__MTHP_STAT_COUNT]; }; +#ifdef CONFIG_SYSFS DECLARE_PER_CPU(struct mthp_stat, mthp_stats); static inline void count_mthp_stat(int order, enum mthp_stat_item item) @@ -287,6 +288,11 @@ static inline void count_mthp_stat(int order, enum mthp_stat_item item) this_cpu_inc(mthp_stats.stats[order][item]); } +#else +static inline void count_mthp_stat(int order, enum mthp_stat_item item) +{ +} +#endif #define transparent_hugepage_use_zero_page() \ (transparent_hugepage_flags & \ -- 2.34.1