From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37791C25B75 for ; Thu, 23 May 2024 19:13:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A52646B0083; Thu, 23 May 2024 15:13:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A01B36B0088; Thu, 23 May 2024 15:13:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F0516B0089; Thu, 23 May 2024 15:13:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 71E516B0083 for ; Thu, 23 May 2024 15:13:50 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1382116042E for ; Thu, 23 May 2024 19:13:50 +0000 (UTC) X-FDA: 82150610220.24.ABD8588 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf26.hostedemail.com (Postfix) with ESMTP id 5F635140016 for ; Thu, 23 May 2024 19:13:47 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=0PL4Ar5s; spf=pass (imf26.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716491627; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DaSZZvzNRbRCRLuNfpy0v+O8FqRfuxuYoiMLYKLlK5w=; b=N1rvEMd2mz4CTTozV+QXR6ZI6D3CBaG+EMHeVG5T/Jdf2dvzXGK5TRuhZWk7XN5c6Pybfk GwZWq3EjKKGz1EBsNXlUaMBi+eipuXkw87f1BdrkRTQj9bhWdQL0zEJczkS/ciekIupF3M muA7369xl8qSm9jJzKb9dX/4Cyoltp8= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=0PL4Ar5s; spf=pass (imf26.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716491627; a=rsa-sha256; cv=none; b=oYZajGvHII2ryIF0pLUZXBOuhZFlc0LSXt6ZDXoeRB3uu98ny14yj+Ggjec33/OPW/kk1/ ONKQn3c+i4h56JhagqOhmSLMShnLiYFvMHWm/idCg+WO0WIhCEw8OnDqiu7ZD+mYe4VJWN Q5RMlSQMb+zUoeVL9rUP8/ODDxQcShI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 3E60A6284D; Thu, 23 May 2024 19:13:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88791C2BD10; Thu, 23 May 2024 19:13:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1716491625; bh=+JOFaXZ73U5uGnk9S9gTiM6JcwXiBpR5hDiNMxbHwEs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=0PL4Ar5sbdb9hd+8AwsrwqUSMI0PeChmRoviG1HBMJXK22+BmiR2yY5/loVJ7TH86 /kUFqgPLQNauTjDcASYiUW/QhCFYj5Vtngv18YndVjQ85l4RGgnMzIDl4cO9IOgmQo GwEFRy1I4FOOsvUe0iHS0V+Llx4IUJN1X/03mynw= Date: Thu, 23 May 2024 12:13:44 -0700 From: Andrew Morton To: Donet Tom Cc: Shuah Khan , Matthew Wilcox , Tony Battersby , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Ritesh Harjani , Mike Rapoport , Muchun Song , David Hildenbrand , stable@vger.kernel.org Subject: Re: [PATCH] selftest: mm: Test if hugepage does not get leaked during __bio_release_pages() Message-Id: <20240523121344.6a67a109e0af2ba70973b34b@linux-foundation.org> In-Reply-To: <20240523063905.3173-1-donettom@linux.ibm.com> References: <20240523063905.3173-1-donettom@linux.ibm.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 5F635140016 X-Stat-Signature: pdp37jaqjchj9dker7784soem3hx71eh X-Rspam-User: X-HE-Tag: 1716491627-860215 X-HE-Meta: U2FsdGVkX1+Su+TCojSEA9WwfqkpaI/s87MgYyRnC3UwT0tEODW+qCnZJhn7KAyalpXQVEi/ZzVURnVueRx+ZxEUJ3n0UZrjxKW4zp1R7yDGiOQLdpKjmfGPhKEZCoYHKAfuWfzLkhzQhb5rQ/l/D3p4qpfHCsLDodMGeS/FZoKjxOuwHid3NZGa5f1wJoaDDybqJIRq94Sb+k3o5Zk6mivtv6WXZsJMmfiQxSbKzupQPsaTx5PJUoY+pNmpdrdUsAZDUn+NkcPp6g5KxnK+fw/3XkfrpmQDr6aCr2pvdbYQS/ElyBD5OiHYa0sB0H8Mn8rPYE3zLjCr1k+5lyDOcj2CfVnRMRUYsFIEjRZoZ/zunjrt/gPfRvrvXeIzBRC6pcbU7TMitep+A0ncP1TTp+aSNwq8Lw2ihYIseuk+FphES9PHCFNE1U6EN1963VRW2CBAt8ucyre+M3esh291HMCzuR4uGqk6Jjmy01AGnnjYiEuAbxtOjRC1LKTg15AJSKXYbtIPlCyZOlCfv5uv09vzGQr6flaNvjIxfIZScZaPIdh6nQSLNlZcS+6WmQeeaAYnax3JNHv9Iw1sw+s4NnYdYIlK1QntjaVC7s+oHxfvD1Y+jMlNmaz+PCsejSYtM0dlPuBkJwUAzEtZj2CZUEj3ELvMmKji/IhsoXiSA8tUZNZBVOv4P338NSLgDP9Yd3laP+SDe5qXJEjmXDps2VjLaBDAAWfvlUludxyNWdRll2wQ7/rQa3RhTScRtUImM0InK8hvEDRdbs680Or4k8hC5YsiGFg9Jn9/9krkPZlAkpPSMWggJt1ZBvQ+VOljo9mz74QGET9kH9Wz62KqiqLWHJsGTrcJwdk3npJUfTTorHGCwokRPiPxlGI0NifyLXaQKxFXfF0NtskvZYooJ+VJOdCmAfncgzrJTf8N34R8IT8bxaMyPQVe2ip9Ynu4rq7z2Y0z1y+uEf0AEeh 8V2tp7vi Su4kvoE0Z5c4pVFns2Q1La/L6XGNpjNCn/rVcoZA4L45zFgndxlMPaSBIQ9+N3UErkiiPUtyAHxe7qPpAAfwvv6mSuqrfqsuy/0w544StmiyPQ4jfzb24Xpilb/QjmzGYBU0akfuYXsMczwR/M4cdaZiaaUfeOvDjPq0V6LyXP9GOTm79F2bSlt9HBBIXwhFFbuqjBO6+lJc/wIKRG59dktOJ+lI5WZMSReaitOmBNpemivyy4NAb9XiE/HKn1OzPJhL/V9K9NykwpEQamOwGd4vsGArG49+vvoTBgp7KnHO+MxMD7dhNJNEwMUjr3Oj67Y8ktFDkQgvzFIyGk3iIpFSrlM/nCdbXjERg5VY5V0DvbtXFM5c2xv8QDymX1AGMqsSvjA2FgNv+K/dZXEWnWnAMkV6e608ImzQ7ZSWDfrpMOEI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 23 May 2024 01:39:05 -0500 Donet Tom wrote: > Commit 1b151e2435fc ("block: Remove special-casing of compound > pages") caused a change in behaviour when releasing the pages > if the buffer does not start at the beginning of the page. This > was because the calculation of the number of pages to release > was incorrect. > This was fixed by commit 38b43539d64b ("block: Fix page refcounts > for unaligned buffers in __bio_release_pages()"). > > We pin the user buffer during direct I/O writes. If this buffer is a > hugepage, bio_release_page() will unpin it and decrement all references > and pin counts at ->bi_end_io. However, if any references to the hugepage > remain post-I/O, the hugepage will not be freed upon unmap, leading > to a memory leak. > > This patch verifies that a hugepage, used as a user buffer for DIO > operations, is correctly freed upon unmapping, regardless of whether > the offsets are aligned or unaligned w.r.t page boundary. > You have stable@vger.kernel.org in the mail headers, so I assume you're proposing this for backporting. When doing this, please include Cc: in the changelog footers and also include a Fixes: target. I'm assuming the suitable Fixes: target for this patch is 38b43539d64b?