linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, David Hildenbrand <david@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Matthew Wilcox (Oracle)" <willy@infradead.org>,
	Mike Rapoport <rppt@kernel.org>, Minchan Kim <minchan@kernel.org>,
	Sergey Senozhatsky <senozhatsky@chromium.org>,
	Hyeonggon Yoo <42.hyeyoo@gmail.com>
Subject: [PATCH RFC 2/6] mm: allow reuse of the lower 16bit of the page type with an actual type
Date: Wed, 22 May 2024 23:03:37 +0200	[thread overview]
Message-ID: <20240522210341.1030552-3-david@redhat.com> (raw)
In-Reply-To: <20240522210341.1030552-1-david@redhat.com>

As long as the owner sets a page type first, we can allow reuse of the
lower 16bit! Restrict it to the head page.

We'll use that for zsmalloc next, to set a proper type while still
reusing that field to store information that cannot go elsewhere for
now.

Fear of running out of bits for storing the actual type? Actually, we
don't need one bit per type, we could store a single value instead.

Signed-off-by: David Hildenbrand <david@redhat.com>
---
 include/linux/mm_types.h   |  5 +++++
 include/linux/page-flags.h | 22 ++++++++++++++--------
 2 files changed, 19 insertions(+), 8 deletions(-)

diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h
index 532a3030405d..6dae8e15037b 100644
--- a/include/linux/mm_types.h
+++ b/include/linux/mm_types.h
@@ -168,6 +168,11 @@ struct page {
 		 *
 		 * See page-flags.h for a list of page types which are currently
 		 * stored here.
+		 *
+		 * Owners of typed folios may reuse the lower 16bit of the
+		 * head page page_type field after setting the page type,
+		 * but must reset these 16 bit to -1 before clearing the
+		 * page type.
 		 */
 		unsigned int page_type;
 	};
diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h
index 104078afe0b1..ed9ac4b5233d 100644
--- a/include/linux/page-flags.h
+++ b/include/linux/page-flags.h
@@ -942,17 +942,23 @@ PAGEFLAG_FALSE(HasHWPoisoned, has_hwpoisoned)
  * __ClearPageFoo *sets* the bit used for PageFoo.  We reserve a few high and
  * low bits so that an underflow or overflow of _mapcount won't be
  * mistaken for a page type value.
+ *
+ * The highest bit must always be 1, to make page_has_type() work as expected.
  */
 
 #define PAGE_TYPE_BASE	0xf0000000
-/* Reserve		0x0000007f to catch underflows of _mapcount */
-#define PAGE_MAPCOUNT_RESERVE	-128
-#define PG_buddy	0x00000080
-#define PG_offline	0x00000100
-#define PG_table	0x00000200
-#define PG_guard	0x00000400
-#define PG_hugetlb	0x00000800
-#define PG_slab		0x00001000
+/*
+ * Reserve		0x0000ffff to catch underflows of _mapcount and
+ * allow owners that set a type to reuse the lower 16 bit for their own
+ * purposes.
+ */
+#define PAGE_MAPCOUNT_RESERVE	-65536
+#define PG_buddy	0x00010080
+#define PG_offline	0x00020000
+#define PG_table	0x00040000
+#define PG_guard	0x00080000
+#define PG_hugetlb	0x00100800
+#define PG_slab		0x00200000
 
 #define PageType(page, flag)						\
 	((page->page_type & (PAGE_TYPE_BASE | flag)) == PAGE_TYPE_BASE)
-- 
2.45.0



  parent reply	other threads:[~2024-05-22 21:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-22 21:03 [PATCH RFC 0/6] mm: page_type, zsmalloc and page_mapcount_reset() David Hildenbrand
2024-05-22 21:03 ` [PATCH RFC 1/6] mm: update _mapcount and page_type documentation David Hildenbrand
2024-05-24  8:58   ` Mike Rapoport
2024-05-22 21:03 ` David Hildenbrand [this message]
2024-05-24 10:04   ` [PATCH RFC 2/6] mm: allow reuse of the lower 16bit of the page type with an actual type David Hildenbrand
2024-05-22 21:03 ` [PATCH RFC 3/6] mm/zsmalloc: use a proper page type David Hildenbrand
2024-05-23 14:55   ` David Hildenbrand
2024-05-23 20:38     ` David Hildenbrand
2024-05-24  8:52     ` Mike Rapoport
2024-05-22 21:03 ` [PATCH RFC 4/6] mm/page_alloc: clear PageBuddy using __ClearPageBuddy() for bad pages David Hildenbrand
2024-05-22 21:03 ` [PATCH RFC 5/6] mm/filemap: reinitialize folio->_mapcount directly David Hildenbrand
2024-05-22 21:03 ` [PATCH RFC 6/6] mm/mm_init: initialize page->_mapcount directly in__init_single_page() David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240522210341.1030552-3-david@redhat.com \
    --to=david@redhat.com \
    --cc=42.hyeyoo@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=rppt@kernel.org \
    --cc=senozhatsky@chromium.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox