From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FC88C25B7A for ; Wed, 22 May 2024 21:03:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B01866B008C; Wed, 22 May 2024 17:03:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB1516B0092; Wed, 22 May 2024 17:03:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 978C96B0093; Wed, 22 May 2024 17:03:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 78A8F6B008C for ; Wed, 22 May 2024 17:03:51 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 32013124BDF for ; Wed, 22 May 2024 21:03:51 +0000 (UTC) X-FDA: 82147258662.24.ADD9DF6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 85D6C40013 for ; Wed, 22 May 2024 21:03:49 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WmvHLmxF; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716411829; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=8bJaVETnceXnZKEpoYXTppVEYfiyqOTFMzgclBfDxIg=; b=siryYqlfkKOb2V/kU4h4CBpVWQO0j/Hlybm0iay8SWD65AbEp7l2ogVETWZhUQusbZmcnx EsrwYNDZDZQ58Q2ZVhTZQZ8me75wnpH74kw4H8+6l4wfnJgs9MyhE4bj5tD7lJo6vzdnLA 7mTOdjB9zH+wsp2aYbrfDzoCiVnW39A= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WmvHLmxF; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716411829; a=rsa-sha256; cv=none; b=ll7JeQZPJ/Rb9nfNgpNieKp9dQvYK6hWn9kyQboRDWaAo4x1VWGr5EvtT9gMe/6kieuUGR e40DFV3S8a0ouRxQ1Yb2jcXmoOKUPuxeITd8HF6yoXSSJ+vuUTK7Hw4mHivRGIJaaHlzAV Wrb3mWloh6B3mf40LAPQ2AfiF+MvbSg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1716411828; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=8bJaVETnceXnZKEpoYXTppVEYfiyqOTFMzgclBfDxIg=; b=WmvHLmxFVg7jFo0KkSlYO+9GBCbnHw2ztI7r2pvvMbFzkQMkajOP4MuqphmwYOX4Y+zVc1 Xuo11p3iIvGfXEm2qinmuZ7Rv83ekdGGO6UMK49Aj49F1VnMUG53xOYZDKes3YI5izugQU xB5gJNpk4ux8Xjae3jm3VKbJtpxMdXY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-369-8G2Dz7GxOOaDT4FP9uenVQ-1; Wed, 22 May 2024 17:03:45 -0400 X-MC-Unique: 8G2Dz7GxOOaDT4FP9uenVQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0546681227E; Wed, 22 May 2024 21:03:45 +0000 (UTC) Received: from t14s.fritz.box (unknown [10.39.192.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 82A9F7412; Wed, 22 May 2024 21:03:42 +0000 (UTC) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, David Hildenbrand , Andrew Morton , "Matthew Wilcox (Oracle)" , Mike Rapoport , Minchan Kim , Sergey Senozhatsky , Hyeonggon Yoo <42.hyeyoo@gmail.com> Subject: [PATCH RFC 0/6] mm: page_type, zsmalloc and page_mapcount_reset() Date: Wed, 22 May 2024 23:03:35 +0200 Message-ID: <20240522210341.1030552-1-david@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 X-Rspamd-Queue-Id: 85D6C40013 X-Stat-Signature: 6iuukrkkx9kq3su4pg9o1tfdt9tajfn8 X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1716411829-905547 X-HE-Meta: U2FsdGVkX1/rYraBEzkCHUw4yJ99F1V+Z05qQBiBKevZNBiZY9ked3dTQZpSOobq0360zVnv+bRVmbGqhwEjCr4o3hMuBr77OkxIPmNVdb8tIMDaJocWrUMd6POcw2dXIShHr0jZZnQAAsPnkUf2r1gT9qtdKAdXYSuW2mgK4a7tbuOUVCmUk1srgwawtPMg4+zxBVR349DflTntIya3rflH+eUgSkbLNO4yFBXioTq1jUW1kcBtAusnGTFCEX+DfBfxES1/PUajRT8iRKVVXoPJEzL+Lg4BxHKtFl6yHtu43F0oMT7zmFxoEi9727J+S82AzhztVcWHG3vkhUMCR/9U9P6j4WHOn4LXOd5I/grswRFvl3oJH9CHy9iLSIoGjj1XMjPyAY7Ozcz1UWL5tNuPJ+damWb5dpRj70l4NjO89724y+EmaQ99WjkH0yPgrrdape3v0irg7cIEeE9uPQa9Uxwrn30dExQku5X8GFhQ49XSqVIN/iz7JqrzPMCmaQBs/sw0/mnJxEjntvt6hIA1rNiGrjsefTHdX8yXLREMVjkAYfLGII8oqfQ23m3jdtcSWopa6LmCtL1Lf/fdertLQRep09BBOOZVKGAGOC7sfKowOGSTuWjVQNhNG991yn2s9dndnBWhZKCfwurD5Hkw8EbW9pA+inUjZcfJKa/654ag/eZZx8Iwbzu9/enrugqpmwheYgcPvhyDggrBuln1yCIKMxkeh3Lb11Pb/12zI5G3qHNXh1jpYVVX4Z3lbJsFLHEblDVQpWfhDc9Ncl+X2s0uGl6rFTDuqBBIlUSpIVTsC5OzDek8tPwiudmWKqZd3TLb9X1Uk5AyJwF6QxfIA6u0Ti0++YlzdtWRWPYrGa2K3FJOcETUjvgmr6YwzKJtbdxEgVBxDq7ZeLCpPOZfZUASpWhDpQnWLhIUe7Gg2m683U4CtezVjnC8HLULwaJjaFTeAsWDrc4qzQ6 GUDWw6f0 m/FA7fVE0Wo5+r3lCdAJEB2E9iwLfksbT/EMUBf/Ttpop1uDpKVrCKHDiCK3asPZ8DhbE4Z+c25Nmx8ZUPK+kVQOdrn9LNgx665hbYVBHGbME+deVHVrBtcpgsxfueEgkqIsz11XJ2HzAGiV/H1k0rCOIzpAQVNBdpOkh/L25pZ4XqIIvJptjHaBJjlXQeSM1wHZ7DzRFRdax7ga3f0QIe9vylVK7vO06QQvQvdD9H36KaWMYq6zYDdRDkS+kuD3zzl4owXQDub0VkRUwlJUrjssm7f2E5peTMHAyhjg6nK8rgV5vIzw54Zc/iAPRk1rtQvlp2ZJznPAl+EPYHooZeZsyHu0RTzUGozGsfxTIp+PFt77S8abyroCVtSxGoPjq991zoJxmXN4kQQoICHaEY+2+3nKztxxuxBydMvTWhJha/Ma/Kvi/C18V7MTIX0o/D5yUdk4tnZ0OyhnqcaNfyEGIw2aw8UO7Tel0bkkfHFjOWMjv63ulj23IRx4sigqsXHxgFOKU4RrDBdKI6PTFEiZAkg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Wanting to remove the remaining abuser of _mapcount/page_type along with page_mapcount_reset(), I stumbled over zsmalloc, which is yet to be converted away from "struct page" [1]. Unfortunately, we cannot stop using the page_type field in zsmalloc code completely for its own purposes. All other fields in "struct page" are used one way or the other. ... but we can limit the abuse to 16 bit, glue it to a apge type that must be set, and document it. page_has_type() will always successfully indicate such zsmalloc pages, and such zsmalloc pages only. We lose zsmalloc support for PAGE_SIZE > 64KB, which should be tolerable. We could use more bits from the page type, but 16 bit sounds like a good idea. So clarify the _mapcount/page_type documentation, use a proper page_type for zsmalloc, and remove page_mapcount_reset(). Only lightly tested with zram. Will have to do more testing and cross-compile checking. [1] https://lore.kernel.org/all/20231130101242.2590384-1-42.hyeyoo@gmail.com/ Cc: Andrew Morton Cc: "Matthew Wilcox (Oracle)" Cc: Mike Rapoport Cc: Minchan Kim Cc: Sergey Senozhatsky Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com> David Hildenbrand (6): mm: update _mapcount and page_type documentation mm: allow reuse of the lower 16bit of the page type with an actual type mm/zsmalloc: use a proper page type mm/page_alloc: clear PageBuddy using __ClearPageBuddy() for bad pages mm/filemap: reinitialize folio->_mapcount directly mm/mm_init: initialize page->_mapcount directly in__init_single_page() include/linux/mm.h | 10 ---------- include/linux/mm_types.h | 29 ++++++++++++++++++++--------- include/linux/page-flags.h | 25 +++++++++++++++++-------- mm/Kconfig | 1 + mm/filemap.c | 2 +- mm/mm_init.c | 2 +- mm/page_alloc.c | 6 ++++-- mm/zsmalloc.c | 23 +++++++++++++++++++---- 8 files changed, 63 insertions(+), 35 deletions(-) base-commit: 29c73fc794c83505066ee6db893b2a83ac5fac63 -- 2.45.0