From: David Hildenbrand <david@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, David Hildenbrand <david@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Mike Rapoport <rppt@kernel.org>, Minchan Kim <minchan@kernel.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>
Subject: [PATCH RFC 0/6] mm: page_type, zsmalloc and page_mapcount_reset()
Date: Wed, 22 May 2024 23:03:35 +0200 [thread overview]
Message-ID: <20240522210341.1030552-1-david@redhat.com> (raw)
Wanting to remove the remaining abuser of _mapcount/page_type along with
page_mapcount_reset(), I stumbled over zsmalloc, which is yet to be
converted away from "struct page" [1].
Unfortunately, we cannot stop using the page_type field in zsmalloc code
completely for its own purposes. All other fields in "struct page" are
used one way or the other.
... but we can limit the abuse to 16 bit, glue it to a apge type that
must be set, and document it. page_has_type() will always successfully
indicate such zsmalloc pages, and such zsmalloc pages only.
We lose zsmalloc support for PAGE_SIZE > 64KB, which should be tolerable.
We could use more bits from the page type, but 16 bit sounds like a good
idea.
So clarify the _mapcount/page_type documentation, use a proper page_type
for zsmalloc, and remove page_mapcount_reset().
Only lightly tested with zram. Will have to do more testing and
cross-compile checking.
[1] https://lore.kernel.org/all/20231130101242.2590384-1-42.hyeyoo@gmail.com/
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: Mike Rapoport <rppt@kernel.org>
Cc: Minchan Kim <minchan@kernel.org>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>
David Hildenbrand (6):
mm: update _mapcount and page_type documentation
mm: allow reuse of the lower 16bit of the page type with an actual
type
mm/zsmalloc: use a proper page type
mm/page_alloc: clear PageBuddy using __ClearPageBuddy() for bad pages
mm/filemap: reinitialize folio->_mapcount directly
mm/mm_init: initialize page->_mapcount directly in__init_single_page()
include/linux/mm.h | 10 ----------
include/linux/mm_types.h | 29 ++++++++++++++++++++---------
include/linux/page-flags.h | 25 +++++++++++++++++--------
mm/Kconfig | 1 +
mm/filemap.c | 2 +-
mm/mm_init.c | 2 +-
mm/page_alloc.c | 6 ++++--
mm/zsmalloc.c | 23 +++++++++++++++++++----
8 files changed, 63 insertions(+), 35 deletions(-)
base-commit: 29c73fc794c83505066ee6db893b2a83ac5fac63
--
2.45.0
next reply other threads:[~2024-05-22 21:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-22 21:03 David Hildenbrand [this message]
2024-05-22 21:03 ` [PATCH RFC 1/6] mm: update _mapcount and page_type documentation David Hildenbrand
2024-05-24 8:58 ` Mike Rapoport
2024-05-22 21:03 ` [PATCH RFC 2/6] mm: allow reuse of the lower 16bit of the page type with an actual type David Hildenbrand
2024-05-24 10:04 ` David Hildenbrand
2024-05-22 21:03 ` [PATCH RFC 3/6] mm/zsmalloc: use a proper page type David Hildenbrand
2024-05-23 14:55 ` David Hildenbrand
2024-05-23 20:38 ` David Hildenbrand
2024-05-24 8:52 ` Mike Rapoport
2024-05-22 21:03 ` [PATCH RFC 4/6] mm/page_alloc: clear PageBuddy using __ClearPageBuddy() for bad pages David Hildenbrand
2024-05-22 21:03 ` [PATCH RFC 5/6] mm/filemap: reinitialize folio->_mapcount directly David Hildenbrand
2024-05-22 21:03 ` [PATCH RFC 6/6] mm/mm_init: initialize page->_mapcount directly in__init_single_page() David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240522210341.1030552-1-david@redhat.com \
--to=david@redhat.com \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=rppt@kernel.org \
--cc=senozhatsky@chromium.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox