From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B0B7C25B77 for ; Wed, 22 May 2024 12:24:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CABCF6B0093; Wed, 22 May 2024 08:24:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C5AD56B0095; Wed, 22 May 2024 08:24:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD4426B0096; Wed, 22 May 2024 08:24:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8FEC46B0093 for ; Wed, 22 May 2024 08:24:10 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2A67C121464 for ; Wed, 22 May 2024 12:24:10 +0000 (UTC) X-FDA: 82145949060.09.091F48C Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2067.outbound.protection.outlook.com [40.107.236.67]) by imf02.hostedemail.com (Postfix) with ESMTP id 4FABC80016 for ; Wed, 22 May 2024 12:24:07 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=faHQ43JD; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf02.hostedemail.com: domain of jgg@nvidia.com designates 40.107.236.67 as permitted sender) smtp.mailfrom=jgg@nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716380647; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SSbvVyX2UW7i3gXl4aA5qOmp/W3Ow+5HG9O3i8ovLEc=; b=OGVTQNN+RIf5d1gMwmXHNzbQ61uP/x4TXrH8NdwrmZjG1Qeuzvbh8AS/iZ3mcexuoHXhuA ndFl/oZD+u+R2/WGvRAj4jZDjy0zbZm2RVm5NUhHdtXbw24YWeIceS6JewElr6ph7l4+lC MiT3ep8wyHtmlxw6pG312/ic4GhnQ5o= ARC-Authentication-Results: i=2; imf02.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=faHQ43JD; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf02.hostedemail.com: domain of jgg@nvidia.com designates 40.107.236.67 as permitted sender) smtp.mailfrom=jgg@nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1716380647; a=rsa-sha256; cv=pass; b=np+jm33GYY8pTJuFvOi3b3Vw8qLddcU60ZsxrPEi2A78pCIhB/pibPbRVLAz7p4/xE17tr P3qWndgohGDBreEar6HDOiF6Pmf1ZbgSyaxjz4HzRHnWShw2FIlu2IMRd6OE9Yj9135rA8 azMDQX2yuLiBViQSJ0IOKNAoDynRGfk= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F3KswqAcMfEuj/gaKkuLgRoi/D5xnF7axEnUrWVc1rriCRc+wtAOhIBeZrtUCURh4hoWKb/h4urmED7qf3UWKYSsbxrys2eTfjubBZLPtbxAGHFW1ES+5gs9vxQHcoHaLbdJOnoPZ9vyashK08kd2lPgwrhiCOBJYrnWmyVU6Y/lZP3nQK1edOLEbGhXD9yHcUQPgo6ctfXeF1sXMWF0k6f00lyfqgv5AkH7vODim78o76WlFaeEUUXm/3YlEVtKQNOnoyl4tjnrpCbeL8kuGH52VLHsaHuTbyAp11nm/KHHacxRVG01+mTJC8M4eQCn48e13bSC92qMOTkhLID2pA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SSbvVyX2UW7i3gXl4aA5qOmp/W3Ow+5HG9O3i8ovLEc=; b=G3T8e1F0ewudUtlu4lXUwqQOSVq6C/8fEztQxykL6bAxTSQXjiJc4/sEQ6TWyaUN16sAgWO5trUCH8j2hnElXNlbniTavotLBRHELdW88RPvXk7Je2COJfrai6OOefpRUQ7rL2txWb5AJ7vs3JUE+Pk96+Mw0P/vxSuGQqvNE0AXSZfMluh1GlElFVbYOAfyAIB9S+kdnOfxoewnp+VZjB+kjjrCP+Sxhd4F66PYcW2EscwzqZ16ZXA4UhjowWQJWYW9IhB7JiGq/01x5mE9xGPBLWZenMDiOpPoVBfVJYgPkmgQK4RCKzLa2AUa4oIT1wpnzlpwzgHZQrRey2OjXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SSbvVyX2UW7i3gXl4aA5qOmp/W3Ow+5HG9O3i8ovLEc=; b=faHQ43JDgoNMC5obsL4E8kwWuJB0GLRSHf8xzozBOxU6Ehne7bTz346xY/Z42L3P6q3SiMDQJsv7abTDi4qfOEIx4vD08RPLEwH/zUIzXu+ECRLxJ6o8yWFIGFDXqJnimQ29FRntAGobM0vsv4pnxJtOGIfSE16Jpj0iQ8+BohBsDeE92YhHAF+ISU1pngoop1d2e+4XpOMieJmIhAZ5LU0DMi92tkniDTXFLmqd/ykylLGt9827pfjJBefLfYnCkKi8Kt0+RSBOTGHnszACY+Y1WSW+ERnFzi1TtmS/UzrIwbG0n2A1kYRr30ZhWfJPx2715Gv+DbP4cIXEoNU3FA== Received: from DM6PR12MB3849.namprd12.prod.outlook.com (2603:10b6:5:1c7::26) by PH8PR12MB6915.namprd12.prod.outlook.com (2603:10b6:510:1bc::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.19; Wed, 22 May 2024 12:23:58 +0000 Received: from DM6PR12MB3849.namprd12.prod.outlook.com ([fe80::c296:774b:a5fc:965e]) by DM6PR12MB3849.namprd12.prod.outlook.com ([fe80::c296:774b:a5fc:965e%4]) with mapi id 15.20.7587.035; Wed, 22 May 2024 12:23:57 +0000 Date: Wed, 22 May 2024 09:23:55 -0300 From: Jason Gunthorpe To: Nicholas Piggin Cc: Christophe Leroy , Andrew Morton , Peter Xu , Oscar Salvador , Michael Ellerman , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "linuxppc-dev@lists.ozlabs.org" Subject: Re: [RFC PATCH v2 18/20] powerpc/64s: Use contiguous PMD/PUD instead of HUGEPD Message-ID: <20240522122355.GR20229@nvidia.com> References: <99575c2c-7840-4fa4-b84e-aaddc7fef4cb@csgroup.eu> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: MN2PR14CA0003.namprd14.prod.outlook.com (2603:10b6:208:23e::8) To DM6PR12MB3849.namprd12.prod.outlook.com (2603:10b6:5:1c7::26) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB3849:EE_|PH8PR12MB6915:EE_ X-MS-Office365-Filtering-Correlation-Id: d1f563b5-f645-4f9d-249c-08dc7a5a0db6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|366007|376005|1800799015; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?bZ093FEt6J6BY7oqp9/Ahu17KaLLBLqFh6fTxvXWtRzo1gTQM2K1E/t486gU?= =?us-ascii?Q?3+nPJiJGrUfOulInR9AlA0S6GfKKZcYK1KjuyjWbNn/fbA1OL3JVspVl67Zo?= =?us-ascii?Q?Gh6S6HZaMVKmbAJgFc5HEj14pU6FhGrFAqpgheCoWvRdV2gCoaJXKRA2qARX?= =?us-ascii?Q?kocIWpruXPfXUcqnCwnjtQCnMogJ4/dXfuLxG89SngD2PT080JCNNNVr5evQ?= =?us-ascii?Q?M1taIFX2euXDoFhOhwb4Gqyc4Vd9kYSUXsYXKEhD6z9IgcaAEif7UqrlbCGV?= =?us-ascii?Q?CPT8pCC50ojEMM7Wam482ACRx6VJ2yi/3CGGO8mhuGRUU60fD+9dLLLLUkAt?= =?us-ascii?Q?+bgmHKi2lXSYMzv7u4vcyzklFhOUps4ewWK4gWuC6DlU1j0xMtEZvCqDE8wT?= =?us-ascii?Q?20FMkV9arfD9cESIXYI2xEYIAHUadS/RZwJPuCVaIz/lyVD5yroPIX8YFZUu?= =?us-ascii?Q?RaWUgUWmkvulBlWrRGbys+OqCrU4wn6Cb4BRzhcNR5YxJ500fSEJJSInnXxy?= =?us-ascii?Q?tty55XU/u2FkAx+Nae93UQRbApVf/agZjJF+JYVWkGkb44WfhsRmU13eB8+C?= =?us-ascii?Q?Ot2RKlaaLT5URSVJ33LY33HHXS6r7GntOmSi7MDRaTu9/mFTFuKJP5xtYAnX?= =?us-ascii?Q?cGzDy6p59tb3djxz7tF/J0O3VIHQLRtwX/H2cOY/KLzrqrWiBYCO8v8URmw1?= =?us-ascii?Q?015P810OBwnKA2YNlnBD+wP7r6U4XQzGiUdYqLzbQkMC163w04xLqAamyIUX?= =?us-ascii?Q?Q7bxyhgoNKs0cNQlbbf8cC/o+ireDlASSdKlaOYoY/WE1t9IIsG/g68fiPBK?= =?us-ascii?Q?VCOvR22OJOkwq2s6ng3Z+8JxRUgQPpZbW59Ev7maf9Hlm0Ygy55ieIo+6vPZ?= =?us-ascii?Q?KxX32bcvvmWbo3cSH3/J/CwiD4jBJWPgGe4QQfI2oVey7DgHbeBnP/JG4gOP?= =?us-ascii?Q?m06YI8Gw7PGiFRQ9xftfu5AkDgOMg4WUS1ESuBukWqIHatFO2VkmRTRvGCXg?= =?us-ascii?Q?sZULJVYiLhKXe48qBfkA3QkXY0d7xMklR4rE1c7WRogdutUYcuQGSOU032Y5?= =?us-ascii?Q?/hrq9x7BHw4jAolKXXSTr7n6WsDQOnHaE9/6Zs8kvUMFwla+1fys4HQBr9pt?= =?us-ascii?Q?/26khscVFrsH+I58MyKEIvnEFLT68xZ5ZfTBz3ExPvb7nxawu/MAtS0NoGfk?= =?us-ascii?Q?OghnRtBbdyquuvDyQQUAkJxLsqARVwgP9TrsQiGLNfmEOXFDYKq8tcuXl6dj?= =?us-ascii?Q?Zj1DPm359yFEKqbHxNUn7W6l3HLECzqRXqCMp8Fisw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB3849.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(376005)(1800799015);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XBkxbeT3bK2bJRxyCyUyxkaqTeSvIG7NTuciD/T2em/Ovpp50pzInKGany4P?= =?us-ascii?Q?HUxhliH958NjjTU2I4uPjfrHBrJN9zsYUkAjKwRx1qhY93X67rBlV+ZQEaqA?= =?us-ascii?Q?C8+TL70/bDcJ5FDCDCix3KKh/jp0FYGaU4RUnwbDZtkzWHKSzYZjdAkUk2bY?= =?us-ascii?Q?Mm9dO5eTKsY7tBqs3DxNUpzTDYDbzCYU8boWPnd8CSCbHip+YLJSiRMh56Kn?= =?us-ascii?Q?aAjg8/A/s3Jr96Qs1q2ur3RsT475nHkWp4YKJ0WaFjJKM47VjTKO2FTC56aA?= =?us-ascii?Q?271vdZN7z/CzwhZTu0N1HiBU9UQxvwQ16Y3SYwFh9qXY7cnb+LMv4lLHT9qC?= =?us-ascii?Q?1e0e/ygZKp0MzMzSYLxSgbPRMjIDlll6S/0UTWTb1MECch0iNBGjpyqxnS0m?= =?us-ascii?Q?4szXaJItJrijx40tiWXoifI1HRKuOZKvHqDkqe98K9NtJhwqmb6SSD18wl/7?= =?us-ascii?Q?BGRdrJigOYG/W7eQ6cU90OzAAV8DX17tRxdpI7B3GhlLqfW8S7XaR4zLHJwx?= =?us-ascii?Q?G2qcjd3LIaZbNU3ripEyIw+tUtZwzhqSeouaku8OtzDirrdYPw5M71YvR41D?= =?us-ascii?Q?dxYkB626ntLU/kFqPXukbUS1LzjrsC9MgergJYOJSlx36MePxQRaFyEYXbgV?= =?us-ascii?Q?s5uLAL3ugsFGJuz05rsP8jJOP1GHfag/rzYiHRqAi1HYMmoC6Cbdrm2MizUd?= =?us-ascii?Q?pki6yLpb7aqtCmK+aSllcTN1RmBm/bGBdfmigMUGPCvV8x/Vt051JCvOqNz2?= =?us-ascii?Q?LrgIVPTsdcl6Rva1J4kSRSX7pVwyUl4kgdpzg/toFjJ9TUr2e4NSuG5f81FU?= =?us-ascii?Q?H6B+youwZzviVdsk5tCNL91wRExcZMK9pCOs40OsVzXqMi6/JcPRx/VsyYHB?= =?us-ascii?Q?agFcql53B0W/ymF1LiKVa/EBV+djEZQKWalJTHT+O86Oiiz0bKh+LOdt1Gnc?= =?us-ascii?Q?g0C2979ExVFmX5b1vTbwTy2yrMgRYNF5x41kZHL+FPDTq9TQZhJMlX5iCMvE?= =?us-ascii?Q?uuSuoDbK+A+EQqkS/5eWwswaVpnSHOU/aUXXjhGYpJAiILq92QqS977n0TCt?= =?us-ascii?Q?Qr+Ugya1eHSl+RhE8zZAEmha04b84d2DtAPc3nMqjyFt5cR/JvWFovN2KO4y?= =?us-ascii?Q?gCfaYw2aJ0bTFQmA50jKwkr1UhQAqdpurrsTOHIWZCAOAF0XvJt29Y+DQMYf?= =?us-ascii?Q?XHghMTkG/yHJZF66QazhvF8Bp7gJ5k/dgpRbWfdmO/2iV3TtPEqiHyo/JtTu?= =?us-ascii?Q?O2bSSVEzwudsOySVP8zHowv3+sZOn40RUzonFcxxMd8+MB3Ld8pfTJkVMoey?= =?us-ascii?Q?mXvZXsMDIN5ifoVN5un+RPF+0dS3p1Hwzrs07hSas5UTZZKE3zuxC4oQnXq0?= =?us-ascii?Q?7A9UhGzu5cWX3DxXbhCCecxJnaKrHkIS4csRYz99/qW3IPqFU/7sULQeKYW0?= =?us-ascii?Q?SErF67bTlbScq69Z+5Sxsioc7ZZujj9iP2XeTS/zOQIulzGozBZwR9X9NSFJ?= =?us-ascii?Q?+pieR7Vpnl1QSMzBPXhEuRF+93KfLe7mUofONSe4wDHbCHxXJQ1nNZ3q9o9X?= =?us-ascii?Q?DrkMwznC0fax6rPRKTE=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: d1f563b5-f645-4f9d-249c-08dc7a5a0db6 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2024 12:23:57.6917 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /UBVWUYyeYK8C6y5JcCkPWDqj+KX2FV/UJ5OnjxkaWxOK0rPrTYbNhtqsqvCb4nN X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6915 X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 4FABC80016 X-Stat-Signature: cx546ftkejd4345rxap6niz11741u85a X-HE-Tag: 1716380647-497047 X-HE-Meta: U2FsdGVkX18pKQf/IGoW4GW6JIwyeBxww6GaNAW3JFEMwtBISAT68NYzar1JXTqGj58gQW7mdksxXsFvLluWTjL9Yjf81ImB34O8zDez1kSiW5rXqY6dQqlzs3EIz5DerfZos+ROPbsvrlXZ0EuyTvPEtHfWJvZiKrzIeiaUeI1yJEjgoWeZziRVFh1b7JWWtGUajX49NP+EmC/NrECYruyd4NPGCr/yYSAbgy9mWpFPTRJ94ABRp7oiTr8NOeSONm8SL98YakdG2tktlBX2LqXzm4SZaxKDi8as8a1kbwid1l0aQWw/gKsdWKrcsggWrIiOSWqyENwCPnO4s2ecd6SdZQRhq53pXxhEDdQZc0OhQO1Qeo8Ka01Ec9NhnEgFx5Z+cJfFZWJi+RNRnqhARsECmsd2Ngi653XM4xkk6d6N9nhtRJXU9er+e3We05RleWjL53z5Ng7jeKAMzfDqNWwUmcSE3C3GGNAB46hM7zXkA55KCABk+YR0eLfVqr7SCsQrZ4Rdb379b8QpM29qlalVh0q4NSmHl/VnO4XWBabGFKEz/EQhHTfGrTJtn5Hj/AqLxNnV27Dat+7qpU0fcDusmXNJkQcnmu1QxkwNZ7LQQ0VH3rlOE5pNmlAfk23Ug8E4v3lvBDazttRooqXuALuKjKQz7zEp5cpHmP16KbofBISCC9hR9WzXJL6bKjj9eQ5xpusXcI4R6b9QrLJA+8HmW6bxpcn5WdJWSkJKBuxZB5xXgDILx4610arH+Ren4/DGu0jYWKre/OAPBgHJ8mVDnmZZU5oQ/Bm6I3UxiTT8lMOlLzp5LrT4TtNVaOhsFrSySaUGYVeK+we9MUNiJR51UpIaP3/zxaQRmirGwouvapYyfixY/9yrCvbCjZwfjur5x0w84KydgIckF4QmaE0sTKWqJxcvqMOhGUBOE3uu1LzPuzfbBsfXgQvxhEIgakZloz4k2a+x8hTw6/C CHRn1jCi c8RFSoJz0tW2Xb1em+/3VZNT0KLSvh0Vh22xwVxJ7KHwSNCEb5crllPyEKD6KlSH03Aq1hgys2G3ka5qptooebyJJoP3ZqPNvOUPsUxkTkka9w2uSC0S/+zpiZYLkjXjdHRmuqv9lD1DWnmpaddcrSODOamd6ohlVqpkNFaB4WSbfOJhmd31YucoSxRSmeHv+dAkIzAFynIWNxgqvgNysmTJG01jOGBdNW7mndT2kfYQduI15T0pEcDjFeOcQjxsTTTGQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 22, 2024 at 11:13:53AM +1000, Nicholas Piggin wrote: > From the mm/ side of things, hugetlb page tables are always walked via > the huge vma which knows the page size and could align address... I > guess except for fast gup? Which should be read-only. So okay you do > need to replicate huge ptes for fast gup at least. Any others? We are trying to get away from this. We want all content in the page table to be walkable via the normal pud/pmd/pte/etc functions and the special huge VMA limited to only weird hugetlbfs internals. It should not leak into the arch. > There's going to need to be a little more to it. __hash_page_huge sets > PTE accessed and dirty for example, so if we allow any PTE readers to > check the non-0th pte we would have to do something about that. Ryan added a special function to get the access and dirty flags from a CONTIG PTE, the arch can do the right thing here. The case where there was a CONTIG PTE that spanned two PMD entries might be some trouble though. > How do you deal with dirty/accessed bits for other subarchs? ARM and RISCV verions will combine the access flags from every sub pte. Their HW is allowed to set dirty/access bits on any PTE in a contiguos set. Jason