From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 378BFC04FFE for ; Mon, 20 May 2024 03:49:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 98FA56B0083; Sun, 19 May 2024 23:49:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 93FC16B0085; Sun, 19 May 2024 23:49:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E07B6B0089; Sun, 19 May 2024 23:49:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5C48E6B0083 for ; Sun, 19 May 2024 23:49:45 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C0BBF140A7D for ; Mon, 20 May 2024 03:49:44 +0000 (UTC) X-FDA: 82137395088.19.05E718F Received: from out-170.mta1.migadu.com (out-170.mta1.migadu.com [95.215.58.170]) by imf06.hostedemail.com (Postfix) with ESMTP id 2E9E6180013 for ; Mon, 20 May 2024 03:49:41 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=HZOl4Brx; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf06.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.170 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716176982; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sO8t5Z6tRQdA5UqsCIe7yGv+cRLvsFB3v+ulXQlOA0U=; b=AADbU1JfwzktNMB7zKHJK9s77iwBrwYAbZ2MixszWXUU4J3OPRAL1jjb+oa7gG7cjv7MUg n90rG+HUvE3jEzO37dMKujr/iwiLvZ5Y5DjIFCkGlAborI7c0Ic2voxvksRV95OeQ/dzrA wj4z0aeJVGEeeNFqg59lSVJov60g4Ew= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=HZOl4Brx; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf06.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.170 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716176982; a=rsa-sha256; cv=none; b=RbZocRU8LNcMrDIjxwjJIVbBCIhIt68M2FiriMkrSV1fvtRchaslHz+Dl09znXNf3JtwvN XWRuchIBOzMjeAgtjCibLvUboaN4S6BBlwJ0ZAv/h4nAEhK/ZskJc4TrdGcEYsHFbWIrKB +fuzfGTBARICYfTD687K6ogSUIvVYpU= X-Envelope-To: oliver.sang@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1716176979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sO8t5Z6tRQdA5UqsCIe7yGv+cRLvsFB3v+ulXQlOA0U=; b=HZOl4BrxH2xaTjntz5P+91eo0G/SyyS6jMnMQmiAPs5e6E4BOtricSyypKxXtyOswCa3bI FdoBMK1LI+NCtMMdA6DIrkDzy2mVe5tcUjMp6UdPDeguoj6Id9ct004huuAvAXIDxzCM+Z vnV9UqmYHh29S3CdlD0qrn5Z1lH31F4= X-Envelope-To: oe-lkp@lists.linux.dev X-Envelope-To: lkp@intel.com X-Envelope-To: linux-mm@kvack.org X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: yosryahmed@google.com X-Envelope-To: tjmercier@google.com X-Envelope-To: roman.gushchin@linux.dev X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: mhocko@kernel.org X-Envelope-To: muchun.song@linux.dev X-Envelope-To: cgroups@vger.kernel.org X-Envelope-To: ying.huang@intel.com X-Envelope-To: feng.tang@intel.com X-Envelope-To: fengwei.yin@intel.com Date: Sun, 19 May 2024 20:49:33 -0700 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Oliver Sang Cc: oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , Andrew Morton , Yosry Ahmed , "T.J. Mercier" , Roman Gushchin , Johannes Weiner , Michal Hocko , Muchun Song , cgroups@vger.kernel.org, ying.huang@intel.com, feng.tang@intel.com, fengwei.yin@intel.com Subject: Re: [linux-next:master] [memcg] 70a64b7919: will-it-scale.per_process_ops -11.9% regression Message-ID: <20240520034933.wei3dffiuhq7uxhv@linux.dev> References: <202405171353.b56b845-oliver.sang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 2E9E6180013 X-Stat-Signature: nxpckfef4d883nu7hduudbqqwfden1gx X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1716176981-210436 X-HE-Meta: U2FsdGVkX19pTDBgVwBYClVplJV1byM58zX8j5Rw+JkZKoU6oI+KZo0xH5SI/PNASgONds1HaWBMOixuzLwd2iD29UlOVUOJeJL8L+8tBiNPZEsxDXj9DCoE1XJqv2jq3sGhqn60geeOCW7urhx9B3+Ho8Y4/UQQ7v4q4Sd3iL4VaodENdRFBZKID8okxERHx5NP+lrhAHpF56D/LXhUH19BJ6VJy1f+r3XnUoKMWAjWPzAJbQaK8BapMNubwXQbORdxy1F3T+mcinr8+dgwpgavFM52SvfvTmx4AHplErKCaMkQbjh3tkC/YGFGw5layqeIOkAs9JyDrNhU/f2lME8atTrcRWb0udyqURx+oYlCM1sx0IhKDT/qCEc2twMDEW/PrVWxYimDK8XcyaG696h6w/VxVoF8NFeYWaMbqX4gmsDkSTCPZPhLaeKnuXcQxPd994eD+YhtrtK6i3SHRXqDjn5i7T4qRzi64U753zd10Hw6RQbg3iz9pHCUXoxd+PlYu0uEQTz4dle+uea0SAnkFpOTmdWZmg8ASN6jfZK/QTPSkkSqqfPp/vi3xr7moUXv8/Squledn1+jsK4UeI0sc+vLFcxEN2BS9JJzN7Vll5JuKocpLrTuKUjUXfj9/EBqBPSHjijwBlJKtHHx6OdxhNXzpKi4HN5Cica5XIQisCKlDXz7FIOeEJocpYyNq0revH1HEVjmtmCz05oWTOSxOjfLzh8zSmKk7T4Z/s3EKIpwxvN/6bfilROBuI9haPHOspTGUS5T0QeZSkydCnU+Q4VEZhXs8hjOxdzZzDnU4LBlJ/mKxM7zqfxECPw/+1nFJwzPo6pYZjMh2qnrKjaaKB5XehfnKoXf2STIiSxZopGHV9U+j4Bw8sO0t3o8i5eg/d65Amw1MIEIEkosoN4L4wy3qtsofNWmo3Ob4/4c0fpuK2PniVwId7rWXHrNG3W2mMjOq+j1mBCpDvT xd17Dy5c Bun4ZvCExiHL/ENQHDiLRRaC43obv8hXxCtERlUgS5oVjdEkFm/kDzQwB2ZiIRVnR+hNfZ98/NZp2nlkW6dLSan/t5vTglKUebmFtJqt0E7DRAA4O0AJguVBkdHTv0mnJSLdE/buER4tUy6z+1YuMWI3jdmnU3HKT6IEELlxDXJ+IDu+tH+YMDmEqC3nlFmdf5J/oLf/Q0XSAqcc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, May 20, 2024 at 10:43:35AM +0800, Oliver Sang wrote: > hi, Shakeel, > > On Sun, May 19, 2024 at 10:20:28AM -0700, Shakeel Butt wrote: > > On Sun, May 19, 2024 at 05:14:39PM +0800, Oliver Sang wrote: > > > hi, Shakeel, > > > > > > On Fri, May 17, 2024 at 11:28:10PM -0700, Shakeel Butt wrote: > > > > On Fri, May 17, 2024 at 01:56:30PM +0800, kernel test robot wrote: > > > > > > > > > > > > > > > Hello, > > > > > > > > > > kernel test robot noticed a -11.9% regression of will-it-scale.per_process_ops on: > > > > > > > > > > > > > > > commit: 70a64b7919cbd6c12306051ff2825839a9d65605 ("memcg: dynamically allocate lruvec_stats") > > > > > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master > > > > > > > > > > > > > Thanks for the report. Can you please run the same benchmark but with > > > > the full series (of 8 patches) or at least include the ff48c71c26aa > > > > ("memcg: reduce memory for the lruvec and memcg stats"). > > > > > > while this bisect, ff48c71c26aa has been checked. it has silimar data as > > > 70a64b7919 (a little worse actually) > > > > > > 59142d87ab03b8ff 70a64b7919cbd6c12306051ff28 ff48c71c26aaefb090c108d8803 > > > ---------------- --------------------------- --------------------------- > > > %stddev %change %stddev %change %stddev > > > \ | \ | \ > > > 91713 -11.9% 80789 -13.2% 79612 will-it-scale.per_process_ops > > > > > > > > > ok, we will run tests on tip of the series which should be below if I understand > > > it correctly. > > > > > > * a94032b35e5f9 memcg: use proper type for mod_memcg_state > > > > > > > > > > Thanks a lot Oliver. One question: what is the filesystem mounted at > > /tmp on your test machine? I just wanted to make sure I run the test > > with minimal changes from your setup. > > we don't have specific partition for /tmp, just use tmpfs > > tmp on /tmp type tmpfs (rw,relatime) > > > BTW, the test on a94032b35e5f9 finished, still have similar score to 70a64b7919 > > ========================================================================================= > compiler/cpufreq_governor/kconfig/mode/nr_task/rootfs/tbox_group/test/testcase: > gcc-13/performance/x86_64-rhel-8.3/process/100%/debian-12-x86_64-20240206.cgz/lkp-skl-fpga01/page_fault2/will-it-scale > > 59142d87ab03b8ff 70a64b7919cbd6c12306051ff28 ff48c71c26aaefb090c108d8803 a94032b35e5f97dc1023030d929 > ---------------- --------------------------- --------------------------- --------------------------- > %stddev %change %stddev %change %stddev %change %stddev > \ | \ | \ | \ > 91713 -11.9% 80789 -13.2% 79612 -13.0% 79833 will-it-scale.per_process_ops > Thanks again. I am not sure if you have a single node machine but if you have, can you try to repro this issue on such machine. At the moment, I don't have access to such machine but I will try to repro myself as well. Shakeel