From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF175C25B75 for ; Mon, 20 May 2024 03:30:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 148096B0088; Sun, 19 May 2024 23:30:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F8C16B0089; Sun, 19 May 2024 23:30:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EDAEB6B008A; Sun, 19 May 2024 23:30:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CFA286B0088 for ; Sun, 19 May 2024 23:30:21 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5AD1B120B5D for ; Mon, 20 May 2024 03:30:21 +0000 (UTC) X-FDA: 82137346242.24.2AE414D Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf21.hostedemail.com (Postfix) with ESMTP id 5696E1C0008 for ; Mon, 20 May 2024 03:30:18 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=UREDd08b; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf21.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.179 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716175818; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+JrWPfIASUzFRmiR/DV6jZQiIB7Zl8bPPeoGLFG72Uo=; b=Jd+3tCdqcyvcH7/AJZjyXex9SxXv1dd/zauznzw/NlwcDuFyzRsMEvOkZTOxbQakvchqjI e+ghyUcfh64vg2OJtGjh8AWnbcAT2ZonVcvZSb5lLUaovMJboIZcaVYMrSOR2mQccBogW6 /CPboa05W5A6dOAuWt2UgC9bHqYN15o= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=UREDd08b; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf21.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.179 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716175818; a=rsa-sha256; cv=none; b=xAEMw5lhnSv7f/vB5Nwly3kfuWw1nwDaBWrVK9kYoe0v6m6T1J8zIaX6GXcOti9PcPAnnZ XrXVfnkdRU/VjylXrAAgi98FADbH4kQApB3DAQLxwCuEH/SWgPTGkjLldFVzujZK5u/cEo lRfsfDHDu+GATEn7+1clSlxlIsv9yR4= Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1ecc23e6c9dso61083655ad.2 for ; Sun, 19 May 2024 20:30:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1716175817; x=1716780617; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+JrWPfIASUzFRmiR/DV6jZQiIB7Zl8bPPeoGLFG72Uo=; b=UREDd08b9d5cO61jjECwa8ZMTMVERB7h96YzIy+0CZFFzcRA7ZUTuusaKQjuk3Mapa wrO+MDkhdxAixSybLM3vCOt0XAoYGDZsiooU0igo2q5iImF8YbzHBXkx/5I7xyhwUhED 4ZOHBH0KXQM0NX/cwEcu8z1CNeH2Y/3bCCnkk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716175817; x=1716780617; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+JrWPfIASUzFRmiR/DV6jZQiIB7Zl8bPPeoGLFG72Uo=; b=k+9aK0GCj+HRfjlamgUKHCiOI94reRRly/ZESe4N4Yleag3xTnBIQChDUoIdh5bwyU FAXruQi2TkBbgSOoTn6/pBSj9JDE6Ir+L5HRjyu6qRa7/0HXmQMwmgNTSY4MvMuQtwuN x73CfEIuENZbj5jDTTuoeXCDZ4uuwdO5Rv5jOzDyDHyrJeJq4cIzblrzFH+EWqGMg9up lfeqnfOZWjoorph5bOY6YjZbi0jfnYHMZUiiwS/gVLz6dkWpYWbmhGBCzNPBjC+4Jcbi xV1YhraNKlQ3Dm/sp2gNhRrqWmaVAQTk2LAIPhxlICSaZs/a/TFVyxo8UxHt6bd5qtiy et8Q== X-Forwarded-Encrypted: i=1; AJvYcCX6pG61hgZnFxe8eXq92DuZr2uy6o33DBC1bQxcaFQlui3mbrgujbgHrchhJPIpfv54K4dxgEYNhdA343lRGjmHWXc= X-Gm-Message-State: AOJu0YxCno1aELHOt2OZj8+rcjgES5kvsB0AIqDJgekXnFaeuGllQIhI VFoYZbXvkKtR9Xbk62IblxRbRfaTirabszXX+72AaOyp/CtxKA7PSLlFaXtbXw== X-Google-Smtp-Source: AGHT+IGEIhXHFo8lQr4BEx8nWbaYE1K8DXMrMP87uwXai76RXva2jls+/QFtIlMVhVxe/QA8pDzVAQ== X-Received: by 2002:a17:902:6bc4:b0:1ea:f9af:ee99 with SMTP id d9443c01a7336-1ef43d28276mr260443125ad.25.1716175817070; Sun, 19 May 2024 20:30:17 -0700 (PDT) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bada3efsm193550625ad.114.2024.05.19.20.30.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 May 2024 20:30:16 -0700 (PDT) Date: Sun, 19 May 2024 20:30:15 -0700 From: Kees Cook To: Kent Overstreet Cc: kernel test robot , Suren Baghdasaryan , oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , Andrew Morton , Randy Dunlap , Alexander Viro , Alex Gaynor , Alice Ryhl , Andreas Hindborg , Benno Lossin , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Boqun Feng , Christoph Lameter , Dennis Zhou , Gary Guo , Miguel Ojeda , Pasha Tatashin , Peter Zijlstra , Tejun Heo , Vlastimil Babka , Wedson Almeida Filho , linux-hardening@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [linux-next:master] [mm/slab] 7bd230a266: WARNING:at_mm/util.c:#kvmalloc_node_noprof Message-ID: <202405192018.9A54A254A@keescook> References: <202405151008.6ddd1aaf-oliver.sang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 5696E1C0008 X-Stat-Signature: 6b8n563ggftu4eg6psbwd9gkeb4rukbj X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1716175818-221775 X-HE-Meta: U2FsdGVkX1+VXdNJhRttWKdAR1eU0bIi/k1zJwU1Eo/Ebxfsoh3HXcVzgolNPaE5H0ijAG5T/bXxwwDaAQkhnEvOl+zVylJDTtC3orNPwI4/xsQrIRAU6aq477vLymKOMvryEuWzZFel3ZDESyV4ec4JbcVZoUnAj7druiXhZrjLhrhJ8bUN8bhMWRh7eAEbiet6ZDn9/hlC5sAAxXXVzttg/+/3uR6dHq1LL2WcCMpt5rhOjOfxo2wh7d4y+Oe2c6/JqixjiQUaqfzx1e7cR71bYgMPxrsx7AR45EEV7Kqo9T6uG72hrCUyJmUuyAkzyyPh9pWWBcDOjzBSrOWk4MtRB/H81MeixruczWT+Zicf4/x8y2X3Uvy/L65UsoSvekQrU1WkdTI73m66Ktdy1Nxi9bNUtVAu0RstrIdYe5vSZ7bvRnXE85Dvs5jJNPW/S3elkEEUPtCBgiE2bUnNLcHZHvqywnKEMDwSLQYQvepXc+GCNnaiqhQCs5XTyXSOvbZr90Er5jef6KHpxkbgACfBFEcEJ8SAmNlyIVSNSssiks0zaHXjO7KWIkhSqzFrzIVJFRsOe0azvwWlcR3PIJ4yBdnbb+eo9W3yUN9HAV46HhtDUpVuVJpjAr0jl+4XWzJLzoHRy01zSDztjjfUtJRTd16agdrxmaL3hwO5gVmSpJ1CPKrgn1YciEEI+4kGiI5l21ou5TRJzI2xYzSO+iRzmczQDQG4jH6T+5yZwDzkBLdSqMa3f/dpXp+o2T8UyHVmCXz2+r06Ub32Xs+xkbHSnXozl/ERc5YqWsFZOyM1FgqJZo9LAzTe+WbQw8yMtJ6sHKHP0aPHUQXoum8V/yscOvXIt76K0ydtobRdSM/CsxQRy7oDlvozrqtq+6gH7JzBGT3SoaSPvok7xtUkt5kNEz2H7SPftx1NJtPoGFF5h5gxzddpwoxxSUVc4wMjkRRwgTY6coHvQ6Tvg36 RY0xV+gL gSaOvp/Wndk55T3DgPR71ReVpqKnBs02qlFHL6T4tHgL49jJL/xon4Z34vmrrUSHlYtWyI7krODpcVXa3mkpoOqbIAR6tvatqSiKO73nJACSIzQ2VLqFHE0RmYS7HSo75CrdfbA6qiCUwvkQU5ozqN8AzpDot4Y88jX1ey9+WyrTCoWKPewlPWS11f1ZCT22gyymKdBjo/heM6w5pbVQyTbVrds7EUhcnBq51fYHhZQkoKPxPVZN8EYJhyxeV/q5TbN3Cym+MaXNwICj31UcMGdcIUZSatP8Kmuqcmyc7CDZekGPwYWd6Pv0HAXJEzyeNKBDIdzXHm9tzdVgZV39NaU7sRb8AUfZWbsglzqhJtJS7SDiJGTk0ShE70eOxivihLVpOA0jjkwjq2ZSIx9wZIotr6WTnjTg1RoVBQWzqnzBKxoCerxVKWI4IGWfMJ24cTOkAjN3roHPuUqkl97RrhHQdA/GtchygzYPDPAT6kRrTk+GIqeLnaUvrTTDkM/bdzyiPM1pzhkalhea4GnuO/PhzZB6RnjcH3Hv6MYxHU7vb5O4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, May 19, 2024 at 07:06:45PM -0400, Kent Overstreet wrote: > this looks like an i915 bug Yeah, agreed. > On Wed, May 15, 2024 at 10:41:19AM +0800, kernel test robot wrote: [...] > > [test failed on linux-next/master 6ba6c795dc73c22ce2c86006f17c4aa802db2a60] [...] > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot > > | Closes: https://lore.kernel.org/oe-lkp/202405151008.6ddd1aaf-oliver.sang@intel.com > > > > > > [ 940.101700][ T5353] ------------[ cut here ]------------ > > [ 940.107107][ T5353] WARNING: CPU: 1 PID: 5353 at mm/util.c:649 kvmalloc_node_noprof (mm/util.c:649 (discriminator 1)) This is: /* Don't even allow crazy sizes */ if (unlikely(size > INT_MAX)) { WARN_ON_ONCE(!(flags & __GFP_NOWARN)); > > [ 940.307791][ T5353] Call Trace: [...] > > [ 940.351795][ T5353] eb_copy_relocations (drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1685) i915 And this is: const unsigned int nreloc = eb->exec[i].relocation_count; ... size = nreloc * sizeof(*relocs); relocs = kvmalloc_array(1, size, GFP_KERNEL); So something isn't checking the "relocation_count" size that I assume is coming in from the ioctl? -Kees -- Kees Cook