From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FF2EC04FFE for ; Fri, 17 May 2024 22:59:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 99CD96B0085; Fri, 17 May 2024 18:59:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 94CAC6B0088; Fri, 17 May 2024 18:59:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 813F66B0089; Fri, 17 May 2024 18:59:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 62EED6B0085 for ; Fri, 17 May 2024 18:59:32 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E29001A04FB for ; Fri, 17 May 2024 22:59:31 +0000 (UTC) X-FDA: 82129406142.29.0DE86EC Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf15.hostedemail.com (Postfix) with ESMTP id A337FA0002 for ; Fri, 17 May 2024 22:59:28 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=VfdxB9f5; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715986769; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=63dS0e3Kbzdve0uW3NiQNVsH3pwTbrQcoewuHNw+evg=; b=iJBRc1bE37RoyE0qxejWLzvKkidyenlKm2WIYOUdnbsV18wFphtcs9kPjw6UnFi0mmTI7j yhgxNOsEXjzZFrl4yHofO9iIH1o72MtMaFA9MYkINev+jjnPuV4W4RV1xOBaNGqPPKMyst PZgebyON8Wg97jM3qYzrooYF4FKA37g= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715986769; a=rsa-sha256; cv=none; b=u2n4iRpQB7ODvtoNdvxA1P2hMdook7O6ipK5jFTgNd8U8HV1pJD+EPwlrb+raEFQGvBr95 p0idg1sPFrlow69HfYAqnaE1UGdvQi9wiqVd/KG0eIi1p0toCmFqnD/OQ0XvkBeJ6efMv5 muMTj5Jel4vWspOdEwdgK/mJO+jgZxk= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=VfdxB9f5; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 5DB41CE1B4F; Fri, 17 May 2024 22:59:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34440C2BD10; Fri, 17 May 2024 22:59:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715986764; bh=i/lf2TVxejq4yug3FFuoGpl/sEmPNn8np1eVzk7EMx0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VfdxB9f5UkPBi+DVIpPNNx1wh81JGtsYu2nbc/+ACQtcMligzURaYIG5SvChMswLe Cf2HHR5Dy4FS/SH+1ft1ngHqNSSsgsQlLr2mTwD0CKuQ04ua+/0bs0qwemDBVceAng GiWKCUqXL4HG/ojnBJ3y+AU0va9YxScuBtZn/OmjnNphbm9x9dCK8Xc8GhnsdnzqKs t49qjD71YJMe/17NEuRmVPyYKkKFlCMbCa8eo0xT4qXRnzynXxXJPKo4KfRnVHVg9x OutgHRJ20LyAbf0Yoj+BQOokoFf9qqGo6CG1SPv0tXZyKtumbqcCe4UI78wPac32ae o7oGKOjVJmv9g== From: SeongJae Park To: Alex Rusuf Cc: SeongJae Park , damon@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH v1 0/7] DAMON multiple contexts support Date: Fri, 17 May 2024 15:59:21 -0700 Message-Id: <20240517225921.128477-1-sj@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240517085151.630844-1-yorha.op@gmail.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: rphhf4pre61c6953866qf55sx1ry81wk X-Rspamd-Queue-Id: A337FA0002 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1715986768-633846 X-HE-Meta: U2FsdGVkX18+fKsuvy4t2C5aBjg6PUz3V/1wPfuUiTnl2wuBkkiutqDU++LG0ezcF7HnVj+5k3jr5XfJ3K+eL/MEOYOQUiX7rvVbx4VJS61fDmb7t6ceQVotIjLc2cC5yXsoUdttax0PjBlEDKccJtwx5B1vP/uFQojJmXe5vRNMxeNkrZq9q9v8ABCbLe8w3YmfluJUjsgP2qr6LW3mLCc5kd+37Ffduk2H+ZsRwYFtLALUaGwMc7w/hTYdWS+90oLZv0aubhDhSb+Lxpe8ZXoN1Msuv8UJjM5umYlaFg7lMbbxEtBF9ojwG4N7SV2RKHpq3fjsnFup3dyc1YfbCGRuTWwxxmsLdeVq510twKZbXdOvn+YzKImsHMIZtOgDLArrPLIS03gcQJGUM1WK+obu83MYoEXNH6QNlYuxeoy10bUjCw2DC+4oVr4GYZv5FwxO8zQPsCJY2cEKm/cc+5d3vMXHXSwpwW7EsVcfWaJA60q/H3UHv6Mun7UHJp2DPOvIUX0gnFZ9/1teqD+7Bq8kHAQpRUnjVQNOtmPLtVUrHdBL8Sap2t3LyIhzpv4WtrNPf16C31QZXpL2+L0gdJtZYnS1zQ3M9Wxh9rVfyx3s6peNIQ3EEwCGp2uM0ZjhOqhfTAUsN1YOASY1jrHc9nPV9v9e6Qmf4DeYYN1hCHZZl1WRWhqNYNsaYOWqa83sXc/rNMMKPRPytV5p+xbgLBrJKBXv4kjdn4toOl9hqH13tjv5imwU9jwp+DjUYIJ7QMuiEexZlfAW1cnqtK556sWcRfj0dX7b+h1BncNR63Yg+wF0Bzp9rxyg/uVya74Jg46AyrI3LcZvwrIcmEuaHU0R/0l11QdNocf7weLtjl4T5m2OVWcbKELxDESZ0OX5dEjIMNnchuW0jBDGLaTeS2kwm27/ATHhmIimkpEdgjXCKBop/tdbeooTAvmGmrNLtnQ6eVUwm+wnFia65I2 zE0qeW55 zMEQJ6jhc4opQ70mi4BPP1X9w4I71C6N6X55D4/Wb88CbCBPWXhYxQ/8Cf0THunSZYZT+Woc+MoCtDz7wO7kQCEZGM3z7L/Z9/6YPuDlfvzBE8AatpYjOMydhA6p0v5M4WIbCs33p6FKRBE6bnh+PtLkO2az+7GgxNYIkJbhSPK3EU2uOv9BqW88lwaNsserJyHCoA5ibrxisJaspeH1wajFti8+u/79xJeGnjl9QUhHQmGOJ7n1qXUwoBsVmi+QJAIn2oRyJt3Xfa0znzxoTndL0xyL2e2uPaGVPK4x2J8EK/+k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000032, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 17 May 2024 11:51:51 +0300 Alex Rusuf wrote: > Hi SJ > > > Hello Alex, > > > > > > Adding high level comments first. I will try to read each patch and add > > detailed comments to those as soon as I get some time. > > > > Also, please Cc linux-mm@ for DAMON patches. I'd also recommend cc-ing > > linux-kernel@. > > Thank you for clarification, I'll add them! > > > > > On Wed, 15 May 2024 18:24:50 +0300 Alex Rusuf wrote: > > > Currently kdamond uses only one context per kthread > > > and most of its time it sleeps, so utilizing several > > > contexts can scale kdamond and allow it to use > > > another set of operations. [...] > > > [3] https://github.com/onlyoneofme/damon-multi-contexts-tests.git > > > > Do you have a plan to integrate this into DAMON selftests or damon-tests? > > Not in the form they are for time being. These are just simple shell scripts > that set up kdamond to use multiple contexts and these scripts only > collect information like DAMO (but only as perf.data). > > Anyway, I think we can integrate them with damon-tests with some modifications > to be able to actually _test_ if multiple contexts work. > > As for DAMON selftests, I didn't touch them for time being, so they truly > need to be modified and expanded, but before doing that I would like > you to look at implementation first, because changes in implementation > could affect selftests, so once we agree on that I will implement selftests. > > Also note, that I didn't integrate changes with debugfs. I remember this is > deprecated interface, but I'm not sure if compatibility need to be preseved > with it, so do we need to expand debugfs for this? I think we should keep debugfs work as was. So I think we should ensure it's not broken, but don't need to expand it to support this new feature. > > > > > > Alex Rusuf (7): > > > mm/damon/core: kdamond_struct abstraction layer > > > > Let's make the subjects clear what it does. For example, this patch's > > subject could be "add kdamonds_struct abstraction layer". Similar comment > > for other patches. Also, I think '_struct' suffix of 'kdamond_struct' is > > not really needed. Let's remove it if there is no special reason to add > > it. > > Sure, I'll change that in next version, thanks! > > > > > > mm/damon/core: list-based contexts organization > > > > I think this can be squashed into the first patch? If not, could you please > > let clarify? > > I just tried to separate those patches for them to be as simple as > possible (actually I failed at that...), but sure, we can squash them. > > > > > > mm/damon/lru_sort: kdamond_struct abstraction layer > > > mm/damon/reclaim: kdamon_struct abstraction layer > > > > Does these two patches mean lru_sort and reclaim are broken by the first > > patch? Let's keep everything unbroken in middle of the patchset, to help > > bisect. > > Yes, they're broken by the first patch, I'll squash them, thanks! > > > > mm/damon/core: rename nr_running_ctxs -> nr_running_kdamonds > > > > I think this would also better to be together with the first patch? I know > > this does not break something, but makes reading patch bit complex. > > No problem, thanks! > > > > > > mm/damon/core: multi-context support > > > mm/damon/core: multi-context awarness for trace events > > > > I think these two patches should be squashed into one patch. Otherwise, the > > trace point is broken in the middle of the patch series, right? > > You're right, I'll squash them, thanks! Cool, I'm looking forward to the next version of this great patchset! Thanks, SJ [...]