From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B01FC25B79 for ; Fri, 17 May 2024 15:46:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A7A406B007B; Fri, 17 May 2024 11:46:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A2A876B0083; Fri, 17 May 2024 11:46:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F21A6B0085; Fri, 17 May 2024 11:46:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 723C26B007B for ; Fri, 17 May 2024 11:46:56 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D1C601A03A7 for ; Fri, 17 May 2024 15:46:55 +0000 (UTC) X-FDA: 82128315990.07.09405A4 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf19.hostedemail.com (Postfix) with ESMTP id 0E0C91A0023 for ; Fri, 17 May 2024 15:46:52 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qPsMCEt7; spf=pass (imf19.hostedemail.com: domain of will@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=will@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715960813; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oTrjQi7xQJ0WGjkZSqMK9KN32AYtmDF0sBNqEPXnHlc=; b=Wi8/se7JtW1gWNUZnaDfv0q5eOJeUVAbhPJQmGPsfEK1ULGhKeWqew/5lrYbVEOo52xI7e Xjlf6l5wEGffCwUXnQSoaebL8MqUPw82ratpfk/XOAJRSeJCGWLNk5RlQYpEYCsnN5iWBk 2qcLWcIKehPMI3WYcOuK406MEfCIL80= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qPsMCEt7; spf=pass (imf19.hostedemail.com: domain of will@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=will@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715960813; a=rsa-sha256; cv=none; b=kvbS2RXSPRHcgzo4U2hGGZdc/6JKlhVfZvjd2tmImOvaFDF8HAmwYUumbAGrHBH08yktFc 7p2Y2d6EejHP2jsoM63gGj5sVbV7fFHvWsmzD38hxGDxqT/E36/8RHKOLg38pMTCbREIe6 0+1utpWKrRRaRV4dB6/k4USeZezRr6E= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D514961DEB; Fri, 17 May 2024 15:46:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 111FAC4AF67; Fri, 17 May 2024 15:46:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715960804; bh=EpkhHazhMZ2fwuDobsplhqZvRLo+YDrsHfPiI4NpGv4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qPsMCEt72a5yEc9EgEt6r+yjYEkV9BPAe1xRO8Mnx0FWUaiC9lvILRG04VRJZWw48 6oi3NhTWACIBMVCpaYFZBzGgjvog9Y2TBWGjwbtg4as/XPHXHwLo0KeYmlix1Tn8jJ 4VeuQ6blAMOigvYJG5R5zp9Slb7rxBGhcGmnSRhVLw3HY2TMrkHzFxNCfy5TM2KOl7 3goZJdJ9Tr8Zr9DvcjkvtgL8pUnnLDDUJrwFLygDVMOs6MaI5wNJFVtqt+sDPTLZKE 8D0fBgS7iYh917OFn63YR+c8+L84i4xjQMciA0V/P7pqzz6WoJLNRgmPCqv4y8iZTU E4tvvudi2KGsA== Date: Fri, 17 May 2024 16:46:32 +0100 From: Will Deacon To: Klara Modin Cc: Mike Rapoport , linux-kernel@vger.kernel.org, Alexandre Ghiti , Andrew Morton , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Donald Dutile , Eric Chanudet , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Liviu Dudau , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Michael Ellerman , Nadav Amit , Palmer Dabbelt , Peter Zijlstra , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Rick Edgecombe , Russell King , Sam Ravnborg , Song Liu , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , bpf@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH RESEND v8 16/16] bpf: remove CONFIG_BPF_JIT dependency on CONFIG_MODULES of Message-ID: <20240517154632.GA320@willie-the-truck> References: <20240505160628.2323363-1-rppt@kernel.org> <20240505160628.2323363-17-rppt@kernel.org> <7983fbbf-0127-457c-9394-8d6e4299c685@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7983fbbf-0127-457c-9394-8d6e4299c685@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 0E0C91A0023 X-Stat-Signature: a4765b4mdrnxegnhhpt4zsmbbc3rp7gy X-HE-Tag: 1715960812-43352 X-HE-Meta: U2FsdGVkX1+7FrgDUAt53nPNxuBqVNUnnlpF+2aAMrINZ3z8SSgcEI0ZtWxQStt8vYU8eN+BcwW6AxmEpa3mjwYFn6YK84NqZBPN3L2DOK85dBvDa84bxTeqKoqbNhphFeSNKe+YowPOKaUGawNtWyqRLZxo9WwxlQQMxcfDEc1F14P88bpkDtyjASetVq9l0PcfNnKwTMEWzlWbRYygnOK0IrUgrvNe/RfRzbvTp93gJRarFXnKa0JMxbEc2DZ9TD31IoMdVaqxHmNFxSRSf1wdS6o5GO8cjpRXH3QtU4sG4TB+/1l+935GpPKnmw/2faXFFITXjHLe0uh33fYTC9F2f6WPUyguqwAorSkzL7eUlVyf8+C+MQkUGhX0ivoNimB6EQwzbQOA25ct7u6115z1AAHcZqpyk8MjJ+XdDlfVCk2mOJ7ydl/qSEqyD68BOLhvsdXN75linSVAUul+IzP0iyQI3r5466hoLgZgq0iCfQVwYiwM9PFN1s98iwiF2knwdRNFdKCQKjwBTBjdZRgG719psjnWm4suMzA8TqVqa2sIcuDNXjbd2p99X4EnThU5i6PAyG1tUv4On+x6DE5kWBbtY+kz2moln1Im+Mji1Vu06LNMyjfOPp5q1/BwIKG5M/ySvTVr1oboaBf+F75n8L/7T+9k3enymcZA5hPKRD+m216Hu/CR/ebsGjNgQw2vfFpRciq+1HPpyvZl7rshB5xBjRYlpXpZr2t0tvMbck5dsak8neXddAvWau/VFcUUWPUWhaUQF5YbzvJO64hbLPZArvjJS3KESx6McDDyn/MoDDG/E3eftFNrga8pol4g486kd2v1YsFwD/315A/CAFMXGKWCyz5qbXRU4SSIhQDc73gGJS4zCsNbEz4f6zLNHo7cwk078+PFjBXUBJ6F6/OuPKV8kWhwQ8LN/zNPM1Vzxvqt1D9gt47B9z930mu9fT2I+bkIruocMmY izLZfIuP LQEqr4eD4WC1DB/jx+kjt9Mo8l++xAh5vC7/YmtRo/dSYhe/jGJDuYtYNf59pUnKuKQt2GAuxh9H6Rg0tWpqvUtT/H1RqtSaO5GgXpC29BjNc01AMRZ6QXJs+jgoi3JtVtSSQWuYJRQ1OkVTjJTpbwGd7A7OP/8AUTSuc5Jj/I44/tuJ9snVqm5gC4Dr7B38UKY4dhbB56Pf9K4QYauQ3Sdrqr7Lefr8itSnXRGYZM9B/mhWxm4tD6ANKRX9uS8bkUKWhE7/wsKveD94GN/rooeb222VGtYKTZGqE9FLjlvoJkX7JhXeHzAyspwQFUbc+1OnnNghleDm+ltXQIoQ0TlRN19oQkqIDksuAR7YKeniGHsdG/0WPk3ezIpaF9rLUJq4e3V7yuutb38A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Klara, On Fri, May 17, 2024 at 01:00:31AM +0200, Klara Modin wrote: > On 2024-05-05 18:06, Mike Rapoport wrote: > > From: "Mike Rapoport (IBM)" > > > > BPF just-in-time compiler depended on CONFIG_MODULES because it used > > module_alloc() to allocate memory for the generated code. > > > > Since code allocations are now implemented with execmem, drop dependency of > > CONFIG_BPF_JIT on CONFIG_MODULES and make it select CONFIG_EXECMEM. > > > > Suggested-by: Björn Töpel > > Signed-off-by: Mike Rapoport (IBM) > > --- > > kernel/bpf/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/kernel/bpf/Kconfig b/kernel/bpf/Kconfig > > index bc25f5098a25..f999e4e0b344 100644 > > --- a/kernel/bpf/Kconfig > > +++ b/kernel/bpf/Kconfig > > @@ -43,7 +43,7 @@ config BPF_JIT > > bool "Enable BPF Just In Time compiler" > > depends on BPF > > depends on HAVE_CBPF_JIT || HAVE_EBPF_JIT > > - depends on MODULES > > + select EXECMEM > > help > > BPF programs are normally handled by a BPF interpreter. This option > > allows the kernel to generate native code when a program is loaded > > This does not seem to work entirely. If build with BPF_JIT without module > support for my Raspberry Pi 3 B I get warnings in my kernel log (easiest way > to trigger it seems to be trying to ssh into it, which fails). Thanks for the report. I was able to reproduce this using QEMU and it looks like the problem is because bpf_arch_text_copy() silently fails to write to the read-only area as a result of patch_map() faulting and the resulting -EFAULT being chucked away. Please can you try the diff below? Will --->8 diff --git a/arch/arm64/kernel/patching.c b/arch/arm64/kernel/patching.c index 255534930368..94b9fea65aca 100644 --- a/arch/arm64/kernel/patching.c +++ b/arch/arm64/kernel/patching.c @@ -36,7 +36,7 @@ static void __kprobes *patch_map(void *addr, int fixmap) if (image) page = phys_to_page(__pa_symbol(addr)); - else if (IS_ENABLED(CONFIG_STRICT_MODULE_RWX)) + else if (IS_ENABLED(CONFIG_EXECMEM)) page = vmalloc_to_page(addr); else return addr;