From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B35BC25B74 for ; Thu, 16 May 2024 14:56:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B77776B007B; Thu, 16 May 2024 10:56:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B01156B0082; Thu, 16 May 2024 10:56:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 979966B0083; Thu, 16 May 2024 10:56:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 727866B007B for ; Thu, 16 May 2024 10:56:44 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 15AAF12020B for ; Thu, 16 May 2024 14:56:44 +0000 (UTC) X-FDA: 82124560728.01.89A9C3A Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [80.241.56.171]) by imf15.hostedemail.com (Postfix) with ESMTP id 1DA6AA000A for ; Thu, 16 May 2024 14:56:40 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=B72fBIQ8; spf=pass (imf15.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.171 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=pass (policy=quarantine) header.from=pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715871401; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=74eMllLeh342ZIjZuqoRqLepm4NGxHaCMq2b5Z56hmY=; b=RoQS5kaD4xsnMVKlaO+ur6TsRIDhHsx1re4ydGRecpCIu0P+lrca7zeABjYatETcnde0TS xVdEg0tC+1F0Dz+ECeg3+ZzRwZuOJa/bZ/z8i2M0bDa2hzq6+JwHJYt8kqIC/z+f3tF3Ba J3hKp0OJsinyqOny6ZHRxDkdFDPmtEo= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=B72fBIQ8; spf=pass (imf15.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.171 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=pass (policy=quarantine) header.from=pankajraghav.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715871401; a=rsa-sha256; cv=none; b=aRKHgwyNGFA6Ed2nyt5N6hJNgT8RKASuMw9jxmKEI6DkR8OI456nUhuTagrKxzBwHGxqkC DtVNkUXc4ppIWmJuVd6PaLCTJ7ZZzFeH6SVAuesEie83/1Y0Cn7dFKVd+3FVAcxePzBvzU hMnVBlyg3UiBwbAabpBOSNSCuYkqWg8= Received: from smtp202.mailbox.org (smtp202.mailbox.org [10.196.197.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4VgCpq2pVlz9sHh; Thu, 16 May 2024 16:56:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1715871395; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=74eMllLeh342ZIjZuqoRqLepm4NGxHaCMq2b5Z56hmY=; b=B72fBIQ8PVUvw1AVhC0pKD9aEicC5puPM1tGp23gLm7PmFibCx+DESumNdKhfYUKTvF4J5 EK7FGC2VF8bn8cdZuDeBiJjPrg97a/IR+mGXUukEMIDp5X4pyYB+vR3MRqEFfkhZ5kUoHv V5kcxfmRdmhdnb+M/mLqrQM/wtX9yreZM6BqCfYKjxrS5t2P/dXfv1MnTUPVckPuokmIKb I1ppxLTGTh3spgDX/zmpzfVBEnDtxjFHGCOYAdNtrJYCJF2foq9sRRFCMU0eeUsLeSBN9Q 4rAlIg85Xp/YrbGgHyxdCseoXiWOpL3MzPGnVB1/KG1Bcup/Cw1FjCcDjO99QA== Date: Thu, 16 May 2024 14:56:16 +0000 From: "Pankaj Raghav (Samsung)" To: Matthew Wilcox Cc: Luis Chamberlain , akpm@linux-foundation.org, djwong@kernel.org, brauner@kernel.org, david@fromorbit.com, chandan.babu@oracle.com, hare@suse.de, ritesh.list@gmail.com, john.g.garry@oracle.com, ziy@nvidia.com, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com Subject: Re: [PATCH v5 05/11] mm: split a folio in minimum folio order chunks Message-ID: <20240516145616.z3gz5d6awy7n3drx@quentin> References: <20240503095353.3798063-1-mcgrof@kernel.org> <20240503095353.3798063-6-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 1DA6AA000A X-Stat-Signature: be89ai6ku89i4q8bdkqktqo7e57bphhx X-Rspam-User: X-HE-Tag: 1715871400-949280 X-HE-Meta: U2FsdGVkX19p6B8BVidfdSMEkDFvOhkP11WNN9B7ptNTZ6ycyHJa4rWfHdiyRXwZS1e57ewIfZwMZFUB+zQEjShN5ieFJinWL5N+sTAWmniAiGnJIaaL4FN42TK2q8bjvorjvKVaMhuM/VN9glzq8nLs04por1Y/uYmLK1xjavnne6/IlwL1Qak/ivBq5Ips/2oUS6xo/U+ugCI11feO4CnrinmexGehpFUQJzTYKm5dwQkXnIxWtpXCKkKzQtCKwMcWoa0dndN1XYa15j4nTpEUVCeODQ2qATTH2zJciuqrC2V3YsLxQ00o3I4wdmoKpMxPYgZjBvDMrtn9daT9J8w5quQLTUH6HohcyXf5ZdHZ09WivzUq6xrOYjrwmhItSyMK+wzebEGsFrD71GybD14LPVRaij4vfQheLN0lGPRYq6sxV0U481bCGtTGOFrX8qLn3LpG4sWBO0AWxzC/4xUyaUH8GWrr794NyYB3dWZhWmZMxaSLduKsGgYKOOex6H5TL4h1l+ZTPeDCKcBp4jgp9ILPe1KuqbNc7ziUZSSUtKpM+twKsZ6BHTTilI0gEiaRx92HAcHMevtimDurAoeuuMd7TpEvixLQHJkdf0TrxBXo75kJsY3WhLp8yTVGWnecoR6t9AQJ85esc1nBrHr3AVhBZTrjeoN69H3SGIrfdH4Oz0No9lnDYFq93HHzr/HpRYvJto8/J5HGbzvCOWxWsmkU29yO+HqXGBiHJvVHHpH0+CcmSRGj0ufUsGSjQZPMCydz1VBBfoFvoh2B1MnadtA3QZlJThqdHeqFMllpBEti6oDeyzU3ZjI4iUa2X+Fp4bxul1ZzgmTQtrrIG5pXpZhoW4qharDi8Yftw/kY+I1nf5XGU+InVZdxA++ty8fkRTIb7Nz1RBtsJ/zr2B/MIxhrglHOZ5G/2bc+64uqjcvQbYcOfhesvahSvdJg6kOTIXvzopZ9NowP13d t69WiLhP /LSkEds4pBXXgTnQgIdPufotrXfR5HU/KLjybWVfWGMMsAVVBrJGIuvJS6lsuFqdzZX6KWjoAzKBHZSrlzPyOwJmoe6qS5MAu9ScKSEjc4bnXZwcueYvFIhCDkOhfMsSzQdVMz//Xxrg0rKTi9pa5vqaWq2X4IjjrwW/lLI4GC5Njcy1zUy60Pez+xTQXQXyldQXuqYc1cpm5/gNivCEWUWBycVX15O6uPnpqi6UeEWX7AkLV7JONOReHPV9XtH3eY60Y0z5/qhLYnT14snMTKk3UpWENHwgLsOhs X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 15, 2024 at 04:32:36PM +0100, Matthew Wilcox wrote: > On Fri, May 03, 2024 at 02:53:47AM -0700, Luis Chamberlain wrote: > > +int split_folio_to_list(struct folio *folio, struct list_head *list); > > ... > > > +static inline int split_folio_to_list(struct page *page, struct list_head *list) > > +{ > > Type mismatch. Surprised the build bots didn't whine yet. Good catch. As we always enabled CONFIG_THP, we didn't detect this issue. > > > > > + min_order = mapping_min_folio_order(folio->mapping); > > + if (new_order < min_order) { > > + VM_WARN_ONCE(1, "Cannot split mapped folio below min-order: %u", > > + min_order); > > + ret = -EINVAL; > > + goto out; > > + } > > Wouldn't we prefer this as: > > if (VM_WARN_ONCE(new_order < min_order, > "Cannot split mapped folio below min-order: %u", > min_order) { > ret = -EINVAL; > goto out; > } > I don't think so: #define VM_WARN_ONCE(cond, format...) (void)WARN_ONCE(cond, format) So we get a build error as follows: In file included from ./include/linux/mm.h:6, from mm/huge_memory.c:8: mm/huge_memory.c: In function ‘split_huge_page_to_list_to_order’: ./include/linux/mmdebug.h:93:39: error: void value not ignored as it ought to be 93 | #define VM_WARN_ONCE(cond, format...) (void)WARN_ONCE(cond, format) | ^ mm/huge_memory.c:3158:21: note: in expansion of macro ‘VM_WARN_ONCE’ 3158 | if (VM_WARN_ONCE(new_order < min_order,