From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23967C25B78 for ; Wed, 15 May 2024 17:12:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 995096B00B0; Wed, 15 May 2024 13:12:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9442F6B00DC; Wed, 15 May 2024 13:12:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 835366B00BC; Wed, 15 May 2024 13:12:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 66B526B03AE for ; Wed, 15 May 2024 13:12:31 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0E60140B5A for ; Wed, 15 May 2024 17:12:31 +0000 (UTC) X-FDA: 82121274102.22.9C4E472 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by imf05.hostedemail.com (Postfix) with ESMTP id 1168D100004 for ; Wed, 15 May 2024 17:12:28 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=layalina-io.20230601.gappssmtp.com header.s=20230601 header.b=XHkhDndA; dmarc=none; spf=pass (imf05.hostedemail.com: domain of qyousef@layalina.io designates 209.85.221.45 as permitted sender) smtp.mailfrom=qyousef@layalina.io ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715793149; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aNosG3ckDHB8NLVJ2gGvIoo4Er1X+7+xgehDnbjd6jc=; b=TMJshNEbhtYu+cK/QqxSAvKh+6qiYsM07FTsOy2OVGWkfMV8OJ9bDGfreaypDulkBKXXoR eZLT0E4Jk8sS+l/QvbGgKXo3T9q2Gvkce71suDXCJ1fE5gwFc7WcIenHs+SUKq2mXNH+/u CfpFJeEIDZlFNT1iIzmqR7WwgmqaGJU= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=layalina-io.20230601.gappssmtp.com header.s=20230601 header.b=XHkhDndA; dmarc=none; spf=pass (imf05.hostedemail.com: domain of qyousef@layalina.io designates 209.85.221.45 as permitted sender) smtp.mailfrom=qyousef@layalina.io ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715793149; a=rsa-sha256; cv=none; b=3H3BgOwmt3twt9PqpuzT3D2OcQB9MNIkuGA/1H6IwoT4tTeqx4/RuJiUTv0F8rM2h9gzuf MMIBQOCcWerTlWSJW3PI3TsObWNibwY9s9OevID1/zP2MTJ8onMYbG9pqLLMRePmpjhkrg Vsdld/Y9MyrmGMc1984mrHmZWZwCBKQ= Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-34e0d47bd98so4642413f8f.0 for ; Wed, 15 May 2024 10:12:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=layalina-io.20230601.gappssmtp.com; s=20230601; t=1715793147; x=1716397947; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=aNosG3ckDHB8NLVJ2gGvIoo4Er1X+7+xgehDnbjd6jc=; b=XHkhDndAgcswrZJ79CTVzExcgyLCRH1T58uQcy8O8hBV4wTc2U6WnncbvOhWOHfDoP 6tHYDPxUxk0ctLDl0al2o265Ec3UFkNThkBwQsJrKFp7TzwZDxsbvWcjEvtVYHyuEkaa K5qAPOcFw/AHanbeYN8JtEjtaQIHcNWIK+eQO9ctsDQagF+xrNi+D6XInAFoZB6R3x0G /GzRAZJnBmveU5fZigifby/C/zMJUBWQGExRsICPqIHxIHdP1OCkLVjCkWF9GW/bmrz2 Y3liib0nPSIZbQulLBdpZAgZ/Tx6KjuLU1CK6RLEO/svTWzgnVK03IKpMT/fRvr/9HAv Lsyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715793147; x=1716397947; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aNosG3ckDHB8NLVJ2gGvIoo4Er1X+7+xgehDnbjd6jc=; b=cUcPPbdVV2X0zkMDpcnuvBJhzPHnWGSmaKybAJhduNHsldQTeoUHcnpLVOSs1tE2TB eswc4SxIYgwXBZCP7gc4hi4r6MNHFzinq6baH+FlFB4W0m5KXYBbZdkKbUsaxlaTkmrl KEGESDt/xCak0mTVfkcBrhYAqlmanCzFIbF2S0eShN/aSB2etNqyOKtJ+UtPNnOQpjXE UsGvx8wYp3Q3BdH+mql1l3AcBhbEy0M1SmUb2LFHHz0yXcBQ4v4rvgf72LFBySurA6O8 2T424m9m9FXXV98mH10RCVdpi44/UPZRqDgldVx4rnN9FFls5bwVv5C1aLvSfWSvksDC 5OTg== X-Forwarded-Encrypted: i=1; AJvYcCWZTa5HKxqFgkW2KYVpjLutU3I8hzYGQxJ9+8YESqMyxV4NczRKbawrDEUOYLky0Q4Q54U/GHYwGeY3wMF89Ltm3WE= X-Gm-Message-State: AOJu0YwotFPYe8hGt9sNYaX2toKa56q1ST8GursQkpAnvxY6wXkB0Hmg 47Vxzc/yQznBzeERlf+D6LIoJljS7f7jLEYkwTWPzrjQsNhjNcm0WvtOKSEwxTk= X-Google-Smtp-Source: AGHT+IFLKOGooEzh5kgxSU0G+WqjP7c8Us/ACZAVQOeBbdHE4Nu/p8dE0Q5EYbLnc34bRxIqp6xGpA== X-Received: by 2002:a05:6000:930:b0:351:d383:6325 with SMTP id ffacd0b85a97d-351d38363cfmr598051f8f.12.1715793147224; Wed, 15 May 2024 10:12:27 -0700 (PDT) Received: from airbuntu (host81-157-90-255.range81-157.btcentralplus.com. [81.157.90.255]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3502b8a780fsm16840240f8f.59.2024.05.15.10.12.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 May 2024 10:12:26 -0700 (PDT) Date: Wed, 15 May 2024 18:12:24 +0100 From: Qais Yousef To: Phil Auld Cc: Peter Zijlstra , Ingo Molnar , Juri Lelli , Steven Rostedt , Vincent Guittot , Daniel Bristot de Oliveira , Thomas Gleixner , Sebastian Andrzej Siewior , Alexander Viro , Christian Brauner , Andrew Morton , Jens Axboe , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] sched/rt: Clean up usage of rt_task() Message-ID: <20240515171224.wbjlke6uavhig2dl@airbuntu> References: <20240514234112.792989-1-qyousef@layalina.io> <20240514235851.GA6845@lorien.usersys.redhat.com> <20240515083238.GA40213@noisy.programming.kicks-ass.net> <20240515112050.GA25724@lorien.usersys.redhat.com> <20240515120613.m6ajyxyyxhat7eb5@airbuntu> <20240515125049.GA29065@lorien.usersys.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240515125049.GA29065@lorien.usersys.redhat.com> X-Rspamd-Queue-Id: 1168D100004 X-Stat-Signature: ugfggwfh6txd3iq9uop3hi3qjxqeeg3y X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1715793148-821265 X-HE-Meta: U2FsdGVkX183DSrR54+xyAy5INZU1IwOuGReNzSw5BRAcbUG02I44gQU2JajvFe5wa9jbJdB/rhohcXiNbgLmnUk7qbsn+Gq0122Avgb5brTj4SuOHE57+CcwybvxxP0ud4Hg4rRW88lJoheKHqtqUvMuzBTbQMCUscoYTwQAME9An/gkyIYGCS0mFhdPXsUtSFJBJt7x3QBa8VjUYJBuYyeaAD9C0psGcxunF1fsPr02epRvDBnMUmJeHr/OR4aQOTG62i5TyjUu0cgkrw8cP71sg1uo7h9OLPf/UyHpqtVAV+1bQ0v+mg++jTN1YznqKjGOwTTAmq1uEmsM2SSEHFJ3kfnijYDlje548IXMlwQj8cug44jqxYwDvZerDfcRscIfmIrE1WT/qKsyXGo3yVmji0VpIXMDWbDm/u9mAT+7/q+YStWvWI6NUnzzr+Y0h0vwVGuh2EVWkMVK7axgWcGvusvlEviN/AOz3OmiJHwKVKyYZZMsDiVXF8Mkw0UjcPLce7iQcndKt/KchjZcz0pu/gUMDNf5FPoOXyP1B2mZGWa9ZCZoOuDfk/M5NqRWneNuE5jO3Qk2WlXA0/udzr8fitPmG90I+0XQedWiQIVRw9Q6sKjbVvW8xnSpIr30hzF2W04IWomGjzMOSLRi08F1WjAaifRbgmbu8G6x96TN8zNca3iRVT8C/I0xKw4pJOwo57zbJ/Gax8nO9YX1waGqNNG/kj59uIlGby1jQmwAAZuoLapVvqUGqmEvbp9/3PZ/4eM7xZoyYGpbG48EKp6I/XDfK01jQuU39Yw4XMyqR0tMCNQL8rBI/F0Iw9J8TQV1oLk3RaQxupyJhGbT0kH+qjKIVV3A0TG86f8Rzht3qU5xZYS+6W6tHfJyuWhbw3KrUSl4ZTRpjbYHu0jZB3Kq6xQqglT4jjm2xOHtlLq/jhq+VcEU/Z4NzcVRpJ5G1n7K+pmGF92/7xDnvP wO77wNH6 YCXJjwUQhdqOOb6OMYMD/Q+El8BAz2VioNztbZeroGY0uWxVd621A+/w1L5IcKUII5d4nqIAoWiSPDJJ4bnYnxWo7cNa04yvZavtG+YV0j9eX5SoI+7ZYjs8JKqlOyWSpb5UTMsGPKCY0doUum26n+ea7EZH11WCziwAh4lifRZsMlxog1fpj/TKD/WvvUKgYdiIeH8pX89Fpuugu/p4qgnTNrE/UbhT9Q4AnUhFXgZk8kAVm7+PpFTJ879ix/heAiPN6vYCRrukxYd7LN5wIGlkG+dTFkoAGYgPlKzw3QROox523VgY9A7Xb0pU+/AA6/2VdzIahxVhxRn3vJb7QR1q3VdzDFipkVDc3ht8gC40Ab3rHGoVcy0+Rwz4wugxWUzMyeRTXF5UWLJjiHHUJ647CnCpf5mDukSVqW3eF4fGjtuK44LZ3/7vqS49yOi9Jw2qZqdTjdUce4ix9C9AfSDszUg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000034, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05/15/24 08:50, Phil Auld wrote: > > > My point was just to call it rt_task() still. > > > > It is called rt_task() still. I just added a new realtime_task() to return true > > for RT and DL. rt_task() will return true only for RT now. > > > > How do you see this should be done instead? I'm not seeing the problem. > > > > Right, sorry. I misread your commit message completely and then all the > places where you changed rt_task() to realtime_task() fit my misreading. > > rt_task() means rt class and realtime_task does what rt_task() used to do. > That's how I would do it, too :) Ah, I see. I updated the commit message to hopefully read better :) """ I define the usage of rt_task() to be tasks that belong to RT class. Make sure that it returns true only for RT class and audit the users and replace the ones required the old behavior with the new realtime_task() which returns true for RT and DL classes. Introduce similar realtime_prio() to create similar distinction to rt_prio() and update the users that required the old behavior to use the new function. """ > Reviewed-by: Phil Auld Thanks for having a look! Cheers -- Qais Yousef