From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78150C25B7A for ; Wed, 15 May 2024 13:12:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D5916B009A; Wed, 15 May 2024 09:12:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9352D6B011B; Wed, 15 May 2024 09:12:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FDAD6B0121; Wed, 15 May 2024 09:12:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 54DD66B009A for ; Wed, 15 May 2024 09:12:43 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id EA0281C0ECF for ; Wed, 15 May 2024 13:12:42 +0000 (UTC) X-FDA: 82120669764.17.3A48A50 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf09.hostedemail.com (Postfix) with ESMTP id 9A3CD140023 for ; Wed, 15 May 2024 13:12:40 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf09.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715778761; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lliFZr6GKraR8G24zn6kAgvIajI96YnfDePdDqHBH4E=; b=svjJpr8QWo1x+4/t5lzFojA9jQHNf+dogfAEkv1g1iy19he4if8aginy2OReFjLj5qqwQK DXZCYErKjgor8QmKovq+OXHa/p3yU+mR/ljwv3LEgG3rBoi+/7zHG8FD8FuUGNCybjzIFm tPiRCdaqWUWdzPcZkjzuDQ5qyeLFsPU= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf09.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715778761; a=rsa-sha256; cv=none; b=PWypT0eSM62WVvGgKMA72uFosccNWavJjt96ip0au1Sfv0ajkwlanaAgI8K/ZaL/bCVopW XlCoEY/VE3OtaG+SjDbJozaSJOGC4NCBQ7x+u7LXcppHjd/a0nODER75vEcy33CLU1zWW9 9KaaFYEi8BCAYYcQ9/0zPGpio6Brchw= Received: from mail.maildlp.com (unknown [172.19.162.254]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4VfYSf3JMSzVm4p; Wed, 15 May 2024 21:08:34 +0800 (CST) Received: from dggpemm500005.china.huawei.com (unknown [7.185.36.74]) by mail.maildlp.com (Postfix) with ESMTPS id EEB3218007D; Wed, 15 May 2024 21:12:35 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by dggpemm500005.china.huawei.com (7.185.36.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 15 May 2024 21:12:35 +0800 From: Yunsheng Lin To: , , CC: , , Yunsheng Lin , Alexander Duyck , Andrew Morton , Subject: [RFC v4 03/13] mm: page_frag: use free_unref_page() to free page fragment Date: Wed, 15 May 2024 21:09:22 +0800 Message-ID: <20240515130932.18842-4-linyunsheng@huawei.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20240515130932.18842-1-linyunsheng@huawei.com> References: <20240515130932.18842-1-linyunsheng@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.69.192.56] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500005.china.huawei.com (7.185.36.74) X-Rspamd-Queue-Id: 9A3CD140023 X-Stat-Signature: ym9a5975uftiseed64h494hzk5xkjf4m X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1715778760-516670 X-HE-Meta: U2FsdGVkX18K7dHh8zHOV+I0al9WYGTV36zdfY9uN0KKX/RhkzBVNyC71EkTMMrzcTh5lixftoQs6asboxpnSxXOUijui84IIPR2MIvTjdcQQsP5xCFk8zFxd+KRas5dWMrt7bN+duQ15ldRnSsoeR4s/QJLj4AZ8t8T8M1VIMNSNRuI0cCsCDbBV4SUmyP0JffUpkLNKHHk2SU7yY1kfmI+JZ/KGu0GGysqLmpfUlo2bCGPkJ9TwFAEd0/wSMg88DNRszeeLXsG9j2HnBJH6VJcntKTB7E5yiUgKPT3ChVMOvbmpobvi05six6IkDEQBzcjGSMxeNjL1mfmRA0L4qNP7D/XAXocKzNRFULeRTDtA9GNBpsU1s8DXw/HLT3gVORbn0q8c6bGhP/Nia13oJOG1AMyl5/Aw+FRrRB8u7zHI/2jPVCsWu0VFxs0i5xx0/O4DgxPTJ5buzVW2CfFC9vJsH0KXhNpbdFbBn1B0aYkXhCc6SbgLpFv6hNEDNXnWvP5VtbxszP86Hj84OAMPipTlR8Ca9vokucLTZPdF/ashBwDxJO/xesZKVgiPSDf2Sk3IvInMew1JA2IGUR0FMAfUX7WgrYNFpCPgVeMqVmeJY3dgB3UhQvJRWWaKbrClPi2/hN+OZXD8WAeBi+HXW3DjqRUWN+jjZAy7t3fXjQ2Cv7ebsl30oY4EjPeHgdYdF1CbzyVp8YAuCAQSP4xQHEC8rY+WlzpLqRtIYd/ZMsA0m9wlPhKnv3q2UD4+u+07uFgYLsqW/v/qa+YnUsyUpJEezc0DdObxaPvVhohSFFj4Z9E/qGgsB5sBaUXnfnoaMX/5Mvo7mRBqChPobqD9Kzj5mCmmtQsRP1aHdy2X2SBhTixwHHmVF9myTInT7c2ot6KMK4mI0giwWO1sqsAGq2AhjPjr8nM6rzwRoiX5zQ+2+rHUwUy0TkU5uHUi4GNpJhHiVUp6JA0n+07JYB +SYFgO9P HjwpWDPzqE5T+WbD+meHvrVBekwnhE5PX/v6I/SnWJ5SgB9CvK2fV92Mtw9fSac3PbvmUMm87+kTfrtDlpbFu1lYAvpEwkceUPdox+rboqtA7+D0ew44IByMToo7ATAC5RppG0GELjXoCc/k7dwhEDqrPo5M8S1IIF4kx1wYS/WABsg24/M8Z97IdnhhW2tDZjT3/9JgoU6OhOlyuoR0ssMsec3o06jsG4uSIXE5vGe/eAWd2JR+CCIYut06lEeZ7mWK+Z8hjap6AMedomI4gtIRs7hn1Ey3p3MHi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: free_the_page() used by page_frag call free_unref_page() or __free_pages_ok() depending on pcp_allowed_order(), as the max order of page allocated for page_frag is 3, the checking in pcp_allowed_order() is unnecessary. So call free_unref_page() directly to free a page_frag page to aovid the unnecessary checking. As the free_the_page() is a static function in page_alloc.c, using the new one also allow moving page_frag related code to a new file in the next patch. CC: Alexander Duyck Signed-off-by: Yunsheng Lin --- mm/page_alloc.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 14d39f34d336..7adb29f8f364 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -4693,6 +4693,9 @@ static struct page *__page_frag_cache_refill(struct page_frag_cache *nc, gfp_t gfp = gfp_mask; #if (PAGE_SIZE < PAGE_FRAG_CACHE_MAX_SIZE) + /* Ensure free_unref_page() can be used to free the page fragment */ + BUILD_BUG_ON(PAGE_FRAG_CACHE_MAX_ORDER > PAGE_ALLOC_COSTLY_ORDER); + gfp_mask = (gfp_mask & ~__GFP_DIRECT_RECLAIM) | __GFP_COMP | __GFP_NOWARN | __GFP_NORETRY | __GFP_NOMEMALLOC; page = alloc_pages_node(NUMA_NO_NODE, gfp_mask, @@ -4722,7 +4725,7 @@ void __page_frag_cache_drain(struct page *page, unsigned int count) VM_BUG_ON_PAGE(page_ref_count(page) == 0, page); if (page_ref_sub_and_test(page, count)) - free_the_page(page, compound_order(page)); + free_unref_page(page, compound_order(page)); } EXPORT_SYMBOL(__page_frag_cache_drain); @@ -4763,7 +4766,7 @@ void *__page_frag_alloc_align(struct page_frag_cache *nc, goto refill; if (unlikely(nc->pfmemalloc)) { - free_the_page(page, compound_order(page)); + free_unref_page(page, compound_order(page)); goto refill; } @@ -4807,7 +4810,7 @@ void page_frag_free(void *addr) struct page *page = virt_to_head_page(addr); if (unlikely(put_page_testzero(page))) - free_the_page(page, compound_order(page)); + free_unref_page(page, compound_order(page)); } EXPORT_SYMBOL(page_frag_free); -- 2.33.0