From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4081EC25B75 for ; Wed, 15 May 2024 12:06:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B28466B030B; Wed, 15 May 2024 08:06:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AD7E56B030E; Wed, 15 May 2024 08:06:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B64A6B030C; Wed, 15 May 2024 08:06:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 602BF6B030C for ; Wed, 15 May 2024 08:06:19 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7B6C180758 for ; Wed, 15 May 2024 12:06:18 +0000 (UTC) X-FDA: 82120502436.14.2D4219D Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by imf07.hostedemail.com (Postfix) with ESMTP id 7159840026 for ; Wed, 15 May 2024 12:06:16 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=layalina-io.20230601.gappssmtp.com header.s=20230601 header.b="Pvi/Xi0J"; spf=pass (imf07.hostedemail.com: domain of qyousef@layalina.io designates 209.85.128.52 as permitted sender) smtp.mailfrom=qyousef@layalina.io; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715774776; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rJYF6H91YS9YSoXm+Tl9JERoBMf7eBC9ZSy+O3IfVoo=; b=ETkDXbT3kS6mj1LDHiHWDfBVrSt9JIWp3r+MFt/MwVbWkfky0utfTVGjU9CyW3p9vOl8/5 14ogsloXQVzgsKkQQJk8NgIbbmwHhoOxciu4nP48D1eJuJawJMiuREhnGmcXIdTTfTie9F yc0PCBqEv0UqjwOkWxWRwZ7CfWIgF9Q= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715774776; a=rsa-sha256; cv=none; b=vpl7rt3H5cCvXnW9pjjeTKblEi1daf9PXRzQW8pPCjf0b28fJpKCDVl2k2TqF2Eaj542hx PGL0V9Cv2I37naHx71xq4TlyyEusvA4FIUFBmnTL67L/XRIoVtpjpnMo92l3LG0j02Fbs8 VaY/p3il3Pq56UM5eOhRMyJD4aBKlDQ= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=layalina-io.20230601.gappssmtp.com header.s=20230601 header.b="Pvi/Xi0J"; spf=pass (imf07.hostedemail.com: domain of qyousef@layalina.io designates 209.85.128.52 as permitted sender) smtp.mailfrom=qyousef@layalina.io; dmarc=none Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-41fd5dc0508so45556025e9.0 for ; Wed, 15 May 2024 05:06:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=layalina-io.20230601.gappssmtp.com; s=20230601; t=1715774775; x=1716379575; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rJYF6H91YS9YSoXm+Tl9JERoBMf7eBC9ZSy+O3IfVoo=; b=Pvi/Xi0JVORS9yHXF57e/UV4Xzv22iDh/6E2pFf8pVxQo8t003GAymkfecx//NEWYp mkPLdmCLd8u0XensNeVWZvKOokUd4ozYxa58vWg1m+JTMF0zqrzI0vtLWJ/ARVmSQHAJ Ddq2HI6Mq42x/Q69kScIySeZ2StiTrIF+fIG3M9x1vbl3UktgSYzqahZMJr7hJ3zsVAO M0nfzD/uvwGdLB9PfYkg1hi/G0gjnLZ6av3LKPQWJ+gD7SPSx9iBpv2Shg9zxVJlx7JF poaKmiEFHcbVcxWFMvwPbnfS9H+8w+VTsFgureW5B+n26+QJUGEJUhgmA/JfG2n97toW gjng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715774775; x=1716379575; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rJYF6H91YS9YSoXm+Tl9JERoBMf7eBC9ZSy+O3IfVoo=; b=H8yzp4Oj8IMNG+iG2hJ45FXeGvO3iQh1vOEq1oI/bMAfo0ymmfl0zf7q5TYSCk5fvq zJhhoQ9jaB9CL38f3miBrA7zXIIfdxNxnT9xdG7LuIu5zp3F0zIleJW9psv0S58+a5fc mPtEePLn8h15ZTFd9oViwcyPc6jcCwtevN56FGi0zuqC5OzLY6m4lK1tXb3c3NJLinrv ScPqqv165iiSNxUgMvDJBO9/+HHxueXkDD+wrJY8xsu3l615yHqqg5EhqPFPipDmy+xl X4VkKGX/Rda1citmyfg7teuu79oDRTRxPksSKJMgL2/hi2nKD160xFR7j4zA6wQXRSNg fg3A== X-Forwarded-Encrypted: i=1; AJvYcCVK2oWu5v9C19NOvD93Nudus7hGLV/4XUD19/98tgpvINa4KtbuhWrfgx3lM4e0FYmB2On+gJpn+giC9kO4L0f+7nQ= X-Gm-Message-State: AOJu0YyHybqf9JzBhcnbnGodcdx+dnxg2NEeUHRKpcFMk+zy0JHqC+yL CK1IXGdS/7KJdP8o2zC3VpXUi36RgRS2rBK55MYcgShd+hotpnKgrNdXCSj9y3E= X-Google-Smtp-Source: AGHT+IFLpgfv8/Esnolm22txMsxpEfskLJZ4i6egdOEr6U9kJff2jGBqFVP62Bj1ZgVi3f/r+yf4Tg== X-Received: by 2002:a05:600c:2187:b0:419:ec38:f34b with SMTP id 5b1f17b1804b1-41feaa439d6mr115391895e9.20.1715774774868; Wed, 15 May 2024 05:06:14 -0700 (PDT) Received: from airbuntu (host81-157-90-255.range81-157.btcentralplus.com. [81.157.90.255]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-41f87d20488sm266011555e9.25.2024.05.15.05.06.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 May 2024 05:06:14 -0700 (PDT) Date: Wed, 15 May 2024 13:06:13 +0100 From: Qais Yousef To: Phil Auld Cc: Peter Zijlstra , Ingo Molnar , Juri Lelli , Steven Rostedt , Vincent Guittot , Daniel Bristot de Oliveira , Thomas Gleixner , Sebastian Andrzej Siewior , Alexander Viro , Christian Brauner , Andrew Morton , Jens Axboe , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] sched/rt: Clean up usage of rt_task() Message-ID: <20240515120613.m6ajyxyyxhat7eb5@airbuntu> References: <20240514234112.792989-1-qyousef@layalina.io> <20240514235851.GA6845@lorien.usersys.redhat.com> <20240515083238.GA40213@noisy.programming.kicks-ass.net> <20240515112050.GA25724@lorien.usersys.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240515112050.GA25724@lorien.usersys.redhat.com> X-Rspam-User: X-Stat-Signature: 5w5cpf9wzpbt8ryzf49uaxeyrtqkofyy X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7159840026 X-HE-Tag: 1715774776-813945 X-HE-Meta: U2FsdGVkX1/qgz0sOLBK1V8AnlJqfjf2tHKtxOMN1sDD0avqaqCENI8JkiaiaTvfAo5bAbnnDfkiz3mFO//cnb1v3tITisyIB3rAUcr8aQHlbN6Jf4KKMEGP7fig0hcODo7iIzji+VmAtWmT5aWAWeN7aRqAmjELmSDrDgmGT0mQzzviJaiDYvQJCi4vIhn+H8s/KfiNllj4JuZ322u3hTTEzmGuehmR2Ju9t+6feiO1UcwmApHmXWdrd7Iw7rMkpb1Fv9W7SmtHsKdcZ/XmSNXZs4F21Pq9JM8U1jh8Hbt596tg2TxLOLKzG5ejmiOkEJtNTpyOFGfLjdZEcPGvpDmbqoGxSDsVf63YfI1p+dbr+rFEoihw2scs17CGuUbxG0JZmS8RRvWVfVSLYoq7Ykevd13j4/pBZr+0TZ9532KF9ePGd1lroCygsddNo5xRqSN3zxoDPiZ1rG8aoLvSS5ZxeARr+QHTUlJKzLKwMjoIRpar32cA/5AreQ7oRXHOHGMj4hzlJ38u8at4u2xLvBXhiW/rBwx2bfFyViz9DDkPo0DqFWqb67HvRGL7LegRtVbhaGwLBAoqPNim2lmwcqPg8sEKrzmXBzoSzpqroFOpmpjrADmehJ+ZW1+nIFzmeX6BriMHPXPHl3Lg2o7+smespUjIFFSToxLSQVp6YJ24qXTYUE2Lj7ljj72+meJPVY2Rf/xm56tYq07FBDuzV/MZ1kKHbyDR4hB1uBPtdCBFoNYf1jFKNR4F+dy7kJJ+4IVMdUCJXiejnnzEkXdhum+i2J9bhv0lyqqKP00+XtY0UVXQO2300jNNhwXPFltdech4t0NUUyhIdpj8HjXA7d6rp4HztLWd1L0IXHmzoEF2n0TxiQMbgv4n5ac/GOhn0L9b1Pfexu/M12+oz7irzxt2ZUISdzPvC43RAQIeI+NuolF8cf4TpLWRn95/yfY/elyiCvu4W8ExnoNaYUW CAgMY++D FNNQ66tZRMk/MAbQ9ePCrhosSF0ohXuVpzsE9NYM+lgvCn3r2Kd4ncD1liMONausfhObPQ9FnEVMukUIJxXsuP4ZIbjrRVS0o0s9SiuLVzvpXAFzet3OZZ00geNxzR/VxRPsAeg+pSKxHPwYYat9WIOX2GCojRHuO3yjI76e2baC5WlS4CGqIiK9ZLid+Zj2jAE1CgM1ic3kY7BEr/FtREqw17hIO/sgwYE/TPh/tUUxH45Z0w1YTLuI2G2vpqX4SrdfUjcFlMv936oiUtQu8dDXwdrhuiAuIhgaRLntkfpFVEh+r0vs7vq0v0sZkMJDcAZejfuhcNK8UaSnvc7D3pU2zAkfGP62ghOSwVLl3jj+nbFUF66x47hWuGTQZW839BMQ4bAY4YbGxZtbnhVl2Fpq/tfHTabQ7fWg3mxvE0gkGTE4nCEHz63wenzJ1LVj/Ply1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000251, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05/15/24 07:20, Phil Auld wrote: > On Wed, May 15, 2024 at 10:32:38AM +0200 Peter Zijlstra wrote: > > On Tue, May 14, 2024 at 07:58:51PM -0400, Phil Auld wrote: > > > > > > Hi Qais, > > > > > > On Wed, May 15, 2024 at 12:41:12AM +0100 Qais Yousef wrote: > > > > rt_task() checks if a task has RT priority. But depends on your > > > > dictionary, this could mean it belongs to RT class, or is a 'realtime' > > > > task, which includes RT and DL classes. > > > > > > > > Since this has caused some confusion already on discussion [1], it > > > > seemed a clean up is due. > > > > > > > > I define the usage of rt_task() to be tasks that belong to RT class. > > > > Make sure that it returns true only for RT class and audit the users and > > > > replace them with the new realtime_task() which returns true for RT and > > > > DL classes - the old behavior. Introduce similar realtime_prio() to > > > > create similar distinction to rt_prio() and update the users. > > > > > > I think making the difference clear is good. However, I think rt_task() is > > > a better name. We have dl_task() still. And rt tasks are things managed > > > by rt.c, basically. Not realtime.c :) I know that doesn't work for deadline.c > > > and dl_ but this change would be the reverse of that pattern. > > > > It's going to be a mess either way around, but I think rt_task() and > > dl_task() being distinct is more sensible than the current overlap. > > > > Yes, indeed. > > My point was just to call it rt_task() still. It is called rt_task() still. I just added a new realtime_task() to return true for RT and DL. rt_task() will return true only for RT now. How do you see this should be done instead? I'm not seeing the problem.