From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEDB0C25B75 for ; Wed, 15 May 2024 10:42:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2D3728D0075; Wed, 15 May 2024 06:42:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 25C538D004F; Wed, 15 May 2024 06:42:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D6718D0075; Wed, 15 May 2024 06:42:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DF1838D004F for ; Wed, 15 May 2024 06:42:24 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 88169C147E for ; Wed, 15 May 2024 10:42:24 +0000 (UTC) X-FDA: 82120291008.06.B66C3D9 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf07.hostedemail.com (Postfix) with ESMTP id 566794000D for ; Wed, 15 May 2024 10:42:22 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=NF9gzcOP; spf=pass (imf07.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715769742; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yE3F00zgM8Ec+9gOT9ropjs1xEfw03srAD/IRCzOsCo=; b=6JQBEdh0dhKrqDahv1yMFO3w5te8XnBiBo8F70XPS3sQhOw1ahmBm/092LLVwB9YH453vO 8HLTOjbXi4BHu0RMK65p3XdpEpCqtejHJpnDOoqeAd5pFqaEdDkmk1nnMRY2RpJcUk4ZDX 12g5Et8J/U5cXw4AqrofzIRkudoG0K8= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=NF9gzcOP; spf=pass (imf07.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715769742; a=rsa-sha256; cv=none; b=aqlu0KscIaYcRFDxciSKbOJfAQIjaj+s0OLkyXxT/+SyF6LM8GhDl5kKusPoc7isxhN0k8 xBFSfHvzFimV5+5kaSzidemAz/r5VKc1O4yhCKsm6uwLwPQK7S0PozQhT/dAi0qiycDcwx nu106xLD3aw7yUgbxdH03yMo0chq0C0= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 794B040E0177; Wed, 15 May 2024 10:42:19 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id DN6m_2lNWs-3; Wed, 15 May 2024 10:42:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1715769736; bh=yE3F00zgM8Ec+9gOT9ropjs1xEfw03srAD/IRCzOsCo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NF9gzcOPp3NEXxQP1UT1pm+893enKzfIqMDg4FkR4pUW/VdY2DPBwvTsuAF9q2/yT cvemirL8rRWJ6epprTVOcMQLyuSdATdiS1B5sm7Uh4oeQrBiWWNaqXGPX2y04mV2B7 IwUmmPMi3Wn0VURN0/J4Ivrk2PGNu5YZPXKUdbI10ZruZTrShRiYcPeKuQ+8Pm3KwJ fkiIQApQIwIPEuizLhxsaUQXWm/ZwZJZGAL7afibQBKpRP5pSea6d+LULH4M02XgAN eDXwLlq+RFaOVCQAGekgDJ3aGDgTCbOWeblnxc+IwFZnB/mUcwXo1ztBG8wstAmihh wAXZG3k7Hn78xuqNUN6b0pOukBQCMQbmzUeA45c2xvWj1c2Q7BTnZaKW57BzWDsbLc 6k/H7I1PQOUssTSKSDxTryAvBdTsq6ELtEGefmisVxs888/HFTX1GkUfQiEZYH0jxi Vd4dlDKWRt/ZwziRTS033lDSDrFZAkshSAaRTjdeP3JClni+aL81VZKH86gtbiSW6n Z+d0vd0VuJj77aYXEAP3shLZYWnOA6FEiOs8/+eBDjbYbGhEsU0QEva8fJ5nXjL4aN x7w1U/pYSI6LuUDaKh/GScF6KHnUBNQDhwynqB3Z3GKewEOdm7W5u0ARbBAdOx4T3z AZrHBIBJn+8FGNYk19MVlGME= Received: from zn.tnic (p5de8ee85.dip0.t-ipconnect.de [93.232.238.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id DE9BD40E016A; Wed, 15 May 2024 10:41:47 +0000 (UTC) Date: Wed, 15 May 2024 12:41:42 +0200 From: Borislav Petkov To: Axel Rasmussen Cc: Andrew Morton , Andy Lutomirski , "Aneesh Kumar K.V" , Christophe Leroy , Dave Hansen , David Hildenbrand , "H. Peter Anvin" , Helge Deller , Ingo Molnar , "James E.J. Bottomley" , John Hubbard , Liu Shixin , "Matthew Wilcox (Oracle)" , Michael Ellerman , Muchun Song , "Naveen N. Rao" , Nicholas Piggin , Oscar Salvador , Peter Xu , Peter Zijlstra , Suren Baghdasaryan , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org Subject: Re: [PATCH v2 1/1] arch/fault: don't print logs for pte marker poison errors Message-ID: <20240515104142.GBZkSRZsa3cxJ3DKVy@fat_crate.local> References: <20240510182926.763131-1-axelrasmussen@google.com> <20240510182926.763131-2-axelrasmussen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240510182926.763131-2-axelrasmussen@google.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 566794000D X-Stat-Signature: brh7y5xih59tq1swg3cw6f5zkqsiwx4y X-Rspam-User: X-HE-Tag: 1715769742-552614 X-HE-Meta: U2FsdGVkX1/IM/kvvWGhlplgNJfcPOdpi4F5fewi2GWZWLsQGYIqSHqvixHutNyE0j586gsFDvX3WLzYntrtI1O5ikklJMlQiYEJFYKAlxjTtTeAm/mIIciwGjNKIQQLAtyVZNt7emu1Sdq21Mb+Wu0zMbWLgfDjFQMUkyw8KtN7SJm2m+jOV4YZgUx/KubbjEIM4DHRk2XIZPIhpkpqdQLYTLYlSGq/pUH8VtLmuH96PGgFUehEL41Z92VX02PkIb07Htv0SpDBRlKJ+wEqo2G5HcBWph2IoK+Go6EndMuMLVy/IRRWnI9xRv1t3DA7dv/7hndA3bQcFNpX1/8x8EvKAaMymyaZYxBT7sygTyUiNG99KEJ1nlxby/bKxYZD/Mtqg8Q7QY3ObHZdDRDOj+0Ox8E2RFC3vC+Sk4G4/W+GTn0G4pTAnkOhV+aiedfjypBJTJ5uk1XLNxz6Mp6MhgwhVzglDbTRkpBcjIS/1qac7+0Bagq03S5ltRRMOqGtQUcy9+PmCcrHetlS6siiILO6jWWqcKppu/ZmRrmv5fWdg8iuDqvJYlgJajecJF7ercevj4mGFsOUACxqbKjsA6b9btjeZrCIFX/Q4Wxs4S8IkNkfMrGByktXb2PJTeaaU7+6uVhoH+FJCw6elGUazak29QtvoQnrNPI5uArbtJthEA+rPlvZyr4D20HMOsVAVy5TQQWkgVq9+afc2rqfZbEJCZIkVl3lgfyycs7ZQYEraZFYVcBfDe6kbE7C2VsN7luy58gnwIIiVfrQ7PzWIIuB/wwKgUuJvCvrj52KfW7TQplLCL+5X54IlJgdIl4cW+DTgNNFG/k+9b79c/i9558CndjLkk7IbAetmkLOkiX+uFflY0PvT/WTQ+GA+1gN+/fNm6nNQv6APpY4TEQxrpBqM0TYAh7Q1n6LMslEg+SSK7yG7/97IxEwaC6ZlrChiw7QwaXNj3vFrKEvid3 UacZLy4O hj9FmkE+Sl2m0JEUONVAcLawQAfI2wmrWqNFQg/nkRyDHNaIjonKmQwsC/vCCEhc77j62AA5kYsHahhbE31dYccCl9rwh1ft3ouvXsXfikzHj30MMgqWlvus4AJgDHC+KTh7sjT+xkTaWCqu6siIFY0IAQ+RnKUcMfy7Xkzi7cgrIXEiF1d6EJCH0rQ6CQYndofLL0kfPUzplelg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 10, 2024 at 11:29:26AM -0700, Axel Rasmussen wrote: > @@ -3938,7 +3938,7 @@ static vm_fault_t handle_pte_marker(struct vm_fault *vmf) > > /* Higher priority than uffd-wp when data corrupted */ > if (marker & PTE_MARKER_POISONED) > - return VM_FAULT_HWPOISON; > + return VM_FAULT_HWPOISON | VM_FAULT_HWPOISON_SILENT; If you know here that this poisoning should be silent, why do you have to make it all complicated and propagate it into arch code, waste a separate VM_FAULT flag just for that instead of simply returning here a VM_FAULT_COMPLETED or some other innocuous value which would stop processing the fault? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette