From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E7BAC25B75 for ; Wed, 15 May 2024 10:31:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86F5B6B03E0; Wed, 15 May 2024 06:31:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F82B6B03E1; Wed, 15 May 2024 06:31:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 698106B03E2; Wed, 15 May 2024 06:31:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4B2F66B03E0 for ; Wed, 15 May 2024 06:31:25 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BFE09411D6 for ; Wed, 15 May 2024 10:31:24 +0000 (UTC) X-FDA: 82120263288.18.0A2C4D6 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by imf14.hostedemail.com (Postfix) with ESMTP id C9B96100007 for ; Wed, 15 May 2024 10:31:22 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=layalina-io.20230601.gappssmtp.com header.s=20230601 header.b="tvDM1FI/"; dmarc=none; spf=pass (imf14.hostedemail.com: domain of qyousef@layalina.io designates 209.85.128.44 as permitted sender) smtp.mailfrom=qyousef@layalina.io ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715769083; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZG5zBn5o6j3jWJFkBRDbSpLzfISGJr4t+twnkK5Jmvo=; b=h/lIueQz9b/mNN4ZR9h6DNPEYEd00y3zt3W6LAbdwx6/u0TK7kXT+0elUxVfknOl3wHLQN nfEuqFHDtLxUQJKBvEXL4Wy5E2Fy8FSc4KVhTKhqWVEsIAK20ieQvQTX4P+kwJIAKEAxJC iMO9fQgLDejMVJuI0hFQneRs1PlSxm8= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=layalina-io.20230601.gappssmtp.com header.s=20230601 header.b="tvDM1FI/"; dmarc=none; spf=pass (imf14.hostedemail.com: domain of qyousef@layalina.io designates 209.85.128.44 as permitted sender) smtp.mailfrom=qyousef@layalina.io ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715769083; a=rsa-sha256; cv=none; b=G9RMPR6S7yjYLmaclUnz9BiNz892/cBVk6kz+K9BwwRvc1kS7o5L2owUCSKVSumVOWgw+p uU/bZHBpiQCgS8heWIrmV3sJe5qgNcDqKqHrWKMuci3WYMTtTSqqiEQ8514HcdZjcVKDh2 X5ivejaUYqip+WPIBCjEj/fC8N6D094= Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-41fd5dc03easo41180245e9.1 for ; Wed, 15 May 2024 03:31:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=layalina-io.20230601.gappssmtp.com; s=20230601; t=1715769081; x=1716373881; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ZG5zBn5o6j3jWJFkBRDbSpLzfISGJr4t+twnkK5Jmvo=; b=tvDM1FI/c/egneS+D6gMuWpkg7K750ajmarfvvH13ke8Bi+b12gwMsAMrg7JJ734ju +WJxA51eBjOxfi+IA/1h1dUCwE5PpitcQ8bozUIdcX/to7f45WN1Lif390QlAVoexDjH G6qk1IZ57fuDc765OCala1bLRzun+RkT1nRHpY/KeztzqVWnOgngzIKazjJ8e8kVLj2U JsWIMFpH2F0WFmDBl4mVCaaj1NlFNb/Mx5W6gk29AEULBi05oFl1hvYOXwQPOwNS0JuK 5w0ctFCit6M48GEIfs8EWNX50HdplyraoQMuXzjuQ26A4bGSYd8rqdYz6moDk6DT3vxa TjoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715769081; x=1716373881; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZG5zBn5o6j3jWJFkBRDbSpLzfISGJr4t+twnkK5Jmvo=; b=XIaTDwM2S1xbwdDpP8b2bfFF5xkpnvUzSIsq+fqXkoy5IH8p0qw2VP0N3mWV5JuUdR YJwUTTSaPIpSuy4tSze4vEdREBeFqTRM5tlgsNPKbx/oiCF3VLhj3undqRDHqbwGV3Oq v2m8BhcCz9YbSRZijmiuWfz3U4bAmH1ohrs5ISSXBE55y1gdl/EKPVMyonXC/CYQB4/h WTBTI6nnt4VLFvNRZxzpKNLvB3qYs8vkm/KQh0eyxIuGgfcQOvE23h63NXk3kmUVps6o 4/2DOuYSGb0mRPYLFi3kLHiJUaF5XavG/3tSpXr3klYxvWXVhW0ApWs5ANZQMqXG2I+h P7vw== X-Forwarded-Encrypted: i=1; AJvYcCUMjr6A9Dylk2DgcfIqRz31MI+7yfXZ9Hw7xKmWvza20q85J2V7cUHMkL0FEQIfShtqpI+HkH6BsAWNYYPPTX+PIUg= X-Gm-Message-State: AOJu0YzsAFXkHvQWjgNCUh7+gWxZyRpzSqEWRHxxKkEfMFq3LT70qLCb pjRhvQyUL4eVlFnaSrHlq91/tCqv2tLmkTxMKvi+tarU79H4lflXwgGeUcjm/5I= X-Google-Smtp-Source: AGHT+IHbRa4f6a0OPIXc+X3mZ/XaiasEuZZegiJVELTp+PTvnfGjOfFYQYTXxfiYT/De51423cv9fw== X-Received: by 2002:a05:600c:310d:b0:416:605b:5868 with SMTP id 5b1f17b1804b1-41fead696bbmr107457525e9.35.1715769081002; Wed, 15 May 2024 03:31:21 -0700 (PDT) Received: from airbuntu (host81-157-90-255.range81-157.btcentralplus.com. [81.157.90.255]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-41fccbe8f74sm229578795e9.8.2024.05.15.03.31.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 May 2024 03:31:20 -0700 (PDT) Date: Wed, 15 May 2024 11:31:18 +0100 From: Qais Yousef To: Peter Zijlstra Cc: Phil Auld , Ingo Molnar , Juri Lelli , Steven Rostedt , Vincent Guittot , Daniel Bristot de Oliveira , Thomas Gleixner , Sebastian Andrzej Siewior , Alexander Viro , Christian Brauner , Andrew Morton , Jens Axboe , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] sched/rt: Clean up usage of rt_task() Message-ID: <20240515103118.qc76v55x4ylqhd52@airbuntu> References: <20240514234112.792989-1-qyousef@layalina.io> <20240514235851.GA6845@lorien.usersys.redhat.com> <20240515083238.GA40213@noisy.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240515083238.GA40213@noisy.programming.kicks-ass.net> X-Rspamd-Queue-Id: C9B96100007 X-Stat-Signature: 6e9bfbn5eri7i4q3ijyz5bwep3pqgtgn X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1715769082-390594 X-HE-Meta: U2FsdGVkX19MhUuv5Eq1P4uOWUayfr8V73p0RW2N6vAMn1DDyTMbuCA0qqMluIRPQXb7FZKcV9v7H85ktWfJM/xX3/adun64L7+ahKQ2Or/tKdw9rt3TCNaBTqxIos6dDHiUXAUOiQvz/SOfnUBQdm0mNqwG/OfNulzCSmGoImcX4jTNJMWubLB06DaNht+/Jl87jKLTpMXLemii4eTqwayJYPh+RdBo2JtrgO6oAm8zxCICwa7MtqHlG3oE18rjogSZuzdM1BPCj8owB3Q6PX8NTccJJ+HYnMiDW46ISLrxOFLR1zvay8HsT2QaKFcjr6NtnQt1ykpFSMqc8LhmF6KNbwQuAQDGMom3mjOz2dCPU0L/Pbq8qQl2zYR6BZbdGZF2952RDeHbyGI61S8+Fzb/TrWS8/rjx7gMCoZPqlGkdtZnW46u4bbmC5HGtbTpUavTPHjFwaBxeBbYWRSIP2uVJVj9fjNWMfjkwx4IkuLb6Be0r3L5U6dQ3V7sT7BNmGq5NAXCPlpCNYGonirXwQ4sQBqDXFa4+W4qqg7KmXfdJaxnaUatIHH2QLAiNY5WHr89xK3Vl83+UBbmh+zS/OrkYG/5HrdtT7LJeLHOh8LC2wROvNH61wDM28KM0a69JM5bHv+KDdy2XbvCUATzISNioKZHLvKmLgzwxEVf14TfoZ5meVKwSv3XXLaNyFM8lrEbKn37HMZ2F7dNmCAPxHJ+wevzFICndmYt4iZ60fx/nb0QAtWmZXFHte5xnT9JL1xsI+lgWQ0tDqGwM0x7odcroPps6xDqjjZVRhT4bYvgi2P5ERLjNhlhZQ5og4bpb0ZCI/V+eyrcR/B5UCrI8keiMIOrUvr4XQdYnUfS3vf6XUjs2yztnoW4c5L/wT01gF28tcpnYfG7qXW+5xH3hlUwrqDFOGu4RDOeBWu6p7/FSHJOKCNS9Rc5y5vAHNzU95vrAIBpt4eMAJPrYRs c2klMmDY sCiF8r+en3w/enDrRvqE+3ttvzzzhJtoyQE3t+HUQwAQUEgnV1MuBn8ebSytYA7WdTAkMWYX1foiPHT9tRU/GohS7z1ui5kRO266pTbrrL6UBr/2+do/Fb1/s5EKkUwHKsLszauZYB1TO2fS6mYA7W7Hmg4BRdpmXF9QBcNDXfSSI6G3BobnkCb/Nxq7E87CJH0Kt5g0qx92n9YGEB4SSeRf9jregQTNtmnxXJIqnybGa42q32jTKOB4Do5OdxI+iS5EJ1bBm3Yju9EptKc2tYbtyNgE7V3JWnprS1yQbrBLd3qlV+u1YFkbSImy8kXlw9QQw/ttLhhzy01iows3qIWJNXR9uBTC32zdxiEBnIPFd8iE5Jrr8Zd4jYLPCyINcQRl6+HJuvTQd3nAscH9cIYEMivWkZJ6WJXopLbjeJjwn2Z7WFtLAdCLIWndX9GaASoQe X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05/15/24 10:32, Peter Zijlstra wrote: > On Tue, May 14, 2024 at 07:58:51PM -0400, Phil Auld wrote: > > > > Hi Qais, > > > > On Wed, May 15, 2024 at 12:41:12AM +0100 Qais Yousef wrote: > > > rt_task() checks if a task has RT priority. But depends on your > > > dictionary, this could mean it belongs to RT class, or is a 'realtime' > > > task, which includes RT and DL classes. > > > > > > Since this has caused some confusion already on discussion [1], it > > > seemed a clean up is due. > > > > > > I define the usage of rt_task() to be tasks that belong to RT class. > > > Make sure that it returns true only for RT class and audit the users and > > > replace them with the new realtime_task() which returns true for RT and > > > DL classes - the old behavior. Introduce similar realtime_prio() to > > > create similar distinction to rt_prio() and update the users. > > > > I think making the difference clear is good. However, I think rt_task() is > > a better name. We have dl_task() still. And rt tasks are things managed > > by rt.c, basically. Not realtime.c :) I know that doesn't work for deadline.c > > and dl_ but this change would be the reverse of that pattern. > > It's going to be a mess either way around, but I think rt_task() and > dl_task() being distinct is more sensible than the current overlap. Judging by some of the users I've seen, I think there were some users not expecting they're not distinct as they were checking for !dl_task() && !rt_task() which I replaced with !realtime_task(). Similar users checking for dl_prio() and rt_prio() in places, and others using rt_prio() to encompass dl_prio(). There were BUG_ON(!rt_task())/WARN_ON(!rt_prio()) in rt.c which I don't think it in intended to encompass dl there. > > > > Move MAX_DL_PRIO to prio.h so it can be used in the new definitions. > > > > > > Document the functions to make it more obvious what is the difference > > > between them. PI-boosted tasks is a factor that must be taken into > > > account when choosing which function to use. > > > > > > Rename task_is_realtime() to task_has_realtime_policy() as the old name > > > is confusing against the new realtime_task(). > > realtime_task_policy() perhaps? Better yes. Updated. Thanks!