From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E633C25B77 for ; Wed, 15 May 2024 06:53:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E2EB8D0072; Wed, 15 May 2024 02:53:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 99CF28D004F; Wed, 15 May 2024 02:53:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 833728D0072; Wed, 15 May 2024 02:53:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 64A118D004F for ; Wed, 15 May 2024 02:53:43 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1379880E7D for ; Wed, 15 May 2024 06:53:43 +0000 (UTC) X-FDA: 82119714726.14.BF3D06D Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf29.hostedemail.com (Postfix) with ESMTP id 43ED9120017 for ; Wed, 15 May 2024 06:53:41 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hvUzU6uh; spf=pass (imf29.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715756021; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ST36cFwOgdO3uv8c/4YdQVxtjEUinbpbcTTUELX6ZB4=; b=ZoNUwJ0OyyJpHFvQFxIPOz6X0k1EPBPkTAUpABoCf+QJqe5XNVnXJ2IpYcTv/Mco7iDE24 phKGJxwAKGqtyaKTWrb9rtvRRY/u7DX9g6HDXYwubEiubel/pNe4Z542DNepdwrFhN+HpV 8wWn7hCndtoI55wmgqjFaQwfrEZqLfU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715756021; a=rsa-sha256; cv=none; b=nXbHGX+n8M/g9KwzD5TDKc2s8kMyRgKceBB8nF5TNazIT0otE2KskUu7QkTpfqwg1B/sJq NuYCC5Z+i4gaSQfqjLWU5CbKNC6BpFpPU1o+w6pEWXLCxLopdrcB88TBA37DMS/xoc1Xp9 YzDs3oINMneKpV3Pbtxemkqzvu27/vc= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hvUzU6uh; spf=pass (imf29.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1f08442b7bcso13922155ad.1 for ; Tue, 14 May 2024 23:53:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715756020; x=1716360820; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ST36cFwOgdO3uv8c/4YdQVxtjEUinbpbcTTUELX6ZB4=; b=hvUzU6uhWIQq6uLDAHFg8DmXt0UyYcNN2KFoYAiUIn4jhtLTmwpHL/IN8N8Yn9KbUp BSHH5txis5UfKEp0eMUkbuV3mqTTX7vLvPpYPcU+uAGUiTJqiIp4of6al0Z3Fpq5ffDw +oMq0a0g915bcsuYZd+2ic8tRmMlefsGz6hib8Jy4fIlwhSAEUbixa1BWtML2msksABY JMciEFMXfG9QtlyQQaw2CCxR29cg/hfo5fqK6wK7VPsydrMS+8iNxTodCe775n9UFcTd 5hgnAsm9IPiJgvt/g8IsUje2sTgykPvudqBhfZu7RmRpCOj3WpDqKBlPVAX5kJloaE7q OUjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715756020; x=1716360820; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ST36cFwOgdO3uv8c/4YdQVxtjEUinbpbcTTUELX6ZB4=; b=mfaXlvJavgHEaWgEW0brV+880lHlwCNUipAzeyW7rDUvBzFr9AoIgBQKSwe8spmyx/ afCa5fxylzWWRbIhVK+S0akbKb8+uYeCTIh0UrZKsdXKmgAOAvuFWSSNTQFwZpRgBEtC lxpRwPW2QdEujE9D6R+uX5PMfpa1RxVkxBxEVwvYV+vcvm/mN9GDPEpmukBQDtvO2wJL NhqxVVHrt6dOTPMVnA0j9CPxQYqT15daxPIi0I2h3uyi9UDdjUwKHMmzXFPN3Z15tLXZ fjl95qBeH7+mdcKnHuchg24uUJkLH4e/mvqBeuGYHNRQcg8dalrbJG/kSEs6AuiABkji Exhw== X-Forwarded-Encrypted: i=1; AJvYcCXFQ9+VrSHiLRG9GOjU5p7C/A2DoJGx8Oa1t9oER3w3oHPS9BOF5bFUr8Nvw/Wf0KuHajTPorATc/pYQnSkdPv5vks= X-Gm-Message-State: AOJu0YxURzqQU9TsAs8zfAF2jjiLEQ3IbuMy1c4O7401Mwr7dxLsJojZ xGwrUb0I4FeomHmvWFziPBZEpkus02cSTsDhTsYRFxsAA8N0l/ie X-Google-Smtp-Source: AGHT+IELR6OLsg9OwtZi2q6H065214V+rnLvq9jo8czN8dNu32SzvGpNpmSBcFYmVIcsSS5PA2L7ZA== X-Received: by 2002:a17:902:6f09:b0:1e3:e1ff:2e79 with SMTP id d9443c01a7336-1ef43f516d5mr147525695ad.45.1715756019990; Tue, 14 May 2024 23:53:39 -0700 (PDT) Received: from LancedeMBP.lan.lan ([2403:2c80:6::304d]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bf31989sm110251385ad.173.2024.05.14.23.53.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 May 2024 23:53:39 -0700 (PDT) From: Lance Yang To: wangkefeng.wang@huawei.com Cc: david@redhat.com, hannes@cmpxchg.org, linux-mm@kvack.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, willy@infradead.org, Lance Yang Subject: Re: [PATCH] mm: refactor folio_undo_large_rmappable() Date: Wed, 15 May 2024 14:53:26 +0800 Message-Id: <20240515065326.37970-1-ioworker0@gmail.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20240515064506.72253-1-wangkefeng.wang@huawei.com> References: <20240515064506.72253-1-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 43ED9120017 X-Rspam-User: X-Stat-Signature: j8ei6rbfkuayc5q6sjxsj4mrykkkxnu4 X-HE-Tag: 1715756021-178496 X-HE-Meta: U2FsdGVkX1++ChNSfAgxrqRD8VVlIry/2JayESl8WO/b20FAbT0/XzDGh0MTxA2BIOSmO8UUkz92FZjFBBkojjogbG+zp3xycTv2reZ5CTExpb6TEHUyeqLDWMKr+KOWciqQnRUN1+obH9nXoCirEBtzuhpyERWzXCkLCJaidcvrqteCG8NiOiXb2wauQTjSNTkIPGE9A1FpHbinaRBlDSeoskL2kYm7mZ6e4VGgqgWaq1lzoCksOTmERy0fw8K857T0buofqriqX2gN8QTlyHXykhDGVtBHS4yWhIg9aWYvxIPeQWbFcFfPkQp/S8N8ef6iISci8h0vjJ1LpNCZQnvH2j4dwCFHcfc6HbKFYsu1kW3UlHIatHmdTx2Mj9UNfQOm5ePeFT7LlSQ92RRo1m+n/tjYv3HuzqwgdmL6IlMaxVvu1zcBwMVVgsPdyJFM0a8Fg2GQQ0uhFqInJJLolZj3q0SsCg1VBc5FACleJ90jCHeFsBwcUIZEhk/nncHLEwzsM9fwdjnueD40paJbsuO9K7g5HtnE/4U1fLeRuh7jeXuWMhfSCg96GnZfEcmKdGLT+V59YznSKrMUasn4ReV8y3c/nnxF2UtDB7PkjS1DK6Ks7lIOY9/tsH/ibXW+MJ3mPmbwhZtOO7aME0TOLCxoygTB1fSMoWe/qMEwuDBJInElkJEMgxl3xrcO/UeZprCpNfNoD4VMOzir33paR4S9jJzjNW7j4I/XjtNOtSSbHThJE4DLUFpZEk3tbnB2GjCJbKVTmvcUPr5cBhCOLGFs/7Riw1yJJ/TgGxr1fSamnonYPKoiqBCN0HocL8iL8wpRkG0E/jQnT3qCIy54J3WyInLYhPPWR0OOjmu0Oh7L4FDbdYq30HUVklXdl+0F3TgvcQ/+JOKDM9pKz3WMYElcVKLYhDT3675KAb/MduzIG2ZukUwBy3gGqduep3GXHn8gYthM/WLpyD/8qCT aYiSBr7T y8E86CaQigzpmfSIkWYdmB2Bg11kgoqMenZ8jUigZ2BS6O+HAINTAdJuI1i/KSG88rxPPHevLdz7Lt1FDs/4O9gDqcr1wvT0fLwkhrFikoJlenxEgbJAw0YrCYcZnZtdgJl1+vCjefcBr6QGVNqOKJcdXhUkd7cXSKBK9pCJDnKR6hUDtQO7MmjiGBLp8Jk52BQaSyqWsD0kKv8ryj4bSg1S8srr1CsFIXjusDDhYaauH//6OILktjf+cAm0Xd/ByAurAh6p2o6bXkfAMSEdac0AuLUvO0Tpakz1SfthdTqonUTQbXUcl7JVg2FdSSxzFVh10WX5WTYLxoFBKm5zB/RwbrfeVrJ9sc6TVRwD2BSecv7670YXEnVzXu4JltCTXJJCx3IMDEwuJTiYrC7+Qs1v/LsoUskK4kADiYZwlG/RYY1nB1o3Mqu+wqHma03KbXol1RBp3xxZDoAljalspUhxGO5o0ulhMOGUK X-Bogosity: Ham, tests=bogofilter, spamicity=0.014210, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Kefeng, > In addtion, move all the checks into headfile to save a function call > for non-large-rmappable or empty deferred_list folio. s/addtion/addition And, IMO, 'headfile' looks a bit weird :) s/headfile/header file Thanks, Lance