From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D5A2C04FFE for ; Wed, 15 May 2024 02:39:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F4538D0062; Tue, 14 May 2024 22:39:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A38D8D004F; Tue, 14 May 2024 22:39:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 892498D0062; Tue, 14 May 2024 22:39:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 69DD78D004F for ; Tue, 14 May 2024 22:39:16 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0DEBB1C187A for ; Wed, 15 May 2024 02:39:16 +0000 (UTC) X-FDA: 82119073512.05.614CC77 Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by imf15.hostedemail.com (Postfix) with ESMTP id B4154A0005 for ; Wed, 15 May 2024 02:39:12 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715740754; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references; bh=h7JSZRmqn8XcITfmHCBZTNxRVPJdZ8DAXevqynnTppY=; b=RhD6TZqZ34kwMDS6O18EuO3DnSzX+XJMWZAD3m34N9ht+BiDzDXkEvmTG4wRMBkCsvJB17 FUu6QVsaQvlPnmqYTJuMIRWz9mtzK23uDXtUQm7fs5LTRVxgy7YDJKpk1phKnxAf+1QsVe dWFxnSW4tVfQFQot6pakbYE4pVuuHUM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715740754; a=rsa-sha256; cv=none; b=h9EdKFS4kOB2AuDatE5Ui/WHbBiCFe4YL/mjqHV2l7RQK0i2ohltvk16FmHtsA6ovvMe9j vzoiW26ukwxAqYS34YSKAm9KX1BdO5QGGyxMm9Gh4odZzQSoT9oNTDK3QgNUuY2zHe9PmS AZlfJaSubFxA5FgF5uHcaGoTUu8rU64= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.19.162.112]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4VfHR24Qq6z1ynTf; Wed, 15 May 2024 10:36:14 +0800 (CST) Received: from canpemm500002.china.huawei.com (unknown [7.192.104.244]) by mail.maildlp.com (Postfix) with ESMTPS id 3D8BF140154; Wed, 15 May 2024 10:39:08 +0800 (CST) Received: from huawei.com (10.173.135.154) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 15 May 2024 10:39:07 +0800 From: Miaohe Lin To: CC: , , , , , , Subject: [PATCH v2] mm/huge_memory: don't unpoison huge_zero_folio Date: Wed, 15 May 2024 10:36:07 +0800 Message-ID: <20240515023607.870022-1-linmiaohe@huawei.com> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.173.135.154] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To canpemm500002.china.huawei.com (7.192.104.244) X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: B4154A0005 X-Rspam-User: X-Stat-Signature: 3gbc1zodqkp4mby9zom1jtidcxony4xw X-HE-Tag: 1715740752-805542 X-HE-Meta: U2FsdGVkX1/apTHebZwY007FqRGDu+x/5w2cPgI9umRiBq38gEhmbRGDq/AjIYWOnStlnpIZ3PRC3DLThFibgtuXpVVztJ8N2gJEbxuKcXpLtbXyNnpyQHFzOIkWcxWbpN3hepLmJP9cBRhRmLnpS7XMynZoXG/XVOewHKpBvwGNQr8VBT/Hm7nRcc0LCWLASVuGlrAUStA7Q1zUfS7fFFaxg5SF6UqIfXyFeMocneJ6eiX+rr/q07mb93oA4c5pV7wHlUvhQ9Y0mQpSKQ6fhH7JbMFPZRaWkjkTxnM0n+KhPZod6sUxG80/M2Xm+f1ryQ5lxND3Gv44QE7UmN6gI5JkB306thJ02cHZnGvfFOHrBXQxhhExhIzpIN6D15p0yj67ZniNY0aYzTj1jMwlCbq00T3/rRBBdpmheVJkpm+VFmJRxbmEFw2AzkxRArvUjw3qO43MEKponVxfmm4iG3mpsqEl9CTf9tsCPd8d3YENZxE6Vueswc8uQdzxZEefeUUOe9likGkX4QLm4AlmpX7ZNwEjdgDp966ewzLzcwIKDI2W8glzOMoEzgqu6SKS9F5zIwKjWZA6n1G1ujEVXduDVbgqvJPdCIKr3xU8Mn5O9TvRewGm1Ks3RlD5V7TxgN3nSh1r8pkzEIiPt87sfhq87I+91CxvG3Bbus3ovWpxZey0B9AITZtPZiUFshrSENu1MPvuCPadycXyzFl/EGyEdDf5XzQBuIWSLd5+oTwzj9cQqCEp2Wr9kMZY6qRbjanLMJ7mJit7ofeRYFwINBmZKbDbL00qNs55np1lHZtt9pUTsKpYNJBtg2JMCLB55vnzpSrnH3jarUMLs6xa3DHcrY+xVOfA0aZ9ZJWlo6IlR1W6OHKnd5VoHe5cKpLL4Xduj2BNTYjQUD89uid+NIDOfoQGrYbX9luTFkJKmH3egBHn1lXvitkOA4aiColNqyj3g+P/o4K5l3ze3ae eond4zqE 1UHhpwsAV/9iTbAqS9zDwPuPbR6U8NL50CuItzG02pFiGNbSXti/4pIAATKerpsiyvekR7ENalOnh+SRzVrGmLzp2B63GMKndmjPGrYroioZGTsj3HC0HrGWbNsMEiYHidsEBRAoPd30x9SRHxXmRm0WmfWWOCZoj/td70PQcMLr47xOm39Barj/hukZ+0E9ma6TQY9sBs/cFkjzqxatrC1Cz3Uv5HCLHLQcw6bYimRku+pGaJoFzzPU1T620Hj3CUAOZZhewfh8X7ovzpQaSl+J/kq3oUZAeV0VrmocG9pxIes1WgR+V4B+Ht5SXtm1Iuzhw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: When I did memory failure tests recently, below panic occurs: kernel BUG at include/linux/mm.h:1135! invalid opcode: 0000 [#1] PREEMPT SMP NOPTI CPU: 9 PID: 137 Comm: kswapd1 Not tainted 6.9.0-rc4-00491-gd5ce28f156fe-dirty #14 RIP: 0010:shrink_huge_zero_page_scan+0x168/0x1a0 RSP: 0018:ffff9933c6c57bd0 EFLAGS: 00000246 RAX: 000000000000003e RBX: 0000000000000000 RCX: ffff88f61fc5c9c8 RDX: 0000000000000000 RSI: 0000000000000027 RDI: ffff88f61fc5c9c0 RBP: ffffcd7c446b0000 R08: ffffffff9a9405f0 R09: 0000000000005492 R10: 00000000000030ea R11: ffffffff9a9405f0 R12: 0000000000000000 R13: 0000000000000000 R14: 0000000000000000 R15: ffff88e703c4ac00 FS: 0000000000000000(0000) GS:ffff88f61fc40000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 000055f4da6e9878 CR3: 0000000c71048000 CR4: 00000000000006f0 Call Trace: do_shrink_slab+0x14f/0x6a0 shrink_slab+0xca/0x8c0 shrink_node+0x2d0/0x7d0 balance_pgdat+0x33a/0x720 kswapd+0x1f3/0x410 kthread+0xd5/0x100 ret_from_fork+0x2f/0x50 ret_from_fork_asm+0x1a/0x30 Modules linked in: mce_inject hwpoison_inject ---[ end trace 0000000000000000 ]--- RIP: 0010:shrink_huge_zero_page_scan+0x168/0x1a0 RSP: 0018:ffff9933c6c57bd0 EFLAGS: 00000246 RAX: 000000000000003e RBX: 0000000000000000 RCX: ffff88f61fc5c9c8 RDX: 0000000000000000 RSI: 0000000000000027 RDI: ffff88f61fc5c9c0 RBP: ffffcd7c446b0000 R08: ffffffff9a9405f0 R09: 0000000000005492 R10: 00000000000030ea R11: ffffffff9a9405f0 R12: 0000000000000000 R13: 0000000000000000 R14: 0000000000000000 R15: ffff88e703c4ac00 FS: 0000000000000000(0000) GS:ffff88f61fc40000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 000055f4da6e9878 CR3: 0000000c71048000 CR4: 00000000000006f0 The root cause is that HWPoison flag will be set for huge_zero_folio without increasing the folio refcnt. But then unpoison_memory() will decrease the folio refcnt unexpectly as it appears like a successfully hwpoisoned folio leading to VM_BUG_ON_PAGE(page_ref_count(page) == 0) when releasing huge_zero_folio. Skip unpoisoning huge_zero_folio in unpoison_memory() to fix this issue. We're not prepared to unpoison huge_zero_folio yet. Fixes: 478d134e9506 ("mm/huge_memory: do not overkill when splitting huge_zero_page") Signed-off-by: Miaohe Lin Cc: --- v2: Change to simply check for the huge zero page. Thanks. --- mm/memory-failure.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/mm/memory-failure.c b/mm/memory-failure.c index 16ada4fb02b7..68bc8d7ff53d 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -2558,6 +2558,12 @@ int unpoison_memory(unsigned long pfn) goto unlock_mutex; } + if (is_huge_zero_folio(folio)) { + unpoison_pr_info("Unpoison: huge zero page is not supported %#lx\n", + pfn, &unpoison_rs); + goto unlock_mutex; + } + if (folio_test_slab(folio) || folio_test_pgtable(folio) || folio_test_reserved(folio) || folio_test_offline(folio)) goto unlock_mutex; -- 2.33.0