From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E025C04FFE for ; Wed, 15 May 2024 01:25:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0DB1B8D0059; Tue, 14 May 2024 21:25:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 08BB08D004F; Tue, 14 May 2024 21:25:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E95548D0059; Tue, 14 May 2024 21:25:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CA1418D004F for ; Tue, 14 May 2024 21:25:09 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 812EB140893 for ; Wed, 15 May 2024 01:25:09 +0000 (UTC) X-FDA: 82118886738.04.1DDD980 Received: from SHSQR01.spreadtrum.com (unknown [222.66.158.135]) by imf15.hostedemail.com (Postfix) with ESMTP id BBCC5A0002 for ; Wed, 15 May 2024 01:25:05 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of zhaoyang.huang@unisoc.com designates 222.66.158.135 as permitted sender) smtp.mailfrom=zhaoyang.huang@unisoc.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715736307; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oiG4O2hCRGEcQ6a9VnNAx6PGi18rQEH1MASbp3fUJb4=; b=DAoyOg1ejBQez/PpMRBm9/l8a+6miY8xdcojxCiG0MXDRaStK91t9dNo0eFKgrWeTb0VRw 0dJgAVWAEFPmw+keplBkvIK/NXWx5u2WGOFk56TP6L8afbsLrdXd+DTyNLdibfbTIDLIl7 rOwlrzboYLqKE8L8etssnKeOhgP1X+k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715736307; a=rsa-sha256; cv=none; b=oT2tHp/UqmFLaGFA+b0i1OGFpooBETL1wt93PmjslaXLCpU1LPNjLYwLk7sBDyG9u7mJST Hv0l2nc9nsC25sm4UL4qckiPVZwCR5K9eEen+f/8cjcBWjhJ27iIljJ7p1SX8ciZMWatZQ a7wS8SVQJlfRq7WCenWUlxcWaJ2/Ywc= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of zhaoyang.huang@unisoc.com designates 222.66.158.135 as permitted sender) smtp.mailfrom=zhaoyang.huang@unisoc.com; dmarc=none Received: from dlp.unisoc.com ([10.29.3.86]) by SHSQR01.spreadtrum.com with ESMTP id 44F1O5Om051360; Wed, 15 May 2024 09:24:05 +0800 (+08) (envelope-from zhaoyang.huang@unisoc.com) Received: from SHDLP.spreadtrum.com (bjmbx01.spreadtrum.com [10.0.64.7]) by dlp.unisoc.com (SkyGuard) with ESMTPS id 4VfFly3fXQz2QDRDk; Wed, 15 May 2024 09:20:46 +0800 (CST) Received: from bj03382pcu01.spreadtrum.com (10.0.73.40) by BJMBX01.spreadtrum.com (10.0.64.7) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Wed, 15 May 2024 09:24:03 +0800 From: "zhaoyang.huang" To: Andrew Morton , Matthew Wilcox , Jens Axboe , Tejun Heo , Josef Bacik , Baolin Wang , , , , , Zhaoyang Huang , Subject: [RFC PATCH 1/2] block: introduce helper function to calculate bps budgt Date: Wed, 15 May 2024 09:23:49 +0800 Message-ID: <20240515012350.1166350-2-zhaoyang.huang@unisoc.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240515012350.1166350-1-zhaoyang.huang@unisoc.com> References: <20240515012350.1166350-1-zhaoyang.huang@unisoc.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.0.73.40] X-ClientProxiedBy: SHCAS03.spreadtrum.com (10.0.1.207) To BJMBX01.spreadtrum.com (10.0.64.7) X-MAIL:SHSQR01.spreadtrum.com 44F1O5Om051360 X-Rspam-User: X-Stat-Signature: hoq68k1qrjej9u8opaz7oknye5s51u7o X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: BBCC5A0002 X-HE-Tag: 1715736305-142926 X-HE-Meta: U2FsdGVkX1/Nx1CyKLDY5Hx8KOw8/RjBbgsMv3SDZK35fLxqktAziWQGIjSUd5IN/b0vsFbwn0JwZLNNUcjgE2UHP3AwiCiequGouBX/8cZWLgx4ix21Vi2OEdHFeC7NnxwwUZZBXUvqim4eyBy3Wnx2cINj9ctje2OT/rhEoJgdlbdh+iTJtIfEDVEZA4c/4SmrIZT4rDc9p3gExAqA7wyEN3ubf9T+eUE8EKqtqAtOGbp6HG6m0mTuYkGHTBsS9dEfESyg72YzXC3dGLy5lRddpu9Qx75bbgSTBVHLu9R3eZbtHM3LNnnwZ4dmJEixbVtODswwd6jYrnKwTMf52j1om1Huoi7X2FUK5QCAHREK8DBHVx1jMuOoMzHWKSxPbwWoSxR9IxxwNPBo3jq65J4P7W+K+zZ3LiXOclMw8MPRCdcWSdcRYILCk68SYnO0YxwZwgOM61DIsO8ym84Y0aoMOCA7VGd5ssgZWiHGSHZOr1vEDHsQnGZoE8ZsR7qZcAgK3UxZJfD3b2FIipLzDgRHadKhQ/MCeJiCEnDOoU9PYX1EVg5VqK9wXrcXy+ojbR86Pn4V2zz8WLcJTB+yZdYAHLFvmeTmQSUYgza2uI5h2JkSntWzCyC1NYd8pRin0X4rg3cYHm6d4kZkbOnCw0V26/wN/U1NGwJ1A7s1TeqwjLSObGZYMTVoQO1awHrGOW+Xv8rB1T8x7qlem29JBr9J2iVsdYO3ru+K7ItJ1aunw51rybleZY7pD+vpqFeQiqBw9gQUC3CecExKMhQHIsiwUSQO8dcRpajd6g0FshR8yXar4iB24tAmfGSPbKvaHzJuHqzim/usd8wUk4eNJMpXcDLjIbkUHzqz5OfyHN/GfeDOKy2TwJnpB0sE10sNP54omtvlK0/Is2kwJttC112DNZL6qWjlG6h9Xw5Xb5Y45DsQOaL6SrS5zHqPTzqff3GsOviR4TS77N6gVj9 hBssyqtM 8njB2cwF9Yyc8zMf2LkIvrPvVXyWnapwfiWsMDRXATMPDIXkXdRlbjvVUjBbw4x8vRuzxcXLI9LhLT9D1VuPHI0o6KaJkKZ0HsxT5x9NtTWCfam5pWPO56hFDGsOlboGxz0+hsARdDjUM5pix7FNORTac/TjQWGQGyaNS/7TkuigR2/GBatEI+3l0zJYRkUYaI5DlxJu+IfNU9/CgviIJ8hCGoLwcTENm6KxrDQI8t/xNJ5A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Zhaoyang Huang The 'over-sized' bio under blk throttle control will be delayed to launch which breaks original IO timing and have the immediate BW be not within the bps limit. Introduce a helper function to calculate block device's budgt which provide the allowed bytes for current bio. Signed-off-by: Zhaoyang Huang --- block/blk-throttle.c | 44 ++++++++++++++++++++++++++++++++++++++ include/linux/blk-cgroup.h | 10 +++++++++ 2 files changed, 54 insertions(+) diff --git a/block/blk-throttle.c b/block/blk-throttle.c index f4850a6f860b..41c75258183d 100644 --- a/block/blk-throttle.c +++ b/block/blk-throttle.c @@ -10,6 +10,7 @@ #include #include #include +#include #include "blk.h" #include "blk-cgroup-rwstat.h" #include "blk-stat.h" @@ -2365,6 +2366,49 @@ void blk_throtl_bio_endio(struct bio *bio) } #endif +unsigned long blk_throttle_budgt(struct block_device *bdev) +{ + struct request_queue *q = bdev_get_queue(bdev); + struct blkcg *blkcg; + struct blkcg_gq *blkg; + struct throtl_grp *tg; + long long bytes_allowed = 0; + unsigned long jiffy_elapsed, jiffy_elapsed_rnd; + u64 bps_limit; + + if (!q) + return U64_MAX; + + rcu_read_lock(); + spin_lock_irq(&q->queue_lock); + blkcg = css_to_blkcg(task_css(current, io_cgrp_id)); + if (!blkcg) + goto out; + + blkg = blkg_lookup(blkcg, q); + if (!blkg || !blkg_tryget(blkg)) + goto out; + + tg = blkg_to_tg(blkg); + bps_limit = tg_bps_limit(tg, READ); + if (bps_limit == U64_MAX) + goto out; + + jiffy_elapsed = jiffy_elapsed_rnd = jiffies - tg->slice_start[READ]; + if (!jiffy_elapsed) + jiffy_elapsed_rnd = tg->td->throtl_slice; + + jiffy_elapsed_rnd = roundup(jiffy_elapsed_rnd, tg->td->throtl_slice); + bytes_allowed = calculate_bytes_allowed(bps_limit, jiffy_elapsed_rnd) + + tg->carryover_bytes[READ]; + blkg_put(blkg); +out: + spin_unlock_irq(&q->queue_lock); + rcu_read_unlock(); + return bytes_allowed; +} + + int blk_throtl_init(struct gendisk *disk) { struct request_queue *q = disk->queue; diff --git a/include/linux/blk-cgroup.h b/include/linux/blk-cgroup.h index dd5841a42c33..ba79fa464e0a 100644 --- a/include/linux/blk-cgroup.h +++ b/include/linux/blk-cgroup.h @@ -15,10 +15,12 @@ */ #include +#include struct bio; struct cgroup_subsys_state; struct gendisk; +struct block_device; #define FC_APPID_LEN 129 @@ -45,6 +47,14 @@ static inline struct cgroup_subsys_state *bio_blkcg_css(struct bio *bio) } #endif /* CONFIG_BLK_CGROUP */ +#ifdef CONFIG_BLK_DEV_THROTTLING +unsigned long blk_throttle_budgt(struct block_device *bdev); +#else +static inline unsigned long blk_throttle_budgt(struct block_device *bdev) +{ + return U64_MAX; +} +#endif int blkcg_set_fc_appid(char *app_id, u64 cgrp_id, size_t app_id_len); char *blkcg_get_fc_appid(struct bio *bio); -- 2.25.1