From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDF51C04FFE for ; Tue, 14 May 2024 16:07:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 64B298D002C; Tue, 14 May 2024 12:07:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D3AB8D000D; Tue, 14 May 2024 12:07:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 474A88D002C; Tue, 14 May 2024 12:07:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 26CF28D000D for ; Tue, 14 May 2024 12:07:45 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A9C7EC12CA for ; Tue, 14 May 2024 16:07:44 +0000 (UTC) X-FDA: 82117482048.09.26F468F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id ED604120023 for ; Tue, 14 May 2024 16:07:42 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=szp5EbkA; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf29.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715702863; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sV6iD1svKcbS7N4QNKK55MN4Ms32RN4vbZOZJWHzc9I=; b=ZFliJNzUmFhOgqrUk+41FUrHZBdm1vLXO1gJRRkP2g9pVbr1JxXLyNIRKvnpkmcd2gNpLU 0qhnehQudQnDNqAJK+Hyk2xW0ZttAJmQSaMOHIEKzdxRCM7bqn05y0apXx4fdq2fTGy6Dl i1skYR5+AG8zqDu3yVr6aiPLUww4kc0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715702863; a=rsa-sha256; cv=none; b=SyfdFv+cQuygsjxRBeh9yqfhdXi87dFLe257aCISRQ2un/A6BpZ+l9JolWY93qBWal/p+X L2m8MO4gUZDcEoXxrElvNRfNdVVp6WS1WcYaxeTCGVcGg/TtS71kTd0MZbqR/Mmz4ou1AA 5x8XbUzAgq7nd+U7iQKfcweEzMnNYK8= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=szp5EbkA; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf29.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id CCF01612D5; Tue, 14 May 2024 16:07:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9ECFEC2BD10; Tue, 14 May 2024 16:07:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1715702861; bh=ML3v5tzrHw3VPJFi38YFLewOGIWpzxuRisvnBjpMwZE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=szp5EbkA0s/5LKz4st/tlejsC9BXeyG4iVh+NDoskdfd8/ms5ij+41djwFLr+SO6f Ulz9rPSS8WHuAZIgdVhPDvYwtP9mOIvBAi1JE8iubmrlD5Bpr1JRik5Hzbsbjbh2Pj LyJ4HrDj7j2tIcwybOem26knshcc5DrFTvZHf9Ss= Date: Tue, 14 May 2024 18:07:33 +0200 From: Greg Kroah-Hartman To: Yuanchu Xie Cc: Wei Liu , Rob Bradford , Theodore Ts'o , Pasha Tatashin , Jonathan Corbet , Thomas Zimmermann , Dan Williams , Tom Lendacky , Kuppuswamy Sathyanarayanan , linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtualization@lists.linux.dev, dev@lists.cloudhypervisor.org Subject: Re: [RFC PATCH v1 1/2] virt: memctl: control guest physical memory properties Message-ID: <2024051429-cultural-prayer-438a@gregkh> References: <20240514020301.1835794-1-yuanchu@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240514020301.1835794-1-yuanchu@google.com> X-Stat-Signature: fccew7auzmahnwoh9khm44x151inkdtc X-Rspamd-Queue-Id: ED604120023 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1715702862-362612 X-HE-Meta: U2FsdGVkX19aBJCD1oZgGDGawd9WQVEqvS8A5iVHTPfzVSWts+c9lYIySC/za2MOglJLkplKl9zCRzVW2UA8ifQOkH8A2Z3RADydYBElJStFKp64eofGM9S9QiM7cUyBmqVvndQsA3Jwna9Ujz/MBW33JZhCqbTcjKnYzx77ZOk7siPbJHDV1HeJruvpD45tay0TNheRZFik9A9CbXQtJ07LBXsUJH31G+hx4HjDtx6tpl/SkUeCiBwZRxGReun+M+V2zJHaIfEUiCCa8oqG6A9JoZx8dLhABXkcQoE8oYBx5VOea5ynqLap6p5sGC62NDjcYd59VcjQ/V5+I6MVk22DUZVf2YqMHQOHZpfASeXQCU1D4CN53JZ1RYSzyujwcSciqXyDxTIVA6x2VwJd6NNxtdQprIZxNvMqv9rhkPmulrNjE24BB4T8ZYe/mYmwRrLCKzjhqXngDgX7tPkYtdcswJW87CHEpp2vDlP5sYw4zjqYN+NPDa4Y3AplPOJwyA0tpZ3f/OIwSaOb9ioE6rvWzYdD4bFY61fjzX0yfcikYkE18Q/PqMS4F4cya8iV/QHuqQnq+zxlkmLer87s5OgtO32S+RWzVYcreZB21V8q3mS9oZXLdnJ8Lu8m+3qf2iKjlku3KJZxju/Ga0ufzwQqnQTrgb6fm09WfNW4dF6Uw56Gb/eVD8I9eqM4yhD/I5Ljjqp7znUg9N59UQ11IbegA87Vyv/g+mDWps56L362wwy3GnWyhnKVhQJ8/eJFnzi8I3uksLykYC/RX4OP03Wz8Kd0+z3Af/1KIcFDxRWkNst3NcbrnnUiftFRkfL/iV8wfGwWqaZ3bH1XaPuCECy5ZVq3Llq0a9sDe5YHQnEG3yXWNv8OTf5WolKmqCOlGKuLzoX5rmy1SPkCpMGi3k65HmdxJOQM23C1mygZLfK8qUT7Kvcmo2apcxVtNq1jSCIAJHklnSSyuPtZYBo 8LJBqnku PqZIWpn/XQQRV0b00EHk9j+xfjkoH9rkys9mXv8mCdfggffTMJGe49EE8Ucad/w/XNlsUa41XeEKyMxQFevWk7ux3AF2I+nUnHsVvvAo6CLLelgoZvgPrz/C5K71UseEhyEClFn1FMJFLRI8gRttDJcowqL9HTKTyypfBtMParV85jhJWRp9PE5zqQDenEFh3sr5xAPsJRKwgFz76h+GbqXI5niVbYwnLd2M4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, May 13, 2024 at 07:03:00PM -0700, Yuanchu Xie wrote: > +/* > + * Used for internal kernel memctl calls, i.e. to better support kernel stacks, > + * or to efficiently zero hugetlb pages. > + */ > +long memctl_vmm_call(__u64 func_code, __u64 addr, __u64 length, __u64 arg, > + struct memctl_buf *buf) > +{ > + buf->call.func_code = func_code; > + buf->call.addr = addr; > + buf->call.length = length; > + buf->call.arg = arg; > + > + return __memctl_vmm_call(buf); > +} > +EXPORT_SYMBOL(memctl_vmm_call); You export something that is never actually called, which implies that this is not tested at all (i.e. it is dead code.) Please remove. Also, why not EXPORT_SYMBOL_GPL()? (I have to ask, sorry.) thanks, greg k-h