From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6935C04FFE for ; Tue, 14 May 2024 21:42:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 048BF6B0213; Tue, 14 May 2024 17:42:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F35BF6B0248; Tue, 14 May 2024 17:42:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DFEC86B024A; Tue, 14 May 2024 17:42:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C1DF76B0213 for ; Tue, 14 May 2024 17:42:13 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6E17BC08B6 for ; Tue, 14 May 2024 21:42:13 +0000 (UTC) X-FDA: 82118324946.14.80FCBA0 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf09.hostedemail.com (Postfix) with ESMTP id 3D047140006 for ; Tue, 14 May 2024 21:42:10 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=P5UIieNZ; dmarc=none; spf=pass (imf09.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715722931; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ks6u9E1Xb1SPvmbnr2M2wRzSluaspaKIb88gMsCbdnw=; b=lhAh2VXcdFoApbOS105bcqjCIJo6p6YdY5/UCFA8vuvXYsC/14nKshVqYQO9AuXojdIrMj nlHo0vnw5OLV2XBaIBr0cDlOIOKOlx08Nt1k3xte4sTgUy4e3DW4bjyM0uUtS++FNy/al4 3T46wvWUjT7vh2R4ww2cu0A0rfGZmUg= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=P5UIieNZ; dmarc=none; spf=pass (imf09.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715722931; a=rsa-sha256; cv=none; b=t/tNP5ARXgckSxTNa9yi3GepUgEoigJ+lHxIP+48DkjJNLMGIHDmdkVGZUzMfryY5Frgoc ehJOLNWGZ57hptw1Bli5Skwej+NsnlP+i/4kIQrFYUpxje7qfXkxCofEWOiRxTO6VYxaI9 GQ73SQbMaZSIi+o5j6nadUgi3D6l5uE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id B5744CE1331; Tue, 14 May 2024 21:42:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF82EC2BD10; Tue, 14 May 2024 21:42:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1715722926; bh=x41lt0y2/QQyRA72DsKY8/rDqXNocvlTMgmU6V5lH0I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=P5UIieNZ0IdpOVfPq5FxAu27iLPTufnjnFL1dLaAqkJ5lR/DYq1p6bfBWt8BHIQE9 sSaZEkF6zWQ5F85/BD1R6J6tYPT0fmeTg5oG/UoG/ptjPj79piaR69ajMN1ZkF/s2Z xsWKJgYelqGa2xrkO8vGfVg0wQgYl8JqT0RpvEhI= Date: Tue, 14 May 2024 14:42:04 -0700 From: Andrew Morton To: Yang Shi Cc: Miaohe Lin , nao.horiguchi@gmail.com, xuyu@linux.alibaba.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -rc7] mm/huge_memory: mark huge_zero_page reserved Message-Id: <20240514144204.88790f125b0275ef68acf6de@linux-foundation.org> In-Reply-To: References: <20240511035435.1477004-1-linmiaohe@huawei.com> <20240514141439.55fba39c81c1af55c9a100e1@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 3D047140006 X-Stat-Signature: g4ykwisqgiz74qtwoyyfqbbneqy6mpuf X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1715722930-532406 X-HE-Meta: U2FsdGVkX19QydPBFtpxox8UmvgTtQTBYSq1hZwzUTGhhJoBKZ/8IU1xkmlri+ho1GbpXkM6h4y0XYBy68CXvLMkR8I8+OpMfqsFL3yrsJSdkNiXRaF4KnN+3j/GnNygxyiVGXbjQYVm2PBfN+s638yf5hk8SISd6IiicvSvqR27ydU5tg752VNfPAHHzZzcFTxboXGw67Wr8Q8e5oAUbSvF7WcHUkjELyxmVPYsORbW+tiAL2ZmkUAyMOZ76tI+dQCIl5FmIOiyvdbkTWPxlY4Hl60Op61jErf0qUamlMDZ0YUqTCLJ8srXBY3zX9jgtHgXtkcGGsDxCc60p4QyxLBMqBlYL0qHRBvj8vNg9SE+/LcPtlLKf+3vhc4r7u3tuS4XGvyVXG7tFAWsdJp2ZTkoRJv37PXDPOX80ZwX9xdDg//L5TywI1kI6Mje4fqYsEEOEsGnEIPDHc1dZK8gSpu+17N8VLp6iHIj3wR6gOzO4uBXvYewL23qnLPR+dgu9EPDhscHg8OMDmK6e3l7S1vjQEAuO/FbuJOKHOzgJmnbEY2/XJXHUkeef3O7sqzJLgnDdP8XDoIW1pM3r0U1nLZKG5oie0hX1hXdbpcjKjiIoFG8ctKI8bbu0v6OS9cSau+f1C+hk4FycpXEiwr2N/eghyXeoQt8x7hpSYvHZ//5ssL2gXwO3UiDx7tmh66iBDc+I1MLa/AoG2hSq6cvOEDtkex50iMNqOJoJDw2FcFXuBY+G8Q0SpmbQanJJRGxWlnPTy4icHFNSqUUVPbFrJw8OV/jgIooTq2vMdFx+PCvdHnsgXqQICx8g/8v1ZYcRWwCevVb7MR3a6keoBIlc3bJHXK260CoozJt45fnC9MpZDfFyNEFVL8gRosKIQ97o/2mgjbsh70OTQNIQvZ0pkMUiA10zZAOK5GvCoo37vi6O4ZOs+vlpvHqgtPkOhbz3p9r2KFFc/SGfh9qo6T ESHPqfkx M77QYfRBL5bhvyi9/W0I76IcuSZrAPBiMg+48nbBl0ZNZ8JkUAaZcaRICMVjp97Z4ZCJWKedjitiVK5N6g/jB2BhEqyBaprmsyU0458EdAUWz7I+wQR+NFnztKPpy1VPfU9d523BK+Te4hejDhlmmIkEFIX3CPNxDl5zik0v8t3064v8/0JGJPlFGAOM9SAdq0YzwRVd2ks8BORrnTEc7rm+TSRJDg2BMLLdwgXGvCISbNC+gGixmYkkxvOelevKTpwUgUNyITSFnVJaLN0frvF4qooYBiEdlKlLFw6IcWu1nk6XSBwr55lugiyGv+pZ4rMCe4OnCAU8Qtf3djo54eZQptVWOoQmKxpYwGzn2GaF8l+THnp9G8/VjOpSiYzNM/BekZmFzRrVXefCysuS39yBKTA58KZ8ajMpdGwbyyOkCCsPGhdwnTikDqYmXYRbZ6Ry4+vexiGWiJyGqooTJjU/52l7rJF3sAjKcvkw9PvtblLFPYIc3IRl/Zm/QzKGXiCYIYsGoQHlRGS4OkMlKhh/OvA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 14 May 2024 15:28:12 -0600 Yang Shi wrote: > On Tue, May 14, 2024 at 3:14 PM Andrew Morton wrote: > > > > On Sat, 11 May 2024 11:54:35 +0800 Miaohe Lin wrote: > > > > > When I did memory failure tests recently, below panic occurs: > > > > > > kernel BUG at include/linux/mm.h:1135! > > > invalid opcode: 0000 [#1] PREEMPT SMP NOPTI > > > CPU: 9 PID: 137 Comm: kswapd1 Not tainted 6.9.0-rc4-00491-gd5ce28f156fe-dirty #14 > > > > > > ... > > > > > > --- a/mm/huge_memory.c > > > +++ b/mm/huge_memory.c > > > @@ -208,6 +208,7 @@ static bool get_huge_zero_page(void) > > > __free_pages(zero_page, compound_order(zero_page)); > > > goto retry; > > > } > > > + __SetPageReserved(zero_page); > > > WRITE_ONCE(huge_zero_pfn, page_to_pfn(zero_page)); > > > > > > /* We take additional reference here. It will be put back by shrinker */ > > > @@ -260,6 +261,7 @@ static unsigned long shrink_huge_zero_page_scan(struct shrinker *shrink, > > > struct page *zero_page = xchg(&huge_zero_page, NULL); > > > BUG_ON(zero_page == NULL); > > > WRITE_ONCE(huge_zero_pfn, ~0UL); > > > + __ClearPageReserved(zero_page); > > > __free_pages(zero_page, compound_order(zero_page)); > > > return HPAGE_PMD_NR; > > > } > > > > This causes a bit of a mess when staged ahead of mm-stable. So to > > avoid disruption I staged it behind mm-stable. This means that when > > the -stable maintainers try to merge it, they will ask for a fixed up > > version for older kernels so you can please just send them this > > version. > > Can you please drop this from mm-unstable since both I and David > nack'ed a similar patch in another thread. > https://lore.kernel.org/linux-mm/20240511032801.1295023-1-linmiaohe@huawei.com/ That appears to link to the incorrect email thread?