From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02619C04FFE for ; Tue, 14 May 2024 19:52:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F00B8D0047; Tue, 14 May 2024 15:52:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 49FC08D000D; Tue, 14 May 2024 15:52:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 367DB8D0047; Tue, 14 May 2024 15:52:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1885B8D000D for ; Tue, 14 May 2024 15:52:19 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id ADF37C095D for ; Tue, 14 May 2024 19:52:18 +0000 (UTC) X-FDA: 82118047956.19.9A5874C Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf01.hostedemail.com (Postfix) with ESMTP id C879A40018 for ; Tue, 14 May 2024 19:52:15 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=II6DADmh; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf01.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.179 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715716335; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Xh5lqeIFxmDIv6drPBD1UeOlHcOcbwmzayc2S6c55cU=; b=jHfUFVi7HXtsajVVhsgEfYuKdyUcUTanpphjBw5TFNGUuTq3iNIQQthcesbgLPJdMtgtY1 J6PphEU9A6G4mwQBqAmcFe8khTNBbysGF/cTcImOzF/SKN3x+iWpyD9bKmDw/UtScu6oak hFaiadAcWq7TnvNAaGLnvb245u0NF/c= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=II6DADmh; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf01.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.179 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715716335; a=rsa-sha256; cv=none; b=sSvdDZAShLOyTE7dpNbHw/IfVAwjvvpCOwrQ+wOO+LMRXRq8XA8kl4hBksb4rQaLSplRQ7 rIWcU9WZNgzRfuqGocc3S7VlZ2ULqL9Ui4XgCDqFp8K/RbekKzRouCeaS2VWfGIUf6anQa gYVdKMpUeQtUoo6asXu8qFMyP5fpvnQ= Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1eca195a7c8so49413115ad.2 for ; Tue, 14 May 2024 12:52:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1715716334; x=1716321134; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Xh5lqeIFxmDIv6drPBD1UeOlHcOcbwmzayc2S6c55cU=; b=II6DADmhLrKA871u7BqZgBPjPwBik/Bt9BZ07Qlp8eQ7I7o9Dr6Xlbe9dmsa7pUgMH 2YQTwI4A7sZUWy20E1eYHd0pDjzgp6YI4StfoUfDtmK715BKA0jel3fqJ7ELjeQgEFFq i989GPDkYUWfVRCv6Pv67xYQ+WJLnYMTT7pnE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715716334; x=1716321134; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Xh5lqeIFxmDIv6drPBD1UeOlHcOcbwmzayc2S6c55cU=; b=TX5LXdFVOR7xm+ndVIGPy/9tkrnIkY1uRsPVfjzxGEs/RwkXRl5IoL33zRiSU/+2Z2 zbrYQXUMAXmhScryjughmyHiiccKXt8KGL4s7ED3+EZqRCZ4CODdtny+GB/YAcHTaSjw nbzPHM4RcFq8uY2KGB5z3y8vj2Ibhne/x4NyWUzpvD4sVwoBwuiFm8ZMkG2IOzanFCJ1 K2t3QzFBbOd5aJ+uBsJyApHPOyojqdIVrXSwqI2cfqzvVx1oaXPRO2us1DlT2LnGPGq2 +9tStM6UE1ojLznPGbO39mST5kBxJ3DxEBkuD7/hNBuvkAbMjWJ1m5OhB6012jagiBB2 pMUQ== X-Forwarded-Encrypted: i=1; AJvYcCV5ke0O9gxurFeb9soAJDnT75wSbn8A3lNAg1PnTkP2YKg5iOaLq++Q7VJ+BgnOMBs8a0vs85CYMurswLu+2LoA/DQ= X-Gm-Message-State: AOJu0YybVGp/1feUt6K+6ZzTbEJf0paeGCmbF6S2HPdaKItsl1aI8aSn jMKmBZW3/SeFgqPCcM3RAx/U5v+znD+ww4sg7rE0r7nKRTKlZVNy02XXwXCUIQ== X-Google-Smtp-Source: AGHT+IE4USN+kE7T6RZD7G5inzqpecMh0wnrqgy4EQ6oLTRU7SRnjNyHXsSdHHrK+4e8wMQQLJM0Rg== X-Received: by 2002:a17:903:2290:b0:1e0:b2d5:5f46 with SMTP id d9443c01a7336-1ef440495b7mr159207695ad.46.1715716334549; Tue, 14 May 2024 12:52:14 -0700 (PDT) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0c038c4csm104274535ad.226.2024.05.14.12.52.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 May 2024 12:52:14 -0700 (PDT) Date: Tue, 14 May 2024 12:52:13 -0700 From: Kees Cook To: Andrew Morton Cc: jeffxu@chromium.org, jannh@google.com, sroettger@google.com, willy@infradead.org, gregkh@linuxfoundation.org, torvalds@linux-foundation.org, usama.anjum@collabora.com, corbet@lwn.net, Liam.Howlett@oracle.com, surenb@google.com, merimus@google.com, rdunlap@infradead.org, jeffxu@google.com, jorgelo@chromium.org, groeck@chromium.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, pedro.falcato@gmail.com, dave.hansen@intel.com, linux-hardening@vger.kernel.org, deraadt@openbsd.org Subject: Re: [PATCH v10 0/5] Introduce mseal Message-ID: <202405141251.8E9580E@keescook> References: <20240415163527.626541-1-jeffxu@chromium.org> <20240514104646.e6af4292f19b834777ec1e32@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240514104646.e6af4292f19b834777ec1e32@linux-foundation.org> X-Rspamd-Queue-Id: C879A40018 X-Stat-Signature: o5c9cokieyzyuj7jp9z9r3w7yferd7rn X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1715716335-159422 X-HE-Meta: U2FsdGVkX180x03jnCzDLscSaG3CQFlUgZN4tYsjiVYAgRIlISt3r3rC3gpYG5psn1mXK+H3kLe6gBR5x66WAdCtgG4IXUVlfKQbPy4JHyIvEen6NUNueGsodgnhuZ9Rlmv2OcT2HkjvswNXE+rJ9xwolnAAc8JLYPma8+/e2ZLtwiBprUWrEIySr1JxXeXJz9zBONDis6jyVSHkIO6/M1p4hcIvrUq0yMyCe0YLN8zB+LCxYUz8WP5xhgTBZYpVG8oloKmMPlTKyMZRha4gr8HbJt8tJRZ0DuXox/aJQhZx4YZRGxQE13N3Y9wqz3JmSIdd8L0iQAXGfFuv4bLXU0NJNGvlMAJHKBJflFxk+gHdK/a4O8QJrA45D+qqBQzLdiCtN53BmasuZms6il1uGM3TsND2cQNeoGi5P52CNlhFC8iTqxzA5Y/v+k60S2SL5p49EZ3BZXIbjRgLFazAT4ZS89Nq/JLu9etEbCx6U0B3ydOqzHi9j19uZFlw0dluNZ5niAfCOfbF9KiVoacx5PhHhNudwPLN4H4uR1guxlnz4/FSx/E/geZT09kqt7E04vLRJk0zNTFokD4KeyDGdDSVtRO7omm0G4WJcEtXBxZlu1iu6s6aZsOkb8wq9RIegQNpvotO5P8uSmua02P71jAXJsg9VHEQYQD96nC7JVgy/dT/B7zvPDSXTG3+V8aOg4+nmUg0zMaDubRerqhq8jzVjbjpnNDG3PJwitXbQ1oVBhFsUvK2Q/GlXf0IE5YtUrrv/8oaxwH/jr16kS3mM5rQ//mp1xT4DkNuWZtrO8TIHAar/icTfpIN+4nmdQFaGsKC+sDz6/h4AdeqUpv3luySmRwLQpqcRqzv3rV1714qPzzgIu5q+PrzLgPbTG2PKXSB8Oxk9pk6pOHIvlJxyJQPIjcbts8Sm/TktPPzMFgrKJwDit0WUe8cXpHjBxmZEuqoGd625GGDI9pDb0H q9u35ioa PgFv5BdwykG5axX/Ww5ZI2R6oUb0rPHM7zcQ/kQuWT5HK9+UcqlyFM+MoMLH6L4P222/djPAUOlS0cNrCUGfkbkZ6Dk40qczT01PqXhkgHJWN3AGbf6/wOu5dI+ULbuPlmFdPPV1j6S1mSfuHWiOlT/A/Yu+D6o2tEjE0rZl34zcXCcpWhaQmljJEED9fR4papqQHilNDGczmk5D2N09JnDLvQ7tYY+/VfnPnYHtobPbh9pZws946XgVPbZWrkQg3HZlFWUwjkWNs6uLYCtLo5g+0iV0Z5mpgnnnlmkNPk2BH5F0Q/NA+lGjbbsw28uTRlnK/gYiLCYBl97/BCxs9AEI2j66h8UXJXktHLAhx5+svZBrl9MGjrVabSUJJucj5w0SLAtM935KSpH2IxvRdwoBfZynG1J2UylpFAzMYKtNYXWEW8av201yluMJrgfl0NUoEYzDjkcsH6uDXX3R1CSAQRCUVATe59WFH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 14, 2024 at 10:46:46AM -0700, Andrew Morton wrote: > On Mon, 15 Apr 2024 16:35:19 +0000 jeffxu@chromium.org wrote: > > > This patchset proposes a new mseal() syscall for the Linux kernel. > > I have not moved this into mm-stable for a 6.10 merge. Mainly because > of the total lack of Reviewed-by:s and Acked-by:s. Oh, I thought I had already reviewed it. FWIW, please consider it: Reviewed-by: Kees Cook > The code appears to be stable enough for a merge. Agreed. > It's awkward that we're in conference this week, but I ask people to > give consideration to the desirability of moving mseal() into mainline > sometime over the next week, please. Yes please. :) -- Kees Cook