From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6F09C04FFE for ; Tue, 14 May 2024 12:40:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 139056B00DD; Tue, 14 May 2024 08:40:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C0CA6B0197; Tue, 14 May 2024 08:40:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ECB146B0199; Tue, 14 May 2024 08:40:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CE5A26B0195 for ; Tue, 14 May 2024 08:40:25 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4B8B4141227 for ; Tue, 14 May 2024 12:40:25 +0000 (UTC) X-FDA: 82116959610.29.6E9829F Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com [209.85.219.171]) by imf22.hostedemail.com (Postfix) with ESMTP id 6CA76C000E for ; Tue, 14 May 2024 12:40:22 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=gLRd5BrG; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf22.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.171 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715690422; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Dr/2UgPjXu/H0D1UFUJeNgJF+vMnPICm51SvEqdX7wE=; b=K4zi479VjTQm7zErY6Kuph3O5g5rvX4iG5H/a/02fZ5HIlGfyadR6X27wzGGzY4MCLKpSI 2YkB2bB5LblYnR1Z4eBVVqwtuTrIxKmhqsJO61tLKcDiIpbwO9yBhYOppfjkAmEZQUYYtP hmltAqz04dWtg2jYNKjkKX2Fqz5CdsY= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=gLRd5BrG; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf22.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.171 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715690422; a=rsa-sha256; cv=none; b=WTZCYOCROo7WeBWPUhol+Q02RJJpQugrzgixGgyTsdgUPmacj/PHDybCVZXTIybITz0HFe opmbGvf4Yl/w7HCWnxyZUlhVUotwo7Vt/Ty1lzQkxTEkn/EGZx29R5kdBWcho5X9OtManl bikb7hF47Skv/0vK0AiQRP+Suwz8WWE= Received: by mail-yb1-f171.google.com with SMTP id 3f1490d57ef6-deb65b541faso5448329276.0 for ; Tue, 14 May 2024 05:40:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1715690421; x=1716295221; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Dr/2UgPjXu/H0D1UFUJeNgJF+vMnPICm51SvEqdX7wE=; b=gLRd5BrG0XrbIQIvXPSStHn2po9VnXcaH5h2Zn5DNbVxD0Q44LwHqllkuIUT+nK4Ip W7/2/KPR97Qx/1Y/OZ5VUUFl2SZFOBahResmn3cPIrpfWdnonekdu/NUFIDLTFiM8MoM u0rIogyuxzXniqdnvMI7Xid0EPARh+ZaqPhOuMpU7o2CwPAGat17u1oY3MyEiXpWNAly 7EYyBGEg3qhmtBEXSmB3Am+6u+5C8bMFRr45K2nOymPDwJefn25L59l348qoIWqp91FV SeN9WBOw4rs0abWjcP3RKJGAyVyeofM28HQvIs1MlhVPcp3/Vbv0Tu2LPXxJQlSpTiFn d5IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715690421; x=1716295221; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Dr/2UgPjXu/H0D1UFUJeNgJF+vMnPICm51SvEqdX7wE=; b=LBU5p1aQCcsmhD0cNrz09CrqDWDPWizoLGihmyrfofXnDIs1eQsWMayVuPslR28JGS K12ZZzi+b4Fjz2YGa2GXdj5hlJKL5Uzz/CkdICQnFIZJfqjNM4Jp+Nm4hfeLmNNUI4do Wnq56o1BVx7OfGOCb2LbFpp9V+c0Ixu0iXG3TbmzlF8SUXekuppB3TjKLD1I9+vSj+LN ggQp8hHBEw3HrVH/D85IYWenvmOI8l5/ub12FRoVBAHSFAiWrDwQcqoJRB71mN1iryiE hVddgPrTo0hDod4NUfr4ntAQwU87EHDO/wZARVb7v2wMBYZMlEsR/FBRKYk9SEfzvB17 lf0g== X-Forwarded-Encrypted: i=1; AJvYcCXZzjtUeML+AzlnCZ7iUTjBcjAEbTKGYXIqK3cFX/kIe7cE2GLUn0ausqwUiwu++nzg/5hS9ACA7mMn8g9QMFgMbpI= X-Gm-Message-State: AOJu0Yx9rPnDhUrL5dEy9SDP2vmAU+mqjZvfRCPaXZGd/+X3Y/O/APlt wx3E0RdMU2epIrcM1knBjJb9LsscG+7lzq4s8r+DkT1+HlQCp47TKBIlgmkEYaAG+TQsjNC0Da+ d X-Google-Smtp-Source: AGHT+IE1+XbMRwozZxpA4C9CaPKdFTjcevNjO2A9IWP4rqyaGNqmRD6s+desWHihx9kNqdTFEJ6FVA== X-Received: by 2002:a25:a292:0:b0:de6:d7f:2a37 with SMTP id 3f1490d57ef6-dee4f324b52mr11464417276.6.1715690421259; Tue, 14 May 2024 05:40:21 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6a166309ba5sm47232376d6.122.2024.05.14.05.40.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 May 2024 05:40:20 -0700 (PDT) Date: Tue, 14 May 2024 08:40:15 -0400 From: Johannes Weiner To: Yajun Deng Cc: akpm@linux-foundation.org, vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: page_alloc: fix the incorrect parameter Message-ID: <20240514124015.GA2697047@cmpxchg.org> References: <20240514065933.1523170-1-yajun.deng@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240514065933.1523170-1-yajun.deng@linux.dev> X-Rspamd-Queue-Id: 6CA76C000E X-Stat-Signature: 14gk9o9wjr9h8ap4c65qmoj83bwur6h6 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1715690422-838479 X-HE-Meta: U2FsdGVkX18PHX3MHR5ra7t+jorphVCGl8/wltQnOgG0Uq/cHdMF4OErKTEnN9z5k7fV2BWz6mTf+Sh//OM1TeLlbHsfozaO5vVcWBfAAfWhVht2onTDb6Kytqr5+4eYnbnkcqakwOxA6lyUoGoHghorO7dXd3gDvbWwfjmaveZBynaHgX7uC5/Yv0hTeKyy05VoxzR5oJ5IZKklT3gquZjDXiV6+iDbNZBVvRtNSSBOcxi3AbyXZUYLK4aUqRbwNahSbn7HK8QgGhDzgrzwl9t05wWvA/Wuh2fWcHU6NSHolNniUYDJiqZhur2pNkYXbVlZJidhirdSdXWWX86YBY5OThzuqf3fLjeC9ao4PC7aM9RcKdv4YJGOu01jjzxNIK04EnKS7MPf3Xx31l+7OLlnSplvqkSLSatzfk8jUmrV+TwIhu9/sSkAYFD5JdOTeyGbhXlUgia42CLihr/CczYRDOs09ExflCLtYxD+VcYWUk9PKJUXTUGUGDr3dc+MrFgdkMs374sx5rBi2AftH5V1JXxLcr6qNkmD90Ofrmmkqt5ridi7nKUyDzxrmex9Xkhi7EkBbq6QDIzepcQyGwN4QvSTSJeDvlmbIGRT8F9O+nC3riYjnQfgclPmE2bmTO+UFofWICHBnLNDePLL9VwrdussWrz8NNjUfX6MBViAbAPN4r153t5kFSQd1KylJLiyeG7roA44Pydz1W/iu9yWoDIvtPX/20/74U83NaJSLiyZwveRqdyQuNcLH7Eb2cQjQekTSEBIhNTOBUkMpor0KW0ipbcYVvuG+fDJKL382lhLF12fUryEbSWEi5vI6+yNfVhSnjTGuOM/LyAPmsjzCCXjP4TWrJczmgn32j91UCBvVUqwNRSEBInZx2EGiaFsq3rCMrgS9Dm69HgMRxj2tggZE3xIY0MVUgLQMq01vx0mT0nc+zP+NzttYSbA97NrdbtzJB2M+nuClON scHdCPP9 19ybrqxbAJPrRBnCjylSYoZlk1fmLBURhX2q2bTQwH28G0mp4CQC9xKMuDo9R0NGTU9Py1MlH2gTffR/n3qwiFgL5HG4e7PhlJGlOE5I5w1vmoZAv8JE20jSFvabylxA2v3bSQe+NMUFLvbtg5S+VGPJPkNFYgiEn6vKaCeD3jrk33tGoSOWGkwrGXh7sAkSsEScvVQLbLR2wiBOZpgCy97G9DnieOONmOCAXkua8UCJt6gdSlWBYoyxbdy7xfmWvuiq0SVBDW+oIXH8DcgvebSKnJeP9dtTaSlBw0kLleLrt7ffHUPuCI+7aB9XvFzaSnjMIUjR1Fswz5LLpaOUv6sBWBYTPLrPDwvVG1j1cO2rYsyyBGYyqzRTH4JaLLOTty8wR1RSVrmqPL6KAzjEBXvaCAHQdi63TY6aaJGkXiyfYnvHTq4wn5/XcCR+IeNB1KKySfeOH14/IrK46DmjJZxLN9WNeLlRoGuznR5pyuaobIOjTsZY8pS4E1fkJWsD7/zmqdxEaXj1kk9wi9goyXn4/sYT29WL4/WcE X-Bogosity: Ham, tests=bogofilter, spamicity=0.002540, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 14, 2024 at 02:59:33PM +0800, Yajun Deng wrote: > The first parameter passed to set_pageblock_migratetype should be the > buddy, not the page. Let's change it back correctly. No it shouldn't be. > Fixes: fd919a85cd55 ("mm: page_isolation: prepare for hygienic freelists") > Signed-off-by: Yajun Deng > --- > mm/page_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index cd584aace6bf..5422f6f8975d 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1728,7 +1728,7 @@ bool move_freepages_block_isolate(struct zone *zone, struct page *page, > > del_page_from_free_list(buddy, zone, order, > get_pfnblock_migratetype(buddy, pfn)); > - set_pageblock_migratetype(page, migratetype); > + set_pageblock_migratetype(buddy, migratetype); > split_large_buddy(zone, buddy, pfn, order); [ pageblock | pageblock ] ^ ^ buddy page We're trying to isolate the second pageblock, but it's part of a bigger buddy. Remove buddy from the free list, update the migratetype of page, then split and free the chunks back. This puts the first pageblock back on the original freelist and the second block onto the isolate list. In the else branch, it's the first block we're interested in: [ pageblock | pageblock ] ^ page So again, take the whole thing off, but now mark the first block isolate, then split and free.