From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A4C7C04FFE for ; Tue, 14 May 2024 16:58:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B23AC8D0031; Tue, 14 May 2024 12:58:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AD39E8D000D; Tue, 14 May 2024 12:58:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 99B468D0031; Tue, 14 May 2024 12:58:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 806A08D000D for ; Tue, 14 May 2024 12:58:25 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9D2D3C12E3 for ; Tue, 14 May 2024 16:58:23 +0000 (UTC) X-FDA: 82117609686.09.DF897A9 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf17.hostedemail.com (Postfix) with ESMTP id D1CF64001B for ; Tue, 14 May 2024 16:58:20 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=gw2gacUo; spf=pass (imf17.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.173 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715705900; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wEkF4iBhBtaf00+75FpppIRiafT1boFmdAFNfkJUL48=; b=iTJ5YPhiBgaGxnLl9XMOP3EQxBuDKODuZkh5UAsPASq/CCOiLW4icUKIh+83G3944qLlD7 TPLJVsl4az5oOCbb301HhEFErRlR30V0Br/zHjNlk0nVgRvAPntjzD1z4u7fBKwhPmlkGJ jk0uqcmEq0Juj3f8BZ3pEra4bJ7ArlA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715705900; a=rsa-sha256; cv=none; b=vld7Df9KgjN336LfSKn93VWCWdfQjj9dsnu9NW5hP+9d3CrccsS3td6nH6wwg7T59AbGWk wQ5eKp+0GbJw6JnD1ewiVv1EotlkmUoSOfjQwS0dt4vfwek5iA4GVXJ3iaSFiolHLrDfQR h/M4w9DH3qPUnCPJx2yYOLcncNySFOI= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=gw2gacUo; spf=pass (imf17.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.173 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1e3c3aa8938so40206845ad.1 for ; Tue, 14 May 2024 09:58:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1715705899; x=1716310699; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wEkF4iBhBtaf00+75FpppIRiafT1boFmdAFNfkJUL48=; b=gw2gacUoztq6QL/N8vtXZYB3V10Q+BOeu+ZDrp43AQN/6A93cWBh/OJqHDDS8T7hRx p9rtUhoq9dYiEsb8lcsHg+gDBiW/XLRQsmJSI9lFcOlOO0yEtOs6D2H3iCUJ6xY+NrUo SuXgDDNk7Plp7o4fHQs48/ECE4rVOZUdOtpsc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715705899; x=1716310699; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wEkF4iBhBtaf00+75FpppIRiafT1boFmdAFNfkJUL48=; b=AtttCFzn3qBr6A8pSCo/WvUrSBuRFsAa8CUXUIC5XeRnO9vKE9r2OdFry3QgjP5ZGg bBHA0tC1r/PgbBIymlfmnTG3tPjlwZBiyD8la6r5tVoYoImO5IhcoBERjNMBn4Ug9C2D TOWCBJZVCjRwd9jFfqU3Ig+SwB1duy30ie4MAZ6JdrpsyGRoHc52qSg0kA6hPaWLxlcv OJHFfLAgvDwXzypWPjzkvMYc5ISoWWNoWBZd9Q6a7tx+HVPt8JJChtZHThEtC6hqjYnF mXw/I8gH4a5r9scWOlaVWaXEivnaXG5EwzJKa4gA67kJobwhMWZN8opOdym2AzOtE3lb nKbw== X-Forwarded-Encrypted: i=1; AJvYcCU1k8vDb3k6+aA3m5qwr+SspP9YPk4u6OSFpP4V+1SkCuNLpEDRFWkXBGz2T7H5vIq8fKh/zHUHTQnksYubv/YPNLM= X-Gm-Message-State: AOJu0Yz0jnBBHh68XSK7mm2q5cpnrKD9ik2JNE9ioojJGXkmUF2cGZ/V vVHapdiPzbgkgzTwoJnLiIDYxCLuNqR8eS2otTYfjBHXr0JuU+QBxVSf5Gxl0w== X-Google-Smtp-Source: AGHT+IFx8txCf+f4PDg/JkVSx/NTLN/wTj1FanyAGcZfdZBY3c1JiC6zHAzNid2BkAx76LnPYKzB7A== X-Received: by 2002:a17:902:e887:b0:1eb:7d1d:67d7 with SMTP id d9443c01a7336-1ef43c0fda8mr180003195ad.3.1715705899703; Tue, 14 May 2024 09:58:19 -0700 (PDT) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0b9d4278sm102727825ad.12.2024.05.14.09.58.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 May 2024 09:58:19 -0700 (PDT) Date: Tue, 14 May 2024 09:58:18 -0700 From: Kees Cook To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, pasha.tatashin@soleen.com, vbabka@suse.cz, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/1] lib: add version into /proc/allocinfo output Message-ID: <202405140957.92089A615@keescook> References: <20240514163128.3662251-1-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240514163128.3662251-1-surenb@google.com> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: D1CF64001B X-Rspam-User: X-Stat-Signature: 88j9k9ss4gurehun8sog1tcdg4jruwnr X-HE-Tag: 1715705900-630590 X-HE-Meta: U2FsdGVkX19PDDz63W+yXC8DafzBUSiKmgP+21Dyg/gqSgUNqeZT4C/bFAFJnaCxoaRLO6YaIRMV5QJTHEFQvoVjqpfW7MdjKBzwcNoFzhyStUR0Rzkc2Ms4im8G5rW8yCLTjVx0aBwfqGuzE8wawjVcKtuMc0Eg2QaY50G0WGL2p87XNm0YZiwCjeMMnH3SBFIwT+3r1QSwo74M1Bpqq3ci22Pzlj09WmLH0zr9Xb5lO2FkdtAb3jkRY3eF9EN9+OKvUD45RKo78pxuxBqASQfEPA6M+eveutsr0ChjfRyRBsF0BaElUPfD5Jo1kDbP4ECD0FwSy6LxbBusi4kl3XVT/H0vWlnjvFjoCe/d0GUTr5SX5m9wnBKfJH9/soHVR9r+w8YIh/CYuZgvgFkeUGjG7mh1JUjn9DgA8HkCSyxhKHknkdVWffbON3yWu9vA4JIW9fK7LTsZnPx5Bq63mqI+QQdhTw8nBklEA5uLgaOHfcaSRz3sDr1w06Q/DtOAhsJRab+QEVVTh509xCWHxqFqxSiz+9XYkrbtzrtbyjx2STjIf8Nz+v/aWRcjQSWGrN5fIkNkgKsR5g0LMUit/dlPqLHZQ5BEXoV3CcYyKGvwfFcTXsBK06Z8xYEpXUqQ4NGQGgbw5fNGoNLrddauEhesIJPnvZshNxmQVjndF4opjQoTMCSVN9IUm1kRWbLZAYOjJuhyFAI9qPw//2pve5usaz5i5VX0mozC0ybujxCQjlcLVo18N8fzRF99aecb5iL70rFTYrcmUTH8QNwac4ewsJ+1Nal8a9QELFkb2C5Ov/S53Lsj6xA5mfhFcSPSucuCIKV7VrRrNqPPrshdA/S22wyyKMZTn83a3vAzrVepm9YROZtyg0qTkRd28fPw6lgicL5zjviYtLCnr5EXhL3ibqZ3suNo8hgM2Pxn1O6A3JPoJu7W3fkAtDtneU7YnsudqXMGyOclf2P/LJ3 bk7MDvlz E4LgbBQ4+bzYxJtnabG/gCGjAHr5yUfDVDgmzMg67U/pNd4lX8DgUj7Jh01Z4pqCSm/iLjfF/SDjbiPXpJ+6jOrXDm8SSbR/FFVlnZx3il3iOJ184x5LgQex1bXB079VcI+yudUvwDkZRLY2vxwuaVIw0Xo9YR6wONFvNjrfWRNeysytvqFcF7zSu4IVCegCCxaB8JPuwHR0M3BOaFp2zGVPPXw9GBda4x7u/TxEC7IVbNuq3pHkiKy9vr/LX0nda1CX+Q3CCmk8KCuLhdTnvdr2IA3d//a/L1VU+2L9D8V7nwl1LSvRW4KDZZ9lKpOZzHXXj6VzOctlRhDi2+UK1ETAt014Q1fkWdgy4EajJaWacUfRqCSOnHN/rAsPHLX6ECoZfnUxo+OTYuS40oRfNP8C7sUaB46b5lrDcYHpVD4fEqM1r0d0xBb3cNQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.010742, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 14, 2024 at 09:31:28AM -0700, Suren Baghdasaryan wrote: > Add version string and a header at the beginning of /proc/allocinfo to > allow later format changes. Example output: > > > head /proc/allocinfo > allocinfo - version: 1.0 > # > 0 0 init/main.c:1314 func:do_initcalls > 0 0 init/do_mounts.c:353 func:mount_nodev_root > 0 0 init/do_mounts.c:187 func:mount_root_generic > 0 0 init/do_mounts.c:158 func:do_mount_root > 0 0 init/initramfs.c:493 func:unpack_to_rootfs > 0 0 init/initramfs.c:492 func:unpack_to_rootfs > 0 0 init/initramfs.c:491 func:unpack_to_rootfs > 512 1 arch/x86/events/rapl.c:681 func:init_rapl_pmus > 128 1 arch/x86/events/rapl.c:571 func:rapl_cpu_online > > Signed-off-by: Suren Baghdasaryan Ah yeah, good idea. (Do we have versioning like this anywhere else in our /proc files? It seems a nice thing to add...) Reviewed-by: Kees Cook -- Kees Cook