From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A9E0C25B75 for ; Mon, 13 May 2024 12:04:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A278B8D0002; Mon, 13 May 2024 08:04:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D8718D0001; Mon, 13 May 2024 08:04:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 89EBF8D0002; Mon, 13 May 2024 08:04:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6E3988D0001 for ; Mon, 13 May 2024 08:04:06 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 03B041C0C9A for ; Mon, 13 May 2024 12:04:05 +0000 (UTC) X-FDA: 82113239292.19.89B0534 Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by imf07.hostedemail.com (Postfix) with ESMTP id CE2C040016 for ; Mon, 13 May 2024 12:04:03 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of honggyu.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=honggyu.kim@sk.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715601844; a=rsa-sha256; cv=none; b=CjvltYoDovbbypkXM+Rww3aH+AkQEaotg2lSO42fmzGcqLov7jmnr4n78aqzRyvghRbQui eZrjTp412z1NOT4g2SAOgOj7h0Ett7kJfYTYcLNK+1IKKzdKRQih/In3nmfhAV4eL9wYf+ Gls8gFXcwVQH9cSN4EOSLH0p5uiowIo= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of honggyu.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=honggyu.kim@sk.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715601844; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D3kJUxNjOe8hd3nHQrH9nphA4gblZojWtQd7rNviWN0=; b=MMopmI4xpm8Lb/AVlytqvTkVtcCXOJgzs40bEZSp2dCqK/w+DJfPGEXXKLrpXm0awtXLFJ QWNOv19eOVRKRIup/raMu/C2J3iE75c7jUnHxQ5MevlBUd/rizNGWpG/R7BZ55loRPiSI/ StImLbfFhbtZFk0F+uylTP2mgjBY0Sw= X-AuditID: a67dfc5b-d85ff70000001748-8a-664201b00e92 From: Honggyu Kim To: SeongJae Park Cc: Honggyu Kim , Andrew Morton , linux-mm@kvack.org, damon@lists.linux.dev, linux-kernel@vger.kernel.org, kernel_team@skhynix.com Subject: Re: [RFC PATCH v4 1/5] mm: make alloc_demote_folio externally invokable for migration Date: Mon, 13 May 2024 21:03:56 +0900 Message-ID: <20240513120358.1503-1-honggyu.kim@sk.com> X-Mailer: git-send-email 2.43.0.windows.1 In-Reply-To: <20240512175447.75943-2-sj@kernel.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrGLMWRmVeSWpSXmKPExsXC9ZZnke4GRqc0g8M72CzmrF/DZvHk/29W i8u75rBZ3Fvzn9Xi8Nc3TA6sHptWdbJ5bPo0id3jxIzfLB4vNs9k9Pi8SS6ANYrLJiU1J7Ms tUjfLoErY+HsVSwFDfwV69ZOY2lgnM7TxcjJISFgInHt5Q4mGPvb+pssIDabgJrElZeTwOIi AooS5x5fZO1i5OJgFtjNKDG/7RozSEJYIE7i5+bbQA0cHCwCqhJ3nvOBhHkFzCSuXJ7NAjFT U+Lx9p/sIDangLHE/n8NYHEhAR6JVxv2M0LUC0qcnPkELM4sIC/RvHU2M8guCYE5bBL/Jn1h hRgkKXFwxQ2WCYz8s5D0zELSs4CRaRWjUGZeWW5iZo6JXkZlXmaFXnJ+7iZGYGguq/0TvYPx 04XgQ4wCHIxKPLwHGJzShFgTy4orcw8xSnAwK4nwOhTapwnxpiRWVqUW5ccXleakFh9ilOZg URLnNfpWniIkkJ5YkpqdmlqQWgSTZeLglGpg9BTK+6/IKXm0e2NZYF7CinmXFDesFb3wMKnk 6t4F567r77o8/3XYV9urdtNbVTr6FuZtjxL02VJ4PXl++doPfS4WlWv9vCTYfl1ZxBA1tXv+ srf8X1bnJny4Gvv/T0ty4jITCelLBZNVXugbKAa8OJ7k7jDJpyZQ62ost+PqhC/T9tzpX7Rt kRJLcUaioRZzUXEiAMkNyg1JAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGLMWRmVeSWpSXmKPExsXCNUNLT3c9o1Oawc6F5hZz1q9hs3jy/zer xednr5ktDs89yWpxedccNot7a/6zWhz++obJgd1j06pONo9Nnyaxe5yY8ZvF48XmmYwe3257 eCx+8YHJ4/MmuQD2KC6blNSczLLUIn27BK6MhbNXsRQ08FesWzuNpYFxOk8XIyeHhICJxLf1 N1lAbDYBNYkrLycxgdgiAooS5x5fZO1i5OJgFtjNKDG/7RozSEJYIE7i5+bbQA0cHCwCqhJ3 nvOBhHkFzCSuXJ7NAjFTU+Lx9p/sIDangLHE/n8NYHEhAR6JVxv2M0LUC0qcnPkELM4sIC/R vHU28wRGnllIUrOQpBYwMq1iFMnMK8tNzMwx1SvOzqjMy6zQS87P3cQIDL1ltX8m7mD8ctn9 EKMAB6MSD+8BBqc0IdbEsuLK3EOMEhzMSiK8DoX2aUK8KYmVValF+fFFpTmpxYcYpTlYlMR5 vcJTE4QE0hNLUrNTUwtSi2CyTBycUg2MVq+2MvJMr45Y8iUslqf1IBO/3e9XXD1tphnnJSr4 5X8msb1uOdYk5rX63Pm1/15tjN3K8efcurcv5UPCY5LXNWsdUFvmJerPwF1xkm1K/4mU13xb Csw22HM1fAv03FyV6XqRQenLxt2/D22Y9SOn0vhnzA37CXc0HddWMCT4LttycGbfRQMzJZbi jERDLeai4kQAfCLvwDkCAAA= X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: CE2C040016 X-Stat-Signature: ekfyzskyxz9rpz97xaf5z4ksuqw5suuz X-HE-Tag: 1715601843-778541 X-HE-Meta: U2FsdGVkX18J8yhPqB2CmzWHvXnKmQ7ZsHT6q3RVFHfMkj5QYMlxEFNKW4iW+s4F53LX/bTXYd5H1VBlOuKG2dgB0k35KpknaXTJMB28jCqU2me4xdgIv7vQZ4JDtH0uy4UDsaLKLX+CMof59MbzMBv3Va11R6To6YMbkBr55xEaxQwhIzMyyDi54pWhmtppVCnfxlzEXHPYDybecKxVavS0v1W7fFhxjFFArPOEijX4FC2ISScf9n2vHFPy8WT/PjHF43wj6TjvR7j9/qpRoTKcsH0Lj1rqd9byEoS1wDhqHz6Y1xg1n6Av1JXqT92/O1+38cgMm2OOQthM9skuYkPhqKIEMcy0j1cxEACgqADBfJJ8Ow3yfhv9nEythP8QBxr10yntX7nO3B13pW+BwkHvTUG6SyG19Sf4CdKBjg1IxZLa/VrzW4NRwumctQ4oZif4SvRfEOuS7JSCb/6DUf1C8H+pCL1vHMGMxGsq5RwbkThi4nQmjavW1OYTiYuLIuip9bTcrBcIerRfRb1x7OzX/QkgLU/J0dvTHxjHpo2uvrs/jOIWOPorR01QiJEfBNhyV9fclxFJ6RecTGXyG9Td5wsp3mey00UQtXy19cuq+DnreJ4iVwrSPKMUAyhfQVcrjvRL/ZApOmoYN9d3gk3W14Y6SWNhor92fs2kimwC+mFhNo9UWvI6QeLSlXc3O1o2jSE+gNY2btkWjTc/L+atbtY5EZNELVfH52u/raVeB80Jh3AGiQgXDwpXwagiMycHjFBgiN11go9lavRMivlt6FJRl43QRgUM+OMHU6QHky6mWrp1OhKWcQp7MPjD5lT30Tu5LLJlz5Xf7ClDrEXZUo9Wk607MpH4zmlw+FGxZjfh6wcksqNokcsBnBThHraRjh2zVM2fQY3REI3TJbbqTFiNeuJZ3sohE6fWOpchM4G0r094pHT4ipTLwHK08D06JwqScv6vN5xJdBr ejB1TdUs IYQKoKumJ/xyvOE+N1Km8Nc1hjIgVMsj1ZBxeqOyeFid2QgqAlUwfmdifBPkTIWADAjE5CGR/KxGrwExfUUR6pVkB0QexQb9xBwMpXGf0Ws/koe7zOMLWa2HtE9HRgYWEt6Fc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, 12 May 2024 10:54:43 -0700 SeongJae Park wrote: > From: Honggyu Kim > > The alloc_demote_folio can be used out of vmscan.c so it'd be better to > remove static keyword from it. > > This function can also be used for both demotion and promotion so it'd > be better to rename it from alloc_demote_folio to alloc_migrate_folio. This description doesn't match with the changes below. > Signed-off-by: Honggyu Kim > Reviewed-by: SeongJae Park > Signed-off-by: SeongJae Park > --- > mm/internal.h | 1 + > mm/vmscan.c | 3 +-- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/internal.h b/mm/internal.h > index b2c75b12014e..b3ca996a4efc 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -1052,6 +1052,7 @@ extern unsigned long __must_check vm_mmap_pgoff(struct file *, unsigned long, > unsigned long, unsigned long); > > extern void set_pageblock_order(void); > +struct folio *alloc_demote_folio(struct folio *src, unsigned long private); I still prefer to rename it to alloc_migrate_folio. > unsigned long reclaim_pages(struct list_head *folio_list); > unsigned int reclaim_clean_pages_from_list(struct zone *zone, > struct list_head *folio_list); > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 6981a71c8ef0..27269bc2bcc5 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -933,8 +933,7 @@ static void folio_check_dirty_writeback(struct folio *folio, > mapping->a_ops->is_dirty_writeback(folio, dirty, writeback); > } > > -static struct folio *alloc_demote_folio(struct folio *src, > - unsigned long private) > +struct folio *alloc_demote_folio(struct folio *src, unsigned long private) Here as well. > { > struct folio *dst; > nodemask_t *allowed_mask; > -- > 2.39.2 > Thanks, Honggyu