From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35625C25B4F for ; Sun, 12 May 2024 19:32:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 99B016B01AE; Sun, 12 May 2024 15:32:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 94AF26B01B1; Sun, 12 May 2024 15:32:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79DD66B01B3; Sun, 12 May 2024 15:32:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 59AAA6B01AE for ; Sun, 12 May 2024 15:32:54 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BB708408B4 for ; Sun, 12 May 2024 19:32:53 +0000 (UTC) X-FDA: 82110741426.05.BBA1860 Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by imf18.hostedemail.com (Postfix) with ESMTP id F15E01C000F for ; Sun, 12 May 2024 19:32:49 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=q5FxJCVv; spf=pass (imf18.hostedemail.com: domain of j.granados@samsung.com designates 210.118.77.12 as permitted sender) smtp.mailfrom=j.granados@samsung.com; dmarc=pass (policy=none) header.from=samsung.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715542370; a=rsa-sha256; cv=none; b=JHcLRbMN9vePkB18t4eoO0jW/Df26dV24zILUycUcHXDNExDjxOlCmt/WPNdayvioe6d5H /zuERDxLn9hdfsvTac/N8knCA3hHj/P/vtwwwnkekxecD1AAD1QAaHnHyRyJ/m8HNw84sf eIXOex/ci4mL4dtrI0YSgvUWqiZ6va8= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=q5FxJCVv; spf=pass (imf18.hostedemail.com: domain of j.granados@samsung.com designates 210.118.77.12 as permitted sender) smtp.mailfrom=j.granados@samsung.com; dmarc=pass (policy=none) header.from=samsung.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715542370; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PvyFmIqnit3tB539Co+7wuRW+IE95f4txoHSn3Qz5ZQ=; b=AOl+8FLzzp4ch04fb5SzZJq1nXIqMy24laz5SeXd8NrSRdMGi/GjZt6xQXpF51AxYWZOEV 73ok+4tzx5/U75rW2p1cd2tu38UZ3lCKDArGi7ysfVau5bbrHUqzfbFjQrbuWajndX6dAh OMr8uuzZjVOS6eftJS/n/anp57QJZ6c= Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20240512193247euoutp028395386268472af00b4482601e7ec58b~O1LGim-aF2248722487euoutp024; Sun, 12 May 2024 19:32:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20240512193247euoutp028395386268472af00b4482601e7ec58b~O1LGim-aF2248722487euoutp024 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1715542367; bh=PvyFmIqnit3tB539Co+7wuRW+IE95f4txoHSn3Qz5ZQ=; h=Date:From:To:CC:Subject:In-Reply-To:References:From; b=q5FxJCVvcRlNbw8l3QKxhirjflXeDHMDCLFZkJiHoP1UZ5QtgKAcSiT7RyfJmt7EW hSZzRaEHz1EygrUV6UWkYAiVy2uPwuauv5W50NHVePQz3uhniwnjBm5u0Enkmqhp4d eAwf+lnGiqc3kjYLFPQ5d+GKvizvaPpKzOgK29BY= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20240512193246eucas1p1b803e1e209b64539505f5fda1778b4dc~O1LFSONbZ3234432344eucas1p1m; Sun, 12 May 2024 19:32:46 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 5A.97.09624.D5911466; Sun, 12 May 2024 20:32:45 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20240512193245eucas1p103d1891d851a519d0ab83e586ccd2cad~O1LErWG9j3233532335eucas1p1u; Sun, 12 May 2024 19:32:45 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20240512193245eusmtrp2908ef0acafe2b5b7a8df17de78204001~O1LEqceM60125201252eusmtrp2d; Sun, 12 May 2024 19:32:45 +0000 (GMT) X-AuditID: cbfec7f2-bfbff70000002598-7b-6641195dba44 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 08.B2.08810.D5911466; Sun, 12 May 2024 20:32:45 +0100 (BST) Received: from CAMSVWEXC02.scsc.local (unknown [106.1.227.72]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20240512193245eusmtip2a45a6ffabbaf52a5c4686fc913dd8737~O1LEbwfVT0200202002eusmtip2K; Sun, 12 May 2024 19:32:45 +0000 (GMT) Received: from localhost (106.210.248.15) by CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 12 May 2024 20:32:44 +0100 Date: Sun, 12 May 2024 21:32:40 +0200 From: Joel Granados To: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= CC: Kees Cook , Jakub Kicinski , Luis Chamberlain , Eric Dumazet , Dave Chinner , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v3 00/11] sysctl: treewide: constify ctl_table argument of sysctl handlers Message-ID: <20240512193240.kholmilosdqjb52p@joelS2.panther.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="qt3jjettk7ey6stj" Content-Disposition: inline In-Reply-To: <8d1daa64-3746-46a3-b696-127a70cdf7e7@t-8ch.de> X-Originating-IP: [106.210.248.15] X-ClientProxiedBy: CAMSVWEXC01.scsc.local (2002:6a01:e347::6a01:e347) To CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) X-Brightmail-Tracker: H4sIAAAAAAAAA2WSfUybVRTGvX2/CqbLS4Fx6XQ6JmziQElMvApqSUbyLotfmS7RZJEK7xgZ LbUdG3NMQHCr42MNHw5QoQxWEGbBUirgCJNgKS2TKqRDxIJIt8k6Bq3brECR8jJd4n+/8zzn Ofec5PIxoZMU8dNlR1iFTJIRQQbiRpN3JOZAeOLBZ/JrX0D5Jg2BPAODJDI2FPHQSvdpDBlM DoCcphkKDRdJ0bfWOzxkM5YSSP+7nUCXeodwVNvmBWi053MSOS6uEsh22UqgsU4djq71l+DI 6Ckkkbq+AENOzU0CLRTPkGig7QqOepa7KLT01zUeWrrnI1BBnRtD42onQCbNZqTWWXD0Q4eH EG9lPsv7EWcs5yGj0Wcx+pZPSEbvLqOYjsZc5kZHNWBGquoBYx+fwplbS2YeY9O6SMaj38qc LTJRrwveCUxIZTPSj7KKp19KDjw0ZtRT8pnwbJ2jkcwDXaFnQAAf0s/CpqZZ3hkQyBfSzQAO LesIrvgTQNVA54bjAdBXZAP3I+YlC+CMJgDrVmqJf7u8I1corjAAqFm5TvkjOB0JKz89x/Mz Se+CI65JzM8hdAL88q5nPYDR3RT8uleH+41gOhkaLpSvvyegxdBac5fkOAgOVc+u92B0Nvxj YmVtKH+Nt8AmH98vB6zNtJsvbawaAQtMxRt8EloMEzyOFwJhb8/bHO+Gns5BjONgODdooDh+ BK52163fD+lyAPt8CxRXtAKozb+zMSkeFo7NbiQSYfPkJPAvBOlNcPxWELfnJlhmPIdxsgCq Tgm57ijY6nDharC95oHLah64rOa/yzg5Fo5XVpD/k5+C2vqbGMcvQp3uNq4BVAsIY7OU0jRW GSdjj8UqJVJlliwtNiVTqgdrv9/qG3R3gS/mFmP7AY8P+sETa+GZ9lYbEOGyTBkbESIQv//y QaEgVXL8A1aR+a4iK4NV9oMtfDwiTBCZ+hgrpNMkR9jDLCtnFfddHj9AlMc7XT13QGVY7D2r Str5inzK21J2qtHwmqcTDTufvDjaNu1gdl2/2l4RYk1wPbQ77NWURbnj9qx7x2L3kPKyfbWv d78luKJy3/Ztv+UmVg0F2ZtiOqO03/FNxFvxQXsam/cWE8s5bzxX59spFo25538iS9R7y8N9 N7z77SfjzLlX6RTyb210c07Sz98XVqTukxynzG+mbQs+URW9YhMlrU6SH+mBey667ZuG0JLu +IAEOI0ydww+erR0PiZ3StLwePZ0zHnpx/MfTpSWffWwZqTnPYnqsBk5RL9OTES6hJvvZYjz ctJ/6Ru+sFoSSic8X5lcLW93qjyW2j3HGk7Y60xRoxG48pAkLhpTKCX/ABbPJLd4BAAA X-Brightmail-Tracker: H4sIAAAAAAAAA2WSf1CTdRzH/T6/Nuxmj4D1ZabosDjMJkOg7zo0ODMf7fd5dpTyY+EDeLEN n20e2XmOH2kxkzWxchZs2maYBzJgCYHY0ofJKsep6Bk3kl9xYilumARSg9HlXf+97v3+vN+f 733vI8TDSyixcLtKy3IqRYGEmkt4pjp8z2REpeXGD9yIRMW8hUT+cx0Uch4zYOhB8z4cNfI+ gAb5PgH60aBE33nGMOR1HiCRo7+bRK1tFwhUVTcO0KWWLyjkO/k3ibxnPSS63FRLoCHXxwRy +ssoZLSW4mjQMkKiO/v7KHSu7icCtUyeFqCJ+0MYmvhzikSl1XdxdM04CBBveQwZazsJ9HOD n0xdzBzRdxFM51HIWBw6xnHiI4px3DUJmIav9jDDDYcBc/FzK2C6r/USzO8Tbozx2m9RjN+x mKkw8ILXRW9LUzi1TssuyVdrtKslW2QoQSqTI2lColwqW/VsxnMJSZKVa1K2sQXbd7LcyjXZ 0ny+cpQs/DWqqPJyN6UHzgXlIEwI6UTonugE5WCuMJy2ATg8MoKFjCdgfeAKGeIIONldToWG RgHs/f7r2UQjgNbGtpkpgn4SHvr0s5k0Ra+AF2/14NMcSafAmnt+wXQAp5sF0FhRDKaNCDob NtoOzrCIToUe873ZFVUY7DrAUyFjPrxweICYZpzeCQftfwUDwiAvhMenhNNyWHBBt7sVhJ4q gaX8/lneDf0PhoARRJgfajI/1GT+rykkr4DNTT3U/+Snod06god4NaytvU1YgOAEiGR1GmWe UiOTahRKjU6VJ81RKx0geIBOfrzhNKi6OSp1AUwIXGBZMNl36hsvEBMqtYqVRIpSdzyfGy7a pnhvF8upszhdAatxgaTgN36CixfkqIPXrNJmyZLjk2SJyfL4JHnyKsnjog2FHyrC6TyFln2X ZQtZ7t8cJgwT67GTquGjd7L6bmyGbnC/3aP15L4qSvRHFQ30FC+b7F+S37GQSwqUke3s+bZ0 BW5TPEV8e0oeHcbvffN6xgdcdarqJev42jOcjy9GvqbexqU1eHaszxR47Y24uE11v90uXbej b6uy3mWdPFs37+WNh6Rp+mxLh2n98t2YuYYviZPYywIx0kxXl2jD9XUW/9XSdn1g0earL0Sn U/vqkMtgOBKgYmN67P1pcf4x76JXYra8n2nelDPHYG3VpafvKdlIm678EdvZMFa0N+vRkl+Y 6HnWLw9WuHedqa80Vb913o3NsdXP79fwJcdjzTdbj71jE1965IcXt1oFwJ7JtRBOp4TQ5Ctk y3FOo/gH5R3XohUEAAA= X-CMS-MailID: 20240512193245eucas1p103d1891d851a519d0ab83e586ccd2cad X-Msg-Generator: CA X-RootMTR: 20240511095125eucas1p1e6cd077a31c94dcdda88967d4ffc9262 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20240511095125eucas1p1e6cd077a31c94dcdda88967d4ffc9262 References: <20240423-sysctl-const-handler-v3-0-e0beccb836e2@weissschuh.net> <20240424201234.3cc2b509@kernel.org> <202405080959.104A73A914@keescook> <8d1daa64-3746-46a3-b696-127a70cdf7e7@t-8ch.de> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: F15E01C000F X-Stat-Signature: 6j7sh7c1eerxcmg6g5tbr48ckgim44qk X-HE-Tag: 1715542369-172377 X-HE-Meta: U2FsdGVkX1/1uJUq59I/gzwslEwZcWyMgEzQSMZmH/awS7PKJ/IOxs4mpCx3MABqFaCoU1NWhN67gSJXtKvR9Tzza2VxIAJtGgFVrCHdxCokXUpdIvX44SmHeMITcyTZyiczeciuNfgJHfTNEGV4rBkLiBQNZ8MTjLLBQxShRgDrv6/hknDru1kGsjYwVpQIP8D51V4NluUsICdSEisWkASncl79O/hvEj/lH2Ey/NU7CwZrj1cVWKDQvSZhSe29DPVjNCIj6efjuxEeFdqFemqqUKPT6yNf3p8Qm1OL9eoNwwi4Q6AF98R2WV9x4mXRxMI0OjLJbFuTdQmXqXgWLE9Qd/RlwEhueI7zNF8qr1dng3VMdFymAlR98Wuz1wVZyq4fTMiF/RVcu3ByEDQlBoQvgYcro8OEZo8687wbIwGa0IgfUne9HPvCNyvMdDTfXH6NmJOy4D3Q2y0Uguq15wmPU5wY4uYomcgZrQLw9Ppw7TA4kYK0sEasu/3AwPVJ1gD2DgweX/BalVEsBACjmi/I4fw146pmapeUMUVwowMmzg/19RVQoBvFLMoubgoE/bTK3SFVAoab0tUftR4lk/45ogpSk4U+2SUosvvs6/ILvd16prk9VA890OBWj2gWKSIW8vqV9g8kccOnqRjaXmEVhKtgHQCrPDq5TvdiyaI5Q4rjsMuegOkwdokfpSsL9LBZ2VR/ZJ2E9AXUBAIZY0dQuesuWnVrR6Fjq+5oH2YA69gpqHB2um/Iq/a+X0DzG+lg+rTEU89EuICzinydQ/Qab2RZXBBRADl1pxv6+ORdX8IDIenNlMCnTMRfjVnbwQm6zh+mmW4xw5Ih7GXXSq8/MDXX6BdggpQPp5SnEZr1z2VndjkrZygMvB4kZaVavVANcIXRAI1/nA0Pfovufl9LQRMSnhv+fULcdiPcf+HLZvuWdQsQggM8oLlT9roDXfXbxXINxnAPk2tJftb rhBN6UVA +vV3Q/VB9C+l1EtzHRU3/hVp0cGlksmDEIZfl/71/ZQBn96aI9YkxWG+LmGShEuwaOjZcWx7tjw7RxBI7xSinX8q8T3efTQFVr9a/EUgRY1P0muPrz6Wp74mGQB1wi0O2ZQU5CgdL3gVXZLsAArzf+u8eOEKF3TI+0/DsNgB8pVLaK0E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --qt3jjettk7ey6stj Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, May 11, 2024 at 11:51:18AM +0200, Thomas Wei=DFschuh wrote: > Hi Kees, >=20 > On 2024-05-08 10:11:35+0000, Kees Cook wrote: > > On Wed, Apr 24, 2024 at 08:12:34PM -0700, Jakub Kicinski wrote: > > > On Tue, 23 Apr 2024 09:54:35 +0200 Thomas Wei=DFschuh wrote: > > > > The series was split from my larger series sysctl-const series [0]. > > > > It only focusses on the proc_handlers but is an important step to be > > > > able to move all static definitions of ctl_table into .rodata. > > >=20 > > > Split this per subsystem, please. > >=20 > > I've done a few painful API transitions before, and I don't think the > > complexity of these changes needs a per-subsystem constification pass. I > > think this series is the right approach, but that patch 11 will need > > coordination with Linus. We regularly do system-wide prototype changes > > like this right at the end of the merge window before -rc1 comes out. >=20 > That sounds good. >=20 > > The requirements are pretty simple: it needs to be a obvious changes > > (this certainly is) and as close to 100% mechanical as possible. I think > > patch 11 easily qualifies. Linus should be able to run the same Coccine= lle > > script and get nearly the same results, etc. And all the other changes > > need to have landed. This change also has no "silent failure" condition= s: > > anything mismatched will immediately stand out. >=20 > Unfortunately coccinelle alone is not sufficient, as some helpers with > different prototypes are called by handlers and themselves are calling > handler and therefore need to change in the same commit. > But if I add a diff for those on top of the coccinelle script to the > changelog it should be obvious. Judging by Kees' comment on "100% mechanical", it might be better just having the diff and have Linus apply than rather than two step process? Have not these types of PRs, so am interested in what folks think. >=20 > > So, have patches 1-10 go via their respective subsystems, and once all > > of those are in Linus's tree, send patch 11 as a stand-alone PR. >=20 > Ack, I'll do that with the cover letter information requested by Joel. >=20 > > (From patch 11, it looks like the seccomp read/write function changes > > could be split out? I'll do that now...) >=20 > Thanks! >=20 > Thomas --=20 Joel Granados --qt3jjettk7ey6stj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEErkcJVyXmMSXOyyeQupfNUreWQU8FAmZBGVgACgkQupfNUreW QU9Dtgv8D/HdnyHHjf9EvZYIA7HnMu2U/9l/w1ouqfAMmi7HS4Y98dZVBP5X3MEe 5neOWNwlQN6rncGIhaLJE+q0M7KL52ej3pWS72olJGcJamFdahPGRN444v49FvCk bCwjbHxOysmwpLAF+XsnYlOGOJ5K0n9eDONYPI2Zg+ehDHMMGyAPx6P+d7rqJzOF WUgIsUGC75GVbawyHRi25emp4svTsNh+cnsG6Fsh8LY0u8ixH1q58bUxOq5Qu8IG aI6TCHU/1z0iFEBV1PAF/NsFx/GHFaJ2v01TDNwEX1J4vOWE8wopJaYDVudy8MGg z8fMq6vlMSQnY3EkN6LKkFUJyS7vnRhowXaWBrY1DoB0zKLziXHhCpWU7JzN4U4N guxBPD1pT8LhIPGBC5wRfKO9LLe8jNKwn7ugcLdCCxzygdPjWizk0M8QVxRnhGKO unK/FP5KS6yFMxT9sppN6halqDwjuwon9WU7vbuINgn2VhTSM7u9/kUzcuq3N/Cu Qk1K0rUf =w318 -----END PGP SIGNATURE----- --qt3jjettk7ey6stj--