From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B43A0C25B4F for ; Sun, 12 May 2024 18:00:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 473956B01A8; Sun, 12 May 2024 14:00:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 425526B01A9; Sun, 12 May 2024 14:00:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2EBFC6B01AA; Sun, 12 May 2024 14:00:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 040976B01A8 for ; Sun, 12 May 2024 14:00:56 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A88C1A168C for ; Sun, 12 May 2024 18:00:56 +0000 (UTC) X-FDA: 82110509712.18.12247D4 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf02.hostedemail.com (Postfix) with ESMTP id 9D2BE80012 for ; Sun, 12 May 2024 18:00:54 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=EFvWblmk; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715536855; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HsqB03Ajp9M3KmogwiK0TlRh6LR6IH5H1KeL3RhckoI=; b=gEykmKvqotv2rc6uzahwmBMOz8xJauYmOdhWNuEIymv5RAhwgVdccZ6ThGA52JXbZ0gnA5 oio0sw3csuspx8IbPTPgdOlzmezK1ZfI7meQeqjkmiIS+tkhEvYUqKngy19UNT2+MUfrbh QH0rWju7rkCYZVOYnB2XgJcCHB9ZF44= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715536855; a=rsa-sha256; cv=none; b=gApC74qtl89Whaf5gD7wGiilXnyBmUPy87zTO2y+TgP4vkGBHZjYsS90OeoiQv5AivA/jm Uk4z44/WgavWx28Cps6N3uXcoa/ZmYYzlZymwVKAj4ib5STsVVItH/EjaWiN4cMQahWg/g lGTmicOX0JJAt4tEfgH0k8F376NW2Gc= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=EFvWblmk; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 2E4B2CE0A57; Sun, 12 May 2024 18:00:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 546D0C116B1; Sun, 12 May 2024 18:00:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715536850; bh=qpiFUol8P0zNhvUFVoN6iW1e1aeFqNHpooxXO9xEl04=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EFvWblmkErJHGxYytEKfxEysBzLmbIM1r9/FpIWdKSUtJmY/U2D408Fqajysf+2wy 1OEGeICXddpUU7816eua76jSCGLa3khOL4jBE5/hV2RHLXU4IyqDGvxmlkTDMHdYJJ dJu6exgqHN0EpZKLZ08wO/hmB9yhwJFNnAjGCrRMnnNByWIBs9TPWR2W1Un6aJdRSO v3gh9cJoOeUO1XTGtlrZa5ZZEvzjZISkE64pDrJfRwseEA6JBmMmPNv9w5J51KMFPb lIDka2y6oiq2EFiW8BPHmL+BegmoiZ+kByDB5JQiFD67l1COYYV1BGb7WCna3hUfgW hsTuaOIzCGm6A== From: SeongJae Park To: SeongJae Park Cc: Honggyu Kim , damon@lists.linux.dev, linux-mm@kvack.org, akpm@linux-foundation.org, apopple@nvidia.com, baolin.wang@linux.alibaba.com, dave.jiang@intel.com, hyeongtak.ji@sk.com, kernel_team@skhynix.com, linmiaohe@huawei.com, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, mathieu.desnoyers@efficios.com, mhiramat@kernel.org, rakie.kim@sk.com, rostedt@goodmis.org, surenb@google.com, yangx.jy@fujitsu.com, ying.huang@intel.com, ziy@nvidia.com, 42.hyeyoo@gmail.com, art.jeongseob@gmail.com Subject: Re: [RFC PATCH v3 1/7] mm/damon/paddr: refactor DAMOS_PAGEOUT with migration_mode Date: Sun, 12 May 2024 11:00:44 -0700 Message-Id: <20240512180044.76086-1-sj@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240511201617.292811-1-sj@kernel.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: nd6w6xagcn43fghi6i1m9eej31afypx7 X-Rspamd-Queue-Id: 9D2BE80012 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1715536854-6474 X-HE-Meta: U2FsdGVkX19pur1ts/jo6mrZEdSkHI4EBOLV8as87RyK5y8W2LjxvUqpUVIayAkG5jwCTeWbrtqoVnJ72FU9/JzKMvct/sW/ml+njJlqB2PoFsDYdh+aVAuNj+3Eo5+/P0qxfz8Z89khqBGiiK4NCFUx6+J9IHqyG0rhb/aNJgXptp+oOJnCkq1tl7nvM0tHoNjsFTnXjdNGfJCVGoNjEOHdhE4DK4EV85iHM0aFE+OTHj/kTifS243rXLHdRaYVcoOuq97yH/30tb7/HVvvggbgygVbaWmSSO6dhJbI/lot0eGWTGsoaRHgVAOpschiSCfZJms2vTJi46HpA75Gd2zeNga6UsTRMw1Qvqampqjxwo06eDlw5NCRklB8lkRrEowgRo43Ox0fLVjvbp1+GwAuyrt6tSDv+y6L6qLfTrbLKDdrIVPCcrWdIxpLrNKEqmyR3GGSX+qWj7C+fWxeYv631l5mvuTPw7Swt3pJmMeiatNm6aXsnZ6CqRAR1UDGHr+7NqPifvgGXQ/Sjm72XOmOOTGaB9VS9JwQ/ocFduWtWz5EqPMNTJAxwobeAtUPXWEa0eCc2lms9JBIRSfG00GcN/ORDFv5qGeoVY87lOljjJhbayMVQ2CGZrxky03ZZdN144McnpAlUqcgAeh19SdsSv6r96FnVpVflMUFC+/OjavmHI48Kd0kiZdgUXFVn+frUdW3RZxMASLHHcvW/Fy0QIFR6INml15Hv1qB+bXzeM/ECJZ9NgDC6+CAWI9r1tOHY8qpuzkvoNFx9ZBBk748kyyuEoibN0KXzlYQEqS+vglENfs8FtryJVQdjDKIALtZO9eoj2C2wGdiEHRbTLUVtrt8d5wpPLAtsFqEomeUOMRjHuG4vxGMjYzdEFBXRpbqdGyMdPJr5wwhWmNINrT+/G8cUHCTqMVHOhdlcxz3CidYref4v764aYv3gEnnfheL40T0uRtL3xtqqY1 VgRh0/Gp QLwGWLA6oD0Wuvu44f1oKnLEjl0F28fdR7PiKoxILqeQ8DNlcriBop2nHlnHUHcLL6aFyNvFPHCk4yltIXu0CB85rLtz+582cTqx1RIfgTR9CK0exoxQL7CqQLJcx+WEWGRLHHampezi3VWYPiyn8nADtHOjCRusjbFbgvirv6q7LpYp/pmzFFVNlepd1LU/VeYFfJjHdKDeAx/OES0Ubr6r3bslBevr4cItGnbkkimaQj1h3wewU89CGJ2mzYF/0vWIeQqFn0Fm6ktIWrmsBOnCYB6xzvv8SwACjqWfG5/1vVymxzmetNBaq9OFxFHQdXso7Z28dfgY5M1SXs7V1yLCvogOwRtih9l0yaDuEqIqm6YEkF2nIumj0/MPel15EJCsdTqjg4ELFnuVE7NIt0nklL6sKhUFQXCUH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 11 May 2024 13:16:17 -0700 SeongJae Park wrote: > On Fri, 5 Apr 2024 12:19:07 -0700 SeongJae Park wrote: > > > On Fri, 5 Apr 2024 15:08:50 +0900 Honggyu Kim wrote: > > > > > This is a preparation patch that introduces migration modes. > > > > > > The damon_pa_pageout is renamed to damon_pa_migrate and it receives an > > > extra argument for migration_mode. > > > > I personally think keeping damon_pa_pageout() as is and adding a new function > > (damon_pa_migrate()) with some duplicated code is also ok, but this approach > > also looks fine to me. So I have no strong opinion here, but just letting you > > know I would have no objection at both approaches. > > Meanwhile, we added one more logic in damon_pa_pageout() for doing page > idleness double check on its own[1]. It makes reusing damon_pa_pageout() for > multiple reason a bit complex. I think the complexity added a problem in this > patch that I also missed before due to the complexity. Show below comment in > line. Hence now I think it would be better to do the suggested way. > > If we use the approach, this patch is no more necessary, and therefore can be > dropped. > > [1] https://lore.kernel.org/20240426195247.100306-1-sj@kernel.org I updated this patchset to address comments on this thread, and posted it as RFC patchset v4 on behalf of Honggyu under his approval: https://lore.kernel.org/20240512175447.75943-1-sj@kernel.org Thanks, SJ [...]