From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17B52C04FFE for ; Sat, 11 May 2024 20:16:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D1026B017A; Sat, 11 May 2024 16:16:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 181E26B017B; Sat, 11 May 2024 16:16:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 048E06B017C; Sat, 11 May 2024 16:16:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DCAE96B017A for ; Sat, 11 May 2024 16:16:29 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0DD8C8022D for ; Sat, 11 May 2024 20:16:29 +0000 (UTC) X-FDA: 82107222498.16.3752666 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf10.hostedemail.com (Postfix) with ESMTP id B60A4C000A for ; Sat, 11 May 2024 20:16:26 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=hO8RqGiS; spf=pass (imf10.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715458587; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=I9w/mYo4w0N+ZzeOubTou4HUQdGqUU2zQROhtoN5118=; b=UJF7IasEUCRvnJY/nf+p9jjVN/uMYXkTP8iGTZ6gXHOr3bG0+wZw+tPNOC+rkK7h+z1oYs TZWne+yS7/uoFlAW4fV3Rh8xpPxC7X6hfHqg2Bhg6krWhIRR20h/GGkJbCqQpLwqNiNVN+ ul0xpFUKrVVSxbWaIXp4410dwdhQM+0= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=hO8RqGiS; spf=pass (imf10.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715458587; a=rsa-sha256; cv=none; b=gNZSmOWMO0PSUkNtdjlKGdamumCqCBycU3GXbDNi8ge4CZUHOhu9itJVLCR0qi6K9fCxZ+ SlkcAJApDmwh3e9ZO4WsNsaJAQyc0b+R6rjTRNWc/TFeewxho3fuz9Oax1/YpaDirpKfP3 jWzoWaVPP6oZ5EJNYjAT5otg0tF1pb0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 5E9E7CE09AF; Sat, 11 May 2024 20:16:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F0B66C2BBFC; Sat, 11 May 2024 20:16:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715458582; bh=+LpkdgC+Wz7IOQEvnu/ilSBedx9vD5FOuP4V+JSN3Ys=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hO8RqGiSiGIdbzIQNIjJaqd4zgy6EslWUiMHUweZkfie3pxeLyxEAbjda0l+zUC6o Y58knSk9QRMq1/ZpO5GNaHVu59Vk9UxEQO6pXmTE2CMF5VBcB27rPgKPVZJVf0ivSO nLZ8PHLf5xzaW3JshPYmUELWfhUi91dKzMHj5XQL3TZ8qjL7YXziEI3qwHQGKQoWED kWraXXxWAX4Qrwcpkd/tZESwllbjt2dPY/NeBsJ82iBUc7OAlyUxMhdQUz0OBUERxV UIpw/+wgG3IzoRjtgFoANMcgM81urgQNdnz1E1ZaoeTi5xgftjJOf17eEW2JPSUjU4 1nB2HyEV7YBew== From: SeongJae Park To: SeongJae Park Cc: Honggyu Kim , damon@lists.linux.dev, linux-mm@kvack.org, akpm@linux-foundation.org, apopple@nvidia.com, baolin.wang@linux.alibaba.com, dave.jiang@intel.com, hyeongtak.ji@sk.com, kernel_team@skhynix.com, linmiaohe@huawei.com, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, mathieu.desnoyers@efficios.com, mhiramat@kernel.org, rakie.kim@sk.com, rostedt@goodmis.org, surenb@google.com, yangx.jy@fujitsu.com, ying.huang@intel.com, ziy@nvidia.com, 42.hyeyoo@gmail.com, art.jeongseob@gmail.com Subject: Re: [RFC PATCH v3 1/7] mm/damon/paddr: refactor DAMOS_PAGEOUT with migration_mode Date: Sat, 11 May 2024 13:16:17 -0700 Message-Id: <20240511201617.292811-1-sj@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240405191907.66958-1-sj@kernel.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: he9jngi6d7837c7knr5ygjsqpb7q7iiy X-Rspamd-Queue-Id: B60A4C000A X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1715458586-61368 X-HE-Meta: U2FsdGVkX1++XI6yZhV93YR0x31j9RUeWZSIUD93nT8uwYNFT0SjmETtPtex2N+fxbra6tDYlwGiDgfaU20q6CTcO8y08sJCCssPckoyHWYYBn9X/DDOvRNQ8z85dOxyhsXeCxieB4QBU51Y7dxBwAdgFFbdbfJ3BNlUTQ60xaH5aG9NoZLAL117DAV4YGT5agnEYKMY27FYxfy0mZomcXig9ZB3kxdmu+YmekO6sAi3UIkgItbkRiHxGVqAZbUc8q1l4GT+Va/IgxTtpl97Aj2oD8R3sbF8rLbCoCXoEOe6K7czhl00HvsDvWOfdi1+YndrP0fxheRoySfJzwhefJJBsEmVkPNtcudbXqnR/Wg3FlpnnACD0B2FrgSfA6PoS24KaaExl0rZzAImYrjlSk1Y2HAK8bztDziOG8JOVTs+V+W/ul9N16IT3KMnEB/l7q3dqiXz+LX9BWEtS6QLktpZwrMgZwIYUVxXGv8FLKGlZ2spjhu5rtBFHGUl5Q1IkePqdWcg04Cwoc91R+lw6BRICOn4CwE1tX41XUO/LyZERluGeCohI9OQDd7SGsQ2EB9PW7dNJomMQll72lrjsHAE3QdRL3t3zEo9Cou6TQG6CPQA2figQDLkTf87M+N+bQDN6lLaNvdSI97z6xfTLkabZx0EFRv+ynfKUMdM7g4kCv6VVKYZxW5vikj8xaQo8TDW0t0zluEknZdxrbjGIr+7mmrRKu773BP9O6aqExPbaxf0kH5j8Q9ry4GoMK9uZsykMTGG9NYlkcg2CCI12stvxp47I5ml/VGyMXYt+trXJPoSeJlWDEcN8FulYNbklPkkUQbICBhfe978Idmp1Yhe1a9c91x0xAscI2l8BG0Klh625dyOT/8vgbbQhj2DkmyamXh7TEfgckq8zKzcxVVdWhJo6mmiKmruTRGXUXmRSSDBvGqg+5R8XsRVO0MCAI57TdYgSTeQv/E1Pgi 0YVx8T8L lsnmz7CGPzoZJ6iCDnWGka9tmg8FE11kKNagY32/9hEWaKqEY4walWF6l5anFYV9BK9eO/aYcGnDzhH4U103+jfzoDy6HyzL0kSlaqfTKDhxk2tGEvVQjKRwe7hzoO2cM7s4UQpbwLKU8SkAGf3EsoLHfp2S2ysIVjWUtXr7feC08Dr49NvpV1QAjnZiLkVFlGz2J78b+UEnFeuFznr2tKJb0/ytlqt2E9qvatYY1afWvRVm4LFs2Atsktcjr+S18z6c0OJKl13IHvVzf429wjlqwr/1UapCeGYmi69yS3KIJx1xJpZ+ateKx2Bo1K5GHy7fucDaSOaDAkkr5qkBvfZR8t4fgnE30DgNJ5KcgymTB/1T2Fj7UOtU72y3FJIAHBmZeZsoZRDufU/dTC5yGtDHLabn3bzZ/qOjZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 5 Apr 2024 12:19:07 -0700 SeongJae Park wrote: > On Fri, 5 Apr 2024 15:08:50 +0900 Honggyu Kim wrote: > > > This is a preparation patch that introduces migration modes. > > > > The damon_pa_pageout is renamed to damon_pa_migrate and it receives an > > extra argument for migration_mode. > > I personally think keeping damon_pa_pageout() as is and adding a new function > (damon_pa_migrate()) with some duplicated code is also ok, but this approach > also looks fine to me. So I have no strong opinion here, but just letting you > know I would have no objection at both approaches. Meanwhile, we added one more logic in damon_pa_pageout() for doing page idleness double check on its own[1]. It makes reusing damon_pa_pageout() for multiple reason a bit complex. I think the complexity added a problem in this patch that I also missed before due to the complexity. Show below comment in line. Hence now I think it would be better to do the suggested way. If we use the approach, this patch is no more necessary, and therefore can be dropped. [1] https://lore.kernel.org/20240426195247.100306-1-sj@kernel.org Thanks, SJ [...] > > > > > No functional changes applied. > > > > Signed-off-by: Honggyu Kim > > --- > > mm/damon/paddr.c | 18 +++++++++++++++--- > > 1 file changed, 15 insertions(+), 3 deletions(-) > > > > diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c > > index 081e2a325778..277a1c4d833c 100644 > > --- a/mm/damon/paddr.c > > +++ b/mm/damon/paddr.c > > @@ -224,7 +224,12 @@ static bool damos_pa_filter_out(struct damos *scheme, struct folio *folio) > > return false; > > } > > > > -static unsigned long damon_pa_pageout(struct damon_region *r, struct damos *s) > > +enum migration_mode { > > + MIG_PAGEOUT, > > +}; > > To avoid name conflicts, what about renaming to 'damos_migration_mode' and > 'DAMOS_MIG_PAGEOUT'? > > > + > > +static unsigned long damon_pa_migrate(struct damon_region *r, struct damos *s, > > + enum migration_mode mm) > > My poor brain has a bit confused with the name. What about calling it 'mode'? > > > { > > unsigned long addr, applied; > > LIST_HEAD(folio_list); > > @@ -249,7 +254,14 @@ static unsigned long damon_pa_pageout(struct damon_region *r, struct damos *s) Before this line, damon_pa_pageout() calls folio_clear_referenced() and folio_test_clear_young() for the folio, because this is pageout code. Changed function, damon_pa_migrate() is not only for cold pages but general migrations. Hence it should also be handled based on the migration mode, but not handled. I think this problem came from the increased complexity of this function. Hence I think it is better to keep damon_pa_pageout() as is and adding a new function for migration. Thanks, SJ [...]