From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FE3CC04FFE for ; Sat, 11 May 2024 06:41:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B0AA6B0160; Sat, 11 May 2024 02:41:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 760DE6B0161; Sat, 11 May 2024 02:41:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 64F976B0162; Sat, 11 May 2024 02:41:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4879C6B0160 for ; Sat, 11 May 2024 02:41:07 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E6C871418FF for ; Sat, 11 May 2024 06:41:06 +0000 (UTC) X-FDA: 82105167732.09.C28F152 Received: from mxhk.zte.com.cn (mxhk.zte.com.cn [63.216.63.40]) by imf13.hostedemail.com (Postfix) with ESMTP id 7526F20014 for ; Sat, 11 May 2024 06:41:04 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=zte.com.cn; spf=pass (imf13.hostedemail.com: domain of xu.xin16@zte.com.cn designates 63.216.63.40 as permitted sender) smtp.mailfrom=xu.xin16@zte.com.cn ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715409665; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references; bh=gmnqGDOaAioOskbzA3SdNMcLCrcuhypuI2vVQgxyCck=; b=yYoiIkfY9XT52CEPUuPw+BbAAo18n2RAWXyx3Dyt5rfJzzeSNHITsOIlpIOBiAUhyCzQzk xzg/fMmsPXFWPPVrMFRr4T5dVgafhUii5pv6jbo0QkvqMex/CLMx2+jHTcf7u0/axq+tPq 8HkDsDYAuVtNkCojylhS+/75/Nr3Iow= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=zte.com.cn; spf=pass (imf13.hostedemail.com: domain of xu.xin16@zte.com.cn designates 63.216.63.40 as permitted sender) smtp.mailfrom=xu.xin16@zte.com.cn ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715409665; a=rsa-sha256; cv=none; b=1JjwdAABrpRiJvhl5L49sAsOrJ9JxRD5Lw73D4Bnl3pRsgnU0JOO2ZncVi49oc0i0lywbS MV5DQir2z6ri8NAphyRsMDAexjwg141vP0rMo25pbYjw8hfE+jN0EKNl6eGrIbHZujhlfs QJQQQVVdwF1/zuRXWfFVu5QBOdWbcII= Received: from mse-fl1.zte.com.cn (unknown [10.5.228.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxhk.zte.com.cn (FangMail) with ESMTPS id 4Vbx3C6SXsz8XrX5; Sat, 11 May 2024 14:40:55 +0800 (CST) Received: from xaxapp01.zte.com.cn ([10.88.99.176]) by mse-fl1.zte.com.cn with SMTP id 44B6ekuN054423; Sat, 11 May 2024 14:40:46 +0800 (+08) (envelope-from xu.xin16@zte.com.cn) Received: from mapi (xaxapp02[null]) by mapi (Zmail) with MAPI id mid32; Sat, 11 May 2024 14:40:48 +0800 (CST) Date: Sat, 11 May 2024 14:40:48 +0800 (CST) X-Zmail-TransId: 2afa663f12f0048-8630a X-Mailer: Zmail v1.0 Message-ID: <20240511144048767fdB7EqYoMHEw6A5b6FrXM@zte.com.cn> Mime-Version: 1.0 From: To: Cc: , , , , Subject: =?UTF-8?B?wqBbUEFUQ0ggbGludXgtbmV4dF0gbW0vaHVnZV9tZW1vcnk6IHJlbW92ZSByZWR1bmRhbnQgbG9ja2luZyB3aGVuIHBhcnNpbmfCoFRIUCBzeXNmcyBpbnB1dA==?= Content-Type: text/plain; charset="UTF-8" X-MAIL:mse-fl1.zte.com.cn 44B6ekuN054423 X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 663F12F7.000/4Vbx3C6SXsz8XrX5 X-Stat-Signature: k78sk6f5de5rudbkcmfypm8ysahp7ap1 X-Rspamd-Queue-Id: 7526F20014 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1715409664-979817 X-HE-Meta: U2FsdGVkX18fimYH2L7fIoiHQlrLEovpGOEjtRALZpvrzhsgqlq5b5Wc1UqFt9dvu+hZtt+Q4riUvEyk/+v/sCgCPZp9n/j6tOV0pOO9Ik8JhR+EHk2ChfIcFZUNkyc9ZJvJ19fcGTtvLJxuGsImWO0OSswOSdLCaj5otLVnNd9MQ7nyZjz878jaFp5ZggCgAcdEXyh+3lo7yBxqZWNsiqV3SesinO9cwX7IW/kexOX8REeq2yC7tpUkxewtq3RI2KexiWpIjlrdPBTEfGoMTKlfBUdVNsDWInqAgYeUWu+N05RWVhq2bQpvydqXiZQv9frst6BDvKNH3LiZlA1Xot+P4dgbp+JmTb1HYUbsoz5mDQyfqbeciQEWL9Ej/79foxAy14+c4tO9wWyljraRxpcKpKFqUSe7ipOnzm2xbQcuaFtWqNdKl6S8h8KUnTBeMuG96a09XWNSdhL1Wp9L5ncLPw65fhdr+spNgPa4JU2CkDsBwoZd4SgulFQRnNWbMRtcrXDcZ8zerdWvU6dLfDEgjAwV2e5hcbBzjY12sWtmSk9S7wd5UDO3msNIZa5F4Yik2DmmVnsMI25Qk0Yzrdybl0pdNkPAKAa5myDYbEBnn8BsiJKFrJ8kdJyx/QLufz8y0lSz/uQJx0L5Z4c/cbfe0Ix6+9Zj2+BQ1lQnWmtyCrk7XElOQX8Dzod37XTU9UMP1OgNeBNi3vLbOtajv4Ko3aECgL8R+KoWfvy9/XWD5Gorr22Hrk4JxvqkzVzEMmk+PLH1WGxzlWJyNr8rcMDjO10k8Rp47G9UsVGDv0+OknRMeeISkS/7ddIkI56ShtdOeQ+0hLCVDcu+etR4qZfembHSsFU6C5p0CHcRV+E2CoeZXMDSNx1R8TaEMHwwvb19VFD8iEaNSRvCYOmHD6t4d0xZBv46ST94iLM5GDqFzzUpq7nMwx7mJuiBS0Qo2lPAeDNZ8CwkP4R6t0V NtwI/weM typ8LuUnafI4Vvp0mUxXlGy8OQ3cykvvmNb4UD2+lESLff5vbObP4iWJUwpqx/0lmAixwUwQWYUA3ozlB27zc84d0rHhCn/hGvQQZ/WNA/oCttS0YdEEkK4MSKXWm8qpjOR/5Rha5XPmAIwe8z3XfUyO1vTxRi7ndFS6lL1zI1bb68AAxnV9Grup7rsRVQZ/c6KkJoH0wiRiDgn9jvE6XU0H4FA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Ran Xiaokai Since sysfs_streq() only performs a simple memory comparison operation and will not introduce any sleepable operation, So there is no need to drop the lock when parsing input. Remove redundant lock and unlock operations to make code cleaner. Signed-off-by: Ran Xiaokai --- mm/huge_memory.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 89f58c7603b2..87123a87cb21 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -478,32 +478,26 @@ static ssize_t thpsize_enabled_store(struct kobject *kobj, int order = to_thpsize(kobj)->order; ssize_t ret = count; + spin_lock(&huge_anon_orders_lock); if (sysfs_streq(buf, "always")) { - spin_lock(&huge_anon_orders_lock); clear_bit(order, &huge_anon_orders_inherit); clear_bit(order, &huge_anon_orders_madvise); set_bit(order, &huge_anon_orders_always); - spin_unlock(&huge_anon_orders_lock); } else if (sysfs_streq(buf, "inherit")) { - spin_lock(&huge_anon_orders_lock); clear_bit(order, &huge_anon_orders_always); clear_bit(order, &huge_anon_orders_madvise); set_bit(order, &huge_anon_orders_inherit); - spin_unlock(&huge_anon_orders_lock); } else if (sysfs_streq(buf, "madvise")) { - spin_lock(&huge_anon_orders_lock); clear_bit(order, &huge_anon_orders_always); clear_bit(order, &huge_anon_orders_inherit); set_bit(order, &huge_anon_orders_madvise); - spin_unlock(&huge_anon_orders_lock); } else if (sysfs_streq(buf, "never")) { - spin_lock(&huge_anon_orders_lock); clear_bit(order, &huge_anon_orders_always); clear_bit(order, &huge_anon_orders_inherit); clear_bit(order, &huge_anon_orders_madvise); - spin_unlock(&huge_anon_orders_lock); } else ret = -EINVAL; + spin_unlock(&huge_anon_orders_lock); return ret; } -- 2.15.2