From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CACAC04FFE for ; Sat, 11 May 2024 21:35:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BFA326B017C; Sat, 11 May 2024 17:35:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BAA166B017D; Sat, 11 May 2024 17:35:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A98436B017E; Sat, 11 May 2024 17:35:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8C9816B017C for ; Sat, 11 May 2024 17:35:13 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D5F70407C5 for ; Sat, 11 May 2024 21:35:12 +0000 (UTC) X-FDA: 82107420864.24.844C2A6 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf02.hostedemail.com (Postfix) with ESMTP id A936C8000B for ; Sat, 11 May 2024 21:35:10 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=A62a2Amv; dmarc=none; spf=pass (imf02.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715463311; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XWnME+21kGQDyCEwHOn18rDz+BMYmCe4aebzla+qSCs=; b=JDiivgnmT3ffuABDT3cA+w4MNc94ivjaqrFxWKtVH19I0hkupavxOtNGUXXHHmhdCWYO0Z qp9foM9krX9uIzUG8wpHuRPwA0Zwgzps5Cn2nCJYaYBR4gLq5EEGQs6GaGfRYBgAyhOf/A O3QsCNPM7rS01FoRRcOe3h3/NnTqfbI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715463311; a=rsa-sha256; cv=none; b=pGTmFr/yobDDzBLZNm8qxYcHcdDN6V87kZrLqUO1EWYzxmTMsReqxLOIz6qwRujOSAbq4w O6AKonDeirf5zHzLNTE7E8iajV/rX2Xmqj0A/4fGbDWut4t8Wo86AgkGT31atQs4mduNE9 7hICTZKGjF+YppB7U+KH6KUuin5yAOk= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=A62a2Amv; dmarc=none; spf=pass (imf02.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id DF30ECE01F4; Sat, 11 May 2024 21:35:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6AC5C2BBFC; Sat, 11 May 2024 21:35:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1715463305; bh=Iz0IsilQgAUTOh74JHraqA/FaEfyfAHJHaHVkWdmv6E=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=A62a2AmvYG15WDk2Lh//NQ4i+S40/qUftxIqT4CKnFH7psUMnM+GvhvZuwfWrvuDF d/qWM59+WzB7P5hkG2oatBCKCudQ65xE4aGZYSjOULDlvZpC9+w27+m2wB8SPzhbdr vF26xZJx0B0d48BRi78l6//CdGlpwxBznJshYEMA= Date: Sat, 11 May 2024 14:35:04 -0700 From: Andrew Morton To: Matthew Wilcox Cc: xu.xin16@zte.com.cn, david@redhat.com, shy828301@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Muchun Song Subject: Re: =?ISO-8859-1?Q?=A0[PATCH?= linux-next] mm/huge_memory: remove redundant locking when =?ISO-8859-1?Q?parsing=A0THP?= sysfs input Message-Id: <20240511143504.2d5dae49d4c76e6608b7cc93@linux-foundation.org> In-Reply-To: References: <20240511144048767fdB7EqYoMHEw6A5b6FrXM@zte.com.cn> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: a7zyrty4ox8om9cohh6ukn6zszr46zz7 X-Rspamd-Queue-Id: A936C8000B X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1715463310-720208 X-HE-Meta: U2FsdGVkX18hhx3QIjXAoed7J0ZKQlM7Uac3Rva8kHX7LYLnGPV155QwLL9i/JvIin4kVieqH5kugtzdjsSlHP0EfMMUbvC2S053bQkfJE4aTBKmiFlxzhAcpuRdDq7bPQmZlbam7eRgls7E0YGlivckZ/uysCYzTlMrNCBfA4AO7NZAq4fgWh8KPkAsF661PV/59y+JVfKthnsbVeg/7nHSLQ62D0ZzmJfqXNpXQl1+4V6KsZt7YxKB1KQpY3bQXEfRTyv9YjnvrVqJvNPgsRiXQJ2ZoQZMkAL76Wv7+Nv1GTYMLa4ndrTGl8fuM6irWv2sZHhLglP2psoyU+ri9LBHYdpp8I0ugkeUZagH2aKpnhUpOnZvoJ+MGI8gHKRx4QfaQk2uKBlKD1tfd9VwALbxlFz2BxIGb2RSJuiGtRpyZFpmVgwqtKDXJEVou03tAuESdKvcBt9gFPGC7XAUUi/dC6oEYUJz1AsoJ2Tldd0rtU2lw85d9tGwK9zS+gkKCYqT8206Z3JVBhz0Z37U50picwdINbvB7gctmqDXy6lHpVtyWT5v40qc69JEQO4NjjmyFdj7AkMqt0kYRR2qXlbtmGIoC4j6XaoDn4UwGnDfLWxptGqt6fWGYQJ7W4wlM/mkD6HzqHQ1LY9sgh68uNKMKqdUry4ckYfwM1SqsBdUZmhPpLmmpil05rox0GG5tNxAkNNJt6vMB0fFmKAeAVqU4OLSwBX4TjCYla7gLfjsnlBCplepO8TNQZPYZf68WQ3p8BWyJpKlglBQu/11vQGWGMX5RLBHPpvfJf5l21JxN4V6jl6bYvLPZnJHB5c4fWJpPmfBY8pLKlYcNtO2A8fyhIYYMFkmCZn6l7Qbwk3c3fKiJZXIzlpXHvgfRTfmmVr0iM+pAC9KEuQmTm/hT8QZFzl9qubKnBZOU5zvACF56uW0UOZRU6hpgfuiHate7jgJsi8KSBe9/vzv0jA y1ol8llb /JIQ6a6Sh8qzJXKBNZBouvTBny2F6mMK21/iYcPUhd5iEeCJWjPAidMmkV+993OC/mZyRg+Tv9EV/74cTSdAa1sH4wMUxlCtqlQy3WLQz7xt0HVh4acWSNm1BD2X/9NCiRdxUry4ujkw3j4JlmpnDbK2Idk1wY3yjlHf5hVwT2QFBbytFJAgYEwfQ1+Ffm3aaBaZNTjpiOBEvIZ3F8ekbkki5HMtnz/qzp4w7hAcoTn5cnzXNhEpx4pekSV9RQSZuN4BZuIn3v+qn+rHJnsGj9i24TDXM0dJbiY1Has8GXtaqOZx9Dros+e3ftJWWspGtDdbQIF9ELNmxJAd4wDkRvjMyFp0BTGtAkmw+Kk+IvEGRKqyC7gKsOoy2zlqfG2HxX5osLpztQpgAgMjLQWHWw9edjTUqZ9dhkTZQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: (cc Muchun) On Sat, 11 May 2024 17:05:13 +0100 Matthew Wilcox wrote: > On Sat, May 11, 2024 at 02:40:48PM +0800, xu.xin16@zte.com.cn wrote: > > From: Ran Xiaokai > > > > Since sysfs_streq() only performs a simple memory comparison operation > > and will not introduce any sleepable operation, So there is no > > need to drop the lock when parsing input. Remove redundant lock > > and unlock operations to make code cleaner. > > i disagree that it makes the code cleaner. Oh. Why is that? The end result looks nice to me and saves a bit of .text.