From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12BBAC25B74 for ; Fri, 10 May 2024 18:43:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9FD916B0118; Fri, 10 May 2024 14:42:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 986636B0119; Fri, 10 May 2024 14:42:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8271B6B011A; Fri, 10 May 2024 14:42:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 625E46B0118 for ; Fri, 10 May 2024 14:42:59 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DE040A0391 for ; Fri, 10 May 2024 18:42:58 +0000 (UTC) X-FDA: 82103358036.27.98A024F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf13.hostedemail.com (Postfix) with ESMTP id 3D2D720008 for ; Fri, 10 May 2024 18:42:57 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf13.hostedemail.com: domain of "SRS0=FI+p=MN=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=FI+p=MN=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715366577; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J3oWdN9YWIIW3kYVAROI1Ro46768bem/3Y4bbZGnkWM=; b=gMPtcU4fa65f6bIeG++A9phGOMYefHhjKlZ3RJgc+58HRI6wmNDy173//t2lEwlAkDq0/O s6jsXsEYMSgGxfB1n/xP3Kt6MxaoKYTHIHszwlrsZke0kQrdee0wHyqQP0AP9iURW8B9dy j9PloduiBIKcbWWqH0CwfvxDw2fUEYs= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf13.hostedemail.com: domain of "SRS0=FI+p=MN=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=FI+p=MN=goodmis.org=rostedt@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715366577; a=rsa-sha256; cv=none; b=Hx39SiRNBCx5TW1vkg54N3h5yExZgjtQ7vjBx9ZE7W4PX7mE0GYabzo9xiDlp7FocnLG61 hECz7T2C6aL1G/mgHw5Y9W+aUxIg84dMFLc9FQmUH9o8PZ9RssEVAZQrbnEr2l1SmxjK7d rS3OLI+ANGtMpqB3SyqAvN2t0vtFFbg= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 28F9C61F5F; Fri, 10 May 2024 18:42:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C08CC113CC; Fri, 10 May 2024 18:42:55 +0000 (UTC) Date: Fri, 10 May 2024 14:42:53 -0400 From: Steven Rostedt To: Vincent Donnefort Cc: David Hildenbrand , mhiramat@kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, mathieu.desnoyers@efficios.com, kernel-team@android.com, rdunlap@infradead.org, rppt@kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v22 2/5] ring-buffer: Introducing ring-buffer mapping functions Message-ID: <20240510144253.4b865a40@rorschach.local.home> In-Reply-To: References: <20240430111354.637356-1-vdonnefort@google.com> <20240430111354.637356-3-vdonnefort@google.com> <20240507223402.206d6ddc@rorschach.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: grdp75nzw1w9a9k5yq9ny3htj3shu49t X-Rspamd-Queue-Id: 3D2D720008 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1715366577-936573 X-HE-Meta: U2FsdGVkX19P1ukdrc7fM60+78BovcpWmVmo0lCFnKxb2AjFv0CVZ4zFtImqzVJSUyt+Y827eL3aWQZapHQ2kbhI1i6OYgw+A/2ghzKTBQPJ0yB9UzXHHcFo0Ip2xeKyrtvxLOh4ug0hSBZ3fNbjI/4TPpSgTFbHRSQfQh1Wx6MswxB1/ryVPAIRnVK2OLuXw1X8UcNvhI4ceY5ts0xXKAXmoXsLEgp8/ocR3lzG6HG5TdxBRSGPs1oF5s/2EMyY/gNM2+Qs6DYKtLv5Z/MEDXeV1NWgMVtPC1OjiLDN3O8CyZdjYrggsSGIUDd+hKXzCfG0zfADaV2r51znJlNByZm+QNto3fAN+3VKz07AwVQnTOELZU9gKL7+Y/ssX4YBq44UoprqNocrM7/NSfL21I95EFvGEC1jBZEgxvASE5KhkRaScMvjZBwDMBR3KC/jMBWf1YxDj+FaENHeQjYxZGqCoM08PZDC4hUDlh5JUy2Ug6lloIO75IqIb9Ik7gZPyPmUQ71HSKg0usG4aG55Q/AVK+aPCnr9N0aEMLfjJQQDA1fuXnNLSGh+FUBnq6uaF14DcpbyMSMMyfIMM7V8B4ebYYPVENBJg6V3hdEoCtaGM0iYP9O1HSOXzXoLikWB14YFKBnTAS7fbCAmKmo3lKNG165HdUQibTeg4pHImZklHIBwFfOFERvsZPUjRzFQ7v8sScQpFYTLntThAfnsneccfKfX1BeVeLqLLNEpGAJoB091HIRQhr34xklK67ZYW8y+8QDSFVgb3ftfl+Iz9I72DFbgMutNW1rHtMBSZ6TqKpz11rHWBKIcaL56RagFJDCZiC14i2Icedf/B+/sUQcOodD6QQOF3txWEfdrNMCXgArNe1NL0YWTWX/HblL0R5NwYm3Udt8yKFYZSw+o3As08kFOO7B4evSLNN2y5jY02lGpfrNPr4FDX1p+Rnh+zJxE1LWyqn7idTG1Znj 5rpXGnHh marCdzHMFSV6fmEzuVyfCYqTbmOFlK1y20sxRQyC/2TI4FIOudwLWviWbxW7eBssJKzhE8g9gGsJMo3A7b41yLEEEzZYF7hA+p7llecLqp/861N3lOWkRZNi3i2wQedCnnwLZCLagVwvUjN0QZ09DLy+6xwtTERIS/ocUGNv7Z0thlK88e+3U3fBtw7lrxfo/wD/anhxlg5Wh8sTAMwux/IRg+K1HS+/h3gjksAicNhuWyoNmoKZcDhS5wfdbg5KNJ6Nq31I9rKTlLwKzP6lmovABig== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 10 May 2024 12:03:12 +0100 Vincent Donnefort wrote: > > I'm not particularly happy about us calling vm_insert_pages with NULL > > pointers stored in pages. > > > > Should we instead do > > > > if (WARN_ON_ONCE(s >= nr_subbufs)) { > > err = -EINVAL; > > goto out; > > } > > > > ? > > I could also nr_pages = p in the event of s >= nr_subbufs... but that > really that shouldn't happen so let's return an error. I'm good with this. It should never happen anyway. -- Steve