From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66C26C25B79 for ; Thu, 9 May 2024 21:52:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E17A96B009A; Thu, 9 May 2024 17:52:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DC8336B009B; Thu, 9 May 2024 17:52:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C687C6B009D; Thu, 9 May 2024 17:52:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A674D6B009A for ; Thu, 9 May 2024 17:52:49 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 324A5A15C9 for ; Thu, 9 May 2024 21:52:49 +0000 (UTC) X-FDA: 82100207658.01.3B3204B Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf05.hostedemail.com (Postfix) with ESMTP id F2CB0100008 for ; Thu, 9 May 2024 21:52:46 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=fBXhR9tG; spf=pass (imf05.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715291567; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tpDh3EbGnG3/bwl8KzPdGOE+DAN1ew75iViGriFZC/g=; b=iWLMd876zxUpObpfoVldO2yBAYezn10ijwgagJ32U0L3MojSUnjdagWgMvBXazYT3vwaU/ DtbR2x/aS9XVVFfI4NHZGZJxWFo/RX+9TN0toPTNu3TeyguG5dTprdfFpoABHeQjhcfH9p A9OzC2/sL8lN4bi+l0A1sOY1IZqDtKU= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=fBXhR9tG; spf=pass (imf05.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715291567; a=rsa-sha256; cv=none; b=q++SmjvgLByNnEg34HDpMcAICxq0iy42kRJHUD06w6ppAwvw+LnTj1T+7Z91Yj4R+qSAMy 3OgNqzN5wJy8MCnuoZ6dMkijNJkMNKKqi0sKdcL7CUBJ+UOkLCaL8WfrVyQkuBEibosxHY DR4Rm/un0DJy6Ig76SXdOMRceQI/kWA= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 0289840E0192; Thu, 9 May 2024 21:52:44 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id TOba2Rxo919j; Thu, 9 May 2024 21:52:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1715291560; bh=tpDh3EbGnG3/bwl8KzPdGOE+DAN1ew75iViGriFZC/g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fBXhR9tGWcdOWe23rNttop//56eTyyDpeXNpJ4lSMVVQPLYUrBtpTfBVn7gGo/QWj zyvH325uv/DDZMSFrXD4Q9RP3gX6kAwFV8tRfZxNbGLyxJ7WgJ4aYKD6mXWj+e6Qnv I6i4UVZXvLmVN1pExwumnJMdf9SiZJHWCmrQ+2xVJzNBt88vHm2m3B3S+sAXQ6pbmv 5DSIrQWewjUb1nPUw1XgVc3FdErhFXT/hy3OFVKhZfdVU0oGIPs+e7p2IMgELyIz2I IIlxNcPJfuehKsogqTd5cLKphDvHoWpUsdScQtfqZZejGokQaiFQ88LR4xERD9bnZw qVLHWhNf3pz69YzJoMYo1dJBubzrzSdII69o1QJLbA/Y/1zgD5PK9OWZqfrlPG2lVZ tabluFfN+2Bm/BvKRVyrCmCEyk03K/SRxsP71Co0U81msPhvVQv1KOR3WDvat7iz4K 8b08YGKo3HQQpH6gYWyqAFfudXshulv3DBQWFZna12k20MoR3lKsIDjlaNa9KzQb+U +ieZ5wwKXM2+GWcl3sAXbdapZSHeOFARb5t9AvptZu6nY9n8Zu96CXgktCMGwPxxXZ srf+BGCDDp/r6NqBQfaQh+g8XANaQw7sfMuLHaaERkbx59uPzCgafGKrZVuRz2nfVd eQ5btGVipzvCBQ3nTI/JzKKU= Received: from zn.tnic (pd953020b.dip0.t-ipconnect.de [217.83.2.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id E5EB940E0249; Thu, 9 May 2024 21:51:53 +0000 (UTC) Date: Thu, 9 May 2024 23:51:47 +0200 From: Borislav Petkov To: Dan Williams Cc: Jonathan Cameron , Shiju Jose , "linux-cxl@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-mm@kvack.org" , "dave@stgolabs.net" , "dave.jiang@intel.com" , "alison.schofield@intel.com" , "vishal.l.verma@intel.com" , "ira.weiny@intel.com" , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "david@redhat.com" , "Vilas.Sridharan@amd.com" , "leo.duran@amd.com" , "Yazen.Ghannam@amd.com" , "rientjes@google.com" , "jiaqiyan@google.com" , "tony.luck@intel.com" , "Jon.Grimm@amd.com" , "dave.hansen@linux.intel.com" , "rafael@kernel.org" , "lenb@kernel.org" , "naoya.horiguchi@nec.com" , "james.morse@arm.com" , "jthoughton@google.com" , "somasundaram.a@hpe.com" , "erdemaktas@google.com" , "pgonda@google.com" , "duenwen@google.com" , "mike.malvestuto@intel.com" , "gthelen@google.com" , "wschwartz@amperecomputing.com" , "dferguson@amperecomputing.com" , "wbs@os.amperecomputing.com" , "nifan.cxl@gmail.com" , tanxiaofei , "Zengtao (B)" , "kangkang.shen@futurewei.com" , wanghuiqiang , Linuxarm , Greg Kroah-Hartman , Jean Delvare , Guenter Roeck , Dmitry Torokhov Subject: Re: [RFC PATCH v8 01/10] ras: scrub: Add scrub subsystem Message-ID: <20240509215147.GBZj1Fc06Ieg8EQfnR@fat_crate.local> References: <63fdbe26b51f4b7c859bfb30287c8673@huawei.com> <20240506103014.GHZjixNhhFkgkMhDg_@fat_crate.local> <20240508172002.GGZju0QvNfjB7Xm6qL@fat_crate.local> <4ceb38897d854cc095fca1220d49a4d2@huawei.com> <20240508192546.GHZjvRuvtu0XSJbkmz@fat_crate.local> <20240509101939.0000263a@Huawei.com> <20240509200306.GAZj0r-h5Tnc0ecIOz@fat_crate.local> <663d3e58a0f73_1c0a1929487@dwillia2-xfh.jf.intel.com.notmuch> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <663d3e58a0f73_1c0a1929487@dwillia2-xfh.jf.intel.com.notmuch> X-Stat-Signature: tbe4asak8f88exkoe1xr3t6a8aonqmfj X-Rspamd-Queue-Id: F2CB0100008 X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1715291566-452484 X-HE-Meta: U2FsdGVkX1/0SGNbyIKhAOBIuW8qaY7dIan2Tj5fUvD4VNdykaF35391zG+p/L58IWbI9XAjOp1H2HdsgE27BGGxm4aqQCK9ZSYEWxOo2jPepDtKPcob4F1THolSexzM/xOEbbY5mf+Slz1uG8G95TPIz4B17b2Wu474MfVBuJD8yHnGlslfuBEzGmR6GsIgiVMUY/CcYUwgaLDmohSwodmJhDpnB3TxbLmlLaUI1EeLZcorK4Rj1V7wHJH7MFWVew+2LFC5OSupPMa0VlQpaQb33CISp00PICiVN3G7JfCmVJ4jRZcts3xYUGps8dDSuYQb/YZasPNoiCmh5lulhrVdPDsCQhy7eeEabvkrDBat0c+KlOeiiFYwTgVgC8eAKpzCOZxG67VTqMWEaaOHTqAS4j7WMYln3pu2yZuIh2+fvxcW6pJUo5UEbZbRm2NgM3Xoh4PWanLaqcwdgPRkaw8RaB39XNsrt+N058FtplE2XQm2ho4C7AB7ldj6AtvwSz72O2aE/WeUT1hWVnwXIiy3bQP5Hx4VMwdUVtz0heuoZf1q6eKdg8YimYQWj8te32sUDH4k+q4K4yj30RVCOm1WzOhFDhxNsup4fQFi7o/PLmH4l12J6BiSDjYxOuA1VpkKDscbxOYhtL/hgREPrWCm9eV62QW5+o3osRyXNGegOuP5q/2KmBT4RrIGdPih/Jzyo2UyTqOsZWKczRNJd8d/KjUVcLr0otAh3DzbV1UEheyVriO/49/EdPNstbB2OIrDbu6djvVmN2p3XT2RPfcQaTqi7Zj3m7kKuN+7uBbCgRne8C6vZipGp2G2YBEVoin3KHrmvs6BjVj27j2tmWuQvHOvffYbpBGRsHUTs7X5LQM4fmdhX65EqvyU0XRF6SOWqCD0Lyzj75PsS9iBThxWu0LAjvFfwqPzl5lpDBAaYssO6yNiv0Gv8L+TT2eiRoV4vXLiVe7tRr/y3Dd OsyKuGsw FUSZ2kuZldvnOceqeU/GGl60Z/Yj6f1LrUt8XvJe6YpoJvDvdM7QhLpa9wl8MFhdJfiJgh11w1sHqol5nSD0ELIW19XISPlvd6ChkTDZo19Z6CjfUvOHGck39xJ07Lqy4OVVE9xVVc58Y+cKos7/iiVaNkwg3QX0TzRy3QReYghVO+X/Vz/vyLuHx1k15tgOeM4jWEeDbve0r4uoLxxWm1jB9wXY5ObFoHC9cBNHR2Qo5oM0h1oqW+OgO3bH/Lw2xSJab+FJreoiWkTPEXukiUV3qwaBVlX+fYts73U/S+GRAS0WHUB94hRAulw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 09, 2024 at 02:21:28PM -0700, Dan Williams wrote: > Recall that there are 461 usages of module_pci_driver() in the kernel. > Every one of those arranges for just registering a PCI driver when the > module is loaded regardless of whether any devices that driver cares > about are present. Sorry, I read your text a bunch of times but I still have no clue what you're trying to tell me. All *I* am saying is since this is a new subsystem and the methods for detecting the scrub functionality are two - either an ACPI table or a GET_SUPPORTED_FEATURES command, then the init function of the subsystem: +static int __init memory_scrub_control_init(void) +{ + return class_register(&scrub_class); +} +subsys_initcall(memory_scrub_control_init); can check for those two things before initializing. If there is no scrubbing functionality, then it can return an error and not load. The same as when we don't load x86 drivers on the wrong vendor and so on. If the check is easy, why not do it? Make more sense? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette