From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FFE3C10F1A for ; Thu, 9 May 2024 20:31:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D9746B0089; Thu, 9 May 2024 16:31:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 189CC6B008A; Thu, 9 May 2024 16:31:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 051146B0092; Thu, 9 May 2024 16:31:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D97326B0089 for ; Thu, 9 May 2024 16:31:26 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 594711C089E for ; Thu, 9 May 2024 20:31:26 +0000 (UTC) X-FDA: 82100002572.05.2463B0D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id A67954000E for ; Thu, 9 May 2024 20:31:24 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fIhFWTXo; spf=pass (imf12.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715286684; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4cz7srw0wchahj3BrBLgg5JQDw/zVyXOLP/W31mZ9gE=; b=UYlbyFvaEVp/5yf3nThGcmp7+l/fwLQPDBDo0UBHXWNB5TOCEW/ZI+UVilJyxt85CRSCXg fkEHwryDbPPYeiCJJIgVZNlQaiZYz/56cPiX6zC3/H2vGECYAb3IY/VUNrMMv0VjFUHW7R TFXc5Oohvr+TdYdNz4fN4bTed1GLcRg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715286684; a=rsa-sha256; cv=none; b=HyJNQR7E1eb1EQl1aNYFiMCINDED8gk5F5eWpDggN4SPtROEIWrUy1w6r8n3dkyQ7ljzzO ENac7aAxsWKDOPPow+jol6p0QFgAIAcTnnH3yqZYAd1uBoFJJAP+MDsL2/mUB0KlT+vJnh vOFIB6LxCuLhGQgEpOsigRNiNI2Qngs= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fIhFWTXo; spf=pass (imf12.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7E1C061D52; Thu, 9 May 2024 20:31:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2BEF6C116B1; Thu, 9 May 2024 20:31:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715286683; bh=3hRwl2K12SkRKNM78wLsl/4te3kJ4BT9nZoF6sCbxbA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fIhFWTXoUfrZEXYXnNpjyqAaUa4FKNKp1liB8UAZMze9KVv4hdAFmJylc4iA2ekx7 0fhwWAgIWjmCNyvHeQ0baHNbtDX7ycaHfa2SXUNVmD1OT3lznGSH7W9ZOMYVq8XzPS XNdetjkAICbPLl6ZcBlFpBrF6uOo19eNlFEH04hmul98ViHyviLWxshHNPkuB4YW8R j/XqzRH4eUz9DNnhN6j1c2zTJ4wOzQvR5+5d/39yVSA5AWK7LBuN0WnPSyQoM+Na7F +byhIpw32XvdJTGUefGzhSRK/x2pK5XgOnr0McvVxwaDjfNk0mDdQZSj4xrD1fIuDV XVepSil5D0/gg== From: SeongJae Park To: Edward Liaw Cc: SeongJae Park , shuah@kernel.org, "=?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?=" , "=?UTF-8?q?G=C3=BCnther=20Noack?=" , Christian Brauner , Richard Cochran , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexei Starovoitov , Daniel Borkmann , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , Muhammad Usama Anjum , Andrew Morton , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-security-module@vger.kernel.org, netdev@vger.kernel.org, linux-riscv@lists.infradead.org, bpf@vger.kernel.org, damon@lists.linux.dev, linux-mm@kvack.org, mathieu.desnoyers@efficios.com Subject: Re: [PATCH v3 13/68] selftests/damon: Drop define _GNU_SOURCE Date: Thu, 9 May 2024 13:31:13 -0700 Message-Id: <20240509203113.63537-1-sj@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240509200022.253089-14-edliaw@google.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: t95xkw81egces65tmo7f8c8qbg7rtf6e X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: A67954000E X-HE-Tag: 1715286684-809010 X-HE-Meta: U2FsdGVkX19JTngI4TFGdTRjPs7N6QnBmp45TB0gy7vGP5V5MtAt3fDJRMDhggv7KpD5bBxoWmggBCxAQZpKDwjIPBNkIiINnd7EM8016N39/vg6ed8ArOuDlaL3ipz9aXxYUVr3QduSXrQx8NNaxenV32ejR6jQLmkCOQO6HoDoEfxf+4rfQrzeLw5vVD+7iR/zxL7WF97DEhv0hfXnJdNn3/jv4ZMtGJTGvFqoK+tW/jnPc68eD3z2O1moDMUPQOEjWP2lxuHG38wVDei9S2LmhagKOammJaYzxPpVhpS7NaoDvpDkUmwvLB/si5QXoSYWcQnNwnoGze2GY+VIPK1hCJwQTk+53rqmM63kGg5bXMVYqBziQFfBjJuzusnMzUb33ldk3PDsUQxCCUFUA8hL+rvqRrT5uwoByTgn2NvZcnKaAnsxywKjYgwSgTCvbpnL39pyozPnxXFyd+lm/LUmd9dL5vSF57/82YVjIAa50C/L/ZPnTJ6wiFKZUQekbyWHgSex//nnP/lmc2YyA3dfyEf3IFjl39m/90dX8p8xtk/qGTZqPGzoktUZo1pPw+tOJ6e2dale88XpHC1AeUwb0GVg+NpVYFowoLpocwilb77CnmpWrL6gY0v6PaaxIBeU3io6/Cin/UtE9kTQKCPLEl2hZL14dAzNRE28kFo7nV2FwgopS2Y9LAXnOvESigM36l75D7lqPAI8Nfd0tjnGWMR5rbWY1sAcuTURQXLI4nxOplBUm0t+nPai/A6usoPPIWUKxiUgsLqHTA6ShFcLamLmy1cYWzP6tRNCbZCfSwF3/4xxqbNS39k0mH48v41KQRefAnNyYEqHuR1VqSxH1baPGdY2Jg6QYEiYQf4wx4j+8jVi4yeRTlnJ2pG51KUIvzt3RycE2VG1xteP/bRRfltt5stIOBuVR/jBREEsdboCXdkllC0gZRhBYMEBVSJ9AFS5NOSGZfTxXwE ls/eADZC hyqN3Pk9F6tdUeoApURWYQGp3uIUujzBMnrU8q8t3T+zMK0NAyACbDQkkcTCpYL5zmHqe4E0lexJ/QnWpafUhs/s5I93xjsHZGaq37Qsd1QxEQ/wwODIxsfkZJnH1c9EK6uzddNLBEbm+1crWDeV27wYHSd8S6CW6/7JRjSFC74CT1HBk0vhoH1WfVeRGFf0YxqFvLz5o13/lRoPNGNCEDNSGDSmXHXRLG+E0kVs1xNLSn8IF+Xl7GB9iUcS3fiA9r0kQW2xnAqLlO/wxlNyCUiR1K1bXWO9bu3gmkrq3ziBv3sLHI2IGbFrZRhqV5gGIX7hh47Q0DWZW7pLWPhyxo4DzoaI74dyAQ2nFnynEn6qsTgZ3KAbv/57aOy5XB4NbSizDJX9rzQ3EWEZ5j1zsDMPyUFh9EwmQBKn5OcWqtw3XevtTcThPjAzgTYvTs0NIwWVh X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Edward, On Thu, 9 May 2024 19:58:05 +0000 Edward Liaw wrote: > _GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent > redefinition warnings. > > Fixes: 809216233555 ("selftests/harness: remove use of LINE_MAX") I show Mathieu's comment on this[1]. I have no strong opinion on this, but if you conclude to remove or change this line, please apply same change to this patch. [1] https://lore.kernel.org/638a7831-493c-4917-9b22-5aa663e9ee84@efficios.com > Signed-off-by: Edward Liaw I also added trivial comments that coming from my personal and humble preferrence below. Other than the above and the below comments, Reviewed-by: SeongJae Park > --- > tools/testing/selftests/damon/debugfs_target_ids_pid_leak.c | 3 --- > .../damon/debugfs_target_ids_read_before_terminate_race.c | 2 -- > 2 files changed, 5 deletions(-) > > diff --git a/tools/testing/selftests/damon/debugfs_target_ids_pid_leak.c b/tools/testing/selftests/damon/debugfs_target_ids_pid_leak.c > index 0cc2eef7d142..7a17a03d555c 100644 > --- a/tools/testing/selftests/damon/debugfs_target_ids_pid_leak.c > +++ b/tools/testing/selftests/damon/debugfs_target_ids_pid_leak.c > @@ -2,9 +2,6 @@ > /* > * Author: SeongJae Park > */ > - > -#define _GNU_SOURCE > - > #include I'd prefer having one empty line between the comment and includes. > #include > #include > diff --git a/tools/testing/selftests/damon/debugfs_target_ids_read_before_terminate_race.c b/tools/testing/selftests/damon/debugfs_target_ids_read_before_terminate_race.c > index b06f52a8ce2d..4aeac55ac93e 100644 > --- a/tools/testing/selftests/damon/debugfs_target_ids_read_before_terminate_race.c > +++ b/tools/testing/selftests/damon/debugfs_target_ids_read_before_terminate_race.c > @@ -2,8 +2,6 @@ > /* > * Author: SeongJae Park > */ > -#define _GNU_SOURCE > - > #include Ditto. And I realize I also forgot adding one empty line before the above #define line. That's why I'm saying this is just a trivial comment :) > #include > #include > -- > 2.45.0.118.g7fe29c98d7-goog Thanks, SJ