From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A17B2C25B10 for ; Thu, 9 May 2024 20:33:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2295A6B0096; Thu, 9 May 2024 16:33:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D8E66B0099; Thu, 9 May 2024 16:33:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 07B3C6B009A; Thu, 9 May 2024 16:33:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D88FF6B0096 for ; Thu, 9 May 2024 16:33:15 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 9791FA10A6 for ; Thu, 9 May 2024 20:33:15 +0000 (UTC) X-FDA: 82100007150.30.24621BF Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id EB68340004 for ; Thu, 9 May 2024 20:33:13 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf01.hostedemail.com: domain of "SRS0=k3mh=MM=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=k3mh=MM=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715286794; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SI1d8TVP4ORIA0O6m+VqC6+mUPlyhsfd4LpKaUgmzBc=; b=fV/stK+TKBtTQlZPBpqt2MtQQ+fmm9hOw2LpAUbl7X9XU3zpCkYSyYnYg+3vBPq4FB3GvM 45zmWJB0iAP3q+i8pIlbAqYxc6Hsh0D+V0/k3I5QT2w718GWGrosQwEJG25jh+vOOzt5iD CkQlhRc1BDhIb7AEPNLXv8eb7rV2Big= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715286794; a=rsa-sha256; cv=none; b=AkmlbBaDrxDAZ7Me1VtTmjFBNJoEvaH95T0RNPJOKz0FhrvUeil/hBmM8PsyCAnpeRYaFv t3coezP0XJxQVgJAD+IC7zshKVOMxcfT9fOXzFNxAfwO4SPB97Gl35oHKqLDDpAoTNTrwA t8NOtPW/RO25roEBUMGcb63SE88bwfA= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf01.hostedemail.com: domain of "SRS0=k3mh=MM=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=k3mh=MM=goodmis.org=rostedt@kernel.org" Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 223DC61DB2; Thu, 9 May 2024 20:33:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6CB2C116B1; Thu, 9 May 2024 20:33:11 +0000 (UTC) Date: Thu, 9 May 2024 16:33:10 -0400 From: Steven Rostedt To: Mike Rapoport Cc: "Guilherme G. Piccoli" , "Luck, Tony" , Kees Cook , Joel Fernandes , "linux-kernel@vger.kernel.org" , "linux-trace-kernel@vger.kernel.org" , Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Lorenzo Stoakes , "linux-mm@kvack.org" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "x86@kernel.org" , "H. Peter Anvin" , Peter Zijlstra , "linux-hardening@vger.kernel.org" , Guenter Roeck , Ross Zwisler , "wklin@google.com" , Vineeth Remanan Pillai , Suleiman Souhlal , Linus Torvalds , Catalin Marinas , Will Deacon Subject: Re: [POC][RFC][PATCH 0/2] pstore/mm/x86: Add wildcard memmap to map pstore consistently Message-ID: <20240509163310.2aa0b2e1@rorschach.local.home> In-Reply-To: References: <3391c693-cf54-526b-79a8-d565e7140947@igalia.com> <20240411154007.5bdf8d95@gandalf.local.home> <20240412132243.053ad096@gandalf.local.home> <20240501105455.42b78a0b@gandalf.local.home> <20240509000023.096d4032@rorschach.local.home> <20240509133122.474130be@rorschach.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: EB68340004 X-Stat-Signature: mtiqgyjxyrs5mcsy1zanjfqneq6w4hma X-Rspam-User: X-HE-Tag: 1715286793-444092 X-HE-Meta: U2FsdGVkX19pPsa7Yvd43s5kzE96iNErdBdBS0W+ipGWgQn2NCknqdo4tTS5g/tKLROAgK6mHfvn7xwqfc/KvhwbBR0F/h589QKvzJCMI8/n/+eoviD7qxAmIiHmaF4y+lPbJAWR9bfAeIWC4QZkk+MHA3O5jKhI0fFDc8pq1JdnWNZewuF6zwpUz10GqDH6Qeb1N8TyXBbsmHP4s9ml/YhcsGRPDv5acIJ9vIIr4t7dQxE4+uiPFaPoQ/L2qMPg5Xg9vc/CBHQRzSgxLPhl2vG4IzoRZzIqveB2qajiKc4tskc96+WEOO60e9nkyc8nC+891HFnZ7PFgmSFIEF0qQpDruzLdKe8mE4lnR2NhYQty84/Iv0SAeXTqMdr66MBBiZOGn2tc9FK9LlfTPavG0MafG4PRZ7Yd0rBcb+Tc6O6FHr5jium9TgSpNPqR5KQ4lX9QDUfZ34zhMYO7cwGW94K8oC9cxVxBNnF3yNLfNVQh4f7on4m4qIqXaZexnT+wTiI2Ce3t2i4fmEE3/GMdN5om0Tc0wDhu/2astJ5z0kBs30C1xjj17GlGxdve9hOqB/+mNxhMXqOeCmRHtH9iBi4P+hcvrn4LAWiwDrXXPyCanj0tO1m9JP2fGdBYoOwWNZBOxxzMKfGLVkCbNuOEHduVIJZtsCdV/I3s62kHNcTRU1rcfsMKXe/VI9h0LdlslODcO96LP3xL//6QYywwf7+s0KYT5v0IGBUxay5IBU66iy4As6vSMZyZ4ysfM0u+fV1nzI2kjpKQcv3RWwfvur/inw0E40EUuLNu3QBlh7DUg1xuD2Eji1Fn4tjbJHd291sQ2790WQA80q/dqFj8XnGtHJckWmPTn7zfWUmRtWAFyiAFwgyWgA1hvtkwsyArBa6cYGo0MYtFkSFva+fU6NuU0rKYKiR1pcE2NhLPBLDoEuRLwNYyjcUDAJGI97llU0IF4QxUl1AebH0GnR qbuBguua ZD8zo4PmjfiszuOU0Eqos1FRfKJJQ/0poWAoI+FkTT7LHEFdFFk0ZudcIeol1L2w2RU675Y2hV2KnGao6m5WF/1tz5rnDog9+fBINnmppeWuHxAnZXH+KuRrWzqemzMTM55JDyM334Dr1RadeWHQYzu9g2ThdVbKgwKtJJ1KDvBIvxcS1MBnoimlolQkqeyNE26I+8O5UAckVXCt7DoHy2T2ojB+vkKv8mjkO6flV5QJlin801kp+hhSpfhRV88z+3Fzvfgdwvbo83ra8IDUotlPLSoJIt8MRnRSOWSfB9YmyIyUd3O7IdtjR4WMd4c87fO2BtvpvW0j5AixaYSTkE5hb/a1UxqjioPDPWaIwNv094ATrXuT4bcA8oyh+QiSTCE+zk9nqultWYEzjN5D5bC+tTAn/s3aFlkF9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 9 May 2024 23:24:20 +0300 Mike Rapoport wrote: > On Thu, May 09, 2024 at 01:31:22PM -0400, Steven Rostedt wrote: > > On Thu, 9 May 2024 00:00:23 -0400 > > Steven Rostedt wrote: > > > > > I tried this approach and it unfortunately picks a different physical > > > location every time :-( > > > > > > So it is either adding to e820 tables or we create a new way to > > > allocate memory at early boot up. > > > > > > > Hmm, now I'm testing it more and it always seems to end up in the same > > location. I'm not sure why it failed the first three times I tried it :-/ > > If the kernel and the command line were the same, they shouldn't have. > e820 translates to memblock the same way every boot and the early > allocations also do not change from boot to boot. > > Could it be that three runs that failed had some differences in the kernel > parameters? > I wonder if KASLR caused it or not. But when I first added it to another machine, it failed to get the same address on the second boot, but was fine after that. Could be just something with my setup. I'm going to backport this to 5.15 and test this on a Chromebook and see what happens there (as that's the motivation behind this work). -- Steve