From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F5C9C10F1A for ; Thu, 9 May 2024 15:09:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 199DE6B0082; Thu, 9 May 2024 11:09:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 123876B0085; Thu, 9 May 2024 11:09:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F2D466B008A; Thu, 9 May 2024 11:09:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D35BC6B0082 for ; Thu, 9 May 2024 11:09:51 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 4E658C01E9 for ; Thu, 9 May 2024 15:09:51 +0000 (UTC) X-FDA: 82099192182.09.A494D01 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf07.hostedemail.com (Postfix) with ESMTP id 57AAC4001E for ; Thu, 9 May 2024 15:09:49 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715267389; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+XttJvlyJ3mLp2zyK8QouoYNQIrtC9sdMiYKSb98kGs=; b=RGM4E41fPyAB1aka74j+BdOYnrYeNVyHHGU2ybppIKjO34E7S8RKsuRPK8r5SHunMv5n2k oL0cMzW4zBA5ux9mVuTXem/yZJY+LAE1hYlpd1v3d52m2R5aw7K7J6nEC6yo44bLnl8nzi E9g2R52csufnNN/OjP2clY008H722eM= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715267389; a=rsa-sha256; cv=none; b=5ic5A0VzzSj7LMxV+5hEuOHS96UKkepDfpnCPZs1fufjZM6EtNdnVLEQ04TWcb6lluunpJ OXALigcG+vKBR1Qkftc8Zt8dMvT/E2vz10sDLs1h1LF6JFTJq97cuizNiX4Im8UC39tNwu j0+7NRKQNiYOvjCuxO9QD+/XTwTkxoI= Received: by verein.lst.de (Postfix, from userid 2407) id 4A618227A87; Thu, 9 May 2024 17:09:43 +0200 (CEST) Date: Thu, 9 May 2024 17:09:42 +0200 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Christoph Hellwig , "Pankaj Raghav (Samsung)" , hch@lst.de, willy@infradead.org, mcgrof@kernel.org, akpm@linux-foundation.org, brauner@kernel.org, chandan.babu@oracle.com, david@fromorbit.com, gost.dev@samsung.com, hare@suse.de, john.g.garry@oracle.com, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, p.raghav@samsung.com, ritesh.list@gmail.com, ziy@nvidia.com Subject: Re: [RFC] iomap: use huge zero folio in iomap_dio_zero Message-ID: <20240509150942.GA15127@lst.de> References: <20240508113949.pwyeavrc2rrwsxw2@quentin> <20240509123107.hhi3lzjcn5svejvk@quentin> <20240509125514.2i3a7yo657frjqwq@quentin> <20240509143250.GF360919@frogsfrogsfrogs> <20240509150828.GK360919@frogsfrogsfrogs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240509150828.GK360919@frogsfrogsfrogs> User-Agent: Mutt/1.5.17 (2007-11-01) X-Stat-Signature: jmi14hf5wsiefm8ig6spneqomzh4o7if X-Rspam-User: X-Rspamd-Queue-Id: 57AAC4001E X-Rspamd-Server: rspam05 X-HE-Tag: 1715267389-725518 X-HE-Meta: U2FsdGVkX1/2vamwxLmHFIYO1W6YttgkNG3qgAyu+CjfIf8J4xbjLh9z1cVLS/p5v6tu07RJWBcsZAu3Cc4jI9AIGkyilN68V0YDQhf5mfdAI7Iu9nGfFY3DSpeEpjLqEXD24/sQKQYCD9dLJqWRZmGtW7D0ZLK8fExrLWKcsfXgNtTPqUpbraunPttgAva3hvSY76Flsn2bYnttzOnHe2e3myg2cyT9ZDHPtHeD/6UpcavvVXT2mS6wIUlyBG6Ub1hfpFpkWAoY53wn20sN386RyIigfI6TIzcTBtB1EJjmiEG8hBM6VnOM3iPNp+vETd3ulK18D4HjX43d+Yp6sdQJ35EMYxS6/EXWeoUxhttF/FX45lUqja4D965VyyFZ9pmT3wf4YRfF2vq/WyzgcNrw5y0t/7G8YYzGliLKvWI4lIpEVJAzuk0S4nBLmKXRbrr2aYXQbpEaH9bU/G4grfJTSjNmZMLCOoL5K9bOOU/6cKxJBv557hA7cn4EDMIqzE5ROTiACOwUpgAKYqsAAuj9S+YXfZcCDzpfqbaVvnNI/M/IMs/oFJ2U8nzw6t0RxHRmcmP7BYNRzBopIqJKoO0z31jUUsq2Y6CABzyVI7/Ddqqi1YhFwFx5b+Ncgjjoctb/PMUzhLAK3IuLf7AhpJXAyQKvdOA6QIIUvBbb7V76bilHCvZacLsEHflseadxF2vvJFdO5KRfgleMduUypJUZumzjVVvVGrSDSSH06YMDdp3c5tjtjjywFSYEZd6WKNVefrsqNbki+8FM0Ssi71lJbfjTMX85QLEXpK28AtVm9l4lkmsmF4OolXg4CxRVc75bKYa8LzDSWdwZrsA8jB327/YEBkRKnC0pyTqfqIm9P1UjF6qhYPYfGp5Jq8AAP3t0ppyoLWN/BKHqzWTHwfiFKOwVXYSol6M7bLlVjHBvAUIDzEkMfnL055W7VNxxR7qN8Ydv3l6f/UCR29v fkSfiuH9 FTCFLvvP1GOCs3NTkwEcjFjR8hGQI7Blk/NLJTSkJrnMkPO6Lvm+tfNTINfFYXRWEb9/wrhgAgn30mjAYaIWhS5cei3fwkP1nNstfa6xSRIVBad59o9JCIEcLuKL9Qna2XoR4mvtOh5CHSCYib/Pp+4PMshIbvwbFs7yP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 09, 2024 at 08:08:28AM -0700, Darrick J. Wong wrote: > Oh. Right, this is for bs>ps. For that case it makes sense to fail the > mount. I was only thinking about bs<=ps with large folios, where it > doesn't. > > (Would we use the zero-hugepage for large folios on a 4k fsblock fs?) The direct I/O zeroing code always deals with sub-blocksize amounts. The buffered zeroing path can deal with larger amounts in a few cases, but that goes through the page cache anyway.