From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9F70C25B4F for ; Thu, 9 May 2024 14:36:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D3E66B0092; Thu, 9 May 2024 10:36:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 382C46B0093; Thu, 9 May 2024 10:36:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 24AAF6B0095; Thu, 9 May 2024 10:36:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 068B26B0092 for ; Thu, 9 May 2024 10:36:45 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6C743C1371 for ; Thu, 9 May 2024 14:36:44 +0000 (UTC) X-FDA: 82099108728.20.2D94DF0 Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) by imf07.hostedemail.com (Postfix) with ESMTP id 0C9AB4000C for ; Thu, 9 May 2024 14:36:41 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=q0nImlRV; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf07.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.177 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715265402; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=d62sDrbwldQWyfBHNDbH1tSKK2ETROA7S+pTbUfGW0k=; b=rifw+UuEE0Xr4Dd2x6aZinLBUfGkwXYh56wIiwEmmKk4QTCnEi8uwud9mfrkoIHTlf/A/b CJF2wLR0ZwN6LQOkOTy2X3Wt/hDdPWPZnfFfw31ubd/qKy1gpJN+mYszQJvlKcPRviESZZ Z3vffyheXwQ6cJm6xXcUeeL5TIhb1mQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715265402; a=rsa-sha256; cv=none; b=a6Wb9+PkgXpyzZRDh94zoiIsB2U5pm5NWNpEfZmz/Xibln+c29ckQHnAIU/sJFzeo7VrbU fuOmtzvnWVLvY2v08ED5r/Vy+spxJfRs0VRjJmijlV7jRDl3ZsTxKWTjOV1xMXGTGky8hP xGoUhkMEh2WVP3PfUTSruU/X6yX7hNs= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=q0nImlRV; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf07.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.177 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-43df052337bso4598421cf.3 for ; Thu, 09 May 2024 07:36:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1715265401; x=1715870201; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=d62sDrbwldQWyfBHNDbH1tSKK2ETROA7S+pTbUfGW0k=; b=q0nImlRVRhRar/CI97tJBBy3h2kuKVGluByxaEgac7MrmX7wiEusVmRrVIJl6x5+Ip UOQOXlcqM7AxphsEiU3JvyTy/BDwdQasijDsqFWCGY0WbX3imP8bWSSkNcudg9IRz/OX MYUXXxyB8o4l6PieB2SXB4UKMIPAz2dHtJGPivkCuFwhHCRYebM6TkSXnMJ6B9Q7JJt4 rOMims0Ak79oj+2WlbhBTEzygZKzrAsptowcGki1PJfdf5L1W3LDWRRKTThwZp+rBgaT k20g/TZE7VgSlXCafunOqlpJWMIVLRsTfED4TocHG2y73ny1DFkrCqTQJ/08Yjfkzjbo PMow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715265401; x=1715870201; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=d62sDrbwldQWyfBHNDbH1tSKK2ETROA7S+pTbUfGW0k=; b=TCjijKZagncbGxtdWbS20iTtyWxCXcysRsyoUXA2GUl0EhRbevXFQWgV29qqUz/Cbi ZImCD3TiazQpaiNeXnGN2Tivwgwr/7qtlAUIj8RCk8w9iXKlNdaobxiZLRsd7YTW5SAe XNJdtVZl04OqQcZhGKhCqQjSdNNeXVd6rZApa8eFL8IQgeDcir9DPckjAd8EhXOgTENS SHChd9pjGgwHEv+oJaUzeaBYc6hz4tX4ykAPrVUdYA9p7zC8fhUCavoOoNS1g2F4Mj20 du9CHJ68j3fy2E3cLJcryxByNK3NDgPBWs+Cq8kEhzHyEHLYJIrf8odUesbOdp/OIDXD /3Ug== X-Forwarded-Encrypted: i=1; AJvYcCU8a6VSK/isz5ybZi1ox5WdzAYXnegM4z+W4cK/uglvGnZc6gSeo8MBVPXfg16du+2909BvloFT2dH2Fv5NG8r5FUs= X-Gm-Message-State: AOJu0YwsdZsHNNu+3LYcRtZ+03njP1ig0dKtm9pKTLfsHCSkaz/SWkmH +mrPvip9zLMLZh5QLdDcdH0pxXYx0ws6hroLf4DSpyF532oM5nDPdTZn8BJ7q1w= X-Google-Smtp-Source: AGHT+IGzhpNIA1VnsSvpxsB3TI/JCTSS4gbwUUo7lk8tUT24yEmwjA9Ux+WExHDN9IKSEnW0OvzNXA== X-Received: by 2002:a05:622a:50a:b0:43d:f612:979e with SMTP id d75a77b69052e-43df6129c5dmr20241621cf.47.1715265401015; Thu, 09 May 2024 07:36:41 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-43df54d6e47sm8862701cf.28.2024.05.09.07.36.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 May 2024 07:36:40 -0700 (PDT) Date: Thu, 9 May 2024 10:36:35 -0400 From: Johannes Weiner To: Roman Gushchin Cc: Andrew Morton , Muchun Song , Michal Hocko , Shakeel Butt , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH rfc 0/9] mm: memcg: separate legacy cgroup v1 code and put under config option Message-ID: <20240509143635.GD374370@cmpxchg.org> References: <20240509034138.2207186-1-roman.gushchin@linux.dev> <20240509142205.GC374370@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240509142205.GC374370@cmpxchg.org> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 0C9AB4000C X-Stat-Signature: qdkbxpqp4dwfyy61eauemp7w5ixtm6y7 X-Rspam-User: X-HE-Tag: 1715265401-807262 X-HE-Meta: U2FsdGVkX1/lfIBp1gJiLpUmKx8nqctVjgz6p/ixq71aDMPveYsF+WGjM6wySxCd2GT9ZRDuqCvg5TnPJ2wS0dOOquV0/11HNmI7TmFmoMIOByJ3lKhrQny7Z+iBdSJlmdmMF7r7o3amcRL6jquAfTfz7NNK/82iGsEVbFkSyllY5b5ED+8yDFecPJSjjg6Dqurm+e7Zr1eDgre+Ini3kt7KyX7tNm0OEAlLeL2OSAj8K9v0djhrK4hAXzsKo8P9kQ5qQJz/oyJHfOEc2uU5Gbrir2qvZi6boslJlFlCYgmksnmaLXizqTrdJLFcuMEKsQHRWWiKDrhfgs9ViiYCTT6HvMwSAOnKieqV2RouBa5YpGUUXqzzZfQj5FPvfarqtZEWN5wA85sRNxG99VvlB1o/cV9fyeckCZKEyoYD4tRxBBZs6kHvAr55qpWEg1RH3xppdhjrqcuaJVIrqOQo6kbWPccX3hrk8DHa5WIYeCIxA4MDUdw+boFqlfjO202E/n/Xt+Ii8bVT0P1rfyl3Wuyp6rAXPDZJATkCAQj+qM9b0IiRrURt8oKpmlpL3HOa1otnwhRvpNRDL+TSeIUV2I7rQpXpc5uTLbWOU86EkVo1D26/MPpEgKWEaOX1RmdQXXZpeLRbnmVeqdNrA8gmRYBA9QVCXCRJEXOwPlOv8R6jTj02Z/12PcJH9Ce7QSb/tIccGIP2Rjq1lJ+vgkXSOo69rUTjcBTlHRZvbwL2pwTABr22vWPOsh0fPJUpMC+MffQWbyzXFQjVr4Y3iSyLJWZQBw5qnho8wz7WTdXs6eioDhNUVRTD6EWCCAYLuQSFt8pl7oiY5gveYpz3SklEr2XihGE0dSya60nLZtFeIt1mQ2ptwh8PkX+02VCd1fzqAmhkAjGlL3BYth8y65dQxcsgPFxIunrgY2wFeJkS7N+rEAtBxuK797HGlbxKs9tEOdacNRXK30BqE1e1L6r dizUgiQU MOC6OtB2jhlHOZQh8rxhmIEA/Vxe0lDcTOU8AKmYkeVx9ZUB2ttvoQic98t58AXYHHIIxH+8fR3kERe9Gq5EBEytTat81NZbvFvj9aaqU1/r+PjHfa/3Lwc9eZNkdwtAQ02BbXdmntbr8R0686QcP6ganEB7lewB0AT5nnUFMOZZsdvOkvz/UYBKpJ++We4Z2uu4HR8hi5h+pZ7YMDk3+cRnNqgUvbII3mb1I/UONjN/esQ6GKyjo0v3RsUUd4iUKV0Gp1nzp0LAovHMKlV/BxRKzRVYmOGarS07gsYv3vTIQRfRHp7DgB+eFX5p0Gk5zamxKw1TXLnhcbR++ckOkRi7d+NV8Dkelm/2uLmYhFG6aPszOnvmLG/rO4J+y5OwGdNT3jb7kKKDtUraeEatRrEOLgVQ/HP+sYIhE9pqjAEEh+QtYtWg5QVEBHqSnSYC0CSGwImI/859t6OEPVgjhYXLqFejp9hjZjhApXRM6p/lme0s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 09, 2024 at 10:22:10AM -0400, Johannes Weiner wrote: > On Wed, May 08, 2024 at 08:41:29PM -0700, Roman Gushchin wrote: > > 3) Is it better to use a new include/linux/memcontrol-v1.h instead of > > mm/internal.h? Or mm/memcontrol-v1.h. > > mm/memcontrol-v1.h sounds good to me. Argh, there is a folio_memcg_lock() callsite in fs/buffer.c. I suppose include/linux/memcontrol-v1.h makes the most sense then.