From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25697C10F1A for ; Thu, 9 May 2024 14:32:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 669516B008A; Thu, 9 May 2024 10:32:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 618E66B008C; Thu, 9 May 2024 10:32:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E0A96B0092; Thu, 9 May 2024 10:32:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2F8866B008A for ; Thu, 9 May 2024 10:32:59 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DCD29160FA5 for ; Thu, 9 May 2024 14:32:58 +0000 (UTC) X-FDA: 82099099236.04.14492DA Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf10.hostedemail.com (Postfix) with ESMTP id BBD7FC001A for ; Thu, 9 May 2024 14:32:56 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=aK9xR7Pg; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of djwong@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=djwong@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715265177; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=A0NYdiPe9Q/DQUKqMW0AZ8P6tEianBP6YWzJOZNfkNg=; b=P19N+Yt0Qr5KNvjqRRjPPH18RJ2WrKRbVggl3pElmfxT3J/J3ZblKriFKOBIzMFQTFSz/V NpHTMtz7GTl6gtHL9GFzPnpNFEktUgBJBzL1c6NwLwPUG2h9j650jcBtOcdyxPr7PYVTi6 xDlypdN/qpTCdgcn/PJPPRsLo26HMp8= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=aK9xR7Pg; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of djwong@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=djwong@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715265177; a=rsa-sha256; cv=none; b=455qWHWiTpbihWL6N1QusSDndHuSyN050AGdyZv8uUtbXKOSY0AQZaENz7zx9qBb92c1H1 X65v1MWRvnqbjPDR1qQ6LFoPTDhcnW/QnyT+VvWhgu7OK6T6qcJ2rUBcvS3PLEHMwUYCca Jkqe+UBTj6ySxjbEWS0YknpSlxK+xqY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 1F78BCE1B40; Thu, 9 May 2024 14:32:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B9ADC116B1; Thu, 9 May 2024 14:32:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715265171; bh=yz+YFbGtkYLL4EGdTd6mZCOqxppkuLvjVZ6QPxvtmJg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aK9xR7PgFB5bDXWjchi/PqHuIU+Au6YYRAM+Mc+i7r8mptyatvOtU9H4ymrCRKzmX i1sa0hT0QuCmU3225WaJYaVv4BtoK1vggutyVLg7djL1WBuTjj7+EdyqT0w8Tc5UzV cplECW9fHgxmwKrmNEi7OF5MMXzHdpv7cKYMhiJsoW2PO4MWua9n3g7I0OBw87Wb5o F8TzTC14QhZ5+Il++GiDZP2p48vWsay4RsUHHuXpR3KC08CzL0MY1485d83TBH1R9Q i/piU4TfG71SnOHL6E9uxmyWLBqTeo44jfN62fB9JzQHw0sEkTn7J2oAR8jltBkZ8F NEv6pP91cFwMg== Date: Thu, 9 May 2024 07:32:50 -0700 From: "Darrick J. Wong" To: Christoph Hellwig Cc: "Pankaj Raghav (Samsung)" , hch@lst.de, willy@infradead.org, mcgrof@kernel.org, akpm@linux-foundation.org, brauner@kernel.org, chandan.babu@oracle.com, david@fromorbit.com, gost.dev@samsung.com, hare@suse.de, john.g.garry@oracle.com, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, p.raghav@samsung.com, ritesh.list@gmail.com, ziy@nvidia.com Subject: Re: [RFC] iomap: use huge zero folio in iomap_dio_zero Message-ID: <20240509143250.GF360919@frogsfrogsfrogs> References: <20240503095353.3798063-8-mcgrof@kernel.org> <20240507145811.52987-1-kernel@pankajraghav.com> <20240508113949.pwyeavrc2rrwsxw2@quentin> <20240509123107.hhi3lzjcn5svejvk@quentin> <20240509125514.2i3a7yo657frjqwq@quentin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: BBD7FC001A X-Stat-Signature: ao1w5mbfn5sn9hs1t55coerp8xyrr1n8 X-Rspam-User: X-HE-Tag: 1715265176-409557 X-HE-Meta: U2FsdGVkX1/5dCPy5g7CVgZDd6l9JU9OJzGsjuVFMqbSCwiAE6rKyKA2LVhpWMJUCuQNs8C0/KB02qugB2Sq0jb/U1MX22EtWbm4mdsGiYsEIthQrMzLFD+x/af7nmaqXjtj45/t15S5442TOLSdzKc528Ctm5yBNE+UAvmFITtM0j8xvC+QTgACqmyMKf33J7VrfGzWnG8Z/wWmhSaxBnXmdJxXmTN8SmSLUgKe3/FY1IgY0cTSMNt2dLD5xv481vHbnsElm9eZzupn4PUuEOIp1zbySqgVO7jq0mmruQlR0ms2MLuvfDXck4HU/XJsXpP3BbgVrAC1ExNsu+rCk9cunqWTcFYZyXO4bwUHUXvekTCvPyNUoL3M/wN0wvFFVjjBEUayWPUNyhx+bD6WcjUvc/Z09ow7bJSQp+3Mga6zPq2QM8g9N5EpdbeAy+CiURwfJ4NsfwabMgQC2F6DkSLfYbgxFAj7qJ6+iekRNsXa0KswrVo0mpcOrcDoubZGxGm4sqtR7287jG0waO8UOccCKN7bU1wXBKPBXjq8P2TaaHTmRc0ypzwIHvoiGY54Bke11YKtyeYb1CIB2mahaPSYuwBJEUDxzUM/LPSq+2B1xZclDmd1qGXh1vPXTVI8cv7DhkdPHdLcw65mm9he/4UzjJpWtZQitqvjgxOzAPzoxYzGRr9HDDkj2U6SsF6MtUTDUreCbbQFSl27kumhqGYJURYdAGG+YD5OeYZ3fBuymDM6xIQ85rnHMWIsrVtcVWaNbwbBl2ySiW4YjAs7PF+LSzSHO7FolRr3bsAcUW+3IG1BT3HvXBebqmwcr2D/u2xaC+PymNM+FhN6xlBotrmcnSXJ8begHfr8sXF8CqGI0tOzwh5ZabzNA8LKSl1AY9ZICj99SjpOwh6xfu5u/gDrg9L9czohY/G7Ffvgc1YXTxT0vDB71LNWJttzuHYLwuE5j2aDp1uNd6u2a9/ BmABAi6d zkxm5ElU8bAKzJnKA/PGffCiagHt4rbY+xWUd6JIQ4+5VLC0dteGbA18oBJxg07e5PQEZ0zY6o8pMGX8Z7EG5Mc7aiqE84tq3jQUf18U+xOTGkvLkkEACUPyLGeIQcT9JNTd5HTS6SFjntHp1JQqJ0cUUgnY0i3Uxv5ga/DKMb1sw4QRnBwTFND+gzlhfnvOJHF43LpIB4du90tqd2IeyXHi3KEPqJwZKN6OArdUAF9Fi0KS0XxI84Wl0n9ehytE6BTLYIlibhaby9Zlg2VtV9YxPGW9cAjTsm475mKpbgTVoIkQQPeHhjDsG4g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 09, 2024 at 05:58:23AM -0700, Christoph Hellwig wrote: > On Thu, May 09, 2024 at 12:55:14PM +0000, Pankaj Raghav (Samsung) wrote: > > We might still fail here during mount. My question is: do we also fail > > the mount if folio_alloc fails? > > Yes. Like any other allocation that fails at mount time. How hard is it to fallback to regular zero-page if you can't allocate the zero-hugepage? I think most sysadmins would rather mount with reduced zeroing performance than get an ENOMEM. --D