From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6995CC10F1A for ; Thu, 9 May 2024 14:12:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BDBF06B0082; Thu, 9 May 2024 10:12:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B8C026B0085; Thu, 9 May 2024 10:12:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A54CB6B0087; Thu, 9 May 2024 10:12:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8A6DA6B0082 for ; Thu, 9 May 2024 10:12:14 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 15688A1614 for ; Thu, 9 May 2024 14:12:14 +0000 (UTC) X-FDA: 82099046988.25.82DE8F8 Received: from mail-oo1-f50.google.com (mail-oo1-f50.google.com [209.85.161.50]) by imf09.hostedemail.com (Postfix) with ESMTP id 4224614001B for ; Thu, 9 May 2024 14:12:11 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=aNgARD72; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf09.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.161.50 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715263931; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kvn9rngIDL29d8F1SzHuLjz6VO7wTPtvUbwSUyJZyRo=; b=CjozupuiCdg/K/IMeJFH5bsmbKgIEEulegZmoOqQY6QeoG2wtviEJEI2Cte6BFh3PyMM1Y U23UG/aAFuNN/kZvVrH/eWZ/pWF4NEQZQVrojPtyuyKyXtjExMp5ykEz/8tEu/J2GXda/b Y/eCMbWjIlUnEeNiNTEobZzA8VbDLg8= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=aNgARD72; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf09.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.161.50 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715263931; a=rsa-sha256; cv=none; b=jsXHiz3NHVWffaeXrJNIhtGZXheliqI8QE30x/Vjk0aU/chISh6R0nXJpgLEuKJedcJfmE cY1Znisgf8luQmJVYQ7q4UBLcsQ0NneLzrum6/nhrwACkbakRP4C8nu+RgSFlmE9iY8Qmh 9Ylx+EoPz8PNieT5jTAwuQtlgYLOkAY= Received: by mail-oo1-f50.google.com with SMTP id 006d021491bc7-5b278131fe3so169850eaf.0 for ; Thu, 09 May 2024 07:12:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1715263930; x=1715868730; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=kvn9rngIDL29d8F1SzHuLjz6VO7wTPtvUbwSUyJZyRo=; b=aNgARD723D21Z7kjXIijiU6t95HpyzYsLryUpd1cuqHBSeuU42spprJ1SM/IAR0Yi9 fKPhJeEZUNXxrG3/rywhcL33YwHlQnKlBaSYeDfajy499DU4Th6gNCxik76pv2x3nhO0 gSXmNXgwu87T75wpnBiQGKxgQ19lwd8dsxFcikVS9ttUXf4BWmJz32wyt0xkGPkVZsC0 bFOxsBoVkNZu4/zX0UQswupFA/UWiMgQnzenM4dHuKy0LTl1S7v6DJC3M3Qp4bhosg2k 6kNfHOGvCqidnR3Qr/abXYWBqafFqp9yjhrDp2QjRPBtbqF22kuZDH33rJ+bHjxoSPef gxBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715263930; x=1715868730; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kvn9rngIDL29d8F1SzHuLjz6VO7wTPtvUbwSUyJZyRo=; b=iY3y5nnkPIC/GITd4y8OYSRin2FMWuHDGXZmtovFwzhY2sOKeg38PPNGv9SgEIayjp eJnkp9pLUxvTwCv/i653MyiSCBY8j4n55zIDz4xIqQSCTwEjGgvQHi5ixZ33sxJnj4Bk wSZp7euO2ZJTP0blyb9tqqz2h/Rn7vRx/tf4TaEQ4JKrLCMeuvTx0ngBTWqHsO8Hy4tw MUYX+KvFd6FcC/Kj05Zr/f+0MV8AvdmSbgt/jYiQBkI4ITDjaLASiI58Dko/NYf36PS2 wCp+7ZxOyCsKDFEC6o8IKVO99gtO0pso01ileqSh5siO8BW6JMVQDjJaONsYsBO/3hvt Wi7g== X-Forwarded-Encrypted: i=1; AJvYcCV9mtkNi6B+vSJdvY7Zc0f+Abef3JhSfMf6h+nOlSEU5tvkJWe8npA80HxvTCwXf13f9rHFJyYE9kWpgo+YU8bfGNA= X-Gm-Message-State: AOJu0Yw2JLoUXIgTQaEB7HK0/ZZaGCbO9pyxKJZC978+XqQNLvArHOS2 vj5AVcGDws8ZYVoKD6jmHVrefgV7QdWE9aEq45wJb3K+7dTRbXTYSTlVu8mq1D4ar52BJWDm0oq B X-Google-Smtp-Source: AGHT+IGfjpV8KyyCSoYBb7jd/faTYT6XDBXmV2leln7rpsUs8MqA5s1oe086inZatvtDiGmDWFpCkg== X-Received: by 2002:a05:6214:110d:b0:6a0:deb6:7b0f with SMTP id 6a1803df08f44-6a15cc96ce2mr42735196d6.29.1715263511394; Thu, 09 May 2024 07:05:11 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6a15f1cd3desm7259176d6.88.2024.05.09.07.05.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 May 2024 07:05:10 -0700 (PDT) Date: Thu, 9 May 2024 10:05:09 -0400 From: Johannes Weiner To: Xiu Jianfeng Cc: mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 -next] mm: memcg: make alloc_mem_cgroup_per_node_info() return bool Message-ID: <20240509140509.GB374370@cmpxchg.org> References: <20240507110832.1128370-1-xiujianfeng@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240507110832.1128370-1-xiujianfeng@huawei.com> X-Stat-Signature: 849iu5z46aqydydxpsksmstg576g6ysf X-Rspamd-Queue-Id: 4224614001B X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1715263931-170728 X-HE-Meta: U2FsdGVkX19DUnXm2ypXIbxc/OODCB+HuyijFgOVecIAJQ3pA8dvUjZLhGPc/w009BTPgMP+T3cv7GAFKUzP1q16R8hj+3uYK1AWUU8C7I8qCq2umzyvOjEdFN5TAeSBlRmhvEHKPEmmOCuMSGzGHA0flutcVUUmRZXH/7FGT1EkTwqSuxLon13/Pq2zVNbXNTz/x8Uqp1xHmBUgi/p4J6qQExF/0eROMZLYo0MqXwoysNs9w2dQOuA7In1x7tFgAiBDiHv9WyKpXa7a7ED468moQKg1Kxxsq7qeEXRdyfluJ+BPIFcp97pDcg+fJwjlzQ0N/qJQOawm7Q06tW7zwuOq2lgHEnOTWSnuxXwHA3eXc9poFfXFeOqATGePSgace0ks6JBD3ErvxrJhfRAuJz4CJWwma79sD7C1zlCT2yMWfCTROLB2s2KrumzA0ueD2bLoniV0xoq/diI1dawAba68YyEPtadAgpPno/AFOFjD0Db8sDbeQdNEUUAoOkjZoEpPFOhTelZt8uDGW2bJsKV4f/7eDW4Z3aX3ygllrM61hJiVp5NvqgU5DWKFC4n6iyfd7IqnilvsNPaZuz57/aZ5Se2CWH7D/pdt6czu22H0DdJudWnnAKrZByigkmrrQSPcNDn9cZ/FfS6T/5cjyXOmUgCKIk04ivof5LBCiXAXYWTfzvuCOG5U5gp8CUvkmr/3iRn1/w1PFQZaySzP8wz6WbHX/oj0OAhUpUxr0uzVjtbt5rsKJOvR2dyUS8JTKgiqZIsca8A3dLzL3yNHq6Fy7hHsCrWkhurALxux/eqCIscAaBYidUFOtJmlg1JdNDQiL8wW1quoQtFUa+yn9xRxShSc4sf/1HMWvQhCtB3psXKsW4B1fUOMuFYi9qIJyO0TqXfnoyCzSITky6kD01mch2TAlVBN0ElaXhFPJHlu6DFjnDyVfZJinfYJ2dcFCdm3Jdkj6+7EuB3frAw B7WGW2OE tK3Pu/aN13hlLMYYr5gUVU7chHLfUj9/yySCyNhDr+QqAqr3/M2ox1zZLUxd63LbLKvgRnoxzw7klSZ1fpEm5B5RRjSOtzlK2dHIEXVtb6x5Mvwttbhp2zh2aoB97mPP8e83W1AEOlh8Tyu/ayDncF3AYeHiW59fPrfmgb4sSrTSBn0RzeWXqzKnof5+nNle6hZLw8DIQt9lHPLKHQ3MgQSiO8DGnV/UrGCKoF+4diRbtrpvvEF1GMkIzfge9mGLhiIYdh917vghIEr+hZvYzcvzM95rKLND6JUf8zenZfFLYrL7aXh/1uNQ0+6DtqpUux0I1Vr8kDaqB18NC+lVMWft3jIq1rXjL/M775wHzafbGzDOa6oOSCOeTxea/zcEOghkJ+iRliSwMjP66UwxQ8MGkXQwkFHi/XnnQhfOoIHJhzodAnWFucPzvpkiXEPH1kakuWhek7RcZY1hJW7B9e3gsHCCdoS4nzztwOdtLDGAWxKILP3seKM/41IzAc3xjwVIrUguDv7BgkvVvVdEJHJhi7bfWhNOGjnFqaFAxodki+dWl9BFqRlyduhwTU0m4zLzvvdXZA3tpc4s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.006455, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 07, 2024 at 11:08:32AM +0000, Xiu Jianfeng wrote: > Currently alloc_mem_cgroup_per_node_info() returns 1 if failed, > make it return bool, false for failure and true for success. > > Signed-off-by: Xiu Jianfeng I also slightly preferred the -ENOMEM version. But this is better than the status quo. Acked-by: Johannes Weiner