From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D172C10F1A for ; Thu, 9 May 2024 08:21:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EEE1F6B0088; Thu, 9 May 2024 04:21:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E9F746B0089; Thu, 9 May 2024 04:21:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D3EF26B008A; Thu, 9 May 2024 04:21:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B57F06B0088 for ; Thu, 9 May 2024 04:21:48 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6BD2F41487 for ; Thu, 9 May 2024 08:21:48 +0000 (UTC) X-FDA: 82098163896.09.CDA5918 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2044.outbound.protection.outlook.com [40.107.215.44]) by imf04.hostedemail.com (Postfix) with ESMTP id E944540011 for ; Thu, 9 May 2024 08:21:43 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=oppo.com header.s=selector1 header.b=kmg+8+xL; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf04.hostedemail.com: domain of hailong.liu@oppo.com designates 40.107.215.44 as permitted sender) smtp.mailfrom=hailong.liu@oppo.com; dmarc=pass (policy=quarantine) header.from=oppo.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715242904; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=krgnfcxgmEXuTMUq4Z0rK9aA40IKgS1fjPSAbICbBsc=; b=Bq4chb6pPjofPIJW+7O1dyf/l1mhKbkiyo4ymX4sDmnT7OVaaB9sb/KUGPKDtd+cTyZTmj KChypkUwhyoZpoTB6gZw+v0Pvw1eC4j7JEDMMQ8bfiSD2ap3FcVbLxxaWE/XTRO8G7Qa6Y Wtc0chFFdGZlFjhg9lVuLhR/xtwgoBs= ARC-Authentication-Results: i=2; imf04.hostedemail.com; dkim=pass header.d=oppo.com header.s=selector1 header.b=kmg+8+xL; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf04.hostedemail.com: domain of hailong.liu@oppo.com designates 40.107.215.44 as permitted sender) smtp.mailfrom=hailong.liu@oppo.com; dmarc=pass (policy=quarantine) header.from=oppo.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1715242904; a=rsa-sha256; cv=pass; b=0kQJSRfQ1uDZ+JxeX6tsJ0Z8VdDAa2OEQNPio8J89VKAXl4OpSjsrgbMVpvedD193mGeWJ mww3mfR9QYqGT7+Mzbin980vC70YhuwLiUudmzHC07hkXKucezc6lnx7HZYweNY+grLuE/ GQcJAveHRn+KAVPYzt2zUl00xe+umTs= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HtFJy3ScapUDv7c9O9/jYEkTOECCdWpN9HbEq2tNFBui44jcFceLBk/Gyr+G21bpsLuqfxGVXDpTLiy9I/mmCTKddS6xmIB6ckklMxK1dcGoO9lt/+mQuttqpQgBV141lfjePamPY1C0zXzPrQoFoYtsx4HnN2hVYr80/0VYoBpLRc5FZ9oVXxP2VkF38qPSkmwm2acHfhLcCGm8c0mP8DERRKP3x+pEN9luyn+pab28aSdHOU+Lk0OB7Bupx/8mD9eKZOEKhf2QLx32tde/zh4yOGAmurxPvU19IOnvEk5nTe5g2p4MjYrCsEpjaHDTNayN+/KWKxeIkjsiz5j8Qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=krgnfcxgmEXuTMUq4Z0rK9aA40IKgS1fjPSAbICbBsc=; b=KAUSqyxWeWMb9N1VxpufRsWSZ7FbU/0biO/R4Xesbk9s0nN5x0MBFUO4kQNCO9os+AkeKlmepQ61wBLgL2XwO+0FdHpzWpXX4UV1Ki1h+PqKw1igx0Sor9lkpspZywm7uEnleeHzCkZlKCsKT4HeaKQ8KO3ZsQAc1+gRDD0SBeb5ZkAN8exKnTvIjdAlHFMr54MZchSHQuSdd+d5CVOq8WC4mumYUG4v3TENapNzjMbDRpqHiCqrBbQnZ4th9+XGn8sXeMZIQ0cgSi1LBf1ylHAmuCRlRmpcVbKqRX4Az/wM1YCHnrFK9YMRMCvewYqaSeXcJnZWV1ThYRJ16Kte5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 58.252.5.68) smtp.rcpttodomain=suse.com smtp.mailfrom=oppo.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=oppo.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oppo.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=krgnfcxgmEXuTMUq4Z0rK9aA40IKgS1fjPSAbICbBsc=; b=kmg+8+xLeJSEJS/ivy6KBSnzG2QYm5KRgPcmvGr8EKocFUleADNL4X+XQYCJIWrAxyNNa+zbLS+2LVJNxBTU/rt/WSIYyCxHne4p71B7Veh0Khgk/Rp3/FjffAw5vm5Dct01aFU34aAKRw0VLRDrvJTMu2Zt/8wylESvLl/V5Ag= Received: from SG2PR06CA0184.apcprd06.prod.outlook.com (2603:1096:4:1::16) by SEZPR02MB6412.apcprd02.prod.outlook.com (2603:1096:101:12f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.46; Thu, 9 May 2024 08:21:38 +0000 Received: from SG2PEPF000B66CA.apcprd03.prod.outlook.com (2603:1096:4:1:cafe::bc) by SG2PR06CA0184.outlook.office365.com (2603:1096:4:1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.45 via Frontend Transport; Thu, 9 May 2024 08:21:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 58.252.5.68) smtp.mailfrom=oppo.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=oppo.com; Received-SPF: Pass (protection.outlook.com: domain of oppo.com designates 58.252.5.68 as permitted sender) receiver=protection.outlook.com; client-ip=58.252.5.68; helo=mail.oppo.com; pr=C Received: from mail.oppo.com (58.252.5.68) by SG2PEPF000B66CA.mail.protection.outlook.com (10.167.240.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7544.18 via Frontend Transport; Thu, 9 May 2024 08:21:37 +0000 Received: from oppo.com (172.16.40.118) by mailappw31.adc.com (172.16.56.198) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 9 May 2024 16:06:36 +0800 Date: Thu, 9 May 2024 16:06:36 +0800 From: Hailong Liu To: Michal Hocko CC: , , , , <21cnbao@gmail.com>, , , , , Oven Subject: Re: [RFC PATCH] mm/vmalloc: fix vmalloc which may return null if called with __GFP_NOFAIL Message-ID: <20240509080636.bauxbgpqdluzpein@oppo.com> References: <20240508125808.28882-1-hailong.liu@oppo.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-Originating-IP: [172.16.40.118] X-ClientProxiedBy: mailappw31.adc.com (172.16.56.198) To mailappw31.adc.com (172.16.56.198) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SG2PEPF000B66CA:EE_|SEZPR02MB6412:EE_ X-MS-Office365-Filtering-Correlation-Id: 2e47d76c-137b-4cd6-beea-08dc70010c1e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|376005|7416005|36860700004|1800799015|82310400017; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?B8AN/UTzokJRBBaHAWOli/Wnx2F3er4SyMfBxBKfwRJi5Su1hNz1MV+xBE42?= =?us-ascii?Q?iY8mJyg3pGEXpAwwahf/2ddlWMywZTMf/k88DBHwL19x+vjcpDO6mUSZL98G?= =?us-ascii?Q?kuzRgKXVKNWf+vZv7Dp0neWM2EASS76yCM0KH6lm0G4j8TrDbOUM0lFkzTxc?= =?us-ascii?Q?9d4ETsJdxXL4owVquseXxjA8in4y3yImhGcgulY+9xlIks9KMjnQiHnUZ0/e?= =?us-ascii?Q?Fei7FRv6a1d+pldcrqm16v7x/rh92Y/tgBKzqqjfTQwsn6S275O5AjdCOrdP?= =?us-ascii?Q?M9kekj5+XOWKxByYJZHIfHf+7daZGKs/ZNx/c23yPT7rRRQkhthVd/QFUXBB?= =?us-ascii?Q?61ijaDPxFAJcFl/Nu9owkUDIXEIqShaJ7XMh0FTHatNpYstOM8pEidIUAFu/?= =?us-ascii?Q?0LGvlzFAST76wEXVgV+e7DyAuMHDD4xCeTYW0UOYMVaVoJ330DbHZQ86v6XT?= =?us-ascii?Q?gHm1Y6t11N9QxaHQYJldIbhDNiDghdLqG7iVGmrzR5fRREFwWzA9pn1DqYS6?= =?us-ascii?Q?Uy+e0peP1eoerYEn+dlnz/d6K401Qa/sFMdrA5DgboOM8iuXRLK8d86FgW/k?= =?us-ascii?Q?/PQeAI/HzPa6y0FynkysDqOqizgV9nOsNeCfXkWrr1kWschitHZI+6ZWTLAd?= =?us-ascii?Q?RJy24APLgVD4s12cPEbO02KluCKuSDQYFUxFXUU9F/siM0Urm29oVWyfSW5+?= =?us-ascii?Q?0X29iRO0at75Yz/iqXxtc4XMis6zJCAjqrb6yfFRKcpyWz54aTgA63sgVf91?= =?us-ascii?Q?8KlVJJwkFR5Zh0JSyjxwzCZRk6+FBGN8KpSm2Nw8KYgV9jz1qo+fslGFUa/2?= =?us-ascii?Q?dpNhu5pKkC/14mAyLP6hU+64H+B6TlmABDUclt36Qc/XF1ktyxYskAHeqGJa?= =?us-ascii?Q?8/LA5mZQ5s30+U/C9IIg8Ak4/2WoRE0rihr1xb4TArHK6gT4thv4hBNlMddA?= =?us-ascii?Q?leHFcG9iPFAChQ8pS+pB7MEWIJlTHNWYsWBNRA0AP/yiw1Q4Y+u4Re/XQJtk?= =?us-ascii?Q?gBewX+ts6a9zZzBhWrA68b2bN6noqHzSBhJApQHueqGrNAfj9EwvmDWnqNq/?= =?us-ascii?Q?9ev6ZOS4n/MugXjx7N4pL5i3ZJh/f7+QAnQU7d9PbyNTd8D7IgJIP6ZhO1pa?= =?us-ascii?Q?Ji+GYRF1JdL3GAn8LxyTDGH1yj8qmzgvwK5H4JcfJd39ZCTeit+rXkbryXA+?= =?us-ascii?Q?m5h+r/qrmJoK61fxDPQWTiqalFLVVzCbImNA83IdvlkkZEwZab0x8V37khkz?= =?us-ascii?Q?5ykl53BYj/lEbN2evqgylgKEHSQTKF+Ea98nR8d5KdDEoTC0QU0ivRkdK0vL?= =?us-ascii?Q?Wg8nbmROKJ/3AKlkFj4DNXJFDlipTyS00n2qyo3TN1LgjNG2HXGr5vrla79b?= =?us-ascii?Q?UKEYQj4sb5ES/AEcQBXWPwbJAirL?= X-Forefront-Antispam-Report: CIP:58.252.5.68;CTRY:CN;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.oppo.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(376005)(7416005)(36860700004)(1800799015)(82310400017);DIR:OUT;SFP:1101; X-OriginatorOrg: oppo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2024 08:21:37.9137 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2e47d76c-137b-4cd6-beea-08dc70010c1e X-MS-Exchange-CrossTenant-Id: f1905eb1-c353-41c5-9516-62b4a54b5ee6 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f1905eb1-c353-41c5-9516-62b4a54b5ee6;Ip=[58.252.5.68];Helo=[mail.oppo.com] X-MS-Exchange-CrossTenant-AuthSource: SG2PEPF000B66CA.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR02MB6412 X-Stat-Signature: rhxck5yr1huoazs4kw9z4c8hbtftext1 X-Rspam-User: X-Rspamd-Queue-Id: E944540011 X-Rspamd-Server: rspam05 X-HE-Tag: 1715242903-906419 X-HE-Meta: U2FsdGVkX19nxZ0NNtu4RWgRXbHE5yRO2v9f0yMXgYokPiZCDYYR5x8JphFl8Qd36lRLifUW2yfQpmOLMJAwBq7t64gCKBUq0mu3GHpa6uPCh46Ne89Lg5+1k4hxZLwASMUniLTnqi2FcdQafj4SF/wiZfkuNlT3voMm3PhLI4hTv3Cue7sDJYEVwHS5h2Odcohcjh+uZu9CAZd5sQ0Loq7w+Ua2XpU2Lx8IfSq3xmc6jd2gbdYQvgpXed0jxAc6r0hhobW56jaxMh3gnTDZkbhWVvtCYok4WprE7DkwHBLjd0v625w4RyKlfpYZ8w8kvrKmnQF1QcIIdx3TT9LJaQbQudV8I0gJ2kSBn4yDoudHxQPB72UypcuJjO/S34sRKmQiObTX89WcrQVIL9Zz5xbBYeOdhRpMw4rnTEcYjDnhG2iiqo+lGgutnDFHoXEEbXLgV8DapTfT1mNQ8Dn2kOeneVWGP2SM8kSYb38pgvPUVWjZ4DxyRGAFxFOiSgP/iCO/Ak+5u75AQsj2Xzx845+3Cu37C001kmUVE6xiC1BOyKFd42nNq9zB4gHNvN9Q0K2MhYIP+jV4S8Lh6SmHfB/C2eyAOG7orZwg0Vy1YX4AXs2n0jImAkhnF4i725j83y/EK4pYnZWXpLh9LAk/gfCPcCMRBeeGnUm2S6/NAwXBOk3bIfzorI1LvPcZWLIoAs5aDP0twZ9iYiIw0niWqjmebw9J4fF7uz200AflA+cpC8NCyeymPprNNZ5q6znFaLzrTVNFMMS0G5R9lm8J/8CxGixm/gz/ClNTxqi9s7dcULeuKXl+laNuRf4601o5batOnTglnyJ/FmkBOhXUFuoOUKbVFnGgne+/5gJI4eQegXAgKBYeYPC9ZN1V3A8ZXVaupv8GTWKcy/7Y5ZvoK/Vez1Ssdii01PiT5UcT6YZNLIM6Z4I4l78gHjmo/ZoPb2GJ8IxVHGX3kYJEzlI p68EVjVl 0x/NujIM+pJK0YVUYSJJC/t5Cq/F0OuzJuq6hryaXtK3zdIoJjoCfMLluYUPFrtqcf2IgP9d5KZsyvIlKudkT+hZQQ+CZZroVtfPT9S2PMxMS+GSWqxzpSDD0IrLSFOBFM+6jv5a1da8oPinRW9CHPDMZR9eBnOdXNtgN6h73tnL30pLYLQmaF6pNBEoNnOyDBGCRlHWarFzhQyTo5bogL1Sy7oiI/KMTtoC9UWD6FBWCzZ2LKjCyAqby1yyA6sji9B3EDqR+UFIVkjqd0cxKiQ0J7vvdi99ISvn3PVW71t5xCJemTaQWvBQM13+GiQc/7aDIJvnUKNPxFWCDVfs7SapNTnxpqIpvSXanJrNcBmCdEO7bFos8TQENDw0q8yuQOuaQCAK+/j59O1VrXRncb0mo85FoPUNtuZJR7PDKJzK6xQGj9JIh/8359W0m4vzNBRpzaX7dT3giP/2aUKZ7WwGpqGjlMrcCnGISiL0yO2ldm3M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 09. May 09:48, Michal Hocko wrote: > On Wed 08-05-24 20:58:08, hailong.liu@oppo.com wrote: > > From: "Hailong.Liu" > > > > Commit a421ef303008 ("mm: allow !GFP_KERNEL allocations for kvmalloc") > > includes support for __GFP_NOFAIL, but it presents a conflict with > > commit dd544141b9eb ("vmalloc: back off when the current task is > > OOM-killed"). A possible scenario is as belows: > > > > process-a > > kvcalloc(n, m, GFP_KERNEL | __GFP_NOFAIL) > > __vmalloc_node_range() > > __vmalloc_area_node() > > vm_area_alloc_pages() > > --> oom-killer send SIGKILL to process-a > > if (fatal_signal_pending(current)) break; > > --> return NULL; > > > > to fix this, do not check fatal_signal_pending() in vm_area_alloc_pages() > > if __GFP_NOFAIL set. > > > > Reported-by: Oven > > Signed-off-by: Hailong.Liu > > --- > > mm/vmalloc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > > index 6641be0ca80b..2f359d08bf8d 100644 > > --- a/mm/vmalloc.c > > +++ b/mm/vmalloc.c > > @@ -3560,7 +3560,7 @@ vm_area_alloc_pages(gfp_t gfp, int nid, > > > > /* High-order pages or fallback path if "bulk" fails. */ > > while (nr_allocated < nr_pages) { > > - if (fatal_signal_pending(current)) > > + if (!(gfp & __GFP_NOFAIL) && fatal_signal_pending(current)) > > Use nofail instead of gfp & __GFP_NOFAIL. > > Other than that looks good to me. After that is fixed, please feel free > to add Acked-by: Michal Hocko > > I believe this should also have Fixes: 9376130c390a ("mm/vmalloc: add support for __GFP_NOFAIL") > -- > Michal Hocko > SUSE Labs Thanks for the review and the Ack! Add Fixes in V2 patch. IIUC, nofail could not used for this case. /* * For order-0 pages we make use of bulk allocator, if * the page array is partly or not at all populated due * to fails, fallback to a single page allocator that is * more permissive. */ if (!order) { /* bulk allocator doesn't support nofail req. officially */ xxx -> nofail = false; } else if (gfp & __GFP_NOFAIL) { /* * Higher order nofail allocations are really expensive and * potentially dangerous (pre-mature OOM, disruptive reclaim * and compaction etc. */ alloc_gfp &= ~__GFP_NOFAIL; nofail = true; } /* High-order pages or fallback path if "bulk" fails. */ while (nr_allocated < nr_pages) { -> nofail is false here if bulk allocator fails. if (fatal_signal_pending(current)) break; -- Best Regards, Hailong.